From e8f67c8b75e8012ec5e322692a1f036e06c20e2b Mon Sep 17 00:00:00 2001 From: Sara Aspery Date: Wed, 27 Nov 2019 05:55:29 +0000 Subject: [PATCH] RM-7068 restrict items in delete hold error msg --- .../org_alfresco_module_rm/hold/HoldServiceImpl.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/hold/HoldServiceImpl.java b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/hold/HoldServiceImpl.java index 258d3124b6..0fa8527d1a 100644 --- a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/hold/HoldServiceImpl.java +++ b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/hold/HoldServiceImpl.java @@ -39,6 +39,7 @@ import java.util.HashSet; import java.util.List; import java.util.Map; import java.util.Set; +import java.util.stream.Stream; import org.alfresco.error.AlfrescoRuntimeException; import org.alfresco.model.ContentModel; @@ -104,6 +105,9 @@ public class HoldServiceImpl extends ServiceBaseImpl private static final String MSG_ERR_HOLD_PERMISSION_GENERIC_ERROR = "rm.hold.generic-permission-error"; private static final String MSG_ERR_HOLD_PERMISSION_DETAILED_ERROR = "rm.hold.detailed-permission-error"; + /** Maximum number of held items to display in error message */ + private static final int MAX_HELD_ITEMS_LIST_SIZE = 5; + /** File Plan Service */ private FilePlanService filePlanService; @@ -570,13 +574,13 @@ public class HoldServiceImpl extends ServiceBaseImpl if (heldNames.size() > 0) { StringBuilder sb = new StringBuilder(); - for (String name : heldNames) - { + Stream stream1 = heldNames.stream(); + stream1.limit(MAX_HELD_ITEMS_LIST_SIZE).forEach((name) -> { sb.append("\n "); sb.append("'"); sb.append(name); sb.append("'"); - } + }); throw new AccessDeniedException(I18NUtil.getMessage(MSG_ERR_HOLD_PERMISSION_DETAILED_ERROR) + sb.toString()); }