inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-10-08 14:51:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merged 5.1.N (5.1.2) to 5.2.N (5.2.1)

Browse Source 
127279 rneamtu: MNT-16043 : Site Manager is able to delete/move/copy locked files
      - Added test case for scenario


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/BRANCHES/DEV/5.2.N/root@127289 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Cristian Turlica
2016-05-20 13:18:08 +00:00
parent 0d69a6a3d7
commit e91cdb7b40
1 changed files with 172 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

177
source/test-java/org/alfresco/repo/site/SiteServiceImplMoreTest.java
View File

@@ -32,14 +32,14 @@ import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import java.io.Serializable;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Set;
import org.alfresco.model.ContentModel;
import org.alfresco.query.PagingRequest;
import org.alfresco.query.PagingResults;
@@ -52,9 +52,11 @@ import org.alfresco.repo.security.authentication.AuthenticationUtil.RunAsWork;
import org.alfresco.repo.security.permissions.AccessDeniedException;
import org.alfresco.repo.transaction.RetryingTransactionHelper;
import org.alfresco.repo.transaction.RetryingTransactionHelper.RetryingTransactionCallback;
import org.alfresco.service.cmr.coci.CheckOutCheckInService;
import org.alfresco.service.cmr.lock.LockService;
import org.alfresco.service.cmr.lock.LockStatus;
import org.alfresco.service.cmr.lock.LockType;
import org.alfresco.service.cmr.lock.NodeLockedException;
import org.alfresco.service.cmr.model.FileFolderService;
import org.alfresco.service.cmr.model.FileInfo;
import org.alfresco.service.cmr.repository.ChildAssociationRef;
@@ -134,7 +136,8 @@ public class SiteServiceImplMoreTest
private static NamespaceService NAMESPACE_SERVICE;
private static NodeService NODE_SERVICE;
private static NodeArchiveService NODE_ARCHIVE_SERVICE;
private static SiteService SITE_SERVICE;
private static SiteService SITE_SERVICE;
private static CheckOutCheckInService COCI_SERVICE;
private static RetryingTransactionHelper TRANSACTION_HELPER;
private static PermissionService PERMISSION_SERVICE;
private static MutableAuthenticationService AUTHENTICATION_SERVICE;
@@ -152,7 +155,8 @@ public class SiteServiceImplMoreTest
NAMESPACE_SERVICE = APP_CONTEXT_INIT.getApplicationContext().getBean("namespaceService", NamespaceService.class);
NODE_SERVICE = APP_CONTEXT_INIT.getApplicationContext().getBean("NodeService", NodeService.class);
NODE_ARCHIVE_SERVICE = APP_CONTEXT_INIT.getApplicationContext().getBean("nodeArchiveService", NodeArchiveService.class);
SITE_SERVICE = APP_CONTEXT_INIT.getApplicationContext().getBean("siteService", SiteService.class);
SITE_SERVICE = APP_CONTEXT_INIT.getApplicationContext().getBean("siteService", SiteService.class);
COCI_SERVICE = APP_CONTEXT_INIT.getApplicationContext().getBean("checkOutCheckInService", CheckOutCheckInService.class);
TRANSACTION_HELPER = APP_CONTEXT_INIT.getApplicationContext().getBean("retryingTransactionHelper", RetryingTransactionHelper.class);
PERMISSION_SERVICE = APP_CONTEXT_INIT.getApplicationContext().getBean("permissionServiceImpl", PermissionService.class);
AUTHENTICATION_SERVICE = APP_CONTEXT_INIT.getApplicationContext().getBean("authenticationService", MutableAuthenticationService.class);
@@ -846,7 +850,170 @@ public class SiteServiceImplMoreTest
res = SiteServiceImpl.tokenizeFilterLowercase(null);
assertNotNull(res);
assertEquals(0, res.length);
}
}
/**
* MNT-16043: Site Owner and Site Manager can delete working copy,
* Site Collaborator cannot
*
* @throws Exception
*/
@Test
public void testSiteRolesPersmissionsToDeleteWorkingCopy() throws Exception
{
final String userSiteOwner = "UserSiteOwner";
final String userSiteManager = "UserSiteManager";
final String userSiteCollaborator = "UserSiteCollaborator";
final String userPrefix = "delete-locked-file";
// create the users
TRANSACTION_HELPER.doInTransaction(new RetryingTransactionCallback<Void>()
{
public Void execute() throws Throwable
{
createUser(userSiteOwner, userPrefix);
createUser(userSiteManager, userPrefix);
createUser(userSiteCollaborator, userPrefix);
return null;
}
});
final String siteShortName = userPrefix + "Site" + System.currentTimeMillis();
final String dummyContent = "Just some old content that doesn't mean anything";
// Create site
final TestSiteAndMemberInfo testSiteAndMemberInfo = perMethodTestSites.createTestSiteWithUserPerRole(siteShortName, "sitePreset",
SiteVisibility.PUBLIC, userSiteOwner);
// create 1 file into the site as the owner of the site
AUTHENTICATION_COMPONENT.setCurrentUser(userSiteOwner);
NodeRef siteContainer = SITE_SERVICE.createContainer(siteShortName, "doclib", ContentModel.TYPE_FOLDER, null);
final FileInfo fileInfo1 = FILE_FOLDER_SERVICE.create(siteContainer, "fileInfo1.txt", ContentModel.TYPE_CONTENT);
ContentWriter writer1 = FILE_FOLDER_SERVICE.getWriter(fileInfo1.getNodeRef());
writer1.putContent(dummyContent);
final FileInfo fileInfo2 = FILE_FOLDER_SERVICE.create(siteContainer, "fileInfo2.txt", ContentModel.TYPE_CONTENT);
ContentWriter writer2 = FILE_FOLDER_SERVICE.getWriter(fileInfo2.getNodeRef());
writer2.putContent(dummyContent);
final FileInfo fileInfo3 = FILE_FOLDER_SERVICE.create(siteContainer, "fileInfo3.txt", ContentModel.TYPE_CONTENT);
ContentWriter writer3 = FILE_FOLDER_SERVICE.getWriter(fileInfo2.getNodeRef());
writer3.putContent(dummyContent);
// Site Manager - can delete working copy but cannot delete the original
// locked file
TRANSACTION_HELPER.doInTransaction(new RetryingTransactionCallback<Void>()
{
public Void execute() throws Throwable
{
// lock a file as userOwner
NodeRef workingCopy = COCI_SERVICE.checkout(fileInfo1.getNodeRef());
assertNotNull(workingCopy);
// make userSiteManager a member of the site
SITE_SERVICE.setMembership(siteShortName, userSiteManager, SiteModel.SITE_MANAGER);
// make sure we are running as userSiteManager
AUTHENTICATION_COMPONENT.setCurrentUser(userSiteManager);
// try delete locked file by owner
try
{
NODE_SERVICE.deleteNode(fileInfo1.getNodeRef());
fail("Cannot perform operation since the node" + fileInfo1.getNodeRef() + " is locked");
}
catch (NodeLockedException ex)
{
// do nothing - is expected
}
// simulate delete from Share - delete the working copy
NODE_SERVICE.deleteNode(workingCopy);
return null;
}
});
// Site Owner - can delete working copy but cannot delete the original
// locked file
TRANSACTION_HELPER.doInTransaction(new RetryingTransactionCallback<Void>()
{
public Void execute() throws Throwable
{
AUTHENTICATION_COMPONENT.setCurrentUser(userSiteOwner);
// lock a file as userOwner
NodeRef workingCopy = COCI_SERVICE.checkout(fileInfo2.getNodeRef());
assertNotNull(workingCopy);
try
{
NODE_SERVICE.deleteNode(fileInfo2.getNodeRef());
fail("Cannot perform operation since the node" + fileInfo1.getNodeRef() + " is locked");
}
catch (NodeLockedException ex)
{
// do nothing- expected
}
NODE_SERVICE.deleteNode(workingCopy);
return null;
}
});
// Site COLLABORATOR - cannot delete working copy or original file
TRANSACTION_HELPER.doInTransaction(new RetryingTransactionCallback<Void>()
{
public Void execute() throws Throwable
{
// lock a file as userOwner
AUTHENTICATION_COMPONENT.setCurrentUser(userSiteOwner);
NodeRef workingCopy = COCI_SERVICE.checkout(fileInfo3.getNodeRef());
assertNotNull(workingCopy);
// make userSiteCollaborator a member of the site
SITE_SERVICE.setMembership(siteShortName, userSiteCollaborator, SiteModel.SITE_COLLABORATOR);
// make sure we are running as userSiteManager
AUTHENTICATION_COMPONENT.setCurrentUser(userSiteCollaborator);
try
{
NODE_SERVICE.deleteNode(fileInfo3.getNodeRef());
fail("You do not have the appropriate permissions to perform this operation");
}
catch (AccessDeniedException ex)
{
// do nothing - is expected
}
// try delete locked file by owner
try
{
NODE_SERVICE.deleteNode(workingCopy);
fail("You do not have the appropriate permissions to perform this operation");
}
catch (AccessDeniedException ex)
{
// do nothing - is expected
}
return null;
}
});
AUTHENTICATION_COMPONENT.setCurrentUser(userSiteOwner);
// Delete the site
TRANSACTION_HELPER.doInTransaction(new RetryingTransactionCallback<Void>()
{
public Void execute() throws Throwable
{
AUTHENTICATION_COMPONENT.getCurrentUserName();
SITE_SERVICE.deleteSite(siteShortName);
return null;
}
});
}
private void assertThatArchivedNodeExists(NodeRef originalNodeRef, String failureMsg)
{
final NodeRef archivedNodeRef = NODE_ARCHIVE_SERVICE.getArchivedNode(originalNodeRef);