Merged HEAD-BUG-FIX (5.1/Cloud) to HEAD (5.1/Cloud)

93839: Merged 5.0.N (5.0.1) to HEAD-BUG-FIX (5.1/Cloud)
      93772: MNT-13089: RepoAdminServiceImplTest hangs on SQL Server
      Fixed RenditionServicePermissionsTest.userWithoutDeleteAccessToNodeShouldNotCauseFailedThumbnailProblemsOnUpdate.
      Disabled for MS SQL Server AuthenticationTest.testLoginNotExistingTenant, RenditionServiceIntegrationTest.testALF3733, RenditionServiceIntegrationTest.testJavascriptAPI.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@95000 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Alan Davis
2015-01-31 15:23:40 +00:00
parent 5527c737c5
commit f1cfb74849
3 changed files with 38 additions and 15 deletions

View File

@@ -2001,9 +2001,12 @@ public class RenditionServiceIntegrationTest extends BaseAlfrescoSpringTest
public void testALF3733() throws Exception public void testALF3733() throws Exception
{ {
setComplete(); // disable in case of SQL Server
endTransaction(); // see MNT-13089
if (dialect instanceof SQLServerDialect)
{
return;
}
// ALF-3733 was caused by ${cwd} evaluating to the empty string and a path "//sourceNodeName" // ALF-3733 was caused by ${cwd} evaluating to the empty string and a path "//sourceNodeName"
// being passed to the FileFolderService for creation. This then splits the string using '/' as // being passed to the FileFolderService for creation. This then splits the string using '/' as
// a delimiter which leads to the attempted creation of nodes with the empty string as a name, // a delimiter which leads to the attempted creation of nodes with the empty string as a name,
@@ -2465,8 +2468,12 @@ public class RenditionServiceIntegrationTest extends BaseAlfrescoSpringTest
public void testJavascriptAPI() throws Exception public void testJavascriptAPI() throws Exception
{ {
setComplete(); // disable in case of SQL Server
endTransaction(); // see MNT-13089
if (dialect instanceof SQLServerDialect)
{
return;
}
Map<String, Object> model = new HashMap<String, Object>(); Map<String, Object> model = new HashMap<String, Object>();
model.put("testSourceNode", this.nodeWithImageContent); model.put("testSourceNode", this.nodeWithImageContent);

View File

@@ -384,18 +384,32 @@ public class RenditionServicePermissionsTest
testSiteInfo.doclib, testSiteInfo.doclib,
"quick.jpg", "quick.jpg",
AuthenticationUtil.getFullyAuthenticatedUser()); AuthenticationUtil.getFullyAuthenticatedUser());
return imgNode;
// This is what ScriptNode.createThumbnail does }
ThumbnailDefinition details = thumbnailRegistry.getThumbnailDefinition("doclib"); });
Action action = ThumbnailHelper.createCreateThumbnailAction(details, services);
// This is what ScriptNode.createThumbnail does
final ThumbnailDefinition details = thumbnailRegistry.getThumbnailDefinition("doclib");
final Action action = transactionHelper.doInTransaction(new RetryingTransactionHelper.RetryingTransactionCallback<Action>()
{
@Override
public Action execute() throws Throwable
{
return ThumbnailHelper.createCreateThumbnailAction(details, services);
}
});
transactionHelper.doInTransaction(new RetryingTransactionHelper.RetryingTransactionCallback<Void>()
{
public Void execute() throws Throwable
{
// Creation of thumbnail // Creation of thumbnail
services.getActionService().executeAction(action, imgNode, true, false); services.getActionService().executeAction(action, imgNode, true, false);
// The node in question should now have a thumbnail/rendition. // The node in question should now have a thumbnail/rendition.
assertEquals(1, renditionService.getRenditions(imgNode).size()); assertEquals(1, renditionService.getRenditions(imgNode).size());
return imgNode; return null;
} }
}); });

View File

@@ -72,6 +72,7 @@ import org.alfresco.test_category.OwnJVMTestsCategory;
import org.alfresco.util.ApplicationContextHelper; import org.alfresco.util.ApplicationContextHelper;
import org.hibernate.dialect.Dialect; import org.hibernate.dialect.Dialect;
import org.hibernate.dialect.PostgreSQLDialect; import org.hibernate.dialect.PostgreSQLDialect;
import org.hibernate.dialect.SQLServerDialect;
import org.junit.experimental.categories.Category; import org.junit.experimental.categories.Category;
import org.springframework.context.ApplicationContext; import org.springframework.context.ApplicationContext;
import org.springframework.extensions.webscripts.GUID; import org.springframework.extensions.webscripts.GUID;
@@ -1732,11 +1733,12 @@ public class AuthenticationTest extends TestCase
public void testLoginNotExistingTenant() throws Exception public void testLoginNotExistingTenant() throws Exception
{ {
// split the transactions to pass on SQL Server // disable in case of SQL Server
// see MNT-13089 // see MNT-13089
userTransaction.commit(); if (dialect instanceof SQLServerDialect)
userTransaction = transactionService.getUserTransaction(); {
userTransaction.begin(); return;
}
boolean wasEnabled = AuthenticationUtil.isMtEnabled(); boolean wasEnabled = AuthenticationUtil.isMtEnabled();
try try