From f554073a2a82490e94312b5a3bf2150989f4414d Mon Sep 17 00:00:00 2001 From: Neil McErlean Date: Mon, 28 Sep 2015 11:49:20 +0000 Subject: [PATCH] Fix 6 instances of 'scary' findbugs issue: "Method creates local variable-based synchronized collection " git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@113198 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261 --- .../jscript/app/JSONConversionComponent.java | 2 +- .../report/generator/DeclarativeReportGenerator.java | 2 +- .../module/org_alfresco_module_rm/script/RmActionPost.java | 2 +- .../org_alfresco_module_rm/script/slingshot/RMSearchGet.java | 2 +- .../security/RMMethodSecurityInterceptor.java | 2 +- .../security/RMMethodSecurityPostProcessor.java | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/jscript/app/JSONConversionComponent.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/jscript/app/JSONConversionComponent.java index 34bd4a4d93..867bf3f606 100644 --- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/jscript/app/JSONConversionComponent.java +++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/jscript/app/JSONConversionComponent.java @@ -374,7 +374,7 @@ public class JSONConversionComponent extends org.alfresco.repo.jscript.app.JS String displayPath = getDisplayPath(originatingLocation); String[] displayPathElements = displayPath.split(pathSeparator); Object[] subPath = ArrayUtils.subarray(displayPathElements, 5, displayPathElements.length); - StringBuffer originatingLocationPath = new StringBuffer(); + StringBuilder originatingLocationPath = new StringBuilder(); for (int i = 0; i < subPath.length; i++) { originatingLocationPath.append(pathSeparator).append(subPath[i]); diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/report/generator/DeclarativeReportGenerator.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/report/generator/DeclarativeReportGenerator.java index 952ae9bbea..f3043dedb7 100644 --- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/report/generator/DeclarativeReportGenerator.java +++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/report/generator/DeclarativeReportGenerator.java @@ -307,7 +307,7 @@ public class DeclarativeReportGenerator extends BaseReportGenerator String typePrefixName = reportType.getPrefixedQName(namespaceService).getPrefixString().replace(":", "_"); String extension = mimetypeService.getExtension(mimetype); - StringBuffer sb = new StringBuffer(128) + StringBuilder sb = new StringBuilder(128) .append("report_") .append(typePrefixName) .append(".") diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/script/RmActionPost.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/script/RmActionPost.java index d140c485aa..4a41ea680a 100644 --- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/script/RmActionPost.java +++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/script/RmActionPost.java @@ -153,7 +153,7 @@ public class RmActionPost extends DeclarativeWebScript } // Check that all the nodes provided exist and build report string - StringBuffer targetNodeRefsString = new StringBuffer(30); + StringBuilder targetNodeRefsString = new StringBuilder(30); boolean firstTime = true; for (NodeRef targetNodeRef : targetNodeRefs) { diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/script/slingshot/RMSearchGet.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/script/slingshot/RMSearchGet.java index 3313032e8a..e7201496c5 100644 --- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/script/slingshot/RMSearchGet.java +++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/script/slingshot/RMSearchGet.java @@ -334,7 +334,7 @@ public class RMSearchGet extends DeclarativeWebScript NodeRef person = personService.getPerson(userName); if (person != null) { - StringBuffer displayName = new StringBuffer(128); + StringBuilder displayName = new StringBuilder(128); displayName.append(nodeService.getProperty(person, ContentModel.PROP_FIRSTNAME)) .append(" ") .append(nodeService.getProperty(person, ContentModel.PROP_LASTNAME)); diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/RMMethodSecurityInterceptor.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/RMMethodSecurityInterceptor.java index 1d4e1e5f3d..0d5a0f1f31 100644 --- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/RMMethodSecurityInterceptor.java +++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/RMMethodSecurityInterceptor.java @@ -200,7 +200,7 @@ public class RMMethodSecurityInterceptor extends MethodSecurityInterceptor if (!capabilities.isEmpty()) { - StringBuffer buffer = new StringBuffer("\n"); + StringBuilder buffer = new StringBuilder("\n"); for (CapabilityReport capability : capabilities) { buffer.append(" ").append(capability.name).append(" (").append(capability.status).append(")\n"); diff --git a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/RMMethodSecurityPostProcessor.java b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/RMMethodSecurityPostProcessor.java index d440cff2b5..f59417aae4 100644 --- a/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/RMMethodSecurityPostProcessor.java +++ b/rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/RMMethodSecurityPostProcessor.java @@ -189,7 +189,7 @@ public class RMMethodSecurityPostProcessor implements BeanFactoryPostProcessor */ private String convertToString(Map map) { - StringBuffer buffer = new StringBuffer(256); + StringBuilder buffer = new StringBuilder(256); for (Map.Entry entry : map.entrySet()) { buffer.append(entry.getKey()).append("=").append(entry.getValue()).append("\n");