From df5a142b434879f121a3ed27b5322280f6b4fde5 Mon Sep 17 00:00:00 2001
From: rlucanu <roxana.lucanu-ghetu@ness.com>
Date: Thu, 12 Sep 2019 12:20:51 +0300
Subject: [PATCH] RM-6943 Changes on AddToHold evaluator

---
 .../rm-ui-evaluators-context.xml              |  1 -
 .../jscript/app/JSONConversionComponent.java  | 29 +++----------------
 2 files changed, 4 insertions(+), 26 deletions(-)

diff --git a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-ui-evaluators-context.xml b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-ui-evaluators-context.xml
index aeeb7699de..290e36f303 100644
--- a/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-ui-evaluators-context.xml
+++ b/rm-community/rm-community-repo/config/alfresco/module/org_alfresco_module_rm/rm-ui-evaluators-context.xml
@@ -23,7 +23,6 @@
       <property name="jsonConversionComponentCache" ref="jsonConversionComponentCache" />
       <property name="mimetypeService" ref="MimetypeService" />
       <property name="dispositionService" ref="dispositionService" />
-      <property name="holdService" ref="HoldService" />
    </bean>
 
    <!--  extends core bean with RM extensions -->
diff --git a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/jscript/app/JSONConversionComponent.java b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/jscript/app/JSONConversionComponent.java
index f6a60aa796..cd93b38818 100644
--- a/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/jscript/app/JSONConversionComponent.java
+++ b/rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/jscript/app/JSONConversionComponent.java
@@ -40,13 +40,11 @@ import java.util.Set;
 
 import org.alfresco.model.ContentModel;
 import org.alfresco.module.org_alfresco_module_rm.capability.CapabilityService;
-import org.alfresco.module.org_alfresco_module_rm.capability.RMPermissionModel;
 import org.alfresco.module.org_alfresco_module_rm.capability.impl.ViewRecordsCapability;
 import org.alfresco.module.org_alfresco_module_rm.disposition.DispositionService;
 import org.alfresco.module.org_alfresco_module_rm.event.EventCompletionDetails;
 import org.alfresco.module.org_alfresco_module_rm.fileplan.FilePlanComponentKind;
 import org.alfresco.module.org_alfresco_module_rm.fileplan.FilePlanService;
-import org.alfresco.module.org_alfresco_module_rm.hold.HoldService;
 import org.alfresco.module.org_alfresco_module_rm.model.RecordsManagementModel;
 import org.alfresco.module.org_alfresco_module_rm.record.RecordService;
 import org.alfresco.module.org_alfresco_module_rm.role.FilePlanRoleService;
@@ -62,6 +60,7 @@ import org.alfresco.service.cmr.model.FileInfo;
 import org.alfresco.service.cmr.repository.ChildAssociationRef;
 import org.alfresco.service.cmr.repository.NodeRef;
 import org.alfresco.service.cmr.security.AccessStatus;
+import org.alfresco.service.cmr.security.PermissionService;
 import org.alfresco.service.cmr.site.SiteInfo;
 import org.alfresco.service.cmr.site.SiteService;
 import org.alfresco.service.namespace.NamespaceService;
@@ -88,7 +87,7 @@ public class JSONConversionComponent extends    org.alfresco.repo.jscript.app.JS
     private static final String IS_RECORD_CONTRIBUTOR_GROUP_ENABLED = "isRecordContributorGroupEnabled";
     private static final String RECORD_CONTRIBUTOR_GROUP_NAME = "recordContributorGroupName";
     private static final String IS_VISIBLE_FOR_CURRENT_USER = "isVisibleForCurrentUser";
-    private static final String IS_ANY_HOLD_VISIBLE_FOR_CURRENT_USER = "isHoldVisibleForCurrentUser";
+    private static final String IS_ADD_TO_HOLD_AVAILABLE = "isAddToHoldAvailable";
 
     /** true if record contributor group is enabled, false otherwise */
     private boolean isRecordContributorsGroupEnabled = false;
@@ -119,9 +118,6 @@ public class JSONConversionComponent extends    org.alfresco.repo.jscript.app.JS
      */
     private DispositionService dispositionService;
 
-    /** Hold service */
-    private HoldService holdService;
-
     /** Indicators */
     private List<BaseEvaluator> indicators = new ArrayList<>();
 
@@ -269,14 +265,6 @@ public class JSONConversionComponent extends    org.alfresco.repo.jscript.app.JS
         this.dispositionService = dispositionService;
     }
 
-    /**
-     * @param holdService hold service
-     */
-    public void setHoldService(HoldService holdService)
-    {
-        this.holdService = holdService;
-    }
-
     /**
      * The initialise method
      */
@@ -342,18 +330,9 @@ public class JSONConversionComponent extends    org.alfresco.repo.jscript.app.JS
                 }
             }
 
-            List<NodeRef> holds = holdService.heldBy(nodeRef, false);
-            if (!CollectionUtils.isEmpty(holds))
+            if (AccessStatus.ALLOWED.equals(permissionService.hasPermission(nodeRef, PermissionService.WRITE)))
             {
-                for (NodeRef hold : holds)
-                {
-                    // return true as soon as we find one hold we have filling permission on
-                    if (AccessStatus.ALLOWED.equals(permissionService.hasPermission(hold, RMPermissionModel.FILING)))
-                    {
-                        rootJSONObject.put(IS_ANY_HOLD_VISIBLE_FOR_CURRENT_USER, true);
-                        break;
-                    }
-                }
+                rootJSONObject.put(IS_ADD_TO_HOLD_AVAILABLE, true);
             }
         }
     }