Simplify inequality check as suggested in code review.

This commit is contained in:
Tom Page
2018-01-08 08:34:42 +00:00
parent 496b2ca208
commit f7e98b5df2

View File

@@ -32,6 +32,7 @@ import static org.apache.commons.lang3.BooleanUtils.isNotTrue;
import java.io.Serializable; import java.io.Serializable;
import java.util.Date; import java.util.Date;
import java.util.Map; import java.util.Map;
import java.util.Objects;
import java.util.Set; import java.util.Set;
import org.alfresco.error.AlfrescoRuntimeException; import org.alfresco.error.AlfrescoRuntimeException;
@@ -261,8 +262,6 @@ public class DispositionProperty extends BaseBehaviourBean
Serializable beforeValue = before.get(propertyName); Serializable beforeValue = before.get(propertyName);
Serializable afterValue = after.get(propertyName); Serializable afterValue = after.get(propertyName);
return ((beforeValue == null && afterValue != null) return !Objects.equals(beforeValue, afterValue);
|| (beforeValue != null && afterValue == null)
|| (beforeValue != null && afterValue != null && !beforeValue.equals(afterValue)));
} }
} }