From ff3bde47cd2a5aba4711afaace4423009f6ecd8d Mon Sep 17 00:00:00 2001
From: Alan Davis <alan.davis@alfresco.com>
Date: Fri, 2 Oct 2020 09:06:21 +0100
Subject: [PATCH] REPO-5358 Deployment modules should extend each other

The alfresco-community-repo's deployment module now provides the basis for alfresco-enterprise-repo and acs-packaging
deployment modules. This makes it like the other branches and avoids duplication of licenses between projects.

(partial picked from commit 80f04dc916e3f0ed29176d0f348bea3a61245ba6)
---
 packaging/distribution/pom.xml       | 14 ++++++++++
 packaging/docker-alfresco/Dockerfile |  7 ++---
 packaging/docker-alfresco/pom.xml    | 41 ++++++++++++----------------
 packaging/pom.xml                    |  4 +++
 4 files changed, 39 insertions(+), 27 deletions(-)
 create mode 100644 packaging/distribution/pom.xml

diff --git a/packaging/distribution/pom.xml b/packaging/distribution/pom.xml
new file mode 100644
index 0000000000..0b230cf5b4
--- /dev/null
+++ b/packaging/distribution/pom.xml
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+    <modelVersion>4.0.0</modelVersion>
+    <groupId>org.alfresco</groupId>
+    <artifactId>alfresco-community-repo-distribution</artifactId>
+    <name>Package Licences and Keystore for Distribution</name>
+    <packaging>jar</packaging>
+
+    <parent>
+        <groupId>org.alfresco</groupId>
+        <artifactId>alfresco-community-repo-packaging</artifactId>
+        <version>6.56.15.300-TEST2-SNAPSHOT</version>
+    </parent>
+</project>
diff --git a/packaging/docker-alfresco/Dockerfile b/packaging/docker-alfresco/Dockerfile
index acca3f6689..5011d89b05 100644
--- a/packaging/docker-alfresco/Dockerfile
+++ b/packaging/docker-alfresco/Dockerfile
@@ -7,6 +7,7 @@ ARG resource_path=target
 
 # Create prerequisite to store tools and properties
 RUN mkdir -p /usr/local/tomcat/shared/classes/alfresco/extension && \
+    mkdir /licenses && \
     mkdir /usr/local/tomcat/alfresco-mmt
 RUN touch /usr/local/tomcat/shared/classes/alfresco-global.properties
 
@@ -14,13 +15,11 @@ RUN touch /usr/local/tomcat/shared/classes/alfresco-global.properties
 # Copy the WAR files to the appropriate location for your application server
 # Copy the JDBC drivers for the database you are using to the lib/ directory.
 # Copy the alfresco-mmt.jar
+# Copy Licenses to the root of the Docker image
 COPY ${resource_path}/war /usr/local/tomcat/webapps
 COPY ${resource_path}/connector/* /usr/local/tomcat/lib/
 COPY ${resource_path}/alfresco-mmt/* /usr/local/tomcat/alfresco-mmt/
-
-# Copy Licenses to the root of the Docker image
-RUN mkdir /licenses
-COPY ${resource_path}/licenses/ /licenses/
+COPY ${resource_path}/dependency/licenses/ /licenses/
 
 # Change the value of the shared.loader= property to the following:
 # shared.loader=${catalina.base}/shared/classes
diff --git a/packaging/docker-alfresco/pom.xml b/packaging/docker-alfresco/pom.xml
index 9c42e816f1..c2367f3256 100644
--- a/packaging/docker-alfresco/pom.xml
+++ b/packaging/docker-alfresco/pom.xml
@@ -16,29 +16,6 @@
 
     <build>
         <plugins>
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-resources-plugin</artifactId>
-                <executions>
-                   <execution>
-                      <id>copy-licenses</id>
-                      <phase>process-resources</phase>
-                      <goals>
-                          <goal>copy-resources</goal>
-                      </goals>
-                      <configuration>
-                          <resources>
-                              <resource>
-                                  <!-- Extract licenses directory -->
-                                  <directory>../distribution/src/main/resources/licenses</directory>
-                                  <filtering>false</filtering>
-                              </resource>
-                          </resources>
-                          <outputDirectory>${project.build.directory}/licenses</outputDirectory>
-                      </configuration>
-                   </execution>
-                </executions>
-            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-dependency-plugin</artifactId>
@@ -126,6 +103,24 @@
                             </artifactItems>
                         </configuration>
                     </execution>
+
+                    <execution>
+                        <id>unpack-licenses</id>
+                        <phase>process-resources</phase>
+                        <goals>
+                            <goal>unpack</goal>
+                        </goals>
+                        <configuration>
+                            <artifactItems>
+                                <artifactItem>
+                                    <groupId>org.alfresco</groupId>
+                                    <artifactId>alfresco-community-repo-distribution</artifactId>
+                                    <type>jar</type>
+                                    <version>${project.version}</version>
+                                </artifactItem>
+                            </artifactItems>
+                        </configuration>
+                    </execution>
                 </executions>
             </plugin>
         </plugins>
diff --git a/packaging/pom.xml b/packaging/pom.xml
index 1a783e4dfe..32ff038435 100644
--- a/packaging/pom.xml
+++ b/packaging/pom.xml
@@ -18,6 +18,7 @@
             </activation>
             <modules>
                 <module>war</module>
+                <module>distribution</module>
                 <module>docker-alfresco</module>
             </modules>
         </profile>
@@ -25,18 +26,21 @@
             <id>community</id>
             <modules>
                 <module>war</module>
+                <module>distribution</module>
             </modules>
         </profile>
         <profile>
             <id>communityDocker</id>
             <modules>
                 <module>war</module>
+                <module>distribution</module>
                 <module>docker-alfresco</module>
             </modules>
         </profile>
         <profile>
             <id>all-tas-tests</id>
             <modules>
+                <module>distribution</module>
                 <module>tests</module>
             </modules>
         </profile>