Tuna Aksoy
d58cfe667b
Fixed minor issues reported by sonar (Unread public/protected field)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63814 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:45:08 +00:00
Tuna Aksoy
36f8250826
Fixed major issues reported by sonar (Use Index Of Char)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63813 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:30:55 +00:00
Tuna Aksoy
1db449f921
Fixed major issues reported by sonar (Performance - Method invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63812 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:28:52 +00:00
Tuna Aksoy
91a5d0e502
Fixed major issues reported by sonar (Useless Overriding Method)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63811 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:26:33 +00:00
Tuna Aksoy
b716d4c23c
Fixed major issues reported by sonar (Parameter Name)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63810 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:23:48 +00:00
Tuna Aksoy
cb22887740
Fixed major issues reported by sonar (If Stmts Must Use Braces)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63809 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:22:30 +00:00
Tuna Aksoy
ee4b49255b
Fixed major issues reported by sonar (Local Variable Name)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63808 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:20:58 +00:00
Tuna Aksoy
7ed08a206f
Fixed major issues reported by sonar (Hide Utility Class Constructor)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63807 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:15:35 +00:00
Tuna Aksoy
807e6179ca
Fixed critical issues reported by sonar (Simplify Conditional)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63806 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:03:24 +00:00
Tuna Aksoy
283fb3aca9
Fixed critical issues reported by sonar (Performance - Method invokes inefficient Number constructor; use static valueOf instead)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63805 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:54:42 +00:00
Tuna Aksoy
d01b4d5881
Fixed minor issues reported by sonar (Constant Name)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63803 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:45:53 +00:00
Tuna Aksoy
173abadbfa
Fixed minor issues reported by sonar (Useless String Value Of)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63802 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:39:32 +00:00
Tuna Aksoy
f4ada629de
Fixed minor issues reported by sonar (Empty Statements)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63801 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:36:32 +00:00
Tuna Aksoy
5d5d659456
Fixed minor issues reported by sonar (Collapsible If Statements)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63800 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:33:14 +00:00
Tuna Aksoy
f52a5c6f5d
Fixed minor issues reported by sonar (Redundant Modifier)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63799 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 20:48:40 +00:00
Tuna Aksoy
0e976c1338
Story: RM-1206 (As a records user I want to be able to add records to a hold(s) I have permission to see so that I can freeze a record)
...
Sub-tasl: RM-1327 (Implement REST API for adding a record to the hold(s))
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63794 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-08 21:42:40 +00:00
Tuna Aksoy
e5abd6fb99
Refactored FreezeService after adding the HoldService
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63769 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-07 15:27:40 +00:00
Tuna Aksoy
90c40688ec
Story: RM-1206 (As a records user I want to be able to add records to a hold(s) I have permission to see so that I can freeze a record)
...
Sub-task: RM-1319 (Implement REST API for getting the holds)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63758 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-07 11:52:25 +00:00
Tuna Aksoy
0a40b0c0dd
Story: RM-1206 (As a records user I want to be able to add records to a hold(s) I have permission to see so that I can freeze a record)
...
Sub-task: RM-1325 (Implement Hold Service)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63732 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-06 22:39:54 +00:00
Tuna Aksoy
d924f111f1
RM-1297 (Access denied if file a record to Unfiled Records where inbound File to rule is set)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63561 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-03 21:58:56 +00:00
Tuna Aksoy
a08546e8b3
Fixed major issues reported by sonar (Preserve Stack Trace)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63502 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 22:36:31 +00:00
Tuna Aksoy
35f08f02f5
Fixed major issues reported by sonar (If Stmts Must Use Braces)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63501 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 22:23:03 +00:00
Tuna Aksoy
3d947e8b9e
Fixed minor issues reported by sonar (Redundant Modifier)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63498 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 17:01:05 +00:00
Tuna Aksoy
8c5e41ef2a
Fixed minor issues reported by sonar (Redundant Modifier)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63497 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 16:56:25 +00:00
Tuna Aksoy
c352137a94
Fixed minor issues reported by sonar (Redundant Modifier)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63496 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 16:49:44 +00:00
Tuna Aksoy
ad190c1731
Fixed critical issues reported by sonar (Empty If Stmt)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63495 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 16:40:09 +00:00
Tuna Aksoy
22a0417b55
Fixed critical issue reported by sonar (Dodgy - Redundant nullcheck of value known to be non-null)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63494 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 16:32:30 +00:00
Tuna Aksoy
4aeb679b28
Fixed critical issues reported by sonar (Dodgy - Dead store to local variable)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63493 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 16:28:31 +00:00
Tuna Aksoy
b5aa5a2237
RM-1204 (As a records user I want to manage the permissions of the root hold container so that I can control who can see the contents of the root hold container)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63383 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-27 13:16:42 +00:00
Mark Hibbins
ce89a20077
RM-1233, Can now specify file-to action folders and categories longer than 255 characters
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63283 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-26 12:08:48 +00:00
Tuna Aksoy
4642f1c366
Merged V2.1 to HEAD:
...
63128: RM-1280: It's possible to create a folder in the root of File Plan via FTP/CIFS/WebDav/NFS
63265: RM-1183 (Null is displayed in values of Supplemental Marking/Transfer Locations selection lists)
63266: RM-879 (Web script error when event used in disposition schedule is removed from Management Console)
63267: RM-1101 (Label is missing for Supplemental Markings/Transfer Locations list on Edit list page)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63280 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-26 11:33:35 +00:00
Tuna Aksoy
2918a8ab43
RM-1183 (Null is displayed in values of Supplemental Marking/Transfer Locations selection lists)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/BRANCHES/V2.1@63265 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-26 09:29:17 +00:00
Mark Hibbins
d2f7765e05
RM-1144, Added max suggestions config, custom properties inclusion and made ui tests more robust
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63260 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-25 19:22:40 +00:00
Tuna Aksoy
c3d8944c44
RM-1203 (As a records user I want to create a new hold so that I can add records to it)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63190 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-24 21:45:18 +00:00
Roy Wetherall
ec04003e69
RM-1280: It's possible to create a folder in the root of File Plan via FTP/CIFS/WebDav/NFS
...
RM-1281: Not possible to create folders in Categories via FTP/CIFS/WebDav/NFS
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/BRANCHES/V2.1@63128 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-24 04:58:53 +00:00
Mark Hibbins
a6035622a6
RM-1234, Changed formatting of date.year.week substitution to match help text
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63075 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-21 18:06:49 +00:00
Mark Hibbins
630de39df6
RM-1169, File-to path substitution to include node parameter
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63051 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-21 15:24:10 +00:00
Roy Wetherall
f543196adb
Unit test for type form filter
...
* experimenting to see if Mockito would allow us to unit test code previously difficult to test
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63014 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-21 07:36:35 +00:00
Roy Wetherall
f69cd3961e
RM-1194: As a records manager I want to create a 'standard' RM site that only displays records meta-data types relevant to standard RM practices, so that I don't get confused by unwanted DoD records meta-data types.
...
* record metadata aspects are now configured via spring and includes which file plan type they are relevant for
* added 'unit test' structure .. for 'real' unit tests, ie anything that doesn't load the application context
* included Mockito, new source location and unit test suite into POM
* added unit and functional tests for feature (server)
* refactored accordingly (webscripts, UI, etc)
* visual test of UI .. automation tests to follow
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63013 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-21 05:40:26 +00:00
Roy Wetherall
ea10e2c2b8
Merged V21 to HEAD:
...
62861: RM-1261: Records/Folders scheduled for destruction can be deleted by user without required capabilities
RM-1258: It's possible to edit, delete and create (via copy) new category without "Create Modify Destroy File Plan Metadata" capability
62862: RM-1267: Delete Record capability is needed to delete the reference
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@62863 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-20 04:25:16 +00:00
Roy Wetherall
4b3aaa171d
RM-1267: Delete Record capability is needed to delete the reference
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/BRANCHES/V2.1@62862 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-20 03:41:20 +00:00
Mark Hibbins
bf0bee9f59
RM-1144, Path substitution suggestion functionality
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@62684 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-17 17:08:22 +00:00
Roy Wetherall
5c21719195
Refacoting of RecordService implementation based on SONAR report
...
* detangle of services
* simplification of spring dependancies
* use of base service impl
* unit tests and Ui integraion tests run locally
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@62646 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-17 03:49:27 +00:00
Roy Wetherall
4614700b89
Merged V2.1 to HEAD:\
...
59208: RM-1115: Manage Rules action is available for a Frozen folder - Added condition that manage rules isn't shown for frozen folders
59343: RM-1114: 'Loading the Document Library' message is displayed on a New Rule page in RM Site - Added appropriate message.loading properties to all languages for rule-details.get and rule-edit.get where this message is used
59361: RM-1105: Adding the RM module causes exceptions when listing the existing audit applications through the audit webscript - Added a try/catch for a ClassCastException around the check to see if the returned object contained a PROP_HOLD_REASON in the RMAfterInvocationProvider. The reason for this is that the containsKeys method will throw a class cast exception if we attempt to see if the keys contain an instance of QName if the returnedObject instance is a TreeMap containing strings as is the case when listing the audit applications through the RESTful interface.
59510: RM-1087: Increase default max number of site pages to 5 instead of 3 - Increased default maximum number of sites pages to 5 in rm-share-config.xml. This threw up an issue in the code that adds the RM Console widget so fixed that too. Important test case for this are that the number of widgets added to the site are smaller than, equal to and greater than the maximum displayed to ensure that the code adding the RM console is fully exercised.
60429: RM-1162: CLONE - Alfresco 4.2.1 could not start with RM module
* see MNT-10259
60430: RM-1162: CLONE - Alfresco 4.2.1 could not start with RM module
* see MNT-10259
* missed files
60431: RM-1162: CLONE - Alfresco 4.2.1 could not start with RM module
* failing tests
* see MNT-10259
60478: RM-1174 (Unable to view record details)
60698: RM-1175: Internal Error on details page of category/folder/record
60699: RM-1177: User's name link on User Rights Report page directs to Admin Console instead of User Profile Page
60700: RM-1176: Couldn't load email mappings
61227: RM-1164: RM 2.1.1 core language bundle refresh
62414: RM-1165 (RM 2.1.1 translation into Simplified Chineese)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@62565 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-14 02:35:16 +00:00
Roy Wetherall
ab04d2ad87
Ensure create category behaviour is executed with sufficient rights.
...
* fixes FileToCreatePathIntegration test
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@62554 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-13 20:56:28 +00:00
Roy Wetherall
295abc79d2
RM-1226: Unable to delete rm site containing category/folder hierarchy which contains a filed record
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@62494 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-13 04:16:20 +00:00
Tuna Aksoy
3bee82f45d
Removed the unused method and the warning
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@61321 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-07 09:31:01 +00:00
Mark Hibbins
241a88c1e3
RM-1144 & RM-1145 - changes to file to action - post review changes
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@61188 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-05 21:23:03 +00:00
Mark Hibbins
24404bab60
RM-1144 & RM-1145 - changes to file to action (forgot to add some file)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@61047 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-04 18:22:09 +00:00
Mark Hibbins
bf3076da88
RM-1144 & RM-1145 - changes to file to action
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@61046 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-04 18:19:37 +00:00