Commit Graph

481 Commits

Author SHA1 Message Date
Tuna Aksoy
0ed42e691c Fixed critical issues reported by sonar (Simplify Conditional)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63806 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:03:24 +00:00
Tuna Aksoy
b64f1467b4 Fixed critical issues reported by sonar (Performance - Method invokes inefficient Number constructor; use static valueOf instead)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63805 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:54:42 +00:00
Tuna Aksoy
3810d137d7 Fixed minor issues reported by sonar (Constant Name)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63803 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:45:53 +00:00
Tuna Aksoy
70010a32d4 Fixed minor issues reported by sonar (Useless String Value Of)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63802 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:39:32 +00:00
Tuna Aksoy
5a6429aa2f Fixed minor issues reported by sonar (Empty Statements)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63801 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:36:32 +00:00
Tuna Aksoy
28b0a01065 Fixed minor issues reported by sonar (Collapsible If Statements)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63800 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:33:14 +00:00
Tuna Aksoy
dee5508911 Fixed minor issues reported by sonar (Redundant Modifier)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63799 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 20:48:40 +00:00
Tuna Aksoy
67cf34c213 Story: RM-1206 (As a records user I want to be able to add records to a hold(s) I have permission to see so that I can freeze a record)
Sub-tasl: RM-1327 (Implement REST API for adding a record to the hold(s))

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63794 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-08 21:42:40 +00:00
Tuna Aksoy
39c17215b7 Refactored FreezeService after adding the HoldService
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63769 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-07 15:27:40 +00:00
Tuna Aksoy
839de8e80c Story: RM-1206 (As a records user I want to be able to add records to a hold(s) I have permission to see so that I can freeze a record)
Sub-task: RM-1319 (Implement REST API for getting the holds)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63758 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-07 11:52:25 +00:00
Tuna Aksoy
31f8d362b1 Story: RM-1206 (As a records user I want to be able to add records to a hold(s) I have permission to see so that I can freeze a record)
Sub-task: RM-1325 (Implement Hold Service)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63732 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-06 22:39:54 +00:00
Tuna Aksoy
f07539e5e1 RM-1297 (Access denied if file a record to Unfiled Records where inbound File to rule is set)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63561 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-03 21:58:56 +00:00
Tuna Aksoy
8f18f765d3 Fixed major issues reported by sonar (Preserve Stack Trace)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63502 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 22:36:31 +00:00
Tuna Aksoy
8c994439be Fixed major issues reported by sonar (If Stmts Must Use Braces)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63501 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 22:23:03 +00:00
Tuna Aksoy
505e29499a Fixed minor issues reported by sonar (Redundant Modifier)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63498 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 17:01:05 +00:00
Tuna Aksoy
172fcf3d77 Fixed minor issues reported by sonar (Redundant Modifier)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63497 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 16:56:25 +00:00
Tuna Aksoy
90c08059e3 Fixed minor issues reported by sonar (Redundant Modifier)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63496 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 16:49:44 +00:00
Tuna Aksoy
83f2f59bcb Fixed critical issues reported by sonar (Empty If Stmt)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63495 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 16:40:09 +00:00
Tuna Aksoy
6df1a7bca4 Fixed critical issue reported by sonar (Dodgy - Redundant nullcheck of value known to be non-null)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63494 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 16:32:30 +00:00
Tuna Aksoy
43a2f10ef6 Fixed critical issues reported by sonar (Dodgy - Dead store to local variable)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63493 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-02 16:28:31 +00:00
Tuna Aksoy
53b15ec26a RM-1204 (As a records user I want to manage the permissions of the root hold container so that I can control who can see the contents of the root hold container)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63383 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-27 13:16:42 +00:00
Mark Hibbins
c9a1328769 RM-1233, Can now specify file-to action folders and categories longer than 255 characters
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63283 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-26 12:08:48 +00:00
Tuna Aksoy
23b76f4026 Merged V2.1 to HEAD:
63128: RM-1280: It's possible to create a folder in the root of File Plan via FTP/CIFS/WebDav/NFS
   63265: RM-1183 (Null is displayed in values of Supplemental Marking/Transfer Locations selection lists)
   63266: RM-879 (Web script error when event used in disposition schedule is removed from Management Console)
   63267: RM-1101 (Label is missing for Supplemental Markings/Transfer Locations list on Edit list page)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63280 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-26 11:33:35 +00:00
Tuna Aksoy
af19a07278 RM-1183 (Null is displayed in values of Supplemental Marking/Transfer Locations selection lists)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/BRANCHES/V2.1@63265 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-26 09:29:17 +00:00
Mark Hibbins
5549dc0925 RM-1144, Added max suggestions config, custom properties inclusion and made ui tests more robust
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63260 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-25 19:22:40 +00:00
Tuna Aksoy
68341737ba RM-1203 (As a records user I want to create a new hold so that I can add records to it)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63190 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-24 21:45:18 +00:00
Roy Wetherall
b8f699ec23 RM-1280: It's possible to create a folder in the root of File Plan via FTP/CIFS/WebDav/NFS
RM-1281: Not possible to create folders in Categories via FTP/CIFS/WebDav/NFS



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/BRANCHES/V2.1@63128 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-24 04:58:53 +00:00
Mark Hibbins
7b34e060f9 RM-1234, Changed formatting of date.year.week substitution to match help text
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63075 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-21 18:06:49 +00:00
Mark Hibbins
cc073a62d3 RM-1169, File-to path substitution to include node parameter
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63051 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-21 15:24:10 +00:00
Roy Wetherall
2a9704ba64 Unit test for type form filter
* experimenting to see if Mockito would allow us to unit test code previously difficult to test



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63014 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-21 07:36:35 +00:00
Roy Wetherall
a01c6a1a42 RM-1194: As a records manager I want to create a 'standard' RM site that only displays records meta-data types relevant to standard RM practices, so that I don't get confused by unwanted DoD records meta-data types.
* record metadata aspects are now configured via spring and includes which file plan type they are relevant for
 * added 'unit test' structure .. for 'real' unit tests, ie anything that doesn't load the application context
 * included Mockito, new source location and unit test suite into POM
 * added unit and functional tests for feature (server)
 * refactored accordingly (webscripts, UI, etc)
 * visual test of UI .. automation tests to follow



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63013 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-21 05:40:26 +00:00
Roy Wetherall
d1e218a846 Merged V21 to HEAD:
62861: RM-1261: Records/Folders scheduled for destruction can be deleted by user without required capabilities
          RM-1258: It's possible to edit, delete and create (via copy) new category without "Create Modify Destroy File Plan Metadata" capability 
   62862: RM-1267: Delete Record capability is needed to delete the reference



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@62863 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-20 04:25:16 +00:00
Roy Wetherall
59a4b2893a RM-1267: Delete Record capability is needed to delete the reference
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/BRANCHES/V2.1@62862 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-20 03:41:20 +00:00
Mark Hibbins
3e5620cc87 RM-1144, Path substitution suggestion functionality
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@62684 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-17 17:08:22 +00:00
Roy Wetherall
fdfb698095 Refacoting of RecordService implementation based on SONAR report
* detangle of services
 * simplification of spring dependancies
 * use of base service impl
 * unit tests and Ui integraion tests run locally 



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@62646 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-17 03:49:27 +00:00
Roy Wetherall
e0eff9e81b Merged V2.1 to HEAD:\
59208: RM-1115: Manage Rules action is available for a Frozen folder - Added condition that manage rules isn't shown for frozen folders
   59343: RM-1114: 'Loading the Document Library' message is displayed on a New Rule page in RM Site - Added appropriate message.loading properties to all languages for rule-details.get and rule-edit.get where this message is used
   59361: RM-1105: Adding the RM module causes exceptions when listing the existing audit applications through the audit webscript - Added a try/catch for a ClassCastException around the check to see if the returned object contained a PROP_HOLD_REASON in the RMAfterInvocationProvider. The reason for this is that the containsKeys method will throw a class cast exception if we attempt to see if the keys contain an instance of QName if the returnedObject instance is a TreeMap containing strings as is the case when listing the audit applications through the RESTful interface.
   59510: RM-1087: Increase default max number of site pages to 5 instead of 3 - Increased default maximum number of sites pages to 5 in rm-share-config.xml. This threw up an issue in the code that adds the RM Console widget so fixed that too. Important test case for this are that the number of widgets added to the site are smaller than, equal to and greater than the maximum displayed to ensure that the code adding the RM console is fully exercised.
   60429: RM-1162: CLONE - Alfresco 4.2.1 could not start with RM module
       * see MNT-10259
   60430: RM-1162: CLONE - Alfresco 4.2.1 could not start with RM module
       * see MNT-10259
       * missed files
   60431: RM-1162: CLONE - Alfresco 4.2.1 could not start with RM module
       * failing tests
       * see MNT-10259
   60478: RM-1174 (Unable to view record details)
   60698: RM-1175: Internal Error on details page of category/folder/record
   60699: RM-1177: User's name link on User Rights Report page directs to Admin Console instead of User Profile Page
   60700: RM-1176: Couldn't load email mappings
   61227: RM-1164: RM 2.1.1 core language bundle refresh
   62414: RM-1165 (RM 2.1.1 translation into Simplified Chineese)



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@62565 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-14 02:35:16 +00:00
Roy Wetherall
728a5bd7bb Ensure create category behaviour is executed with sufficient rights.
* fixes FileToCreatePathIntegration test



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@62554 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-13 20:56:28 +00:00
Roy Wetherall
805495ef3e RM-1226: Unable to delete rm site containing category/folder hierarchy which contains a filed record
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@62494 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-13 04:16:20 +00:00
Tuna Aksoy
646f0dd87b Removed the unused method and the warning
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@61321 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-07 09:31:01 +00:00
Mark Hibbins
9ce6a21575 RM-1144 & RM-1145 - changes to file to action - post review changes
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@61188 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-05 21:23:03 +00:00
Mark Hibbins
0723b193e3 RM-1144 & RM-1145 - changes to file to action (forgot to add some file)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@61047 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-04 18:22:09 +00:00
Mark Hibbins
01a232a29a RM-1144 & RM-1145 - changes to file to action
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@61046 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-04 18:19:37 +00:00
Roy Wetherall
45f47af6a9 RM-1147: A user can create a 'vanilla' or DOD compliant records management site
* RM-1178: Add DOD site and file plan types to DOD specific content model
 * RM-1179: Extend create site dialog to set allow creation of DOD compliant RM site
 * RM-1180: Create a patch to update all existing file plans to be, by default, DOD compliant




git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@60943 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-02-03 05:28:56 +00:00
Tuna Aksoy
664dfcf77c Bug fixing for RM-1124, RM-1125, RM-1126 and RM-1127
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@60648 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-01-28 11:40:43 +00:00
Tuna Aksoy
a88193cda7 RM-1124 (RM user can create a folder within the unfiled records area)
RM-1125 (RM user can delete a folder within the unfiled records area)
RM-1126 (RM user can edit the meta-data of a folder within the unfiled records area)
RM-1127 (RM user can view the details of a folder in the unfiled records area)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@60639 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-01-27 22:10:17 +00:00
Roy Wetherall
9fe518548b RM-1162: CLONE - Alfresco 4.2.1 could not start with RM module
* see MNT-10259



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/BRANCHES/V2.1@60429 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-01-23 01:47:00 +00:00
Tuna Aksoy
4ff24f8310 RM revision recovery
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@60128 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-01-18 23:30:35 +00:00
Roy Wetherall
868fa5134d RM-1116: Add global DOD enabled configuration
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@59991 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-01-16 09:07:02 +00:00
Tuna Aksoy
ed7cfe5598 RM-1124 (RM user can create a folder within the unfiled records area)
RM-1125 (RM user can delete a folder within the unfiled records area)
RM-1126 (RM user can edit the meta-data of a folder within the unfiled records area)
RM-1127 (RM user can view the details of a folder in the unfiled records area)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@59986 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-01-15 23:16:32 +00:00
Roy Wetherall
e8d8fd98ca RM-765: Ensure schema based patches are not executed on a newly installed system
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@59974 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-01-15 17:33:55 +00:00