Commit Graph

981 Commits

Author SHA1 Message Date
Tom Page
2dcdc2f727 RM-2466 Pass through total results count as if nothing is filtered.
Change PagingResultsPostMethodInvocationProcessor to always return the
total results count as if nothing is filtered. This should fix the case
where nothing is filtered, and is a concession to the fact that we cannot
know how many total results there will be from a single page. We will fix
this later by filtering the results before we get to this processor, but
the processor is a good backup filter.

Change the rm-automation tests not to use the pagination details at the
bottom of the browse list pages, as these will often now be incorrect.

In making this change I also looked at using the getTotalResultCount()
interface with a range as the interface supports returning a minimum and
maximum on the total number of results. This would be very useful here,
as it should allow us to say that we don't know how many results there
will be.  However most of the webscripts don't support a range, and so
this leads to some odd results in Share (e.g. 'Showing results 1 to 50
of -1').

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108482 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-17 09:01:00 +00:00
Tuna Aksoy
2fca73abcf RM-2466 (Show the correct number of existing pages and make them available for navigation in the Security Clearance page)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108366 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-15 16:25:24 +00:00
Neil McErlean
4b31b3d2e9 Added missing testcase, part of RM-2343. Test ensures that whitespace-only values for 'classified by' result in a 4xx HTTP response.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108248 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-14 11:43:10 +00:00
Neil McErlean
719b6248b0 Part of RM-2343. Ensure that blank or whitespace-only values for the 'Classified By' field are not accepted.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108246 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-14 11:13:06 +00:00
Tuna Aksoy
554ad56e63 Fixed failing automated UI tests
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108149 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-11 15:56:28 +00:00
Tuna Aksoy
fd680d6ec5 RM-2388 (User without any clearance should not see the classify action)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108131 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-10 15:50:55 +00:00
Tuna Aksoy
087c926d1b RM-2129 (Check classification before method execution)
* Preventing access to information without appropriate security clearance

+review RM-117

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107738 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-06 15:24:26 +00:00
Tuna Aksoy
b035fee545 RM-2129 (Check classification before method execution)
* Commenting the list of pre enforcement check methods temporarily out. getProperties causes problems in the UI although all the integration tests succeed.

+review RM-117

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107681 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-03 15:28:05 +00:00
Tuna Aksoy
2fbfa84b35 RM-2129 (Check classification before method execution)
+review RM-117

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107676 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-03 14:41:53 +00:00
Tuna Aksoy
fc27e39843 RM-2129 (Check classification before method execution)
+review RM @rwetherall

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107649 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-02 18:05:18 +00:00
Tuna Aksoy
0ea850d558 RM-2130 (Check classification after method execution, filtering results where appropriate)
- Code refactored

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107441 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-30 19:15:27 +00:00
Neil McErlean
b37ce590c0 RM-2333, RM-2341, RM-2342, RM-2343, RM-2344, RM-2346.
Changed Classification Agency to optional throughtout the stack and added a new mandatory property Classified By throughout the stack.
Addressing the fallout in the existing tests due to these changes.
Also enhanced some existing tests to validate the classified by value persistence.

Still to do: need to initialise the Classified By field in the Classify dialog to the current user's full name (not as easy as I'd thought) and add additional AC tests.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107433 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-30 15:32:47 +00:00
Tuna Aksoy
5cba834058 Workflows could not be started after classification enforcement
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107368 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-29 21:27:25 +00:00
Tuna Aksoy
5ce8ba691a Merged DEV/ENFORCE to HEAD:
105194: First pass at classification interceptor
   105294: Fixed compilation issue
   105323: Updated Aikau version to 1.0.20
   105565: RM-2129 (Check classification before method execution)
   105923: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106103: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106104: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106169: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106187: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106283: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106356: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106552: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106639: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106657: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106658: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106772: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106774: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107009: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107163: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107164: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107246: RM-2130 Post method invocation processor for QueryEngineResults.
   107252: RM-2130 (Post method invocation processor for QueryEngineResults)
   107253: RM-2130 Make CollectionPostMethodInvocationProcessor concrete.
   107257: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107270: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107272: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107273: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107274: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107275: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107282: RM-2130 Add support for other collections than Lists.
   107344: RM-2367 (Automate AC: Access to saved search)
   107355: RM-2130 Support for specific instantiable collections.
   107363: RM-2130 (Check classification after method execution, filtering results where appropriate)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107367 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-29 21:24:16 +00:00
Tuna Aksoy
fd7351d338 RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107363 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-29 17:03:48 +00:00
Tom Page
2ab9c52517 RM-2130 Support for specific instantiable collections.
It's impossible to instantiate/clone a generic collection, so if a member of the collection
changes then our only option is to attempt to remove it.  This has two problems. Firstly,
this is far more brutal than we desire in many cases. Secondly, some collections do not
implement the remove method (e.g. anything returned by Arrays.asList()).

As an attempt to work around this issue we've created some specific implementation
processors. This introduces new potential problems - e.g. if someone has used an exotic
type of list it will be replaced with an ArrayList by the ListPostMethodInvocationProcessor.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107355 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-29 15:18:49 +00:00
Tom Page
e2d6d363a4 RM-2130 Add support for other collections than Lists.
Unfortunately most methods in the CollectionUtils helper class convert
collections to lists, and so is not suitable for our usage.

+review RM @taksoy

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107282 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-29 08:48:10 +00:00
Tuna Aksoy
039c0cd8d2 RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107275 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-28 19:50:07 +00:00
Tuna Aksoy
985d8de393 RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107272 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-28 13:39:10 +00:00
Tuna Aksoy
e6b3975ee8 RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107270 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-27 22:23:19 +00:00
Tuna Aksoy
06e273bb9f RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107257 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-26 16:00:26 +00:00
Tom Page
30c3a1eda7 RM-2130 Make CollectionPostMethodInvocationProcessor concrete.
+review RM-113

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107253 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-26 15:36:13 +00:00
Tuna Aksoy
53c55fd8c5 RM-2130 (Post method invocation processor for QueryEngineResults)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107252 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-26 15:28:22 +00:00
Tom Page
858afc00f5 RM-2130 Post method invocation processor for QueryEngineResults.
+review RM @taksoy

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107246 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-26 14:47:03 +00:00
Tuna Aksoy
62e12cadaf RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107164 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-25 22:45:52 +00:00
Neil McErlean
cdcd367e68 RM-2333. Rename ClassificationAuthority to ClassificationAgency. +review RM
This addresses parts of RM-2341, RM-2342, RM-2343 and RM-2344. It replaces authority with agency in the content model
, the services and their APIs, the UI layer and the rm-automation tests.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107108 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-25 13:24:38 +00:00
Tuna Aksoy
aa6326cc54 RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107009 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-24 19:39:48 +00:00
Tuna Aksoy
87d77fd755 RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106774 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-22 22:41:26 +00:00
Tuna Aksoy
21a62b3e1f RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106772 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-22 21:52:08 +00:00
Tuna Aksoy
5cc5da5e9e RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106658 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-21 21:58:42 +00:00
Tuna Aksoy
eee6c481ce RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106657 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-21 19:47:57 +00:00
Tuna Aksoy
cb7811c693 RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106639 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-20 18:42:32 +00:00
Tom Page
58cd957bd5 RM-2326 Rest API for GET exemption categories.
+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106576 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 15:35:32 +00:00
Tom Page
1ef89f8ebb RM-2320 Java API for getExemptionCategories.
Also RM-2321 automation testing for the initial loading of exemption
categories.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106565 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 14:28:20 +00:00
Tuna Aksoy
0a0ccbc76c RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106552 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 12:39:04 +00:00
Tom Page
c29b51f179 RM-2319 Declare parameter key as "final".
This is needed to compile in java 7, but not java 8.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106532 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 10:16:06 +00:00
Tom Page
911f489875 RM-2319 Refactor ClassificationServiceBootstrap.
Simplify code to load classification levels, classification reasons and
exemption categories using the same method.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106530 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:52:20 +00:00
Tom Page
06d0c37b25 RM-2319 Validate classification reasons and exemption categories.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106529 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:52:18 +00:00
Tom Page
8f5a8334f7 RM-2319 Create a general classification scheme entity validator.
Replace the existing classification level validator with the new class.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106528 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:52:13 +00:00
Tom Page
a4948b8a2a RM-2319 Separate the field validation from ClassificationLevelValidation.
Create field validators that are small and potentially re-usable.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106527 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:52:10 +00:00
Tom Page
64dbd9174d RM-2319 Refactor ClassificationServiceDAO.
All the config loading is now done by a single method using a factory to
create the individual entities.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106526 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:52:07 +00:00
Tom Page
86f339ec6c RM-2319 Create marker interface for entities created from config files.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106525 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:52:05 +00:00
Tom Page
ece8e174cb RM-2319 Bootstrap initial exemption categories into the system.
This change does not include any validation. There is currently no
validation being done for classification reasons either, so it seemed
to make sense to do both in a separate change.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106417 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-17 15:38:10 +00:00
Tuna Aksoy
49415773bc RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106356 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-16 20:17:27 +00:00
Tuna Aksoy
37b7d1270d RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106283 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-16 14:30:37 +00:00
Tuna Aksoy
1b2fa2630f RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106187 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-16 09:12:56 +00:00
Tuna Aksoy
90f787ea27 RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106169 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-15 20:59:10 +00:00
Neil McErlean
8932133146 Trivial changes. Improved an exception message after review comments and fixed a copyright year.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106143 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-15 13:37:14 +00:00
Neil McErlean
60e9d56536 Implementation of new tests as part of RM-2241.
Test to ensure the Unclassified abbreviation ('U') is rejected when duplicated by end user configuration.
Test to ensure any duplicate abbreviations are rejected.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106134 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-15 12:04:27 +00:00
Tuna Aksoy
e1a8997524 RM-2130 (Check classification after method execution, filtering results where appropriate)
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106104 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-14 22:32:59 +00:00