Commit Graph

1018 Commits

Author SHA1 Message Date
Tom Page
2e0c28fe1b RM-2502 Create new constraint for initial classification.
Previously we were restricting the initial classification to be a level
that the current user could access, but this is not always the case for
downgraded content.

Also add new integration test for initial classification constraint.

I tried adding a test that extended our BaseRMTestCase, but the
transactions all happened as system (or admin maybe?), and so the level 2
user is always allowed to reclassify level 1 content (by the constraint).
Consequently I ended up creating a stand-alone test for this.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@110144 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-08-14 13:34:56 +00:00
Tom Page
3c4becdd85 RM-2529 Add classified aspect as system rather than the user "admin".
This change causes ClassifyTest.testClassifyFrozenRecord() to fail. The
test is accurately reflecting a bug in the server that this change reveals
(or introduces).  See RM-2530.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@110137 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-08-14 12:48:57 +00:00
Neil McErlean
9355bddfe8 Implementation and unit tests for RM-2481, RM-2482, RM-2483 and RM-2489.
This checkin adds behaviours for ensuring that classification aspect/properties are correclty copied between nodes and their renditions on the creation of new renditions, on the classification or reclassification of nodes with existing renditions.

To do this I needed what should be, in my opinion, a common Alfresco utility method - the ability to copy an aspect from one node to another (aspect meaning property group i.e. no assocs).
I've created that method and put it in CoreServicesExtras. It should really be moved to core.

+ review RM


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@110069 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-08-13 16:29:38 +00:00
Roy Wetherall
eace8ef026 RM-2509: The destruction of electronic records is not possible as it gets ghosted before destruction.
* unit test added to reproduce issue



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109872 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-08-11 04:18:12 +00:00
Tom Page
05da180731 RM-2500 Enable editing of classification scheme.
Allow adding and removing classification levels, classification reasons and
exemption categories after the server has been started for the first time.
It is also possible to alter the display text associated with an existing
level, reason or category.  All changes require a server restart.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109854 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-08-10 13:45:44 +00:00
Tom Page
43ea2e5bc4 RM-2477 Treat the empty string in the same way as null.
Fix an issue in the behaviour checking where the empty string was being
passed as the instructions when nothing was set.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109843 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-08-10 10:24:57 +00:00
Roy Wetherall
c24479e4b5 Remove catch Throwables identified by Sonar
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109736 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-08-07 02:57:57 +00:00
Roy Wetherall
8f2f5258d1 Acceptance Criteria Automation for RM-1997: Content store data cleansing
* added @AlfrescoTest annotation dependency to help track AC's back to JIRA
 * feedback from previous review
 * see RM-2460, RM-2461, RM-2462, RM-2505, RM-2506, RM-2507

+review RM 



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109733 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-08-07 02:04:51 +00:00
Tuna Aksoy
7e61856833 RM-2402 (Extend classification schedule REST API)
RM-2433 (Extend reclassification REST API)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109730 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-08-06 22:10:14 +00:00
Neil McErlean
fbeafa2b6e RM-2440. Ensuring that users reclassifying content see the correct set of levels.
Added a new test case where an admin and an RM Manager (only cleared to secret) both try to reclassify a record.
Added a new group (GROUP_RM_MANAGER_FILE_CATEGORY_ONE) for an RM Manager who can file records as well as read.
Added some utility methods and fields.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109524 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-08-04 11:20:07 +00:00
Tuna Aksoy
355f17d2b3 RM-2433 (Extend REST API for content reclassification)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109307 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-31 15:30:43 +00:00
Tom Page
50bbb2b4ff RM-2470 Remove unnecessary cast (code review fix).
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109203 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-30 10:21:10 +00:00
Tuna Aksoy
1049d16238 RM-2448 (Extend classified document properties view)
RM-2449 (Extend classified record properties view)

+review RM-137

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109185 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-29 21:42:31 +00:00
Tuna Aksoy
63e0466482 RM-2402 (Extend classification REST API)
+review RM-143

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109184 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-29 20:11:28 +00:00
Tom Page
9edd378291 RM-2470 Change security clearance sorting to be by full name.
Enable sorting by multiple fields and configure the security clearance page
to use first name, last name and then fall back to user name as a tie
breaker.

The rm-automation test fails for me locally, as the person search is case
sensitive. I'm pushing this anyway because Bamboo didn't protest at the
old sorting method (which also failed locally due to case sensitivity).

Remove "final" from UserQueryParams so it can be mocked.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109169 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-29 15:16:25 +00:00
Tuna Aksoy
10495abb88 Temporary fix for the failing UI tests
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109158 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-29 13:35:05 +00:00
Tuna Aksoy
d895833b56 RM-2448 (Extend classified document properties view)
RM-2449 (Extend classified record properties view)

+review RM-137

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109139 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-29 10:25:32 +00:00
Tuna Aksoy
a08ea6908a RM-2402 (Extend classification REST API)
+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109137 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-29 10:23:26 +00:00
Roy Wetherall
24b6655eeb Data destruction and cleansing
* added content destruction component which ensures all records and classified content are immediately destroyed and optionally cleansed
 * extension to eager content cleaner to allow cleansing to take place just before the content is deleted from the content store
 * base content cleanser
 * simple implementation of DoD 5220-22M cleansing algoritm
 * data cleansing enabled global configuration
 * data cleansing bean configuration
 * unit tests
 * see RM-2463 and RM-2464

+review RM 



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109121 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-29 01:26:49 +00:00
Tuna Aksoy
8c441c8835 Fixed typo
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109021 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-27 12:43:31 +00:00
Tom Page
d8da135d63 RM-2401, RM-2400, RM-2409 Store classification schedule properties.
Update Java API to store the classification schedule properties.

Fix the classification aspect behaviour to check newly classified
documents.

Add an application context test that the downgrade instructions are
mandatory when the downgrade date is set.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@109015 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-27 10:27:16 +00:00
Neil McErlean
7322da8f66 Addressing review comments from RM-132. Original issues were RM-2431 and RM-2432.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108993 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-25 07:24:34 +00:00
Tom Page
49de2937c9 RM-2400 Add policy for classification schedule properties.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108941 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-24 13:19:09 +00:00
Tom Page
b1d88d737c RM-2401 Pass classification schedule fields when classifying content.
Create a new data transfer object and add all the classification fields to
it. Update everywhere we're classifying content with the API to use the
data transfer object.  Also update the new edit classification API.

Break the classifyContent implementation into several smaller methods and
update unit tests to target these methods.

Don't actually use new fields in this commit, as there was plenty in this
commit as it was!

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108928 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-24 09:36:52 +00:00
Tuna Aksoy
39aa063654 Fixed failing integration tests
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108913 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-23 22:07:23 +00:00
Tuna Aksoy
4376c2a152 Fixed version number in some java and js files
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108912 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-23 21:38:31 +00:00
Tuna Aksoy
992a3be30e RM-2421 (Add PUT method to classify content REST API)
+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108911 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-23 21:15:31 +00:00
Tuna Aksoy
c6f5d7d718 RM-2420 (Add edit classification to ClassifyService Java API)
+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108910 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-23 21:14:25 +00:00
Tuna Aksoy
671fbfcaa1 RM-2422 (Reuse existing classify file dialog for edit classification)
+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108909 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-23 21:13:05 +00:00
Neil McErlean
ebc34f9209 Work that's part of RM-2431 and RM-2432.
Added to the classified-content-model - various properties as described in RM-2431 along with a constraint on Reclassification Action.
Addition to the ClassificationSchemeService of methods and types associated with Reclassification. (Upgrade, Downgrade, Declassify). See RM-2432.
Behaviour bean that will automatically set lastReclassificationAction and lastReclassifyBy in response to any change to currentClassificationLevel.
Also some util methods in RMCollections.
Fixed some spelling mistakes in classification-related properties.



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108878 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-23 16:13:43 +00:00
Tom Page
9d5fb95ced RM-2400 Add new properties to ClassifiedContentModel.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108860 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-23 13:06:49 +00:00
Tom Page
3b159f2ba9 RM-2400 Add classification schedule properties to model.
Refactor constraints, and create new constraints for exemption categories
and classification reasons.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108859 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-23 13:06:48 +00:00
Tuna Aksoy
aff3da54ef RM-2129 (Check classification before method execution)
* Renamed ClassificationEnformentException to AccessDeniedException

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108657 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-21 12:49:06 +00:00
Tuna Aksoy
3ea9843ac3 RM-2129 (Check classification before method execution)
* Code tidy up

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108640 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-21 10:55:57 +00:00
Roy Wetherall
9a9560fa6c Fixes to classification enforcement:
* only process services that start with an upper case character.  We were being over zealous in our checking which was causing problems, we only care about public services.
 * add enable/disable/isenabled methods to pre-processor
 * switch off pre-processing when post-processing
 * remove method black list
 * unit tests, integration tests and UI tests run locally

+review RM @taksoy



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108613 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-21 05:30:53 +00:00
Tuna Aksoy
8d16bbf699 RM-2129 (Check classification before method execution)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108598 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-20 14:38:12 +00:00
Tuna Aksoy
700ac87fb0 RM-2466 (Show the correct number of existing pages and make them available for navigation in the Security Clearance page)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108542 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-19 19:57:43 +00:00
Tom Page
703fcbef77 RM-2466 Pass through total results count as if nothing is filtered.
Change PagingResultsPostMethodInvocationProcessor to always return the
total results count as if nothing is filtered. This should fix the case
where nothing is filtered, and is a concession to the fact that we cannot
know how many total results there will be from a single page. We will fix
this later by filtering the results before we get to this processor, but
the processor is a good backup filter.

Change the rm-automation tests not to use the pagination details at the
bottom of the browse list pages, as these will often now be incorrect.

In making this change I also looked at using the getTotalResultCount()
interface with a range as the interface supports returning a minimum and
maximum on the total number of results. This would be very useful here,
as it should allow us to say that we don't know how many results there
will be.  However most of the webscripts don't support a range, and so
this leads to some odd results in Share (e.g. 'Showing results 1 to 50
of -1').

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108482 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-17 09:01:00 +00:00
Tuna Aksoy
1121127ed2 RM-2466 (Show the correct number of existing pages and make them available for navigation in the Security Clearance page)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108366 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-15 16:25:24 +00:00
Neil McErlean
d5f4ecaa35 Added missing testcase, part of RM-2343. Test ensures that whitespace-only values for 'classified by' result in a 4xx HTTP response.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108248 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-14 11:43:10 +00:00
Neil McErlean
71565ff47a Part of RM-2343. Ensure that blank or whitespace-only values for the 'Classified By' field are not accepted.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108246 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-14 11:13:06 +00:00
Tuna Aksoy
0e34fa64d4 Fixed failing automated UI tests
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108149 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-11 15:56:28 +00:00
Tuna Aksoy
6a8eeda795 RM-2388 (User without any clearance should not see the classify action)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@108131 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-10 15:50:55 +00:00
Tuna Aksoy
d35a700360 RM-2129 (Check classification before method execution)
* Preventing access to information without appropriate security clearance

+review RM-117

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107738 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-06 15:24:26 +00:00
Tuna Aksoy
c2405ac03a RM-2129 (Check classification before method execution)
* Commenting the list of pre enforcement check methods temporarily out. getProperties causes problems in the UI although all the integration tests succeed.

+review RM-117

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107681 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-03 15:28:05 +00:00
Tuna Aksoy
a6ab82152d RM-2129 (Check classification before method execution)
+review RM-117

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107676 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-03 14:41:53 +00:00
Tuna Aksoy
e6fe911fcf RM-2129 (Check classification before method execution)
+review RM @rwetherall

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107649 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-07-02 18:05:18 +00:00
Tuna Aksoy
ea4d00f100 RM-2130 (Check classification after method execution, filtering results where appropriate)
- Code refactored

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107441 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-30 19:15:27 +00:00
Neil McErlean
fa3f1230a4 RM-2333, RM-2341, RM-2342, RM-2343, RM-2344, RM-2346.
Changed Classification Agency to optional throughtout the stack and added a new mandatory property Classified By throughout the stack.
Addressing the fallout in the existing tests due to these changes.
Also enhanced some existing tests to validate the classified by value persistence.

Still to do: need to initialise the Classified By field in the Classify dialog to the current user's full name (not as easy as I'd thought) and add additional AC tests.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107433 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-30 15:32:47 +00:00
Tuna Aksoy
366af3d7c4 Workflows could not be started after classification enforcement
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107368 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-29 21:27:25 +00:00