Tuna Aksoy
90575729d4
Fixed major issues reported by sonar (Reliance on default encoding)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@65399 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-22 16:21:52 +00:00
Tuna Aksoy
de0a70d7db
Fixed major issues reported by sonar (Static Variable Name)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@65398 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-22 16:03:14 +00:00
Tuna Aksoy
a8fdd3ec97
Fixed critical issues reported by sonar (Performance - Inefficient use of keySet iterator instead of entrySet iterator)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@65396 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-22 15:56:17 +00:00
Roy Wetherall
4f64a8adbb
Remove hardcoded references to dod specific properties
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@65037 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-21 02:53:13 +00:00
Tuna Aksoy
cf8175476d
Minor fixes for the hold service
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64903 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-19 17:03:46 +00:00
Roy Wetherall
9509bc258a
RM-1326: Write tests for Hold Service
...
* unit test completed for hold service
* some improvements to unit test base
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64854 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-19 10:55:10 +00:00
Roy Wetherall
5269a6ee24
Hold Service Improvements:
...
* HoldService API explanded beyound immediate use case needs to form a more complete API, plus some tweaks to method names
* unit test (via Mockito) added .. still some todo's (see RM-1326)
* integration test added .. to test behaviour interactions (see RM-1326)
* method level permissions added to Hold service .. should see filtering of results based on permissions
* added behaviour to HoldService to unfreeze records and record folders when hold is deleted (same as old relinquish action)
* deprecation of dupliacte methods found in FreezeService
* fix up use of deprecated methods throughout code .. note that warnings have only been hidden in actions that are soon to be deprecated too
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64834 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-19 05:02:04 +00:00
Tuna Aksoy
b10cf6d159
Fixed minor issues reported by sonar (Collapsible If Statements)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64833 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-19 00:32:43 +00:00
Tuna Aksoy
e26257d9da
Fixed minor issues reported by sonar (Modifier Order)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64832 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-19 00:30:50 +00:00
Tuna Aksoy
313ea83366
Fixed minor issues reported by sonar (Redundant Modifier)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64831 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-19 00:26:17 +00:00
Tuna Aksoy
ade8ee947e
Fixed major issues reported by sonar (Unused formal parameter)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64829 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-19 00:02:52 +00:00
Tuna Aksoy
1eed08edd9
Fixed major issues reported by sonar (Simplify Boolean Expression)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64828 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-18 23:50:41 +00:00
Tuna Aksoy
00e0d02446
Fixed major issues reported by sonar (Unnecessary Local Before Return)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64827 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-18 23:41:13 +00:00
Tuna Aksoy
82b5c60bb9
Fixed major issues reported by sonar (Member name)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64826 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-18 23:26:53 +00:00
Tuna Aksoy
4f3c08a780
Fixed major issues reported by sonar (Simplify Boolean Return)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64825 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-18 23:22:27 +00:00
Tuna Aksoy
6af1e78e54
Fixed major issues reported by sonar (Final Class)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64824 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-18 23:12:10 +00:00
Tuna Aksoy
f145f7785a
RM-1321 (Implement UI for adding records/folders to hold(s))
...
RM-1334 (Implement UI for removing an item from hold(s))
* Added actions/capabilities so that the actions add to hold and remove from hold can be called from the UI
* Also everything related to the freeze/unfreeze actions has been removed from rm-share
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64814 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-18 17:07:05 +00:00
Roy Wetherall
808c83f4a6
Rename rma:unfiledRecordContinerChildt to rma:unfiledRecordFolder
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64752 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-17 23:45:26 +00:00
Roy Wetherall
693400d3ac
UI tests for RM-1148 and RM-1194
...
* added record info helper to encapsulate record row in file plan
* added page object for 'edit record metadata' action
* ensure that edit record metadata action is not present in the UI if there are not aspects to add (ie in the standard RM site)
* renamed and extedned RecordDetailsPage
* added AbstractSiteNavigation to work around dependancy issue that was blocking execution of tests
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64678 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-17 01:20:48 +00:00
Tuna Aksoy
fe83f87904
Fixed failing unit test
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64666 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-15 09:10:57 +00:00
Tuna Aksoy
7a01126f7c
Story: RM-1206 (As a records user I want to be able to add records to a hold(s) I have permission to see so that I can freeze a record)
...
Sub-task: RM-1321 (Implement UI for adding records/folders to hold(s))
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64360 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-14 17:49:34 +00:00
Tuna Aksoy
bcc5c7351b
Refactor RM model so that rma:hold is used
...
* Remaining work to make it consistent for the UI part
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64188 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-14 10:32:15 +00:00
Tuna Aksoy
cdb1add607
Fixed major issues reported by sonar (Simplify Boolean Expression)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64169 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-13 22:52:16 +00:00
Roy Wetherall
d50b7a20a9
Refactor RM model so that rma:hold is used
...
* rma:holdContainerChild removed
* capabilities, forms and actions updated
* UI tests updated
* relates to RM-1203, RM-1205, RM-1209
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64116 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-13 10:19:45 +00:00
Tuna Aksoy
af91dc9538
Removed warnings
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64047 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-12 17:32:55 +00:00
Mark Hibbins
a378ade7a1
RM-1309, Made the configuration of the node property suggestion functionality easier by moving list of types/aspects to global properties file
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@64027 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-12 16:03:24 +00:00
Tuna Aksoy
c3ac745ffb
Fixed major issues reported by sonar (Simplify Boolean Expression)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63886 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-11 09:04:52 +00:00
Tuna Aksoy
b92d582589
RM-1319 (Implement REST API for getting the holds)
...
* Added more information about the hold
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63879 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-10 21:41:02 +00:00
Tuna Aksoy
c389da144d
Story: RM-1207 (As a records user I want to remove records from a hold(s) that I have permission to see so that I can unfreeze a record)
...
Sub-task: RM-1332 (Implement REST API for removing an item from hold(s))
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63860 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-10 16:27:58 +00:00
Tuna Aksoy
aa8c52f72f
RM-1330 (Implement REST API for getting the hold(s) for a given node)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63826 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-10 11:07:41 +00:00
Tuna Aksoy
94ff93a642
Fixed failing unit tests
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63816 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 23:19:51 +00:00
Tuna Aksoy
d58cfe667b
Fixed minor issues reported by sonar (Unread public/protected field)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63814 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:45:08 +00:00
Tuna Aksoy
36f8250826
Fixed major issues reported by sonar (Use Index Of Char)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63813 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:30:55 +00:00
Tuna Aksoy
1db449f921
Fixed major issues reported by sonar (Performance - Method invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63812 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:28:52 +00:00
Tuna Aksoy
91a5d0e502
Fixed major issues reported by sonar (Useless Overriding Method)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63811 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:26:33 +00:00
Tuna Aksoy
b716d4c23c
Fixed major issues reported by sonar (Parameter Name)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63810 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:23:48 +00:00
Tuna Aksoy
cb22887740
Fixed major issues reported by sonar (If Stmts Must Use Braces)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63809 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:22:30 +00:00
Tuna Aksoy
ee4b49255b
Fixed major issues reported by sonar (Local Variable Name)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63808 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:20:58 +00:00
Tuna Aksoy
7ed08a206f
Fixed major issues reported by sonar (Hide Utility Class Constructor)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63807 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:15:35 +00:00
Tuna Aksoy
807e6179ca
Fixed critical issues reported by sonar (Simplify Conditional)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63806 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 22:03:24 +00:00
Tuna Aksoy
283fb3aca9
Fixed critical issues reported by sonar (Performance - Method invokes inefficient Number constructor; use static valueOf instead)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63805 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:54:42 +00:00
Tuna Aksoy
d01b4d5881
Fixed minor issues reported by sonar (Constant Name)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63803 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:45:53 +00:00
Tuna Aksoy
173abadbfa
Fixed minor issues reported by sonar (Useless String Value Of)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63802 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:39:32 +00:00
Tuna Aksoy
f4ada629de
Fixed minor issues reported by sonar (Empty Statements)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63801 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:36:32 +00:00
Tuna Aksoy
5d5d659456
Fixed minor issues reported by sonar (Collapsible If Statements)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63800 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 21:33:14 +00:00
Tuna Aksoy
f52a5c6f5d
Fixed minor issues reported by sonar (Redundant Modifier)
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63799 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-09 20:48:40 +00:00
Tuna Aksoy
0e976c1338
Story: RM-1206 (As a records user I want to be able to add records to a hold(s) I have permission to see so that I can freeze a record)
...
Sub-tasl: RM-1327 (Implement REST API for adding a record to the hold(s))
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63794 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-08 21:42:40 +00:00
Tuna Aksoy
e5abd6fb99
Refactored FreezeService after adding the HoldService
...
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63769 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-07 15:27:40 +00:00
Tuna Aksoy
90c40688ec
Story: RM-1206 (As a records user I want to be able to add records to a hold(s) I have permission to see so that I can freeze a record)
...
Sub-task: RM-1319 (Implement REST API for getting the holds)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63758 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-07 11:52:25 +00:00
Tuna Aksoy
0a40b0c0dd
Story: RM-1206 (As a records user I want to be able to add records to a hold(s) I have permission to see so that I can freeze a record)
...
Sub-task: RM-1325 (Implement Hold Service)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@63732 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2014-03-06 22:39:54 +00:00