* Update schema validation report
- Introduced changes to tell apart problems due to optional unapplied
patches within schema validation report
* Update SchemaDifferenceHelper
- Now populating optionalUpgradePatches list during the schema bootstrap
registration to conform with patch registration mechanising already in use
- Added tests
* Make minor corrections
Co-authored-by: Nana Insaidoo <nana.insaidoo@meterian.com>
- MySQLDeleteNotExistsExecutor (by extending DeleteNotExistsExecutor) to cope with MySQLspecific fetch size limitation and restrictions
- updated tests
- moved tests to AllDBTestsTestSuite from AppContextExtraTestSuite
* Add unit test to look for unreferenced test classes.
It's very unusual that we write a test class which should not also be added to a test suite.
* Utilise the hierarchy of NonBuildTests markers to help exclude false positives.
* Update all omitted tests.
Either add the test to AllUnitTestsSuite if it passes and runs quickly, mark the test with the appropriate NonBuildTests interface or mark the class as abstract (if appropriate).
Mark one test (RemoteTransformerClientTest) as a NeverRunTest even though it passes because it takes 12 seconds to run and is marked as deprecated.
* Mark two Camel tests as 'never run' because they failed on the CI.
* SEARCH-2802: Filter HTTP requests (now "none" and "secret" communication methods are available) from X509 Web Filter.
* SEARCH-2802: HttpClientFactory (for Repository and Search Services clients) support for Shared Secret communication.
* SEARCH-2802: Fix HttpClientFactory base unit tests.
* Add events tests
* Polished put test: connects to JMS via TCP and validate that the event sent is also received back
* Now the tests provides a simple main() that listens on the topic, useful for quick debug sessions
* Now the user name is collected in the calling thread, so that the sendEvent does not silently fails
* Apply changes following review
* Now using queue system to guarantee events order
* Add license
* Updated logs and corrected comments
* Remove empty methods
* Now catering for spurious events at startup when database is bootstrapped
* Now preserving the txn-id in all events
* Moved up definitions in events2.xml after PR feedback
Co-authored-by: Bruno Bossola <bruno@meterian.com>
* SEARCH-2768 Add callback feature for asynchronous ACL updates.
Change default for user filter to empty, as changes from all users could affect metadata
or permissions which might need to be indexing by the enterprise Elasticsearch Connector.
* SEARCH-2768 Add unit test for new listeners.
* SEARCH-2768 Rename listener callback function.
* SEARCH-2768 Add unit test to test suite.
* incremented pom versions to 11.0 so that 9 may be used by 7.0.1 and 10 for 7.0.2
* version.schema not changed this time as it had already been incremented by 100 to 14100
* Added method selectNodesWithAspects that accepts a boolean as param to order values
* Added param ordered to IdsEntity class
* Added optional ordered param to the query template that orderes the results by node id in asc order
* Added method getNodesWithAspects that accepts a boolean as param to order values in nodeDAO
* FixedACLUpdater Job calls the new getNodesWithAspects, with the ordered param as true
- fix messaging context for tests by adding missing mocked beans and properties
- add tests for amqp, jms, activemq protocols
- add travis job to run messaging tests
* Performance optimisation spike
* Event2 is now sending event asynchronously
* Now forcing synchronous calls in tests for events2
* Now qualifying the event service used in tests
Co-authored-by: Nana Insaidoo <insaidoo.nana@yahoo.it>
* On move node, verify if parent has pending acl aspect applied and consider the pending shared ACL to update inheritance to avoid ending up with mixed permissions as children of pending acl nodes do not have the correct acls and when moved, keep their wrong acl.
* Add public method setInheritanceForChildren that receives an additional param: forceSharedACL. If an unexpected ACL occurs in a child, it can be overridden by setting it.
* Implement method setInheritanceForChildren that receives an additional parameter: forceSharedACL
* Add method setFixedAcls that receives an additional parameter: forceSharedACL - When a child node has an unexpected ACL, setting this parameter to true will force it to assume the new shared ACL instead of throwing a concurrency exception. When the shared ACL is forces, a warning is thrown in the log informing on what node exactly are we forcing the ACL. This is only possible when the child ACL is type SHARED and when it has an unexpected ACL
* All methods that called setFixedAcls without the new parameter will continue to operate as normal, as having forceSharedACL=false
* Added property forceSharedACL to the FixedACLUpdaterJob. If set to true it will force shared ACL to propagate through children even if there is an unexpected ACL
* When there is a exception detected when doing setInheritanceForChildren on the job, catch and log the error, but do not rollback the entire batch
* On copy/move unit tests I changed the ACL of the target folders on copy and move tests so that the old shared ACL accessed was never the same for origin and target folders as happens when performing these operations between sites
* Added unit test to verify fix for MNT-21898 - testAsyncWithNodeMoveChildToChildPendingFolder
* Added unit test to verify system property for the job: forceSharedACL - testAsyncWithErrorsForceSharedACL
* version.schema=14100 (100 more than used for ACS 7.0.0 originally)
* Reset pom.xml version to next major number (9), as 8.x will be used for 7.0.0 HFs
- Fix the name property persistence in ContentModelFormProcessor to only save when the property value is actually changed. This prevents the FilenameFilteringInterceptor to be called when there are no changes to the file name.
* REPO-5376 Remove all temporary code
* Remove DBStats, SingleTaskRestartableWatch
* Remove propertiesCache and aspectsCache from DBQueryEngine as they were marked as temporary
* Remove further temporary code
Co-authored-by: Nana Insaidoo <insaidoo.nana@yahoo.it>
* [SEARCH-2677] Extract SearchEngineResultSet and SearchEngineResultMetadata interfaces
* [SEARCH-2677] Scan the ResultSet decorator chain for a maximum of 3 nested levels
Re enabling changes disabled in ACS-936 we can see deadlock in asynchronouslyRefreshedCacheThreadPool (AbstractAsynchronouslyRefreshedCache).
There should be no reason to be calling the dictionary destroy method before the doCall() finishes...and it is the use of the destroy method that carries the risk of deadlock.
Proposed fix: the liveLock is used for the doCall() method, this will stop deadlock from external calls to dictionary destroy() while doCall is in progress.
Removed invalidating cache fix (e.g. fix the issue where cluster nodes could have null values and other nodes had default value… so no properly invalidated on node startup). This fix was moved in ClusteringBootstrap as the initial one was causing issues.
* MNT-14308: CMIS - optionally request rendition(s) when uploading docs - part 2
- note: PublicApiAlfrescoCmisServiceFactory extends AlfrescoCmisServiceFactory and overrides getCmisServiceTarget
- hence, also ensure property (cmis.create.doc.request.renditions.set) is set for public rest api spring context
- note: set following log4j.properties: log4j.logger.org.alfresco.opencmis=info
* MNT-14308: CMIS - optionally request rendition(s) when uploading docs - part 2
- tweak info log to output property on init (since service currently instantiated on every call)
- note: set following log4j.properties: log4j.logger.org.alfresco.opencmis=info
Created unit test testIfGroupIsAdminAuthority to check if public method isAdminAuthority correctly validates groups:
* Verify it can identify GROUP_ALFRESCO_ADMINISTRATORS as an admin group
* Verify created groups (non administrators) and users are not considered administrators
* Add a subgroup to the parent group and verify if its still identified as non admin
* Add the group to the administrators group and verify if both group and subgroup are identified correctly as admins
* Add the user to the subgroup and verify if he's an admin
* Create a group with the same name as an admin user, group should not be identified as admin
- add an **activemq** messaging component bean (of type `org.apache.camel.component.activemq.ActiveMQComponent`)
- add a common **jmsConfig** bean to be used by all the three messaging component beans: **jms**, **activemq** and **amqp**
- exclude `activemq-broker` dependencies
- remove unnecessary messaging configuration
* MNT-14308: CMIS - optionally request rendition(s) when uploading docs
- add new configurable option to request set of renditions when uploading via CMIS (none by default)
- note: in the event a client *relied* on previous behaviour (rather than dynamic requests) the property can be overridden & set to "doclib"
- add info message to show new property when initialising CMIS, ie. set of requested renditions set (empty by default)
- note: set following log4j.properties: log4j.logger.org.alfresco.opencmis=info
* REPO-5549 Fix: Local transformer names must exist and be unique doclib Read from ... when overriding a Local transform.
* Problem was that there were two conflicting pieces of code in play in the LocalTransformRegistry.register method. One that checked for duplicate T-Engine names and the other that allowed transforms to be overridden if they had the same name.
* The code checking for duplicate names needed an extra clause to only look at T-Engines (they have a T-Engine url associated with them).
* The code that overrode transforms then worked, but still had issues as the supported source to target mimetypes, priorities and max sizes were not cleared.
* It turned out to be simpler to split the original LocalTransformRegistry.register method into two. Extracting a new method into CombinedConfig.removeOverriddenOrInvalidTransformers that discarded invalid or overridden config before the list of supported source to target mimetypes was created rather than try to fix them up later. This is why there appear to be quite a few changes.
* More extensive unit tests were also added.
* MNT-20775 : rest api /deleted-nodes with maxitems parameter take longer when there are more items in the trash can
Based on offset and limit, returns only the required results from database
Added count query for ArchivedNodes