Commit Graph

1542 Commits

Author SHA1 Message Date
Oana Nechiforescu
8ca5dda4a4 RM-2324 AC Automation: Invalid values
Added unit tests for ExemptionCategoryFieldsValidator.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106913 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-24 07:58:15 +00:00
Neil McErlean
708b7bd0d4 Trivial reformatting done as part of RM-2323.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106839 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-23 10:11:37 +00:00
Tom Page
2fb85342f1 RM-2326 Rest API for GET exemption categories.
+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106576 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 15:35:32 +00:00
Tom Page
27f94a7682 RM-2322 Check modifying the exemption categories.
The unit test was already written - just applying the acceptance criteria
to it so we can track where it's tested.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106568 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 14:53:27 +00:00
Tom Page
3bcad6ee1e RM-2320 Java API for getExemptionCategories.
Also RM-2321 automation testing for the initial loading of exemption
categories.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106565 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 14:28:20 +00:00
Gloria Broadbent
19762c52c8 FRENCH: Updated RM 3.0 bundle based on EN-RM-rev105468
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106538 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 10:53:57 +00:00
Tom Page
bd7dced251 RM-2319 Move exemption category descriptions to a new file.
We don't expect to need these strings translating, so move them to another
file and add that to the exclusion list.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106536 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 10:38:54 +00:00
Gloria Broadbent
b92760806e ITALIAN: Updated RM 3.0 bundle based on EN-RM-rev105468
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106535 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 10:28:55 +00:00
Gloria Broadbent
db199546a8 SPANISH: Updated RM 3.0 bundle based on EN-RM-rev105468
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106534 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 10:27:31 +00:00
Gloria Broadbent
f3daa16af5 GERMAN: Updated RM 3.0 bundle based on EN-RM-rev105468
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106533 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 10:25:53 +00:00
Tom Page
3eb1599fd9 RM-2319 Declare parameter key as "final".
This is needed to compile in java 7, but not java 8.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106532 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 10:16:06 +00:00
Gloria Broadbent
54c885f267 DUTCH: Updated RM 3.0 bundle based on EN-RM-rev105468
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106531 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 10:14:16 +00:00
Tom Page
5d1ab4fa87 RM-2319 Refactor ClassificationServiceBootstrap.
Simplify code to load classification levels, classification reasons and
exemption categories using the same method.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106530 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:52:20 +00:00
Tom Page
941b637552 RM-2319 Validate classification reasons and exemption categories.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106529 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:52:18 +00:00
Tom Page
81f5c589c5 RM-2319 Create a general classification scheme entity validator.
Replace the existing classification level validator with the new class.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106528 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:52:13 +00:00
Tom Page
4ee3afa208 RM-2319 Separate the field validation from ClassificationLevelValidation.
Create field validators that are small and potentially re-usable.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106527 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:52:10 +00:00
Tom Page
88ee670c81 RM-2319 Refactor ClassificationServiceDAO.
All the config loading is now done by a single method using a factory to
create the individual entities.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106526 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:52:07 +00:00
Tom Page
cbe6ca551e RM-2319 Create marker interface for entities created from config files.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106525 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:52:05 +00:00
Gloria Broadbent
21398ab549 DUTCH: Updated RM 3.0 bundle based on EN-RM-rev105468
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106520 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:26:39 +00:00
Gloria Broadbent
9cb76fbba8 JAPANESE: Updated RM 3.0 bundle based on EN-RM-rev105468
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106519 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:25:29 +00:00
Gloria Broadbent
18f7bdbf63 ITALIAN: Updated RM 3.0 bundle based on EN-RM-rev105468
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106518 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:19:27 +00:00
Gloria Broadbent
8bd59289e5 SPANISH: Updated RM 3.0 bundle based on EN-RM-rev105468
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106516 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:18:06 +00:00
Gloria Broadbent
7dfc1057e2 FRENCH: Updated RM 3.0 bundle based on EN-RM-rev105468
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106514 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:16:55 +00:00
Gloria Broadbent
c8aaefbe6e GERMAN: Updated RM 3.0 bundle based on EN-RM-rev105468
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106513 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-19 09:15:03 +00:00
Tom Page
14bd5e4da8 RM-2319 Bootstrap initial exemption categories into the system.
This change does not include any validation. There is currently no
validation being done for classification reasons either, so it seemed
to make sense to do both in a separate change.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106417 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-17 15:38:10 +00:00
Neil McErlean
c43ac5ab12 Trivial changes. Improved an exception message after review comments and fixed a copyright year.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106143 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-15 13:37:14 +00:00
Neil McErlean
1a3e5293ff Additional checkin related to RM-2291. Change the unit test so that it validates only the levels configured by the user (in .json file) and excludes the built-in special case of Unclassified.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106141 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-15 13:24:16 +00:00
Neil McErlean
623ac8eff8 Implementation of new tests as part of RM-2241.
Test to ensure the Unclassified abbreviation ('U') is rejected when duplicated by end user configuration.
Test to ensure any duplicate abbreviations are rejected.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106134 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-15 12:04:27 +00:00
Neil McErlean
a2005bfb1a Slight change following review comments. Doesn't affect test execution.
--This mine, and those below, will be ignored--

M    ClassificationServiceBootstrapUnitTest.java


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106120 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-15 09:27:43 +00:00
Tuna Aksoy
f2010a9f2f RM-2280 (Move the code for checking if the content is classified to the service layer)
* moved the check to content classification service
   
+review RM-87

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106090 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-12 20:39:33 +00:00
Tom Page
ac56441fc3 RM-2217 Allow null as a filter value.
Also add a few unit tests for the file.

+review RM-96

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106034 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-12 13:19:08 +00:00
Tuna Aksoy
7c62bef29e RM-2260 (Users with read&file permissions on content can not classify it if they are not the owners)
+review RM @rwetherall

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106030 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-12 12:57:09 +00:00
Tom Page
ed210cd336 RM-2217 Filtering with special characters - fix backslash.
+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106011 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-12 10:09:21 +00:00
Neil McErlean
5aeeb146be RM-2235. Changed Unclassified to 'U', which is the ID and abbreviation for unclassified.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105782 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-09 09:21:39 +00:00
Tuna Aksoy
aaecf7ad80 RM-2280 (Move the code for checking if the content is classified to the service layer)
* Added integration tests
   
+review RM-87

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105748 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-08 13:53:44 +00:00
Tuna Aksoy
14a1c9f9bc RM-2280 (Move the code for checking if the content is classified to the service layer)
+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105735 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-08 11:03:19 +00:00
Neil McErlean
670fcbfb8d Slight refactor of test code for improved readability following review. Part of RM-2235.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105718 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-08 09:30:42 +00:00
Neil McErlean
f8c417d0d0 Initial implementation of RM-2238, RM-2288, RM-2289 & RM-2290. Classification Abbreviations and tests.
In fact, this is pretty much done. Still to do: Unclassified Abbreviation.

New class ClassificationLevelValidation which contains the various validation checks for level abbreviations. Unit tests for same. This new class is used by ClassificationServiceBootstrap.
Added a new exception type just so that we have somewhere to store any illegal characters in a level abbreviation.
Had to change the classification level IDs to “TS”, “S” & “C” as “Confidential” has a length > 10. I’d been thinking of doing this is a separate commit but the additional validation requires that we do it now.
Minor fallout in test code due to ID changes.



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105641 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-05 15:58:10 +00:00
Tuna Aksoy
9b61610016 In the user security clearance page if users cannot be found an error message should not be displayed.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105631 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-05 14:28:04 +00:00
Tuna Aksoy
3d8d3a2301 RM-2260 (Users with read&file permissions on content can not classify it if they are not the owners)
* Fixed failing integration test

+review RM-83

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105567 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-05 09:31:43 +00:00
Tuna Aksoy
34beffedad RM-2260 (Users with read&file permissions on content can not classify it if they are not the owners)
+review RM @rwetherall

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105541 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-04 15:41:00 +00:00
Neil McErlean
c247ea32aa Fix for slight coding issue - note there are no recorded problems from this.
Replaced String == with String.equals.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105496 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-03 20:23:04 +00:00
Tuna Aksoy
2ca633319d RM-2247 (Add classification banner to document details)
RM-2248 (Add classification banner to record details)

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105441 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-03 09:46:09 +00:00
Tom Page
91314b4833 Fix a few places I missed refactoring.
Hopefully this will fix the build.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105318 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-02 11:17:19 +00:00
Tom Page
ae171d5008 Rename ClassificationService to ClassificationSchemeService.
Also rename ClassificationServiceException to ClassificationException.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105317 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-02 10:20:37 +00:00
Tom Page
81dbb54471 Fix failing test on Sonar build.
Avoid calling the I18N utility by checking the display label key directly.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105312 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-02 09:21:30 +00:00
Tuna Aksoy
7916227e88 RM-2208 (Prevent classification of shared content)
+review RM @rwetherall

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105284 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-01 13:32:12 +00:00
Tuna Aksoy
5834374b85 RM-2203 (Show selected classification reason id's rather than description)
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105215 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-01 10:08:26 +00:00
Tom Page
43a2784387 Use mock in unit test for ClearanceLevelManager.
Although I'm not sure exactly why this unit test failed on the Sonar build,
it seems sensible to remove the dependency on another class by using a mock.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105192 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-06-01 07:59:10 +00:00
Tuna Aksoy
04ff5a228a RM-2270: Fixed bean definition
+review RM-67

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105023 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2015-05-29 11:48:33 +00:00