inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-31 17:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,774 Commits 324 Branches 2,170 Tags
b3a707b8ab08ef678d29eb6e70fca97ab1c60f80
Commit Graph

160 Commits

Author SHA1 Message Date
Tuna Aksoy
ea4d00f100 RM-2130 (Check classification after method execution, filtering results where appropriate) 
- Code refactored

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107441 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-30 19:15:27 +00:00
Neil McErlean
fa3f1230a4 RM-2333, RM-2341, RM-2342, RM-2343, RM-2344, RM-2346. 
Changed Classification Agency to optional throughtout the stack and added a new mandatory property Classified By throughout the stack.
Addressing the fallout in the existing tests due to these changes.
Also enhanced some existing tests to validate the classified by value persistence.

Still to do: need to initialise the Classified By field in the Classify dialog to the current user's full name (not as easy as I'd thought) and add additional AC tests.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107433 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-30 15:32:47 +00:00
Tuna Aksoy
7b5835297d Merged DEV/ENFORCE to HEAD: 
105194: First pass at classification interceptor
   105294: Fixed compilation issue
   105323: Updated Aikau version to 1.0.20
   105565: RM-2129 (Check classification before method execution)
   105923: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106103: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106104: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106169: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106187: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106283: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106356: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106552: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106639: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106657: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106658: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106772: RM-2130 (Check classification after method execution, filtering results where appropriate)
   106774: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107009: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107163: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107164: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107246: RM-2130 Post method invocation processor for QueryEngineResults.
   107252: RM-2130 (Post method invocation processor for QueryEngineResults)
   107253: RM-2130 Make CollectionPostMethodInvocationProcessor concrete.
   107257: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107270: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107272: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107273: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107274: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107275: RM-2130 (Check classification after method execution, filtering results where appropriate)
   107282: RM-2130 Add support for other collections than Lists.
   107344: RM-2367 (Automate AC: Access to saved search)
   107355: RM-2130 Support for specific instantiable collections.
   107363: RM-2130 (Check classification after method execution, filtering results where appropriate)

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107367 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-29 21:24:16 +00:00
Tom Page
e9a5f28f85 RM-2130 Support for specific instantiable collections. 
It's impossible to instantiate/clone a generic collection, so if a member of the collection
changes then our only option is to attempt to remove it.  This has two problems. Firstly,
this is far more brutal than we desire in many cases. Secondly, some collections do not
implement the remove method (e.g. anything returned by Arrays.asList()).

As an attempt to work around this issue we've created some specific implementation
processors. This introduces new potential problems - e.g. if someone has used an exotic
type of list it will be replaced with an ArrayList by the ListPostMethodInvocationProcessor.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107355 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-29 15:18:49 +00:00
Tuna Aksoy
423850002e RM-2130 (Post method invocation processor for QueryEngineResults) 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107252 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-26 15:28:22 +00:00
Tom Page
06ed0a6015 RM-2130 Post method invocation processor for QueryEngineResults. 
+review RM @taksoy

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@107246 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-26 14:47:03 +00:00
Neil McErlean
5a88c1d5c8 RM-2333. Rename ClassificationAuthority to ClassificationAgency. +review RM 
This addresses parts of RM-2341, RM-2342, RM-2343 and RM-2344. It replaces authority with agency in the content model
, the services and their APIs, the UI layer and the rm-automation tests.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@107108 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-25 13:24:38 +00:00
Tuna Aksoy
72ec88a334 Code formatting 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106945 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-24 08:51:45 +00:00
Oana Nechiforescu
4720ee2cdc RM-2324 AC Automation: Invalid values 
fix

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106937 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-24 08:42:01 +00:00
Oana Nechiforescu
8ca5dda4a4 RM-2324 AC Automation: Invalid values 
Added unit tests for ExemptionCategoryFieldsValidator.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106913 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-24 07:58:15 +00:00
Neil McErlean
708b7bd0d4 Trivial reformatting done as part of RM-2323. 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106839 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-23 10:11:37 +00:00
Tuna Aksoy
24cc5ca519 RM-2130 (Check classification after method execution, filtering results where appropriate) 
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106658 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-21 21:58:42 +00:00
Tuna Aksoy
862fde1e61 RM-2130 (Check classification after method execution, filtering results where appropriate) 
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106657 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-21 19:47:57 +00:00
Tuna Aksoy
3772764f8e RM-2130 (Check classification after method execution, filtering results where appropriate) 
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106639 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-20 18:42:32 +00:00
Tom Page
2fb85342f1 RM-2326 Rest API for GET exemption categories. 
+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106576 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-19 15:35:32 +00:00
Tom Page
27f94a7682 RM-2322 Check modifying the exemption categories. 
The unit test was already written - just applying the acceptance criteria
to it so we can track where it's tested.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106568 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-19 14:53:27 +00:00
Tuna Aksoy
e79b4a9d8f RM-2130 (Check classification after method execution, filtering results where appropriate) 
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106552 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-19 12:39:04 +00:00
Tom Page
5d1ab4fa87 RM-2319 Refactor ClassificationServiceBootstrap. 
Simplify code to load classification levels, classification reasons and
exemption categories using the same method.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106530 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-19 09:52:20 +00:00
Tom Page
941b637552 RM-2319 Validate classification reasons and exemption categories. 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106529 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-19 09:52:18 +00:00
Tom Page
81f5c589c5 RM-2319 Create a general classification scheme entity validator. 
Replace the existing classification level validator with the new class.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106528 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-19 09:52:13 +00:00
Tom Page
4ee3afa208 RM-2319 Separate the field validation from ClassificationLevelValidation. 
Create field validators that are small and potentially re-usable.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106527 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-19 09:52:10 +00:00
Tom Page
88ee670c81 RM-2319 Refactor ClassificationServiceDAO. 
All the config loading is now done by a single method using a factory to
create the individual entities.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106526 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-19 09:52:07 +00:00
Tom Page
14bd5e4da8 RM-2319 Bootstrap initial exemption categories into the system. 
This change does not include any validation. There is currently no
validation being done for classification reasons either, so it seemed
to make sense to do both in a separate change.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106417 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-17 15:38:10 +00:00
Tuna Aksoy
d79c6c2105 RM-2130 (Check classification after method execution, filtering results where appropriate) 
+review RM-94

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/DEV/ENFORCE@106283 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-16 14:30:37 +00:00
Neil McErlean
1a3e5293ff Additional checkin related to RM-2291. Change the unit test so that it validates only the levels configured by the user (in .json file) and excludes the built-in special case of Unclassified. 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106141 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-15 13:24:16 +00:00
Neil McErlean
623ac8eff8 Implementation of new tests as part of RM-2241. 
Test to ensure the Unclassified abbreviation ('U') is rejected when duplicated by end user configuration.
Test to ensure any duplicate abbreviations are rejected.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106134 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-15 12:04:27 +00:00
Neil McErlean
a2005bfb1a Slight change following review comments. Doesn't affect test execution. 
--This mine, and those below, will be ignored--

M    ClassificationServiceBootstrapUnitTest.java


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106120 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-15 09:27:43 +00:00
Tuna Aksoy
f2010a9f2f RM-2280 (Move the code for checking if the content is classified to the service layer) 
* moved the check to content classification service
   
+review RM-87

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106090 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-12 20:39:33 +00:00
Tom Page
ac56441fc3 RM-2217 Allow null as a filter value. 
Also add a few unit tests for the file.

+review RM-96

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106034 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-12 13:19:08 +00:00
Tom Page
ed210cd336 RM-2217 Filtering with special characters - fix backslash. 
+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@106011 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-12 10:09:21 +00:00
Neil McErlean
670fcbfb8d Slight refactor of test code for improved readability following review. Part of RM-2235. 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105718 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-08 09:30:42 +00:00
Neil McErlean
f8c417d0d0 Initial implementation of RM-2238, RM-2288, RM-2289 & RM-2290. Classification Abbreviations and tests. 
In fact, this is pretty much done. Still to do: Unclassified Abbreviation.

New class ClassificationLevelValidation which contains the various validation checks for level abbreviations. Unit tests for same. This new class is used by ClassificationServiceBootstrap.
Added a new exception type just so that we have somewhere to store any illegal characters in a level abbreviation.
Had to change the classification level IDs to “TS”, “S” & “C” as “Confidential” has a length > 10. I’d been thinking of doing this is a separate commit but the additional validation requires that we do it now.
Minor fallout in test code due to ID changes.



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105641 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-05 15:58:10 +00:00
Tuna Aksoy
34beffedad RM-2260 (Users with read&file permissions on content can not classify it if they are not the owners) 
+review RM @rwetherall

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105541 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-04 15:41:00 +00:00
Neil McErlean
c247ea32aa Fix for slight coding issue - note there are no recorded problems from this. 
Replaced String == with String.equals.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105496 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-03 20:23:04 +00:00
Tuna Aksoy
2ca633319d RM-2247 (Add classification banner to document details) 
RM-2248 (Add classification banner to record details)

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105441 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-03 09:46:09 +00:00
Tom Page
ae171d5008 Rename ClassificationService to ClassificationSchemeService. 
Also rename ClassificationServiceException to ClassificationException.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105317 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-02 10:20:37 +00:00
Tom Page
81dbb54471 Fix failing test on Sonar build. 
Avoid calling the I18N utility by checking the display label key directly.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105312 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-02 09:21:30 +00:00
Tuna Aksoy
7916227e88 RM-2208 (Prevent classification of shared content) 
+review RM @rwetherall

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105284 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-01 13:32:12 +00:00
Tuna Aksoy
5834374b85 RM-2203 (Show selected classification reason id's rather than description) 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105215 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-01 10:08:26 +00:00
Tom Page
43a2784387 Use mock in unit test for ClearanceLevelManager. 
Although I'm not sure exactly why this unit test failed on the Sonar build,
it seems sensible to remove the dependency on another class by using a mock.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@105192 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-06-01 07:59:10 +00:00
Tom Page
655a8d8a5d RM-2123 Ensure user has clearance to classify content. 
Also add clearance check method into security profile.

+review RM-58

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@104750 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-05-22 13:20:00 +00:00
Tom Page
eafaad25ea RM-2123 Use runAsAuthentication instead of actual authentication. 
Check that the user the command is run as has clearance to view the
classification levels, rather than the user that initiated the command.

+review RM-58

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@104729 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-05-22 08:43:12 +00:00
Tom Page
94c65b83e8 RM-2123 Move clearance checking to SecurityClearanceService. 
Refactor ContentClassificationService#hasClearance so that it calls out to
SecurityClearanceService#isCurrentUserClearedForClassification. Restrict
isCurrentUserClearedForClassification so that it only applies to the current
authenticated user (we don't need to use it for anything else).  Also
extract classification level comparison to a new class.

+review RM-58

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@104568 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-05-20 08:28:46 +00:00
Tom Page
4d94c8b66b RM-2123 Don't create a user called system. 
Also add special check in clearance service that gives system user maximum
clearance.

+review RM-58

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@104480 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-05-19 09:57:02 +00:00
Tuna Aksoy
62558fbbc1 Removed warnings 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@104477 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-05-18 21:24:33 +00:00
Neil McErlean
2c7885cfc6 Added some javadoc to clarify that ExceptionUtils.expectedException doesn't try to work around checked exceptions. 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@104391 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-05-18 15:11:16 +00:00
Tom Page
f03e36ee91 RM-2123 Give clearance to the admin and system users. 
Make sure this is executed as a patch and also bootstrapped into a clean
system using the BootstrapImporterModuleComponent.

Also restrict access to the classification levels (via the get API) to
only the levels that the user has clearance to.

+review RM

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@104376 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-05-18 15:03:59 +00:00
Tom Page
24780dc472 RM-2123 Create a new service for content classification. 
Move methods to do with content from the ClassificationService and the
SecurityClearanceService into the ContentClassificationService.

Remove the dependency of SecurityClearanceService on ClassificationService
which will allow us to reverse this dependency in the next commit.  This is
needed in order to filter classifications by the current user's clearance.
Nb. This included adding a method in the SecurityClearanceService called
isClearedForClassification, which looks quite similar to a new API Roy
created hasClearance (see ContentClassificationService).  In the future we
should look to see if we can consolidate these.

Remove dependency of ClassificationServiceBootstrap on the services, so that
it can be passed into them. This allows us to provide access to the POJO
managers in the services (this is made harder as the POJO managers aren't
Spring beans).  In order to initialise these objects, change the POJO
managers to use setters rather than constructor arguments. This allows us
to store a reference to the manager before the data has been loaded.

Move the attribute service keys for classification levels and reasons into
the ClassifiedContentModel.

Expect NO_CLEARANCE to be passed into the ClearanceLevelManager, as
otherwise we have to have logic to exclude it (see initialise in the old
SecurityClearanceService) and then more logic to include it again (see the
old constructor for ClearanceLevelManager).

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@104375 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-05-18 15:03:57 +00:00
David Webster
d42c0cabdd RM-2197: Adds missing unit tests, as identified by Tom during +review RM-56 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@104306 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-05-15 16:09:36 +00:00
David Webster
2714c77cec RM-2120: More accurate error checking in test, as almost suggested by Neil during +review RM-46 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@104296 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
 2015-05-15 14:51:56 +00:00