3023 Commits

Author SHA1 Message Date
N Smith
40ec46f565 Added Getter methods to all the Workflow DTOs and fixed various warnings.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21357 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-22 16:05:04 +00:00
Mark Rogers
5b86cfb4e9 transfer service : read only implementation plus unit test
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21353 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-22 13:04:15 +00:00
N Smith
5d4cfd5ab0 Task Form Processor now handles Webscript-safe version of task Id, where the $ is replaced by an _.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21352 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-22 10:31:32 +00:00
N Smith
9ddf7d5857 Added support for packageItems to the TaskFormProcessor.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21344 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-21 16:39:44 +00:00
Nick Burch
17bcf56a93 ActionTrackingService work
Initial cancel support, and some duplicate instance work (mostly updating tests to handle it coming along). Duplicate id assignment work still remains


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21340 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-21 15:49:19 +00:00
Nick Burch
0442d3564d ActionTrackingService test updates
Make the cache key generation less brittle, add unit tests for listing functions, and stub out the cancel related tests


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21332 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-21 13:52:16 +00:00
Mark Rogers
3b6972a208 javadoc update to lock service
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21330 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-21 12:43:59 +00:00
Mark Rogers
484e218e50 transfer service : now deals with restored nodes + unit tests.
work in progress on sync of folders containing alien nodes - incomplete so commented out.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21329 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-21 12:29:18 +00:00
Nick Burch
ca58f8d202 Test suite update following action tests refactoring
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21328 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-21 12:16:18 +00:00
Nick Burch
fd87beb9a2 Action test refactoring
Reduce duplication between tests which all need working and failing actions that behave in a predictable, testable way


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21327 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-21 12:07:45 +00:00
N Smith
0dc1d2b4cf Fixing broken WorkflowFormProcessorTest.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21321 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-21 09:59:24 +00:00
N Smith
e2d9d74873 Refactored the persistence for WorkflowFormProcessor and TaskFormProcessor.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21315 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-20 19:02:58 +00:00
Nick Burch
6f828a8b97 Action Tracking Service work (Replication Task 79) -
Basic cache population (no id clash avoidance yet though), along with basic tracking and simpler unit tests


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21312 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-20 17:00:29 +00:00
N Smith
5d2143cfe5 Added Package/PackageItem Action Group data to Workflow and Task FormProcessors.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21307 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-20 14:34:23 +00:00
Nick Burch
44f1aa459b Further ActionTrackingService work
Documentation on DTOs, and flesh out more of the logic. Existing unit tests still happy despite the new features, new unit tests to follow


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21294 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-20 11:24:09 +00:00
Mark Rogers
0844595d01 Fix for unit test.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21292 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-20 11:07:45 +00:00
Nick Burch
a2b793c21e Action Tracking Service work (replication task 79)
New concrete data transfer classes for holding the basic details on executing actions, and basic support (but no unit tests yet) for storing and retrieving these


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21281 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-19 16:56:34 +00:00
Nick Burch
a18efbbb6f Stub out executing action listing methods (Workflow 79)
Return types are not yet correct, and methods are stubbed, but the general contract for finding out which actions are currently executing, and where is now in place.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21267 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-19 14:35:08 +00:00
N Smith
18f23482b6 Implemented persistence for the WorkflowFormProcessor.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21258 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-19 10:46:11 +00:00
Nick Burch
2bfa74df80 Action execution tracking update
Push the logic out to another service, which will shortly also handle cluster wide information on which actions are running (Workflow task 79)


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21254 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-19 09:32:26 +00:00
Jan Vonka
5db5f0a1a6 ALF-3885: find multiple class behaviours through (super-)class hierarchy (not just first) - warning: pls review/test your registered (super-)class behaviours
Merged BRANCHES/DEV/WORKP1 to HEAD
        21224: ALF-3885: find multiple class behaviours through type hierarchy (not just first)
        21249: ALF-3885: follow-on to r21224 (to fix PersonServiceTest.testSplitDuplicates)


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21253 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-19 08:34:35 +00:00
Nick Burch
5214729811 Expand a couple of replication service tests
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21247 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-16 16:24:43 +00:00
Gavin Cornwell
8fb13891c9 Feedback from sprint 1 demo: Changed a few labels to be consistent with the rest of Share and made the start workflow forms look more like the wireframes i.e. adding field groupings. Also changed a form processor WARN message to DEBUG.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21236 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-16 12:02:04 +00:00
Mark Rogers
cdf5065976 transfer service : revision 21204 missed these two files.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21217 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-16 07:57:13 +00:00
Mark Rogers
9ac570b049 Improve java doc for policy component.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21208 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-15 18:44:02 +00:00
Nick Burch
8b75235419 ActionService support for recording why persisted actions fail, on the action definition, plus tests
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21206 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-15 16:49:04 +00:00
Mark Rogers
f805895f51 transfer service : transfers permissions.
now sets cm:modifiedDate on update + unit test.
    new permissions unit test.
    added "readOnly" flag to API  does nothing yet.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21204 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-15 15:53:07 +00:00
Derek Hulley
37e0b65814 SAIL-390 (SAIL-294): NodeDAO: Allow cm:auditable to be set
- Added test and guard against client code wiping out cm:auditable by not passing in any values
 - If the cm:auditable behaviour is off and NO cm:auditable properties are passed in, then do nothing


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21192 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-15 10:37:56 +00:00
Gavin Cornwell
546fb81b59 Added form config for pooled review & approve workflow and handling of group assignee to WorkflowFormProcessor
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21180 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-14 20:40:23 +00:00
Derek Hulley
136dc70f9d SAIL-390 (SAIL-294): NodeDAO: Allow cm:auditable to be set
- Allow cm:auditable properties to be set directly
                 behaviourFilter.disableBehaviour(ContentModel.ASPECT_AUDITABLE);        // Lasts for txn
                // Set the auditable properties explicitly
                auditableProps.put(ContentModel.PROP_MODIFIER, "ThisUser");
                nodeService.addProperties(nodeRef, auditableProps);



git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21178 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-14 18:18:32 +00:00
N Smith
75c6e063c2 Fixed a bug in the WorkflowFormProcessor so it now properly processes Webscript-friendly versions of workflow definition Ids.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21177 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-14 17:59:22 +00:00
Nick Burch
7c46ccea69 Have the action service record when actions run, and if they worked
Handles persisting this action data for sucessful actions
(Failure information persistance still to follow)
Includes lots of unit tests for working and failing sync and async actions


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21175 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-14 16:08:37 +00:00
N Smith
a7d55e7fe4 Fixed failing tests in TaskFormProcessorTest caused by AssociationFieldProcessor not converting the values from NodeRefs to Strings.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21173 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-14 15:29:30 +00:00
N Smith
650f4e4b8d Created the new WorkflowFormProcessor which processes forms based on a workflow definition name.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21172 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-14 15:10:17 +00:00
Dave Ward
d6fdc2fb03 Merged V3.3-BUG-FIX to HEAD
21132: ALF-3855: Refactored repository authentication filters so that same code is re-used for Web Client, Web Script, Web DAV and Sharepoint authentication
      - 'Uber Filter' part 3
      - Means we now support Kerberos Authentication for Sharepoint
      - Threw away a lot of duplicated code
      - New common AuthenticationDriver interface created and now implemented by core authentication code
      - Sharepoint and BaseSSOAuthenticationFilter now both use AuthenticationDrivers
      - Needs regression testing
   21137: ALF-3841: Alfresco Explorer SSO Authentication Filters now accept ticket parameters too
      - Can be turned back off with ntlm.authentication.browser.ticketLogons=false or kerberos.authentication.browser.ticketLogons=false
      - Wiki updated
   21141: ALF-3855: Fixed wiring
   21146: ALF-2879: 'xamconnector' module behaviour for xam:archived
      - Application of xam:archived recurses and locks both files and folders
      - cm:content nodes also have the store selector applied for the XAMContentStore
      - TODO: Archive properties
   21165: Fixed ALF-3867: SQL format error when re-instating orphaned content URL
      - Parameter was not bounded with #
      - Added unit test to ensure SQL generated is correct
   21169: Merged V3.3 to V3.3-BUG-FIX
      21168: (RECORD ONLY Merged PATCHES/V3.2.1 to V3.3
         21166: Merged V3.3-BUG-FIX to PATCHES/V3.2.1
            21165: Fixed ALF-3867: SQL format error when re-instating orphaned content URL
               - Parameter was not bounded with #
               - Added unit test to ensure SQL generated is correct
      21118: Latest SpringSurf libs:
         - Fix for missing read of "keystore" in Remote config
         - Session Fixation attack mitigation improvements:
         - A Surf application no longer generates a Session (and therefore no JSESSIONID) until a user is authenticated - simply visiting a login page or similar will no longer generate a Session
         - Existing Sessions are always invalidated and destroyed if found when a user is authenticated via the LoginController (i.e. due to a JSESSIONID captured via an XSS attack)

         Merged HEAD to V3.3
            21111: Fix to encode form parameter on Share login template - prevents its potential use as an reflected XSS attack vector
            21117: Session Fixation mitigation:
               - Removed Session creation from Share index.jsp

         Merged V3.3-BUG-FIX-2010_06_24 to V3.3
            21096: Fix for ALF-3718 - JSF client login page input validator is too aggressive ("Login" button is disabled if username contains forward slash)
      21088: Latest SpringSurf libs


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21170 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-14 14:49:50 +00:00
Neil McErlean
dd816edd2b Added a removeRating method to the RatingService JS API.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21163 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-14 13:38:20 +00:00
Neil McErlean
f41389f6b9 Rating Service. Added DELETE webscript and fixed bug.
There is now a rating.delete webscript.
  Plus a bug was fixed where the ratings weren't actually being deleted.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21161 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-14 13:28:46 +00:00
Mark Rogers
9dde9b2ab5 Transfer service : more work on just sending content that is required.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21160 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-14 13:10:05 +00:00
Gavin Cornwell
240e0d9f05 Adding new files missed yesterday from merge of re-factored form.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21155 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-14 11:15:21 +00:00
Gavin Cornwell
57107790f6 Build fix
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21147 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-14 06:28:44 +00:00
Neil McErlean
a1b1872e2e RatingService JavaScript API.
This is a preliminary JavaScript API for the RatingService.
  The intention is to get something committed to enable possible feedback and to lay the basis for any improvements that be needed later.
  It's the normal Alfresco JS API changes. The root object is 'ratingService' and all the methods are on that object.
  Highly non-OO.
  But it is tested.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21145 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-13 22:05:01 +00:00
Derek Hulley
7c27a2c711 Fix SAIL-389 (SAIL-294): NodeDAO: single-valued, d:any properties don't handle increasing array values
- Re-enabled test and fixed assertion


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21138 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-13 15:34:43 +00:00
Derek Hulley
e7dff0383a Fix SAIL-389 (SAIL-294): NodeDAO: single-valued, d:any properties don't handle increasing array values
- Incorrect translation of raw values back to Serializable for cache purposes
 - Addition of Savepoint around alf_node insert


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21136 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-13 15:22:53 +00:00
Nick Burch
297309f1aa Action tracking of execution status (Replication 78)
Support for getting the start & end execution times, status and failure reason for actions, persisted if the action is
(Execution doesn't update these yet though)


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21135 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-13 15:10:47 +00:00
Gavin Cornwell
4cd5e90110 Merged BRANCHES/DEV/FORM-REFACTOR-MERGE to HEAD:
20935: Branch for form processor refactor merge
   21075: Utility class to help with writing tests which require creation/management of a person.
   21076: Forms Processor Refactor. Refactored the FilteredFormProcessor and ContentModelFormProcessor classes to be more concise. Also introduced the notion of a Field, FieldProcessors and the FieldProcessorRegistry. These are currently responsible for generating different types of fields such as Association fields, Property fields and the various transient fields.
   21083: Moved some utility classes into the correct packages for Forms.
   21084: Created
   21087: Created TaskFormProcessor
   21101: Added test for fdk:period property, in particular the retrieval of it's data type parameters
   21109: Fixed some issues witht he field processor logging. Also fixed an issue where data type properties were not being set correctly for Period property fields.
   21121: Changed AssociationFieldProcessor so that it now adds an empty list as a value instead of null.
   21124: Formatting updates and disabled FDK test ready for merge to HEAD


This commit contains all the re-factoring Nick has been doing to make the form processor mechansim more flexible for form filter developers and more importantly to make it easier to add additional form processor implementations, in particular the TaskFormProcessor and WorkflowFormProcessor. 

A field processor mechanism has also been introduced, this allows the processing of fields to be handled outside of the form processor and means common field handling code can be reused across different form processors. The field processors are also pluggable via Spring config so it's easy for customers to add their own or replace/override ours.

We have run numerous tests (unit and manual UI) and all seems well but as with any change of this size there maybe some edge cases that get missed so please let one of us know if you see any strange behaviour.

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21134 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-13 15:03:19 +00:00
Mark Rogers
e468ab3a4b transfer service : work in progress.
implementation of transfer requsite.
    API change isComplete to isSync

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21130 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-13 14:04:23 +00:00
Neil McErlean
eece9fef5e Rating Service. Allow fractional ratings.
I've changed the ratings 'score' from an integer to a float as fractional ratings seems like a reasonable idea to me.
  This had impact all through the Java layer, the REST layer, the model and the test code.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21128 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-13 13:31:07 +00:00
Andrew Hind
ed8497e2b7 ALF-32142: CLONE - patch.updateDmPermissions takes too long to complete
- initial fix
- untested as 2.2.latest -> HEAD is currently badly broken

git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21125 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-13 12:20:07 +00:00
Neil McErlean
7ebf2e5e6a RatingService GET node ratings statistics via REST.
Added node rating stats to the ratings.get webscript (for each scheme):
    average (mean) of all ratings for this node.
    total (sum) of all ratings for this node.
    count of all ratings for this node.


git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21108 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-12 16:07:08 +00:00
Nick Burch
5a3d53e5c1 Replication Service test which ensures that the right things get copied by the tranfer service
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@21097 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
2010-07-12 14:27:10 +00:00