119558 gcornwell: Merged code coverage improvements to 5.1-MC1 (5.1.0)
r117774 gjames: RA-567: Increase /workflow/processes API code coverage
r117773 gjames: RA-567: /workflow/processes coverage, removed unused ActivitiTypeConverter
r116883 gjames: RA-531: reapplied change after merge, for MultiTServiceImpl test coverage
r116629 gjames: RA-568 Increase /workflow/process-definitions API code coverage
r116574 gjames: RA-569 Increase /workflow/tasks API code coverage
r116286 gjames: RA-567: Increase /workflow/processes API code coverage
r115853 gjames: RA-566: Increasing /people api coverage (description field)
r115811 gjames: RA-566: Increasing /people api coverage
r113007 gjames: Adding additional test coverage for DictionaryNamespaceComponent and DynamicNamespacePrefixResolver RA-521
r113006 gjames: Adding additional test coverage for DictionaryNamespaceComponent and DictionaryComponent RA-514
r112969 gjames: Adding additional test coverage for TemplateServiceImpl RA-530
r112960 gjames: Alternative test approach for ModuleServiceImpl RA-520
r112703 gjames: Adding additional test coverage for NodeLocatorService RA-522
r112702 gjames: Adding additional test coverage for JobLockServiceImpl RA-516
r112699 gjames: Adding additional test coverage for ModuleServiceImpl RA-520
r112508 gjames: Adding additional test coverage for RenditionServiceImpl RA-526
r112476 gjames: Adding additional test coverage for ContentServiceImpl RA-513
r112475 gjames: Adding additional test coverage for MimetypeMap RA-519
r112238 gjames: Adding additional test coverage for MimetypeMap RA-519
r112237 gjames: Adding additional test coverage for TaggingService RA-529
r112236 gjames: Adding additional test coverage for MultiTServiceImpl RA-531
r112206 gjames: Adding additional test coverage for ContentServiceImpl RA-513
r112167 gcornwell: RA-523: Increase NodeService code coverage (removed redundant code that was testing a version store we no longer use)
r112102 gjames: Reverted changes to PermissionServiceImpl for RA-524
r112048 gjames: Temporarily removed some PermissionServiceImpl code. I need to put it back.
r111620 gjames: Adding additional test coverage for PermissionService RA-524
r111619 gjames: Added some @Override to make Sonar happier
r111456 gjames: Adding additional test coverage for AuthenticationService RA-509
r111427 gjames: Adding additional test coverage for AttributeService RA-509
r111317 gjames: Adding additional test coverage for WorkflowService RA-533
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@119945 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
91057: Merged V4.2-BUG-FIX (4.2.5) to HEAD-BUG-FIX (5.0/Cloud)
90986: MNT-11732: ephemeral locks have configurable threshold over which locks will be automatically made persistent instead.
By setting the new property, administrators may control how ephemeral locks are created, for example:
property alfresco.ephemeralLock.expiryThresh=30
This will mean that when a LockService client requests that an ephemeral lock is created with a timeout of greater than 30 seconds, the lock will be created as a persistent lock instead (the ephemeral lifetime request is vetoed).
By setting this property to -1, ALL locks will be created as persistent locks (giving the old, pre-ephemeral locking behaviour). By leaving this at the default (48 hours) the newer locking behaviour is completely unaffected, e.g. ephemeral locks may be created with up to 48 hour expiry time and over this limit an exception is thrown (and the lock is not created).
By setting the value to something in between these settings it is possible to have quite a nice balance of behaviour. Using the example of 30 seconds, as above, will mean that using Share's "Edit Online" to edit a document in MS Word will result in a persistent lock (as MS Word requests approx 1 hour for its locks). After Solr has performed its next incremental index, then the Word document may be seen in the "Document's I'm Editing" filter in Share, since this is a persistent (in-DB) lock.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@94765 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
85993 : ACE-2181 : Non-owner cannot execute cancel editing for content
- Tests changes according to new lock store behavior
86133 : ACE-2181 : Non-owner cannot execute cancel editing for content
- Added test case - attempt to unlock node by user who has ALL_PERMISSIONS
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@86239 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
<< Put the code back to HEAD >>
86049 : Reverse merged HEAD (5.0/Cloud)
<< Cause of 4 errors in https://bamboo.alfresco.com/bamboo/browse/ALF-ENT-141 >>
85880: ACE-2181 : Reverse Merge HEAD (5.0)
<< Implementing another approach for MNT-10946 and ACE-2181 >>
Merged HEAD-BUG-FIX (5.0/Cloud) to HEAD (4.3/Cloud)
71600: Merged V4.2-BUG-FIX (4.2.3) to HEAD-BUG-FIX (4.3/Cloud)
70349: Merged DEV to V4.2-BUG-FIX (4.2.3)
70294 : MNT-10946 : Admin is no longer able to unlock files
- Check if node is locked before unlock for non-admin or System users. Fix related test
85881: ACE-2181 : Merged DEV to HEAD (5.0)
76214 : MNT-10946 : Admin is no longer able to unlock files
- Drop check for lockowner from AbstractLockStore.set. Fix related test
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@86238 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
<< Cause of 4 errors in https://bamboo.alfresco.com/bamboo/browse/ALF-ENT-141 >>
85880: ACE-2181 : Reverse Merge HEAD (5.0)
<< Implementing another approach for MNT-10946 and ACE-2181 >>
Merged HEAD-BUG-FIX (5.0/Cloud) to HEAD (4.3/Cloud)
71600: Merged V4.2-BUG-FIX (4.2.3) to HEAD-BUG-FIX (4.3/Cloud)
70349: Merged DEV to V4.2-BUG-FIX (4.2.3)
70294 : MNT-10946 : Admin is no longer able to unlock files
- Check if node is locked before unlock for non-admin or System users. Fix related test
85881: ACE-2181 : Merged DEV to HEAD (5.0)
76214 : MNT-10946 : Admin is no longer able to unlock files
- Drop check for lockowner from AbstractLockStore.set. Fix related test
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@86049 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
<< Implementing another approach for MNT-10946 and ACE-2181 >>
Merged HEAD-BUG-FIX (5.0/Cloud) to HEAD (4.3/Cloud)
71600: Merged V4.2-BUG-FIX (4.2.3) to HEAD-BUG-FIX (4.3/Cloud)
70349: Merged DEV to V4.2-BUG-FIX (4.2.3)
70294 : MNT-10946 : Admin is no longer able to unlock files
- Check if node is locked before unlock for non-admin or System users. Fix related test
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@85880 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
84030: Merged V4.2-BUG-FIX (4.2.4) to HEAD-BUG-FIX (5.0/Cloud)
83370: Merged V4.2.3 (4.2.3.1) to V4.2-BUG-FIX (4.2.4)
79190: Merged DEV to PATCHES/V4.2.3
79172 : MNT-12049 : After uploading a document via WebDAV using DnD or copy/paste, the document appears as locked to Alfresco
- Unit test added
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@84620 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
79307: Merged V4.2-BUG-FIX (4.2.4) to HEAD-BUG-FIX (5.0/Cloud)
79080: Merged V4.2.3 (4.2.3) to V4.2-BUG-FIX (4.2.4)
78999: MNT-12049 : After uploading a document via WebDAV using DnD or copy/paste, the document appears as locked to Alfresco
- Fixed build failure
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@82699 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
73457: Merged V4.2-BUG-FIX (4.2.3) to HEAD-BUG-FIX (4.3/Cloud)
73376: Merged DEV to V4.2-BUG-FIX (4.2.3)
73246 : MNT-11615 : LockServiceImpl.getLockState() throws ClassCastException
- Added toString() call for ContentModel.PROP_LOCK_LIFETIME properties in LockableAspectInterceptor.
- Unit test was corrected.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@74778 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
73355: Merged V4.2-BUG-FIX (4.2.3) to HEAD-BUG-FIX (4.3/Cloud)
73281: Merged V4.1-BUG-FIX (4.1.10) to V4.2-BUG-FIX (4.2.3)
73054 (REDO MERGE): Added LockDAO.releaseLockQuiet and used it for the callback's precautionary lock release
- Fixes MNT-11507: JobLockService automatic refresh is triggering a retry under normal conditions
- Prevents a DEBUG message from RetryingTransactionInterceptor when the normal condition is for
the lock to no longer exist
73279: Fix javadoc for JobLockService.releaseLock to include @throws
This revision undoes the behaviour change of JobLockService.releaseLock introduced by:
56164: Fixes ALF-19964: Breaking API change in JobLockService.releaseLock
The JobLockService now behaves the same on 4.1.x and 4.2.x, while all bug fixes are preserved.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@74773 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
71600: Merged V4.2-BUG-FIX (4.2.3) to HEAD-BUG-FIX (4.3/Cloud)
70349: Merged DEV to V4.2-BUG-FIX (4.2.3)
70294 : MNT-10946 : Admin is no longer able to unlock files
- Check if node is locked before unlock for non-admin or System users. Fix related test
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@74694 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
70226: Merged V4.2-BUG-FIX (4.2.3) to HEAD-BUG-FIX (4.3/Cloud)
70137: Reverse Merge V4.2-BUG-FIX (4.2.3)
<< Commit appears to have resulted in lots of build errors. Not obvious why. >>
70056: Merged DEV to V4.2-BUG-FIX (4.2.3)
69689 : MNT-10946 : Admin is no longer able to unlock files
- Check if node is locked for non-admin users. Fix related test
69751 : MNT-10946 : Admin is no longer able to unlock files
- Changed warn message
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@70491 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
70223: Merged V4.2-BUG-FIX (4.2.3) to HEAD-BUG-FIX (4.3/Cloud)
70056: Merged DEV to V4.2-BUG-FIX (4.2.3)
69689 : MNT-10946 : Admin is no longer able to unlock files
- Check if node is locked for non-admin users. Fix related test
69751 : MNT-10946 : Admin is no longer able to unlock files
- Changed warn message
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@70488 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
65738: Merged V4.2-BUG-FIX (4.2.2) to HEAD-BUG-FIX (4.3/Cloud)
65639: Merged DEV to V4.2-BUG-FIX (4.2.2)
65624 : MNT-10477 : Lock on document being edited online persists when updating name of document
- LockableAspectInterceptor checks for EPHEMERAL locks if they exists. Fix related test
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@66268 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
55423: ALF-20031: LockStore is no longer used as a cache for persistent locks - it only holds Lifetime.EPHEMERAL locks.
55458: ALF-20031: added repeatable read within transactions to LockStores
55461: ALF-20031: moved transactional test code into separate test classes to avoid clutter.
55470: ALF-20031: added test for LockStore reads when no transaction is available.
55473: Generated LockState.toString() to aid debugging, stack trace clarity etc.
55481: ALF-20031: added tests for null value behaviour (transactional repeatable reads).
55663: ALF-20031: (work in progress, broken tests) removing concurrency locks from AbstractLockStore.
55664: ALF-20031: moved inner Thread classes to anonymous inner classes as there will be more of these coming.
55675: ALF-20031: fixed AbstractLockStoreTxTest
55681: ALF-20031: added more test cases to AbstractLockStoreTxTest
55683: Added missing tests to enterprise.repo.cluster package's BuildSafeTestSuite.
55684: ALF-20031: Fix HazelcastLockStoreTest to clear lock store backing map in createLockStore() fixture setup.
55688: Commented LockStore.clear() as a DO NOT USE method.
55694: ALF-20031: removed LockStore.contains() as this is not required, and was currently unsafe (no repeatable reads).
55696: ALF-20031: Fix AbstractLockStore.clear(): was not clearing transactionally scoped map.
55700: ALF-20031: removed concurrency locks from LockServiceImpl.getLockState(NodeRef)
55712: ALF-20031: removed concurrency lock from LockServiceImpl.lock()
55716: ALF-20031: removed lockstore locking from LockableAspectInterceptor.
55718: ALF-20031: renamed method to isEphemeralLock()
55719: ALF-20031: removed concurrency lock from LockServiceImpl.unlock()
55728: ALF-20031: added cm:lockLifetime property to content model, and added persistence within lockservice.
55732: ALF-20031: LockableAspectInterceptor no longer uses ephemeral lockstore for setProperties() handling.
55753: ALF-20031: upon tx rollback, ephemeral locks are now rolled back to the last known value, rather than always being unlocked.
55759: ALF-20031: temporary fix, AbstractLockStoreTxTest needs further attention for thread coordination.
55760: ALF-20091: disabled spawning of new transactions in LockKeeperImpl.refreshAllLocks()
55767: ALF-20031: changed AbstractLockStore to use getFullyAuthenticatedUser() instead of getRunAsUser().
55833: ALF-20091: reverted LockKeeperImpl to previous (create new tx) behaviour. Altered test to use separate transactions per lock phase.
55855: ALF-20031: fixed ReplicationServiceIntegrationTest, LockableAspectInterceptor's handling of cm:lockLifetime.
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@55893 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
