Compare commits

...

22 Commits

Author SHA1 Message Date
alfresco-build
8cd46d4585 [maven-release-plugin][skip ci] prepare release 23.7.0.2 2025-10-21 11:39:37 +00:00
Debjit Chattopadhyay
11d71e1941 (MNT-24776) Category Picker Error when a User does not have Read Permissions to a Category
(MNT-24776) Category Picker Error when a User does not have Read Permissions to a Category
2025-10-21 15:30:44 +05:30
Debjit Chattopadhyay
353d50a35c MNT-24776 adding if-else conditionals to avoid null values
(cherry picked from commit be02be5a8b)
2025-10-21 12:12:06 +05:30
alfresco-build
2daafc711d [maven-release-plugin][skip ci] prepare for next development iteration 2025-10-19 04:45:23 +00:00
alfresco-build
dfa94fbe21 [maven-release-plugin][skip ci] prepare release 23.7.0.1 2025-10-19 04:45:22 +00:00
Somnath-Deshmukh
4a93aec66b MNT-25359 Validating and Sanitizing the comment before posting (#3615)
MNT-25359 Validating and Sanitizing the comment before posting to prevent any XSS attack
2025-10-17 21:00:11 +05:30
Jakub Kochman
3f0bbc9844 Updating release/23.N branch to 23.7.0 after 23.6.0 ACS release [skip ci] 2025-10-10 11:19:17 +02:00
alfresco-build
cb9ad42101 [maven-release-plugin][skip ci] prepare for next development iteration 2025-10-09 16:41:21 +00:00
alfresco-build
ca385b3bbc [maven-release-plugin][skip ci] prepare release 23.6.0.33 2025-10-09 16:41:20 +00:00
Kacper Magdziarz
19c1582f1e [ACS-10423] Bump IE/SS to 2.0.17 (#3612) 2025-10-09 17:38:42 +02:00
alfresco-build
06a918b082 [maven-release-plugin][skip ci] prepare for next development iteration 2025-10-09 13:44:28 +00:00
alfresco-build
f543de9959 [maven-release-plugin][skip ci] prepare release 23.6.0.32 2025-10-09 13:44:26 +00:00
Debjit Chattopadhyay
8124279e6a Merge pull request #3610 from Alfresco/fix/revert_MNT_24776
Revert "MNT-24776 adding if-else conditionals to avoid null values"
2025-10-09 18:27:59 +05:30
Debjit Chattopadhyay
4281fd5b2d Revert "MNT-24776 adding if-else conditionals to avoid null values"
This reverts commit 393b064918.
2025-10-09 18:14:50 +05:30
alfresco-build
d10d88306b [maven-release-plugin][skip ci] prepare for next development iteration 2025-10-09 10:12:06 +00:00
alfresco-build
1d7a37cd8c [maven-release-plugin][skip ci] prepare release 23.6.0.31 2025-10-09 10:12:04 +00:00
Debjit Chattopadhyay
4bcb795452 Merge pull request #3609 from Alfresco/fix/MNT-24776_backport_to_23.N
MNT-24776 backport to release/23.N
2025-10-09 14:34:25 +05:30
Debjit Chattopadhyay
393b064918 MNT-24776 adding if-else conditionals to avoid null values
(cherry picked from commit be02be5a8b)
2025-10-09 13:29:30 +05:30
alfresco-build
f741f2ca45 [maven-release-plugin][skip ci] prepare for next development iteration 2025-10-08 15:59:31 +00:00
alfresco-build
ef676f11e4 [maven-release-plugin][skip ci] prepare release 23.6.0.30 2025-10-08 15:59:29 +00:00
cezary-witkowski
478c81fee3 [ACS-10454] Bump AOS to fix "Edit in Microsoft Office" error (#3606) 2025-10-08 16:57:01 +02:00
alfresco-build
cf9cc8042d [maven-release-plugin][skip ci] prepare for next development iteration 2025-10-06 13:25:18 +00:00
30 changed files with 179 additions and 154 deletions

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo-amps</artifactId> <artifactId>alfresco-community-repo-amps</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<modules> <modules>

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-governance-services-community-parent</artifactId> <artifactId>alfresco-governance-services-community-parent</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<modules> <modules>

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-governance-services-automation-community-repo</artifactId> <artifactId>alfresco-governance-services-automation-community-repo</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<build> <build>

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-governance-services-community-parent</artifactId> <artifactId>alfresco-governance-services-community-parent</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<modules> <modules>

View File

@@ -1,3 +1,3 @@
SOLR6_TAG=2.0.13 SOLR6_TAG=2.0.17
POSTGRES_TAG=15.4 POSTGRES_TAG=15.4
ACTIVEMQ_TAG=5.18.3-jre17-rockylinux8 ACTIVEMQ_TAG=5.18.3-jre17-rockylinux8

View File

@@ -8,7 +8,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-governance-services-community-repo-parent</artifactId> <artifactId>alfresco-governance-services-community-repo-parent</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<properties> <properties>

View File

@@ -4,7 +4,7 @@
# Version label # Version label
version.major=23 version.major=23
version.minor=6 version.minor=7
version.revision=0 version.revision=0
version.label= version.label=

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-governance-services-community-repo-parent</artifactId> <artifactId>alfresco-governance-services-community-repo-parent</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<build> <build>

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo</artifactId> <artifactId>alfresco-community-repo</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<modules> <modules>

View File

@@ -8,7 +8,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo-amps</artifactId> <artifactId>alfresco-community-repo-amps</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<properties> <properties>

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo</artifactId> <artifactId>alfresco-community-repo</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<dependencies> <dependencies>

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo</artifactId> <artifactId>alfresco-community-repo</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<properties> <properties>

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo</artifactId> <artifactId>alfresco-community-repo</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<dependencies> <dependencies>

View File

@@ -9,6 +9,6 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo-packaging</artifactId> <artifactId>alfresco-community-repo-packaging</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
</project> </project>

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo-packaging</artifactId> <artifactId>alfresco-community-repo-packaging</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<properties> <properties>

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo</artifactId> <artifactId>alfresco-community-repo</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<modules> <modules>

View File

@@ -1,3 +1,3 @@
SOLR6_TAG=2.0.13 SOLR6_TAG=2.0.17
POSTGRES_TAG=15.4 POSTGRES_TAG=15.4
ACTIVEMQ_TAG=5.18.3-jre17-rockylinux8 ACTIVEMQ_TAG=5.18.3-jre17-rockylinux8

View File

@@ -6,7 +6,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo-packaging</artifactId> <artifactId>alfresco-community-repo-packaging</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<modules> <modules>

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo-tests</artifactId> <artifactId>alfresco-community-repo-tests</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<organization> <organization>

View File

@@ -9,7 +9,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo-tests</artifactId> <artifactId>alfresco-community-repo-tests</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<developers> <developers>

View File

@@ -9,7 +9,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo-tests</artifactId> <artifactId>alfresco-community-repo-tests</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<developers> <developers>

View File

@@ -8,7 +8,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo-tests</artifactId> <artifactId>alfresco-community-repo-tests</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<properties> <properties>

View File

@@ -9,7 +9,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo-tests</artifactId> <artifactId>alfresco-community-repo-tests</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<developers> <developers>

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo-packaging</artifactId> <artifactId>alfresco-community-repo-packaging</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<properties> <properties>

View File

@@ -2,7 +2,7 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion> <modelVersion>4.0.0</modelVersion>
<artifactId>alfresco-community-repo</artifactId> <artifactId>alfresco-community-repo</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
<packaging>pom</packaging> <packaging>pom</packaging>
<name>Alfresco Community Repo Parent</name> <name>Alfresco Community Repo Parent</name>
@@ -24,7 +24,7 @@
<properties> <properties>
<acs.version.major>23</acs.version.major> <acs.version.major>23</acs.version.major>
<acs.version.minor>6</acs.version.minor> <acs.version.minor>7</acs.version.minor>
<acs.version.revision>0</acs.version.revision> <acs.version.revision>0</acs.version.revision>
<acs.version.label /> <acs.version.label />
<amp.min.version>${acs.version.major}.0.0</amp.min.version> <amp.min.version>${acs.version.major}.0.0</amp.min.version>
@@ -113,7 +113,7 @@
<dependency.jakarta-json-path.version>2.9.0</dependency.jakarta-json-path.version> <dependency.jakarta-json-path.version>2.9.0</dependency.jakarta-json-path.version>
<dependency.json-smart.version>2.5.2</dependency.json-smart.version> <dependency.json-smart.version>2.5.2</dependency.json-smart.version>
<alfresco.googledrive.version>4.1.0</alfresco.googledrive.version> <alfresco.googledrive.version>4.1.0</alfresco.googledrive.version>
<alfresco.aos-module.version>3.4.0-A.1</alfresco.aos-module.version> <alfresco.aos-module.version>3.4.0</alfresco.aos-module.version>
<alfresco.api-explorer.version>23.4.0</alfresco.api-explorer.version> <!-- Also in alfresco-enterprise-share --> <alfresco.api-explorer.version>23.4.0</alfresco.api-explorer.version> <!-- Also in alfresco-enterprise-share -->
<alfresco.maven-plugin.version>2.2.0</alfresco.maven-plugin.version> <alfresco.maven-plugin.version>2.2.0</alfresco.maven-plugin.version>
@@ -154,7 +154,7 @@
<connection>scm:git:https://github.com/Alfresco/alfresco-community-repo.git</connection> <connection>scm:git:https://github.com/Alfresco/alfresco-community-repo.git</connection>
<developerConnection>scm:git:https://github.com/Alfresco/alfresco-community-repo.git</developerConnection> <developerConnection>scm:git:https://github.com/Alfresco/alfresco-community-repo.git</developerConnection>
<url>https://github.com/Alfresco/alfresco-community-repo</url> <url>https://github.com/Alfresco/alfresco-community-repo</url>
<tag>23.6.0.29</tag> <tag>23.7.0.2</tag>
</scm> </scm>
<distributionManagement> <distributionManagement>

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo</artifactId> <artifactId>alfresco-community-repo</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<dependencies> <dependencies>

View File

@@ -2,7 +2,7 @@
* #%L * #%L
* Alfresco Remote API * Alfresco Remote API
* %% * %%
* Copyright (C) 2005 - 2016 Alfresco Software Limited * Copyright (C) 2005 - 2025 Alfresco Software Limited
* %% * %%
* This file is part of the Alfresco software. * This file is part of the Alfresco software.
* If the software was purchased under a paid Alfresco license, the terms of * If the software was purchased under a paid Alfresco license, the terms of
@@ -31,6 +31,14 @@ import java.util.HashMap;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import org.apache.commons.lang3.StringUtils;
import org.json.simple.JSONObject;
import org.owasp.html.PolicyFactory;
import org.owasp.html.Sanitizers;
import org.springframework.extensions.webscripts.Cache;
import org.springframework.extensions.webscripts.Status;
import org.springframework.extensions.webscripts.WebScriptRequest;
import org.alfresco.model.ContentModel; import org.alfresco.model.ContentModel;
import org.alfresco.model.ForumModel; import org.alfresco.model.ForumModel;
import org.alfresco.repo.content.MimetypeMap; import org.alfresco.repo.content.MimetypeMap;
@@ -44,10 +52,6 @@ import org.alfresco.service.cmr.security.PermissionService;
import org.alfresco.service.namespace.NamespaceService; import org.alfresco.service.namespace.NamespaceService;
import org.alfresco.service.namespace.QName; import org.alfresco.service.namespace.QName;
import org.alfresco.service.namespace.RegexQNamePattern; import org.alfresco.service.namespace.RegexQNamePattern;
import org.json.simple.JSONObject;
import org.springframework.extensions.webscripts.Cache;
import org.springframework.extensions.webscripts.Status;
import org.springframework.extensions.webscripts.WebScriptRequest;
/** /**
* This class is the controller for the comments.post web script. * This class is the controller for the comments.post web script.
@@ -58,7 +62,7 @@ import org.springframework.extensions.webscripts.WebScriptRequest;
public class CommentsPost extends AbstractCommentsWebScript public class CommentsPost extends AbstractCommentsWebScript
{ {
/** /**
* Overrides AbstractCommentsWebScript to add comment * Overrides AbstractCommentsWebScript to add comment
*/ */
@Override @Override
protected Map<String, Object> executeImpl(NodeRef nodeRef, WebScriptRequest req, Status status, Cache cache) protected Map<String, Object> executeImpl(NodeRef nodeRef, WebScriptRequest req, Status status, Cache cache)
@@ -66,6 +70,19 @@ public class CommentsPost extends AbstractCommentsWebScript
// get json object from request // get json object from request
JSONObject json = parseJSON(req); JSONObject json = parseJSON(req);
// Validating and Sanitizing comment content to prevent XSS
String commentContent = getOrNull(json, "content");
if (StringUtils.isBlank(commentContent))
{
throw new IllegalArgumentException("Comment content must not be empty");
}
else
{
PolicyFactory policy = Sanitizers.FORMATTING.and(Sanitizers.LINKS);
String safeContent = policy.sanitize(commentContent);
json.replace("content", safeContent);
}
/* MNT-10231, MNT-9771 fix */ /* MNT-10231, MNT-9771 fix */
this.behaviourFilter.disableBehaviour(nodeRef, ContentModel.ASPECT_AUDITABLE); this.behaviourFilter.disableBehaviour(nodeRef, ContentModel.ASPECT_AUDITABLE);
@@ -99,32 +116,32 @@ public class CommentsPost extends AbstractCommentsWebScript
{ {
// fetch the parent to add the node to // fetch the parent to add the node to
NodeRef commentsFolder = getOrCreateCommentsFolder(nodeRef); NodeRef commentsFolder = getOrCreateCommentsFolder(nodeRef);
// get a unique name // get a unique name
String name = getUniqueChildName("comment"); String name = getUniqueChildName("comment");
// create the comment // create the comment
NodeRef commentNodeRef = nodeService.createNode(commentsFolder, NodeRef commentNodeRef = nodeService.createNode(commentsFolder,
ContentModel.ASSOC_CONTAINS, ContentModel.ASSOC_CONTAINS,
QName.createQName(NamespaceService.CONTENT_MODEL_1_0_URI, QName.createValidLocalName(name)), QName.createQName(NamespaceService.CONTENT_MODEL_1_0_URI, QName.createValidLocalName(name)),
ForumModel.TYPE_POST).getChildRef(); ForumModel.TYPE_POST).getChildRef();
// fetch the title required to create a comment // fetch the title required to create a comment
String title = getOrNull(json, JSON_KEY_TITLE); String title = getOrNull(json, JSON_KEY_TITLE);
HashMap<QName, Serializable> props = new HashMap<QName, Serializable>(1, 1.0f); HashMap<QName, Serializable> props = new HashMap<QName, Serializable>(1, 1.0f);
props.put(ContentModel.PROP_TITLE, title != null ? title : ""); props.put(ContentModel.PROP_TITLE, title != null ? title : "");
nodeService.addProperties(commentNodeRef, props); nodeService.addProperties(commentNodeRef, props);
ContentWriter writer = contentService.getWriter(commentNodeRef, ContentModel.PROP_CONTENT, true); ContentWriter writer = contentService.getWriter(commentNodeRef, ContentModel.PROP_CONTENT, true);
// fetch the content of a comment // fetch the content of a comment
String contentString = getOrNull(json, JSON_KEY_CONTENT); String contentString = getOrNull(json, JSON_KEY_CONTENT);
writer.setMimetype(MimetypeMap.MIMETYPE_HTML); writer.setMimetype(MimetypeMap.MIMETYPE_HTML);
writer.putContent(contentString); writer.putContent(contentString);
return commentNodeRef; return commentNodeRef;
} }
/** /**
* generates an comment item value * generates an comment item value
* *
@@ -134,34 +151,34 @@ public class CommentsPost extends AbstractCommentsWebScript
private Map<String, Object> generateItemValue(NodeRef commentNodeRef) private Map<String, Object> generateItemValue(NodeRef commentNodeRef)
{ {
Map<String, Object> result = new HashMap<String, Object>(4, 1.0f); Map<String, Object> result = new HashMap<String, Object>(4, 1.0f);
String creator = (String)this.nodeService.getProperty(commentNodeRef, ContentModel.PROP_CREATOR); String creator = (String) this.nodeService.getProperty(commentNodeRef, ContentModel.PROP_CREATOR);
Serializable created = this.nodeService.getProperty(commentNodeRef, ContentModel.PROP_CREATED); Serializable created = this.nodeService.getProperty(commentNodeRef, ContentModel.PROP_CREATED);
Serializable modified = this.nodeService.getProperty(commentNodeRef, ContentModel.PROP_MODIFIED); Serializable modified = this.nodeService.getProperty(commentNodeRef, ContentModel.PROP_MODIFIED);
boolean isUpdated = false; boolean isUpdated = false;
if (created instanceof Date && modified instanceof Date) if (created instanceof Date && modified instanceof Date)
{ {
isUpdated = ((Date)modified).getTime() - ((Date)created).getTime() > 5000; isUpdated = ((Date) modified).getTime() - ((Date) created).getTime() > 5000;
} }
// TODO refactor v0 Comments API to use CommentService (see ACE-5437) // TODO refactor v0 Comments API to use CommentService (see ACE-5437)
Serializable owner = this.nodeService.getProperty(commentNodeRef, ContentModel.PROP_OWNER); Serializable owner = this.nodeService.getProperty(commentNodeRef, ContentModel.PROP_OWNER);
String currentUser = this.serviceRegistry.getAuthenticationService().getCurrentUserName(); String currentUser = this.serviceRegistry.getAuthenticationService().getCurrentUserName();
boolean isSiteManager = this.permissionService.hasPermission(commentNodeRef, SiteModel.SITE_MANAGER) == (AccessStatus.ALLOWED); boolean isSiteManager = this.permissionService.hasPermission(commentNodeRef, SiteModel.SITE_MANAGER) == (AccessStatus.ALLOWED);
boolean isCoordinator = this.permissionService.hasPermission(commentNodeRef, PermissionService.COORDINATOR) == (AccessStatus.ALLOWED); boolean isCoordinator = this.permissionService.hasPermission(commentNodeRef, PermissionService.COORDINATOR) == (AccessStatus.ALLOWED);
boolean canEditComment = isSiteManager || isCoordinator || currentUser.equals(creator) || currentUser.equals(owner); boolean canEditComment = isSiteManager || isCoordinator || currentUser.equals(creator) || currentUser.equals(owner);
result.put("node", commentNodeRef); result.put("node", commentNodeRef);
result.put("author", this.personService.getPerson(creator)); result.put("author", this.personService.getPerson(creator));
result.put("isUpdated", isUpdated); result.put("isUpdated", isUpdated);
result.put("canEditComment", canEditComment); result.put("canEditComment", canEditComment);
return result; return result;
} }
/** /**
* generates the response model for adding a comment * generates the response model for adding a comment
* *
@@ -194,7 +211,7 @@ public class CommentsPost extends AbstractCommentsWebScript
} }
return commentsFolder; return commentsFolder;
} }
/** /**
* returns the nodeRef of the existing one * returns the nodeRef of the existing one
* *
@@ -207,7 +224,7 @@ public class CommentsPost extends AbstractCommentsWebScript
{ {
List<ChildAssociationRef> assocs = nodeService.getChildAssocs(nodeRef, ForumModel.ASSOC_DISCUSSION, RegexQNamePattern.MATCH_ALL); List<ChildAssociationRef> assocs = nodeService.getChildAssocs(nodeRef, ForumModel.ASSOC_DISCUSSION, RegexQNamePattern.MATCH_ALL);
ChildAssociationRef firstAssoc = assocs.get(0); ChildAssociationRef firstAssoc = assocs.get(0);
return nodeService.getChildByName(firstAssoc.getChildRef(), ContentModel.ASSOC_CONTAINS, COMMENTS_TOPIC_NAME); return nodeService.getChildByName(firstAssoc.getChildRef(), ContentModel.ASSOC_CONTAINS, COMMENTS_TOPIC_NAME);
} }
else else
@@ -220,7 +237,7 @@ public class CommentsPost extends AbstractCommentsWebScript
{ {
return prefix + "-" + System.currentTimeMillis(); return prefix + "-" + System.currentTimeMillis();
} }
/** /**
* creates the comments folder if it does not exists * creates the comments folder if it does not exists
* *
@@ -229,35 +246,34 @@ public class CommentsPost extends AbstractCommentsWebScript
*/ */
private NodeRef createCommentsFolder(final NodeRef nodeRef) private NodeRef createCommentsFolder(final NodeRef nodeRef)
{ {
NodeRef commentsFolder = AuthenticationUtil.runAs(new AuthenticationUtil.RunAsWork<NodeRef>() NodeRef commentsFolder = AuthenticationUtil.runAs(new AuthenticationUtil.RunAsWork<NodeRef>() {
{
public NodeRef doWork() throws Exception public NodeRef doWork() throws Exception
{ {
NodeRef commentsFolder = null; NodeRef commentsFolder = null;
AuthenticationUtil.pushAuthentication(); AuthenticationUtil.pushAuthentication();
// ALF-5240: turn off auditing round the discussion node creation to prevent // ALF-5240: turn off auditing round the discussion node creation to prevent
// the source document from being modified by the first user leaving a comment // the source document from being modified by the first user leaving a comment
behaviourFilter.disableBehaviour(nodeRef, ContentModel.ASPECT_AUDITABLE); behaviourFilter.disableBehaviour(nodeRef, ContentModel.ASPECT_AUDITABLE);
try try
{ {
// MNT-12082: set System user for creating forumFolder and commentsFolder nodes // MNT-12082: set System user for creating forumFolder and commentsFolder nodes
AuthenticationUtil.setFullyAuthenticatedUser(AuthenticationUtil.getSystemUserName()); AuthenticationUtil.setFullyAuthenticatedUser(AuthenticationUtil.getSystemUserName());
nodeService.addAspect(nodeRef, QName.createQName(NamespaceService.FORUMS_MODEL_1_0_URI, "discussable"), null); nodeService.addAspect(nodeRef, QName.createQName(NamespaceService.FORUMS_MODEL_1_0_URI, "discussable"), null);
nodeService.addAspect(nodeRef, QName.createQName(NamespaceService.FORUMS_MODEL_1_0_URI, "commentsRollup"), null); nodeService.addAspect(nodeRef, QName.createQName(NamespaceService.FORUMS_MODEL_1_0_URI, "commentsRollup"), null);
List<ChildAssociationRef> assocs = nodeService.getChildAssocs(nodeRef, QName.createQName(NamespaceService.FORUMS_MODEL_1_0_URI, "discussion"), RegexQNamePattern.MATCH_ALL); List<ChildAssociationRef> assocs = nodeService.getChildAssocs(nodeRef, QName.createQName(NamespaceService.FORUMS_MODEL_1_0_URI, "discussion"), RegexQNamePattern.MATCH_ALL);
if (assocs.size() != 0) if (assocs.size() != 0)
{ {
NodeRef forumFolder = assocs.get(0).getChildRef(); NodeRef forumFolder = assocs.get(0).getChildRef();
Map<QName, Serializable> props = new HashMap<QName, Serializable>(1, 1.0f); Map<QName, Serializable> props = new HashMap<QName, Serializable>(1, 1.0f);
props.put(ContentModel.PROP_NAME, COMMENTS_TOPIC_NAME); props.put(ContentModel.PROP_NAME, COMMENTS_TOPIC_NAME);
commentsFolder = nodeService.createNode( commentsFolder = nodeService.createNode(
forumFolder, forumFolder,
ContentModel.ASSOC_CONTAINS, ContentModel.ASSOC_CONTAINS,
QName.createQName(NamespaceService.CONTENT_MODEL_1_0_URI, COMMENTS_TOPIC_NAME), QName.createQName(NamespaceService.CONTENT_MODEL_1_0_URI, COMMENTS_TOPIC_NAME),
QName.createQName(NamespaceService.FORUMS_MODEL_1_0_URI, "topic"), QName.createQName(NamespaceService.FORUMS_MODEL_1_0_URI, "topic"),
props).getChildRef(); props).getChildRef();
} }
@@ -267,12 +283,12 @@ public class CommentsPost extends AbstractCommentsWebScript
AuthenticationUtil.popAuthentication(); AuthenticationUtil.popAuthentication();
behaviourFilter.enableBehaviour(nodeRef, ContentModel.ASPECT_AUDITABLE); behaviourFilter.enableBehaviour(nodeRef, ContentModel.ASPECT_AUDITABLE);
} }
return commentsFolder; return commentsFolder;
} }
}, AuthenticationUtil.getSystemUserName()); }, AuthenticationUtil.getSystemUserName());
return commentsFolder; return commentsFolder;
} }

View File

@@ -1,83 +1,92 @@
<#macro renderParent node indent=" "> <#macro renderParent node indent=" ">
<#escape x as jsonUtils.encodeJSONString(x)> <#escape x as jsonUtils.encodeJSONString(x)>
${indent}"parent": ${indent}"parent":
${indent}{ ${indent}{
<#if (node != rootNode) && node.parent??> <#if (node != rootNode) && node.parent??>
<@renderParent node.parent indent+" " /> <@renderParent node.parent indent+" " />
</#if> </#if>
${indent}"type": "${node.typeShort}", ${indent}"type": "${node.typeShort}",
${indent}"isContainer": ${node.isContainer?string}, ${indent}"isContainer": ${node.isContainer?string},
${indent}"name": "${node.properties.name!""}", ${indent}"name": "${node.properties.name!""}",
${indent}"title": "${node.properties.title!""}", ${indent}"title": "${node.properties.title!""}",
${indent}"description": "${node.properties.description!""}", ${indent}"description": "${node.properties.description!""}",
<#if node.properties.modified??>${indent}"modified": "${xmldate(node.properties.modified)}",</#if> <#if node.properties.modified??>${indent}"modified": "${xmldate(node.properties.modified)}",</#if>
<#if node.properties.modifier??>${indent}"modifier": "${node.properties.modifier}",</#if> <#if node.properties.modifier??>${indent}"modifier": "${node.properties.modifier}",</#if>
${indent}"displayPath": "${node.displayPath!""}", ${indent}"displayPath": "${node.displayPath!""}",
${indent}"qnamePath": "${node.qnamePath!""}", ${indent}"qnamePath": "${node.qnamePath!""}",
<#if node.aspects??> <#if node.aspects??>
${indent}"aspects": ${indent}"aspects":
${indent}[ ${indent}[
<#list node.aspects as aspect> <#list node.aspects as aspect>
"${shortQName(aspect)}" "${shortQName(aspect)}"
<#if aspect_has_next>,</#if> <#if aspect_has_next>,</#if>
</#list> </#list>
${indent}], ${indent}],
</#if> </#if>
${indent}"nodeRef": "${node.nodeRef}" ${indent}"nodeRef": "${node.nodeRef}"
${indent}}, ${indent}},
</#escape> </#escape>
</#macro> </#macro>
<#macro pickerResultsJSON results> <#macro pickerResultsJSON results>
<#escape x as jsonUtils.encodeJSONString(x)> <#escape x as jsonUtils.encodeJSONString(x)>
{ {
"data": "data":
{ {
<#if parent??> <#if parent??>
<@renderParent parent /> <@renderParent parent />
</#if> </#if>
"items": "items":
[ [
<#list results as row> <#list results as row>
{ {
"type": "${row.item.typeShort}", "type": "${row.item.typeShort}",
"parentType": "${row.item.parentTypeShort!""}", "parentType": "${row.item.parentTypeShort!""}",
"isContainer": ${row.item.isContainer?string}, "isContainer": ${row.item.isContainer?string},
<#if row.container??>"container": "${row.container!""}",</#if> <#if row.container??>"container": "${row.container!""}",</#if>
"name": "${row.item.properties.name!""}", <#if row.item.properties?? && row.item.properties.name??>
<#if row.item.aspects??> "name": "${row.item.properties.name!""}",
"aspects": [ <#else>
<#list row.item.aspects as aspect> "name": "${(row.item.name)!row.item?string!""}",
"${shortQName(aspect)}" </#if>
<#if aspect_has_next>,</#if> <#if row.item.aspects??>
</#list> "aspects": [
], <#list row.item.aspects as aspect>
</#if> "${shortQName(aspect)}"
"title":<#if row.item.properties["lnk:title"]??>"${row.item.properties["lnk:title"]}", <#if aspect_has_next>,</#if>
<#elseif row.item.properties["ia:whatEvent"]??>"${row.item.properties["ia:whatEvent"]}", </#list>
<#else>"${row.item.properties.title!""}",</#if> ],
"description": "${row.item.properties.description!""}", </#if>
<#if row.item.properties.modified??>"modified": "${xmldate(row.item.properties.modified)}",</#if> <#if row.item.properties??>
<#if row.item.properties.modifier??>"modifier": "${row.item.properties.modifier}",</#if> "title":<#if row.item.properties["lnk:title"]??>"${row.item.properties["lnk:title"]}",
<#if row.item.siteShortName??>"site": "${row.item.siteShortName}",</#if> <#elseif row.item.properties["ia:whatEvent"]??>"${row.item.properties["ia:whatEvent"]}",
<#if row.item.properties["ia:fromDate"]??>"fromDate": "${xmldate(row.item.properties["ia:fromDate"])}",</#if> <#else>"${row.item.properties.title!""}",</#if>
"displayPath": "${row.item.displayPath!""}", "description": "${row.item.properties.description!""}",
"qnamePath": "${row.item.qnamePath!""}", <#else>
<#if row.item.typeShort != "cm:person" && row.item.typeShort != "cm:authorityContainer"> "title": "${(row.item.name)!row.item?string!""}",
"userAccess": "description": "",
{ </#if>
"create": ${row.item.hasPermission("CreateChildren")?string}, <#if row.item.properties.modified??>"modified": "${xmldate(row.item.properties.modified)}",</#if>
"edit": ${row.item.hasPermission("Write")?string}, <#if row.item.properties.modifier??>"modifier": "${row.item.properties.modifier}",</#if>
"delete": ${row.item.hasPermission("Delete")?string} <#if row.item.siteShortName??>"site": "${row.item.siteShortName}",</#if>
}, <#if row.item.properties["ia:fromDate"]??>"fromDate": "${xmldate(row.item.properties["ia:fromDate"])}",</#if>
</#if> "displayPath": "${row.item.displayPath!""}",
"nodeRef": "${row.item.nodeRef}"<#if row.selectable?exists>, "qnamePath": "${row.item.qnamePath!""}",
"selectable" : ${row.selectable?string}</#if> <#if row.item.typeShort != "cm:person" && row.item.typeShort != "cm:authorityContainer">
}<#if row_has_next>,</#if> "userAccess":
</#list> {
] "create": ${row.item.hasPermission("CreateChildren")?string},
} "edit": ${row.item.hasPermission("Write")?string},
} "delete": ${row.item.hasPermission("Delete")?string}
</#escape> },
</#if>
"nodeRef": "${row.item.nodeRef}"<#if row.selectable?exists>,
"selectable" : ${row.selectable?string}</#if>
}<#if row_has_next>,</#if>
</#list>
]
}
}
</#escape>
</#macro> </#macro>

View File

@@ -7,7 +7,7 @@
<parent> <parent>
<groupId>org.alfresco</groupId> <groupId>org.alfresco</groupId>
<artifactId>alfresco-community-repo</artifactId> <artifactId>alfresco-community-repo</artifactId>
<version>23.6.0.29</version> <version>23.7.0.2</version>
</parent> </parent>
<dependencies> <dependencies>

View File

@@ -3,7 +3,7 @@
repository.name=Main Repository repository.name=Main Repository
# Schema number # Schema number
version.schema=19500 version.schema=19600
# Directory configuration # Directory configuration