mirror of
https://github.com/Alfresco/alfresco-community-repo.git
synced 2025-06-30 18:15:39 +00:00
d1db3663e4
Added new policy to aspect rn:rendition. Rendition nodes, before deletion, have their non-primary parent assocs removed. Otherwise the deletion of rendition nodes (which just moves them to the archive store) means that renditionService.getRenditions() returns those deleted assocs.
Enabled HTMLRenderingEngineTest.testImagesSameFolder test case. Changed it slightly so that it deletes renditions/extracted images between test runs to prevent unwanted overwriting of renditions
Enabled RenditionServiceIntegrationTest.testRenditionPlacements test case. Fixed the test path to point to /.../filename.txt as it should.
Rewrote the end of the test to cover the cases where a rendition is attempting to overwrite another.
Refactoring: renamed numerous private variables to aid readability
Changes to RenditionNodeManager. If:
a rendition is to an existing node that is not a rendition OR
a rendition is to an existing rendition node whose source is not the same as the current one OR
a rendition is to an existing rendition node whose renditionDef's name has changed
Then throw an exception. We explicitly disallow these use cases now. We may support them in the future with a "forceOverwrite" option somewhere.
StandardRenditionLocationResolverImpl now uses a RepositoryHelper to locate CompanyHome rather than a Lucene search
Extensive debug logging added to the service.
Added some javadoc
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@23330 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
216 lines
11 KiB
Java
216 lines
11 KiB
Java
/*
|
|
* Copyright (C) 2005-2010 Alfresco Software Limited.
|
|
*
|
|
* This file is part of Alfresco
|
|
*
|
|
* Alfresco is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Lesser General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Alfresco is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
package org.alfresco.repo.rendition;
|
|
|
|
import java.io.Serializable;
|
|
import java.util.HashMap;
|
|
import java.util.List;
|
|
import java.util.Map;
|
|
|
|
import org.alfresco.model.ContentModel;
|
|
import org.alfresco.repo.model.Repository;
|
|
import org.alfresco.service.ServiceRegistry;
|
|
import org.alfresco.service.cmr.rendition.RenditionDefinition;
|
|
import org.alfresco.service.cmr.rendition.RenditionService;
|
|
import org.alfresco.service.cmr.repository.ChildAssociationRef;
|
|
import org.alfresco.service.cmr.repository.NodeRef;
|
|
import org.alfresco.service.cmr.repository.StoreRef;
|
|
import org.alfresco.service.cmr.search.ResultSet;
|
|
import org.alfresco.service.cmr.search.SearchService;
|
|
import org.alfresco.service.namespace.NamespaceService;
|
|
import org.alfresco.service.namespace.QName;
|
|
import org.alfresco.util.BaseAlfrescoSpringTest;
|
|
import org.alfresco.util.GUID;
|
|
|
|
/**
|
|
* @author Brian Remmington
|
|
* @author Nick Smith
|
|
*/
|
|
public class StandardRenditionLocationResolverTest extends BaseAlfrescoSpringTest
|
|
{
|
|
private ServiceRegistry serviceRegistry;
|
|
private NodeRef companyHome;
|
|
private StandardRenditionLocationResolverImpl locationResolver;
|
|
private RenditionService renditionService;
|
|
private SearchService searchService;
|
|
private Repository repositoryHelper;
|
|
|
|
/**
|
|
* Called during the transaction setup
|
|
*/
|
|
@Override
|
|
@SuppressWarnings("deprecation")
|
|
protected void onSetUpInTransaction() throws Exception
|
|
{
|
|
super.onSetUpInTransaction();
|
|
|
|
// Get the required services
|
|
this.serviceRegistry = (ServiceRegistry) this.getApplicationContext().getBean("ServiceRegistry");
|
|
this.nodeService=serviceRegistry.getNodeService();
|
|
this.searchService = serviceRegistry.getSearchService();
|
|
this.renditionService = (RenditionService) this.getApplicationContext().getBean("RenditionService");
|
|
this.repositoryHelper = (Repository) this.getApplicationContext().getBean("repositoryHelper");
|
|
ResultSet rs = searchService.query(StoreRef.STORE_REF_WORKSPACE_SPACESSTORE, SearchService.LANGUAGE_XPATH,
|
|
"/app:company_home");
|
|
if (rs.length() != 1)
|
|
{
|
|
fail("Could not find company home");
|
|
}
|
|
companyHome = rs.getNodeRef(0);
|
|
locationResolver = new StandardRenditionLocationResolverImpl();
|
|
locationResolver.setServiceRegistry(serviceRegistry);
|
|
locationResolver.setRepositoryHelper(repositoryHelper);
|
|
}
|
|
|
|
public void testChildAssociationFinder()
|
|
{
|
|
QName renditionKind = QName.createQName(NamespaceService.APP_MODEL_1_0_URI, "test");
|
|
NodeRef sourceNode = makeNode(companyHome, ContentModel.TYPE_CONTENT);
|
|
NodeRef tempRenditionNode = makeNode(sourceNode, ContentModel.TYPE_CONTENT);
|
|
|
|
RenditionDefinition renditionDef = renditionService.createRenditionDefinition(renditionKind,
|
|
"brians_test_engine");
|
|
|
|
RenditionLocation location =
|
|
locationResolver.getRenditionLocation(sourceNode,renditionDef, tempRenditionNode);
|
|
|
|
assertEquals(sourceNode, location.getParentRef());
|
|
assertNull(location.getChildName());
|
|
assertNull(location.getChildRef());
|
|
|
|
NodeRef targetFolder = makeNode(companyHome, ContentModel.TYPE_FOLDER);
|
|
String companyHomeName = (String) nodeService.getProperty(companyHome, ContentModel.PROP_NAME);
|
|
String targetFolderName = (String) nodeService.getProperty(targetFolder, ContentModel.PROP_NAME);
|
|
String template = "/"+companyHomeName+"/"+targetFolderName+"/brian.xml";
|
|
renditionDef.setParameterValue(RenditionService.PARAM_DESTINATION_PATH_TEMPLATE, template);
|
|
location = locationResolver.getRenditionLocation(sourceNode, renditionDef, tempRenditionNode);
|
|
|
|
assertEquals(targetFolder, location.getParentRef());
|
|
assertEquals("brian.xml", location.getChildName());
|
|
assertNull(location.getChildRef());
|
|
|
|
template=targetFolderName+"/test-${sourceContentType}.xml";
|
|
renditionDef.setParameterValue(RenditionService.PARAM_DESTINATION_PATH_TEMPLATE, template);
|
|
location = locationResolver.getRenditionLocation(sourceNode, renditionDef, tempRenditionNode);
|
|
|
|
assertEquals(targetFolder, location.getParentRef());
|
|
assertEquals("test-"+ContentModel.PROP_CONTENT.getLocalName()+".xml", location.getChildName());
|
|
assertNull(location.getChildRef());
|
|
|
|
// Test that when the template path specifies an existing node then that
|
|
// node is set as the 'childRef' property on the RenditionLocation.
|
|
NodeRef destinationNode = makeNode(targetFolder, ContentModel.TYPE_CONTENT);
|
|
String destinationName = (String) nodeService.getProperty(destinationNode, ContentModel.PROP_NAME);
|
|
template = targetFolderName + "/" + destinationName;
|
|
renditionDef.setParameterValue(RenditionService.PARAM_DESTINATION_PATH_TEMPLATE, template);
|
|
location = locationResolver.getRenditionLocation(sourceNode, renditionDef, tempRenditionNode);
|
|
|
|
assertEquals(targetFolder, location.getParentRef());
|
|
assertEquals(destinationName, location.getChildName());
|
|
assertEquals(destinationNode, location.getChildRef());
|
|
|
|
// Test that the 'destination node' param takes precedence over them 'template path' param.
|
|
template = "/" + targetFolderName + "/brian.xml";
|
|
renditionDef.setParameterValue(RenditionService.PARAM_DESTINATION_PATH_TEMPLATE, template);
|
|
renditionDef.setParameterValue(RenditionService.PARAM_DESTINATION_NODE, destinationNode);
|
|
location = locationResolver.getRenditionLocation(sourceNode, renditionDef, tempRenditionNode);
|
|
|
|
assertEquals(targetFolder, location.getParentRef());
|
|
assertEquals(destinationName, location.getChildName());
|
|
assertEquals(destinationNode, location.getChildRef());
|
|
}
|
|
|
|
public void testCreatesFoldersForTemplatedLocation() throws Exception
|
|
{
|
|
QName fooName = QName.createQName(NamespaceService.CONTENT_MODEL_1_0_URI, "testFooFolder");
|
|
QName barName = QName.createQName(NamespaceService.CONTENT_MODEL_1_0_URI, "testBarFolder");
|
|
String fooPath = "/testFooFolder";
|
|
String barPath = fooPath + "/testBarFolder";
|
|
|
|
List<ChildAssociationRef> childAssocs = nodeService.getChildAssocs(companyHome, ContentModel.ASSOC_CONTAINS,
|
|
fooName);
|
|
assertTrue("Folder " + fooPath + " should not exist!", childAssocs.isEmpty());
|
|
|
|
QName renditionKind = QName.createQName(NamespaceService.APP_MODEL_1_0_URI, "test");
|
|
NodeRef sourceFolder = makeNode(companyHome, ContentModel.TYPE_FOLDER);
|
|
NodeRef sourceNode = makeNode(sourceFolder, ContentModel.TYPE_CONTENT);
|
|
NodeRef tempRenditionNode = makeNode(companyHome, ContentModel.TYPE_CONTENT);
|
|
|
|
RenditionDefinition renditionDef = renditionService.createRenditionDefinition(renditionKind,
|
|
"nicks_test_engine");
|
|
|
|
String pathTemplate = barPath + "${cwd}nick.xml";
|
|
renditionDef.setParameterValue(RenditionService.PARAM_DESTINATION_PATH_TEMPLATE, pathTemplate);
|
|
|
|
RenditionLocation location =
|
|
locationResolver.getRenditionLocation(sourceNode,renditionDef, tempRenditionNode);
|
|
|
|
NodeRef fooNode = checkFolder(fooName, companyHome, "Foo");
|
|
NodeRef barNode = checkFolder(barName, fooNode, "Bar");
|
|
NodeRef finalFolderNode = checkFolder(nodeService.getPrimaryParent(sourceFolder).getQName(), barNode, "Final Folder");
|
|
|
|
assertEquals("Final folder is not the rendition parent!", finalFolderNode, location.getParentRef());
|
|
assertEquals("nick.xml", location.getChildName());
|
|
}
|
|
|
|
// public void testOldRenditionIsOrphaned() throws Exception
|
|
// {
|
|
// QName renditionKind = QName.createQName(NamespaceService.APP_MODEL_1_0_URI, "test");
|
|
// NodeRef sourceNode = makeNode(companyHome, ContentModel.TYPE_CONTENT);
|
|
// NodeRef tempRenditionNode = makeNode(sourceNode, ContentModel.TYPE_CONTENT);
|
|
// ChildAssociationRef tempRenditionLocation=nodeService.getPrimaryParent(tempRenditionNode);
|
|
//
|
|
// RenditionDefinition definition = renditionService.createRenditionDefinition(renditionKind,
|
|
// "nicks_test_engine");
|
|
// ChildAssociationRef oldRendition =
|
|
// nodeService.createNode(sourceNode, RenditionModel.ASSOC_RENDITION, definition.getRenditionName(), ContentModel.TYPE_CONTENT);
|
|
// definition.setParameterValue(RenditionService.PARAM_ORPHAN_EXISTING_RENDITION, true);
|
|
//
|
|
// //Test deletes old rendition if it's under source Node and new rendition is not.
|
|
// locationResolver.getRenditionLocation(sourceNode, definition, tempRenditionLocation);
|
|
//
|
|
// List<ChildAssociationRef> sourceChildren = nodeService.getChildAssocs(sourceNode);
|
|
// assertFalse("The old rendition association should ahve been removed!", sourceChildren.contains(oldRendition));
|
|
// assertFalse("The old rendition should have been deleted!", nodeService.exists(oldRendition.getChildRef()) );
|
|
// }
|
|
|
|
private NodeRef checkFolder(QName folderName, NodeRef parentName, String folderMessageName)
|
|
{
|
|
List<ChildAssociationRef> folderAssocs = nodeService.getChildAssocs(parentName, ContentModel.ASSOC_CONTAINS, folderName);
|
|
assertEquals("Folder " + folderMessageName + " should exist!", 1, folderAssocs.size());
|
|
NodeRef folderNode = folderAssocs.get(0).getChildRef();
|
|
assertEquals(folderMessageName+" node is wrong type!", ContentModel.TYPE_FOLDER, nodeService.getType(folderNode));
|
|
assertEquals(folderMessageName+" node has wrong name!", folderName.getLocalName(),
|
|
nodeService.getProperty(folderNode, ContentModel.PROP_NAME));
|
|
return folderNode;
|
|
}
|
|
|
|
private NodeRef makeNode(NodeRef parent, QName nodeType)
|
|
{
|
|
String uuid = GUID.generate();
|
|
Map<QName, Serializable> props = new HashMap<QName, Serializable>();
|
|
props.put(ContentModel.PROP_NAME, uuid);
|
|
ChildAssociationRef assoc = nodeService.createNode(parent, ContentModel.ASSOC_CONTAINS, QName.createQName(
|
|
NamespaceService.CONTENT_MODEL_1_0_URI, uuid), nodeType, props);
|
|
return assoc.getChildRef();
|
|
}
|
|
|
|
}
|