mirror of
https://github.com/Alfresco/alfresco-community-repo.git
synced 2025-08-14 17:58:59 +00:00
57488: Merged V4.2-BUG-FIX (4.2.1) to HEAD-BUG-FIX (Cloud/4.3) 57318: Merged V4.1-BUG-FIX (4.1.7) to V4.2-BUG-FIX (4.2.0) 56965 : Merged DEV to V4.1-BUG-FIX (4.1.7) 55964 : MNT-9662 : HTTP error 500 when renaming a space with a numerical name via WebDAV - Prevent folders to take part in any kind of shuffle operation. 56308 : MNT-9662 : HTTP error 500 when renaming a space with a numerical name via WebDAV - Unit test that demonstrate issue. - Fixed unit test failure that causes prevous merge (r57176) to be reverted. git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@61830 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
259 lines
10 KiB
Java
259 lines
10 KiB
Java
/*
|
|
* Copyright (C) 2005-2013 Alfresco Software Limited.
|
|
*
|
|
* This file is part of Alfresco
|
|
*
|
|
* Alfresco is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Lesser General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Alfresco is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
package org.alfresco.repo.webdav;
|
|
|
|
import static org.junit.Assert.fail;
|
|
import static org.junit.Assert.assertTrue;
|
|
import static org.junit.Assert.assertEquals;
|
|
|
|
import static org.mockito.Mockito.never;
|
|
import static org.mockito.Mockito.verify;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
import java.util.Arrays;
|
|
import java.util.List;
|
|
|
|
import org.alfresco.model.ContentModel;
|
|
import org.alfresco.repo.security.authentication.AuthenticationUtil;
|
|
import org.alfresco.repo.transaction.RetryingTransactionHelper.RetryingTransactionCallback;
|
|
import org.alfresco.service.cmr.model.FileFolderService;
|
|
import org.alfresco.service.cmr.model.FileInfo;
|
|
import org.alfresco.service.cmr.repository.NodeRef;
|
|
import org.alfresco.service.cmr.repository.NodeService;
|
|
import org.alfresco.service.cmr.repository.StoreRef;
|
|
import org.alfresco.service.cmr.search.ResultSet;
|
|
import org.alfresco.service.cmr.search.SearchService;
|
|
import org.alfresco.service.transaction.TransactionService;
|
|
import org.alfresco.util.ApplicationContextHelper;
|
|
import org.alfresco.util.GUID;
|
|
import org.junit.After;
|
|
import org.junit.Before;
|
|
import org.junit.BeforeClass;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.Mockito;
|
|
import org.mockito.runners.MockitoJUnitRunner;
|
|
import org.springframework.context.ApplicationContext;
|
|
import org.springframework.mock.web.MockHttpServletRequest;
|
|
import org.springframework.mock.web.MockHttpServletResponse;
|
|
|
|
/**
|
|
* Tests for the {@link MoveMethod} class.
|
|
*
|
|
* @author Matt Ward
|
|
*/
|
|
@RunWith(MockitoJUnitRunner.class)
|
|
public class MoveMethodTest
|
|
{
|
|
private static ApplicationContext ctx;
|
|
|
|
private MoveMethod moveMethod;
|
|
private @Mock WebDAVHelper davHelper;
|
|
private MockHttpServletRequest req;
|
|
private MockHttpServletResponse resp;
|
|
private NodeRef rootNode;
|
|
private @Mock FileFolderService mockFileFolderService;
|
|
private @Mock WebDAVLockService davLockService;
|
|
private String destPath;
|
|
private String sourcePath;
|
|
private FileInfo sourceFileInfo;
|
|
private NodeRef sourceParentNodeRef;
|
|
private NodeRef destParentNodeRef;
|
|
private NodeRef sourceNodeRef;
|
|
|
|
private SearchService searchService;
|
|
private FileFolderService fileFolderService;
|
|
private NodeService nodeService;
|
|
private TransactionService transactionService;
|
|
private WebDAVHelper webDAVHelper;
|
|
|
|
private NodeRef companyHomeNodeRef;
|
|
|
|
@BeforeClass
|
|
public static void setUpBeforeClass() throws Exception
|
|
{
|
|
ctx = ApplicationContextHelper.getApplicationContext(new String[]
|
|
{
|
|
"classpath:alfresco/application-context.xml", "classpath:alfresco/web-scripts-application-context.xml",
|
|
"classpath:alfresco/remote-api-context.xml"
|
|
});
|
|
}
|
|
|
|
@After
|
|
public void tearDown()
|
|
{
|
|
moveMethod = null;
|
|
req = null;
|
|
resp = null;
|
|
|
|
AuthenticationUtil.clearCurrentSecurityContext();
|
|
}
|
|
|
|
@Before
|
|
public void setUp() throws Exception
|
|
{
|
|
req = new MockHttpServletRequest();
|
|
resp = new MockHttpServletResponse();
|
|
rootNode = new NodeRef("workspace://SpacesStore/node1");
|
|
moveMethod = new MoveMethod()
|
|
{
|
|
@Override
|
|
protected LockInfo checkNode(FileInfo fileInfo, boolean ignoreShared, boolean lockMethod)
|
|
throws WebDAVServerException
|
|
{
|
|
return new LockInfoImpl();
|
|
}
|
|
|
|
@Override
|
|
protected LockInfo checkNode(FileInfo fileInfo) throws WebDAVServerException
|
|
{
|
|
return new LockInfoImpl();
|
|
}
|
|
};
|
|
moveMethod.setDetails(req, resp, davHelper, rootNode);
|
|
|
|
sourceFileInfo = Mockito.mock(FileInfo.class);
|
|
when(sourceFileInfo.isFolder()).thenReturn(true);
|
|
|
|
destPath = "/path/to/dest.doc";
|
|
moveMethod.m_strDestinationPath = destPath;
|
|
|
|
sourcePath = "/path/to/source.doc";
|
|
moveMethod.m_strPath = sourcePath;
|
|
|
|
when(davHelper.getFileFolderService()).thenReturn(mockFileFolderService);
|
|
|
|
List<String> sourcePathSplit = Arrays.asList("path", "to", "source.doc");
|
|
when(davHelper.splitAllPaths(sourcePath)).thenReturn(sourcePathSplit);
|
|
|
|
|
|
List<String> destPathSplit = Arrays.asList("path", "to", "dest.doc");
|
|
when(davHelper.splitAllPaths(destPath)).thenReturn(destPathSplit);
|
|
|
|
|
|
when(mockFileFolderService.resolveNamePath(rootNode, sourcePathSplit)).thenReturn(sourceFileInfo);
|
|
|
|
FileInfo destFileInfo = Mockito.mock(FileInfo.class);
|
|
when(mockFileFolderService.resolveNamePath(rootNode, destPathSplit)).thenReturn(destFileInfo);
|
|
|
|
sourceParentNodeRef = new NodeRef("workspace://SpacesStore/parent");
|
|
destParentNodeRef = new NodeRef("workspace://SpacesStore/parent");
|
|
|
|
|
|
sourceNodeRef = new NodeRef("workspace://SpacesStore/sourcefile");
|
|
|
|
when(davHelper.getLockService()).thenReturn(davLockService);
|
|
|
|
searchService = ctx.getBean("SearchService", SearchService.class);
|
|
fileFolderService = ctx.getBean("FileFolderService", FileFolderService.class);
|
|
nodeService = ctx.getBean("NodeService", NodeService.class);
|
|
transactionService = ctx.getBean("transactionService", TransactionService.class);
|
|
webDAVHelper = ctx.getBean("webDAVHelper", WebDAVHelper.class);
|
|
|
|
AuthenticationUtil.setFullyAuthenticatedUser(AuthenticationUtil.getAdminUserName());
|
|
|
|
companyHomeNodeRef = transactionService.getRetryingTransactionHelper().doInTransaction(new RetryingTransactionCallback<NodeRef>()
|
|
{
|
|
@Override
|
|
public NodeRef execute() throws Throwable
|
|
{
|
|
// find "Company Home"
|
|
StoreRef storeRef = new StoreRef(StoreRef.PROTOCOL_WORKSPACE, "SpacesStore");
|
|
ResultSet resultSet = searchService.query(storeRef, SearchService.LANGUAGE_LUCENE, "PATH:\"/app:company_home\"");
|
|
NodeRef result = resultSet.getNodeRef(0);
|
|
resultSet.close();
|
|
|
|
return result;
|
|
}
|
|
});
|
|
}
|
|
|
|
|
|
@Test
|
|
public void canRenameFolders() throws Exception
|
|
{
|
|
moveMethod.moveOrCopy(sourceNodeRef, sourceParentNodeRef, destParentNodeRef, "dest.doc");
|
|
|
|
verify(mockFileFolderService).rename(sourceNodeRef, "dest.doc");
|
|
verify(davLockService).unlock(sourceNodeRef);
|
|
verify(mockFileFolderService, never()).create(destParentNodeRef, "dest.doc", ContentModel.TYPE_CONTENT);
|
|
}
|
|
|
|
|
|
@Test
|
|
public void canRenameFoldersWhenNewNameMatchesShufflePattern() throws Exception
|
|
{
|
|
when(davHelper.isRenameShuffle(destPath)).thenReturn(true);
|
|
when(davHelper.isRenameShuffle(sourcePath)).thenReturn(false);
|
|
|
|
// Test: Perform the rename
|
|
moveMethod.moveOrCopy(sourceNodeRef, sourceParentNodeRef, destParentNodeRef, "dest.doc");
|
|
|
|
|
|
verify(mockFileFolderService).rename(sourceNodeRef, "dest.doc");
|
|
verify(davLockService).unlock(sourceNodeRef);
|
|
verify(mockFileFolderService, never()).create(destParentNodeRef, "dest.doc", ContentModel.TYPE_CONTENT);
|
|
}
|
|
|
|
@Test
|
|
public void testMNT_9662()
|
|
{
|
|
transactionService.getRetryingTransactionHelper().doInTransaction(new RetryingTransactionCallback<Object>()
|
|
{
|
|
@Override
|
|
public Object execute() throws Throwable
|
|
{
|
|
// create test folder with name that doesn't match getDAVHelper().isRenameShuffle()
|
|
FileInfo testFileInfo = fileFolderService.create(companyHomeNodeRef, "folder-" + GUID.generate().substring(29), ContentModel.TYPE_FOLDER);
|
|
|
|
req = new MockHttpServletRequest(WebDAV.METHOD_MOVE, "/alfresco/webdav/" + testFileInfo.getName());
|
|
resp = new MockHttpServletResponse();
|
|
req.setServerPort(8080);
|
|
req.setContextPath("/alfresco");
|
|
req.setServletPath("/webdav");
|
|
|
|
moveMethod = new MoveMethod();
|
|
moveMethod.setDetails(req, resp, webDAVHelper, companyHomeNodeRef);
|
|
|
|
// generate new name that matches getDAVHelper().isRenameShuffle()
|
|
String newName = GUID.generate().substring(28);
|
|
req.addHeader(WebDAV.HEADER_DESTINATION, "http://localhost:8080/alfresco/webdav/" + newName);
|
|
|
|
try
|
|
{
|
|
moveMethod.execute();
|
|
|
|
assertTrue(nodeService.exists(testFileInfo.getNodeRef()));
|
|
assertEquals(newName, nodeService.getProperty(testFileInfo.getNodeRef(), ContentModel.PROP_NAME));
|
|
}
|
|
catch (WebDAVServerException e)
|
|
{
|
|
fail("Fail to rename folder: " + (e.getCause() != null ? e.getCause().getMessage() : e.getMessage()));
|
|
}
|
|
finally
|
|
{
|
|
nodeService.deleteNode(testFileInfo.getNodeRef());
|
|
}
|
|
return null;
|
|
}
|
|
});
|
|
}
|
|
}
|