mirror of
https://github.com/Alfresco/alfresco-community-repo.git
synced 2025-08-07 17:49:17 +00:00
64703: Fix ACE-987: NPE in NodeEntity during post-commit write through to shared cache - Query selecting specific root nodes was not fully populating the stored entity - The failure itself mainly occurs when a check is made to prevent duplication of cache transfers (the cached value is the same); once the cache has an entry, the error would not have occurred again. git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/alfresco/HEAD/root@66181 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
182 lines
6.8 KiB
Java
182 lines
6.8 KiB
Java
/*
|
|
* Copyright (C) 2005-2010 Alfresco Software Limited.
|
|
*
|
|
* This file is part of Alfresco
|
|
*
|
|
* Alfresco is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU Lesser General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Alfresco is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public License
|
|
* along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
package org.alfresco.repo.domain.node;
|
|
|
|
import java.io.Serializable;
|
|
import java.util.Collection;
|
|
import java.util.Collections;
|
|
import java.util.List;
|
|
|
|
import junit.framework.TestCase;
|
|
|
|
import org.alfresco.model.ContentModel;
|
|
import org.alfresco.repo.cache.SimpleCache;
|
|
import org.alfresco.repo.domain.node.NodeDAO.NodeRefQueryCallback;
|
|
import org.alfresco.repo.transaction.RetryingTransactionHelper;
|
|
import org.alfresco.repo.transaction.RetryingTransactionHelper.RetryingTransactionCallback;
|
|
import org.alfresco.service.ServiceRegistry;
|
|
import org.alfresco.service.cmr.repository.NodeRef;
|
|
import org.alfresco.service.cmr.repository.StoreRef;
|
|
import org.alfresco.service.transaction.TransactionService;
|
|
import org.alfresco.test_category.OwnJVMTestsCategory;
|
|
import org.alfresco.util.ApplicationContextHelper;
|
|
import org.alfresco.util.Pair;
|
|
import org.junit.Assert;
|
|
import org.junit.experimental.categories.Category;
|
|
import org.springframework.context.ApplicationContext;
|
|
|
|
/**
|
|
* Additional tests for the Node DAO.
|
|
*
|
|
* @see NodeDAO
|
|
*
|
|
* @author Derek Hulley
|
|
* @since 3.4
|
|
*/
|
|
@Category(OwnJVMTestsCategory.class)
|
|
public class NodeDAOTest extends TestCase
|
|
{
|
|
private ApplicationContext ctx = ApplicationContextHelper.getApplicationContext();
|
|
|
|
private TransactionService transactionService;
|
|
private RetryingTransactionHelper txnHelper;
|
|
private NodeDAO nodeDAO;
|
|
private SimpleCache<Serializable, Node> rootNodesCache;
|
|
|
|
@SuppressWarnings("unchecked")
|
|
@Override
|
|
public void setUp()
|
|
{
|
|
ServiceRegistry serviceRegistry = (ServiceRegistry) ctx.getBean(ServiceRegistry.SERVICE_REGISTRY);
|
|
transactionService = serviceRegistry.getTransactionService();
|
|
txnHelper = transactionService.getRetryingTransactionHelper();
|
|
txnHelper.setMinRetryWaitMs(10);
|
|
txnHelper.setRetryWaitIncrementMs(10);
|
|
txnHelper.setMaxRetryWaitMs(50);
|
|
|
|
nodeDAO = (NodeDAO) ctx.getBean("nodeDAO");
|
|
rootNodesCache = (SimpleCache<Serializable, Node>) ctx.getBean("node.rootNodesSharedCache");
|
|
}
|
|
|
|
public void testTransaction() throws Throwable
|
|
{
|
|
final boolean[] newTxn = new boolean[] {false};
|
|
RetryingTransactionCallback<Long> getTxnIdCallback = new RetryingTransactionCallback<Long>()
|
|
{
|
|
public Long execute() throws Throwable
|
|
{
|
|
return nodeDAO.getCurrentTransactionId(newTxn[0]);
|
|
}
|
|
};
|
|
// No txn
|
|
try
|
|
{
|
|
getTxnIdCallback.execute();
|
|
fail("Should have failed when running outside of a transaction");
|
|
}
|
|
catch (Throwable e)
|
|
{
|
|
// Expected
|
|
}
|
|
// Read-only
|
|
assertNull("No Txn ID should be present in read-only txn", txnHelper.doInTransaction(getTxnIdCallback, true));
|
|
// First success
|
|
Long txnId1 = txnHelper.doInTransaction(getTxnIdCallback);
|
|
assertNull("No Txn ID should be present in untouched txn", txnId1);
|
|
// Second success
|
|
newTxn[0] = true;
|
|
Long txnId2 = txnHelper.doInTransaction(getTxnIdCallback);
|
|
assertNotNull("Txn ID should be present by forcing it", txnId2);
|
|
}
|
|
|
|
public void testGetNodesWithAspects() throws Throwable
|
|
{
|
|
final NodeRefQueryCallback callback = new NodeRefQueryCallback()
|
|
{
|
|
public boolean handle(Pair<Long, NodeRef> nodePair)
|
|
{
|
|
// Don't need more
|
|
return false;
|
|
}
|
|
};
|
|
transactionService.getRetryingTransactionHelper().doInTransaction(new RetryingTransactionCallback<Void>()
|
|
{
|
|
@Override
|
|
public Void execute() throws Throwable
|
|
{
|
|
nodeDAO.getNodesWithAspects(
|
|
Collections.singleton(ContentModel.ASPECT_AUDITABLE),
|
|
1L, 1000L,
|
|
callback);
|
|
return null;
|
|
}
|
|
}, true);
|
|
}
|
|
|
|
public void testGetPrimaryChildAcls() throws Throwable
|
|
{
|
|
List<NodeIdAndAclId> acls = nodeDAO.getPrimaryChildrenAcls(1L);
|
|
assertNotNull("Null list", acls);
|
|
}
|
|
|
|
public void testGetStoreId() throws Throwable
|
|
{
|
|
// Get all stores
|
|
List<Pair<Long, StoreRef>> storePairs = nodeDAO.getStores();
|
|
// Check each one
|
|
for (Pair<Long, StoreRef> storePair : storePairs)
|
|
{
|
|
StoreRef storeRef = storePair.getSecond();
|
|
// Check
|
|
Pair<Long, StoreRef> checkStorePair = nodeDAO.getStore(storeRef);
|
|
assertEquals("Store pair did not match. ", storePair, checkStorePair);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Ensure that the {@link NodeEntity} values cached as root nodes are valid instances.
|
|
* <p/>
|
|
* ACE-987: NPE in NodeEntity during post-commit write through to shared cache
|
|
*/
|
|
public void testRootNodeCacheEntries() throws Throwable
|
|
{
|
|
// Get the stores
|
|
List<Pair<Long, StoreRef>> storeRefPairs = nodeDAO.getStores();
|
|
assertTrue("No stores in the system.", storeRefPairs.size() > 0);
|
|
// Drop all cache entries and reload them one by one
|
|
for (Pair<Long, StoreRef> storeRefPair : storeRefPairs)
|
|
{
|
|
StoreRef storeRef = storeRefPair.getSecond();
|
|
nodeDAO.getRootNode(storeRef);
|
|
}
|
|
// The cache should be populated again
|
|
Collection<Serializable> keys = rootNodesCache.getKeys();
|
|
assertTrue("Cache entries were not populated. ", keys.size() > 0);
|
|
// Check each root node
|
|
for (Serializable key : keys)
|
|
{
|
|
NodeEntity node = (NodeEntity) rootNodesCache.get(key);
|
|
// Create a good value
|
|
NodeEntity clonedNode = (NodeEntity) node.clone();
|
|
// Run equals and hashcode
|
|
node.hashCode();
|
|
Assert.assertEquals(node, clonedNode); // Does NPE check implicitly
|
|
}
|
|
}
|
|
} |