[ACS-180] Add Description column to My libraries / Favorites (#1486)

* [ACS-180] Add Description column to My libraries / Favorites

* Fix e2e test

* Fix datatable selector

* Fix role and visibility selectors

* Add description to search library layout

* Final fix
This commit is contained in:
davidcanonieto
2020-06-16 14:54:26 +01:00
committed by GitHub
parent 7130a5c15c
commit 03b75a5fb3
7 changed files with 83 additions and 12 deletions

View File

@@ -1340,11 +1340,21 @@
"key": "title",
"title": "APP.DOCUMENT_LIST.COLUMNS.NAME",
"type": "text",
"class": "adf-expand-cell-5",
"class": "adf-expand-cell-3",
"sortable": true,
"template": "app.columns.libraryName",
"desktopOnly": false
},
{
"id": "app.favorite.libraries.description",
"key": "description",
"title": "APP.DOCUMENT_LIST.COLUMNS.DESCRIPTION",
"type": "text",
"class": "adf-ellipsis-cell adf-expand-cell-5",
"sortable": true,
"template": "app.columns.libraryDescription",
"desktopOnly": true
},
{
"id": "app.libraries.role",
"key": "role",
@@ -1377,11 +1387,21 @@
"key": "title",
"title": "APP.DOCUMENT_LIST.COLUMNS.NAME",
"type": "text",
"class": "adf-expand-cell-5",
"class": "adf-expand-cell-3",
"sortable": true,
"template": "app.columns.libraryName",
"desktopOnly": false
},
{
"id": "app.favorite.libraries.description",
"key": "description",
"title": "APP.DOCUMENT_LIST.COLUMNS.DESCRIPTION",
"type": "text",
"class": "adf-ellipsis-cell adf-expand-cell-5",
"sortable": true,
"template": "app.columns.libraryDescription",
"desktopOnly": true
},
{
"id": "app.favorite.libraries.role",
"key": "role",

View File

@@ -1375,11 +1375,21 @@
"key": "title",
"title": "APP.DOCUMENT_LIST.COLUMNS.NAME",
"type": "text",
"class": "adf-expand-cell-5",
"class": "adf-expand-cell-3",
"sortable": true,
"template": "app.columns.libraryName",
"desktopOnly": false
},
{
"id": "app.favorite.libraries.description",
"key": "description",
"title": "APP.DOCUMENT_LIST.COLUMNS.DESCRIPTION",
"type": "text",
"class": "adf-ellipsis-cell adf-expand-cell-5",
"sortable": true,
"template": "app.columns.libraryDescription",
"desktopOnly": true
},
{
"id": "app.libraries.role",
"key": "role",
@@ -1412,11 +1422,21 @@
"key": "title",
"title": "APP.DOCUMENT_LIST.COLUMNS.NAME",
"type": "text",
"class": "adf-expand-cell-5",
"class": "adf-expand-cell-3",
"sortable": true,
"template": "app.columns.libraryName",
"desktopOnly": false
},
{
"id": "app.favorite.libraries.description",
"key": "description",
"title": "APP.DOCUMENT_LIST.COLUMNS.DESCRIPTION",
"type": "text",
"class": "adf-ellipsis-cell adf-expand-cell-5",
"sortable": true,
"template": "app.columns.libraryDescription",
"desktopOnly": true
},
{
"id": "app.favorite.libraries.role",
"key": "role",

View File

@@ -107,7 +107,7 @@ describe('File Libraries', () => {
});
it('[C217095] has the correct columns', async () => {
const expectedColumns = [ 'Name', 'My Role', 'Visibility' ];
const expectedColumns = [ 'Name', 'Description', 'My Role', 'Visibility' ];
const actualColumns = await dataTable.getColumnHeadersText();
expect(actualColumns).toEqual(expectedColumns);
@@ -176,7 +176,7 @@ describe('File Libraries', () => {
});
it('[C289893] has the correct columns', async () => {
const expectedColumns = [ 'Name', 'My Role', 'Visibility' ];
const expectedColumns = [ 'Name', 'Description', 'My Role', 'Visibility' ];
const actualColumns = await dataTable.getColumnHeadersText();
expect(actualColumns).toEqual(expectedColumns);

View File

@@ -176,7 +176,7 @@ describe('Search results - libraries', () => {
await searchInput.searchFor(site1.name);
await dataTable.waitForBody();
const expectedColumns = [ 'Name', 'My Role', 'Visibility' ];
const expectedColumns = [ 'Name', 'Description', 'My Role', 'Visibility' ];
const actualColumns = await dataTable.getColumnHeadersText();
expect(actualColumns).toEqual(expectedColumns);