inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2025-07-24 17:31:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACA-1911] Un-Share file - permission error notification (#743)

Browse Source 
* remove update permission check

* add 403 error

* show 403 error

* update test

* update e2e

* update

Co-Authored-By: pionnegru <bogdan.cilibiu@ness.com>
This commit is contained in:
Cilibiu Bogdan
2018-10-23 09:35:30 +03:00
committed by Suzana Dirla
parent a6c420b54f
commit 07703547ec
6 changed files with 70 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
e2e/components/dialog/share-dialog.ts
View File

@@ -116,7 +116,7 @@ export class ShareDialog extends Component {
return toggleClass.includes('checked');
}
async isShareToggleEnabled() {
async isShareToggleDisabled() {
const toggleClass = await this.getShareToggle().getAttribute('class');
return toggleClass.includes('mat-disabled');
}

21
e2e/suites/actions/unshare-file.test.ts
View File

@@ -738,8 +738,7 @@ describe('Unshare a file', () => {
done();
});
// TODO: ACA-1911
xit('on File Libraries - file shared by other user - [C286682]', async () => {
it('on File Libraries - file shared by other user - [C286682]', async () => {
await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES);
await dataTable.waitForHeader();
await dataTable.doubleClickOnRowByName(sitePrivate);
@@ -749,7 +748,7 @@ describe('Unshare a file', () => {
await toolbar.menu.clickMenuItem('Shared link settings');
await shareDialog.waitForDialogToOpen();
expect(await shareDialog.isShareToggleEnabled()).toBe(false, 'Share toggle enabled for consumer');
expect(await shareDialog.isShareToggleDisabled()).toBe(false, 'Share toggle enabled for consumer');
});
it('on File Libraries - file shared by the user - [C286701]', async () => {
@@ -762,11 +761,10 @@ describe('Unshare a file', () => {
await toolbar.menu.clickMenuItem('Shared link settings');
await shareDialog.waitForDialogToOpen();
expect(await shareDialog.isShareToggleEnabled()).toBe(true, 'Share toggle disabled for consumer');
expect(await shareDialog.isShareToggleDisabled()).toBe(false, 'Share toggle enabled for consumer');
});
// TODO: ACA-1911
xit('on Shared Files - file shared by other user - [C286687]', async () => {
it('on Shared Files - file shared by other user - [C286687]', async () => {
await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.SHARED_FILES);
await dataTable.waitForHeader();
await dataTable.selectItem(file1);
@@ -774,7 +772,7 @@ describe('Unshare a file', () => {
await toolbar.menu.clickMenuItem('Shared link settings');
await shareDialog.waitForDialogToOpen();
expect(await shareDialog.isShareToggleEnabled()).toBe(false, 'Share toggle enabled for consumer');
expect(await shareDialog.isShareToggleDisabled()).toBe(false, 'Share toggle enabled for consumer');
});
it('on Shared Files - file shared by the user - [C286702]', async () => {
@@ -785,11 +783,10 @@ describe('Unshare a file', () => {
await toolbar.menu.clickMenuItem('Shared link settings');
await shareDialog.waitForDialogToOpen();
expect(await shareDialog.isShareToggleEnabled()).toBe(true, 'Share toggle disabled for consumer');
expect(await shareDialog.isShareToggleDisabled()).toBe(false, 'Share toggle enabled for consumer');
});
// TODO: ACA-1911
xit('on Favorites - file shared by other user - [C286697]', async () => {
it('on Favorites - file shared by other user - [C286697]', async () => {
await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES);
await dataTable.waitForHeader();
await dataTable.selectItem(file1);
@@ -797,7 +794,7 @@ describe('Unshare a file', () => {
await toolbar.menu.clickMenuItem('Share');
await shareDialog.waitForDialogToOpen();
expect(await shareDialog.isShareToggleEnabled()).toBe(false, 'Share toggle enabled for consumer');
expect(await shareDialog.isShareToggleDisabled()).toBe(false, 'Share toggle enabled for consumer');
});
it('on Favorites - file shared by the user - [C286703]', async () => {
@@ -808,7 +805,7 @@ describe('Unshare a file', () => {
await toolbar.menu.clickMenuItem('Share');
await shareDialog.waitForDialogToOpen();
expect(await shareDialog.isShareToggleEnabled()).toBe(true, 'Share toggle disabled for consumer');
expect(await shareDialog.isShareToggleDisabled()).toBe(false, 'Share toggle enabled for consumer');
});
});