various bug fixes (#1010)

* various bug fixes

* use 'remove favorite' label where appropriate

* fix toggle favorite component labels

* e2e type check and fixes

* favorite library label

* support toggle favorite component selectors

* update tests

* update e2e tests

* update e2e

* e2e update

* update e2e
This commit is contained in:
Denys Vuika
2019-03-14 15:40:38 +00:00
committed by GitHub
parent becd71adff
commit 07f45e08cf
18 changed files with 218 additions and 171 deletions

View File

@@ -38,6 +38,8 @@ export class Menu extends Component {
submenu: 'app-context-menu-item .mat-menu-item',
editFolder: `.mat-menu-item[id$='editFolder']`,
favoriteAction: `.mat-menu-item[id$='favorite.add']`,
removeFavoriteAction: `.mat-menu-item[id$='favorite.remove']`,
editOffline: `.mat-menu-item[title='Edit offline']`,
cancelEditing: `.mat-menu-item[title='Cancel editing']`
};
@@ -56,7 +58,10 @@ export class Menu extends Component {
downloadAction: ElementFinder = this.component.element(by.cssContainingText(Menu.selectors.item, 'Download'));
editFolderAction: ElementFinder = this.component.element(by.css(Menu.selectors.editFolder));
editOfflineAction: ElementFinder = this.component.element(by.css(Menu.selectors.editOffline));
favoriteAction: ElementFinder = this.component.element(by.cssContainingText(Menu.selectors.item, 'Favorite'));
favoriteAction: ElementFinder = this.component.element(by.css(Menu.selectors.favoriteAction));
removeFavoriteAction: ElementFinder = this.component.element(by.css(Menu.selectors.removeFavoriteAction));
toggleFavoriteAction: ElementFinder = this.component.element(by.cssContainingText(Menu.selectors.item, 'Favorite'));
toggleRemoveFavoriteAction: ElementFinder = this.component.element(by.cssContainingText(Menu.selectors.item, 'Remove favorite'));
joinAction: ElementFinder = this.component.element(by.cssContainingText(Menu.selectors.item, 'Join'));
leaveAction: ElementFinder = this.component.element(by.cssContainingText(Menu.selectors.item, 'Leave'));
managePermissionsAction: ElementFinder = this.component.element(by.cssContainingText(Menu.selectors.item, 'Permissions'));
@@ -260,6 +265,18 @@ export class Menu extends Component {
return await this.favoriteAction.isPresent();
}
async isRemoveFavoritePresent() {
return await this.removeFavoriteAction.isPresent();
}
async isToggleFavoritePresent() {
return await this.toggleFavoriteAction.isPresent();
}
async isToggleRemoveFavoritePresent() {
return await this.toggleRemoveFavoriteAction.isPresent();
}
async isJoinLibraryPresent() {
return await this.joinAction.isPresent();
}

View File

@@ -207,6 +207,11 @@ export class Toolbar extends Component {
return await this.menu.clickMenuItem('Favorite');
}
async clickMoreActionsRemoveFavorite() {
await this.openMoreMenu();
return await this.menu.clickMenuItem('Remove favorite');
}
async clickMoreActionsDelete() {
await this.openMoreMenu();
return await this.menu.clickMenuItem('Delete');