From 0a8a3895a14cb42de5b429090e5358109a724949 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bartosz=20Seku=C5=82a?= <bsekula12@gmail.com>
Date: Thu, 25 Nov 2021 13:31:38 +0100
Subject: [PATCH] [AAE-6309] Cleaning process references (#2360)

* [AAE-6309] Cleaning process references

* [AAE-6309] Added test for disabled button
---
 .../create-menu/create-menu.component.spec.ts |  2 +-
 .../main-action/main-action.component.html    |  2 ++
 .../main-action/main-action.component.spec.ts | 24 +++++++++++++++----
 .../main-action/main-action.component.ts      |  2 --
 src/app/testing/app-extension-service-mock.ts |  4 ++--
 src/app/testing/content-action-ref.ts         |  8 +++----
 6 files changed, 29 insertions(+), 13 deletions(-)

diff --git a/src/app/components/create-menu/create-menu.component.spec.ts b/src/app/components/create-menu/create-menu.component.spec.ts
index 8e45d4980..52e83fc92 100644
--- a/src/app/components/create-menu/create-menu.component.spec.ts
+++ b/src/app/components/create-menu/create-menu.component.spec.ts
@@ -59,7 +59,7 @@ describe('CreateMenuComponent', () => {
       ])
     );
 
-    spyOn(extensionService, 'getMainAction').and.returnValue(getContentActionRef());
+    spyOn(extensionService, 'getMainAction').and.returnValue(of(getContentActionRef()));
 
     fixture = TestBed.createComponent(CreateMenuComponent);
   });
diff --git a/src/app/components/main-action/main-action.component.html b/src/app/components/main-action/main-action.component.html
index ab221f3e6..7cb9a4793 100644
--- a/src/app/components/main-action/main-action.component.html
+++ b/src/app/components/main-action/main-action.component.html
@@ -3,6 +3,8 @@
         <button
             *ngSwitchCase="actionTypes.button"
             mat-stroked-button
+            [id]="action.id"
+            [disabled]="action.disabled"
             (click)="runAction(action.actions.click)"
             class="app-main-action-button"
         >
diff --git a/src/app/components/main-action/main-action.component.spec.ts b/src/app/components/main-action/main-action.component.spec.ts
index 857eca9a0..ecf2c9894 100644
--- a/src/app/components/main-action/main-action.component.spec.ts
+++ b/src/app/components/main-action/main-action.component.spec.ts
@@ -28,14 +28,14 @@ import { MainActionComponent } from './main-action.component';
 import { TranslationService, TranslationMock } from '@alfresco/adf-core';
 import { AppExtensionService } from '@alfresco/aca-shared';
 import { of } from 'rxjs';
-import { ACTION_CLICK, ACTION_TITLE } from '../../testing/content-action-ref';
+import { ACTION_CLICK, ACTION_TITLE, getContentActionRef } from '../../testing/content-action-ref';
 import { AppExtensionServiceMock } from '../../testing/app-extension-service-mock';
 import { CommonModule } from '@angular/common';
 import { MatButtonModule } from '@angular/material/button';
 import { TranslateModule } from '@ngx-translate/core';
 
 describe('MainActionComponent', () => {
-  let startProcessButtonComponent: MainActionComponent;
+  let mainActionComponent: MainActionComponent;
   let fixture: ComponentFixture<MainActionComponent>;
   let appExtensionService: AppExtensionServiceMock;
 
@@ -51,7 +51,7 @@ describe('MainActionComponent', () => {
     appExtensionService = TestBed.inject(AppExtensionService);
 
     fixture = TestBed.createComponent(MainActionComponent);
-    startProcessButtonComponent = fixture.componentInstance;
+    mainActionComponent = fixture.componentInstance;
 
     fixture.detectChanges();
   });
@@ -64,7 +64,7 @@ describe('MainActionComponent', () => {
 
   it('should not display button if main action is not configured', () => {
     spyOn(appExtensionService, 'getMainAction').and.returnValue(of(undefined));
-    startProcessButtonComponent.ngOnInit();
+    mainActionComponent.ngOnInit();
     fixture.detectChanges();
 
     const button = fixture.debugElement.nativeElement.querySelector('.app-main-action-button');
@@ -79,4 +79,20 @@ describe('MainActionComponent', () => {
 
     expect(runExtensionActionSpy).toHaveBeenCalledWith(ACTION_CLICK);
   });
+
+  it('should not call button if main action is disabled', () => {
+    const disabledMainActionRef = getContentActionRef();
+    disabledMainActionRef.disabled = true;
+
+    spyOn(appExtensionService, 'getMainAction').and.returnValue(of(disabledMainActionRef));
+    const runAction = spyOn(mainActionComponent, 'runAction');
+
+    mainActionComponent.ngOnInit();
+    fixture.detectChanges();
+
+    const button = fixture.debugElement.nativeElement.querySelector(`#${disabledMainActionRef.id}`);
+    button.click();
+
+    expect(runAction).not.toHaveBeenCalled();
+  });
 });
diff --git a/src/app/components/main-action/main-action.component.ts b/src/app/components/main-action/main-action.component.ts
index 412b676f6..08972f3f8 100644
--- a/src/app/components/main-action/main-action.component.ts
+++ b/src/app/components/main-action/main-action.component.ts
@@ -29,8 +29,6 @@ import { Component, OnDestroy, OnInit } from '@angular/core';
 import { Observable, Subject } from 'rxjs';
 import { takeUntil } from 'rxjs/operators';
 
-export const START_PROCESS_ACTION_ID = 'alfresco.app.start.process';
-
 @Component({
   selector: 'app-main-action',
   templateUrl: './main-action.component.html',
diff --git a/src/app/testing/app-extension-service-mock.ts b/src/app/testing/app-extension-service-mock.ts
index eefa1b4e3..5fad39538 100644
--- a/src/app/testing/app-extension-service-mock.ts
+++ b/src/app/testing/app-extension-service-mock.ts
@@ -24,11 +24,11 @@
  */
 
 import { ContentActionRef } from '@alfresco/adf-extensions';
-import { Observable } from 'rxjs';
+import { Observable, of } from 'rxjs';
 import { getContentActionRef } from './content-action-ref';
 export class AppExtensionServiceMock {
   getMainAction(): Observable<ContentActionRef> {
-    return getContentActionRef();
+    return of(getContentActionRef());
   }
 
   runActionById(_id: string) {}
diff --git a/src/app/testing/content-action-ref.ts b/src/app/testing/content-action-ref.ts
index 527ef89a6..d10589a56 100644
--- a/src/app/testing/content-action-ref.ts
+++ b/src/app/testing/content-action-ref.ts
@@ -24,18 +24,18 @@
  */
 
 import { ContentActionRef, ContentActionType } from '@alfresco/adf-extensions';
-import { Observable, of } from 'rxjs';
 
 export const ACTION_TITLE = 'ACTION_TITLE';
 export const ACTION_CLICK = 'ACTION_CLICK';
 
-export const getContentActionRef = (): Observable<ContentActionRef> => {
-  return of({
+export const getContentActionRef = (): ContentActionRef => {
+  return {
     id: 'id',
     type: ContentActionType.button,
     title: ACTION_TITLE,
+    disabled: false,
     actions: {
       click: ACTION_CLICK
     }
-  });
+  };
 };