[ACA-1259] automate remaining tests for sidebar (#977)

* automate remaining tests for sidebar

* formatting

e2e/components/header/header.ts

@@ -23,23 +23,29 @@
  * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
  */
 
-import { ElementFinder, by, browser } from 'protractor';
+import { ElementFinder, by, browser, until } from 'protractor';
 import { Component } from '../component';
 import { UserInfo } from './user-info';
 import { Menu } from '../menu/menu';
 import { Toolbar } from './../toolbar/toolbar';
 import { SearchInput } from '../search/search-input';
+import { BROWSER_WAIT_TIMEOUT } from '../../configs';
 
 export class Header extends Component {
   private static selectors = {
     root: 'app-header',
     logoLink: by.css('.app-menu__title'),
     userInfo: by.css('aca-current-user'),
-    moreActions: by.id('app.header.more')
+    moreActions: by.id('app.header.more'),
+
+    sidenavToggle: `[id='adf-sidebar-toggle-start']`,
+    expandedSidenav: by.css(`[data-automation-id='expanded']`),
+    collapsedSidenav: by.css(`[data-automation-id='collapsed']`)
   };
 
   logoLink: ElementFinder = this.component.element(Header.selectors.logoLink);
   moreActions: ElementFinder = browser.element(Header.selectors.moreActions);
+  sidenavToggle: ElementFinder = this.component.element(by.css(Header.selectors.sidenavToggle));
 
   userInfo: UserInfo = new UserInfo(this.component);
   menu: Menu = new Menu();
@@ -58,5 +64,30 @@ export class Header extends Component {
   async isSignOutDisplayed() {
     return await this.userInfo.menu.isMenuItemPresent('Sign out');
   }
+
+  async clickSidenavToggle() {
+    await this.sidenavToggle.click();
+  }
+
+  async isExpandedSidenav() {
+    return await browser.isElementPresent(Header.selectors.expandedSidenav);
+  }
+
+  async expandSideNav() {
+    const expanded = await this.isExpandedSidenav();
+    if ( !expanded ) {
+      await this.clickSidenavToggle();
+      await browser.wait(until.elementLocated(Header.selectors.expandedSidenav), BROWSER_WAIT_TIMEOUT, '--- timeout waiting for expanded sidenav' );
+    }
+  }
+
+  async collapseSideNav() {
+    const expanded = await this.isExpandedSidenav();
+    if ( expanded ) {
+      await this.clickSidenavToggle();
+      await browser.wait(until.elementLocated(Header.selectors.collapsedSidenav), BROWSER_WAIT_TIMEOUT, '--- timeout waiting for collapsed sidenav')
+    }
+  }
+
 }
 

e2e/components/sidenav/sidenav.ts

@@ -23,8 +23,8 @@
  * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
  */
 
-import { ElementFinder, ElementArrayFinder, by, element } from 'protractor';
-import { SIDEBAR_LABELS } from '../../configs';
+import { ElementFinder, ElementArrayFinder, by, element, browser } from 'protractor';
+import { SIDEBAR_LABELS, BROWSER_WAIT_TIMEOUT } from '../../configs';
 import { Menu } from '../menu/menu';
 import { Component } from '../component';
 import { Utils } from '../../utilities/utils';
@@ -37,28 +37,29 @@ export class Sidenav extends Component {
     expansion_panel: ".mat-expansion-panel-header",
     expansion_panel_content: ".mat-expansion-panel-body",
     active: 'mat-accent',
-    activeLink: '.mat-accent',
+    activeClass: '.item--active',
     activeChild: 'item--active',
+
     newButton: '[data-automation-id="create-button"]',
 
-    personalFiles: `[id='app.navbar.personalFiles']`,
-    fileLibraries: `[id='app.navbar.libraries.menu']`,
-    myLibraries: `[id='app.navbar.libraries.files']`,
-    favoriteLibraries: `[id='app.navbar.libraries.favorite']`,
-    shared: `[id='app.navbar.shared']`,
-    recentFiles: `[id='app.navbar.recentFiles']`,
-    favorites: `[id='app.navbar.favorites']`,
-    trash: `[id='app.navbar.trashcan']`
+    personalFiles: `[data-automation-id='app.navbar.personalFiles']`,
+    fileLibraries: `[data-automation-id='app.navbar.libraries.menu']`,
+    myLibraries: `[data-automation-id='app.navbar.libraries.files']`,
+    favoriteLibraries: `[data-automation-id='app.navbar.libraries.favorite']`,
+    shared: `[data-automation-id='app.navbar.shared']`,
+    recentFiles: `[data-automation-id='app.navbar.recentFiles']`,
+    favorites: `[data-automation-id='app.navbar.favorites']`,
+    trash: `[data-automation-id='app.navbar.trashcan']`
   };
 
   links: ElementArrayFinder = this.component.all(by.css(Sidenav.selectors.link));
-  activeLink: ElementFinder = this.component.element(by.css(Sidenav.selectors.activeLink));
+  activeLink: ElementFinder = this.component.element(by.css(Sidenav.selectors.activeClass));
   newButton: ElementArrayFinder = this.component.all(by.css(Sidenav.selectors.newButton));
 
   personalFiles: ElementFinder = this.component.element(by.css(Sidenav.selectors.personalFiles));
   fileLibraries: ElementFinder = this.component.element(by.css(Sidenav.selectors.fileLibraries));
-  myLibraries: ElementFinder = this.component.element(by.css(Sidenav.selectors.myLibraries));
-  favoriteLibraries: ElementFinder = this.component.element(by.css(Sidenav.selectors.favoriteLibraries));
+  myLibraries: ElementFinder = browser.element(by.css(Sidenav.selectors.myLibraries));
+  favoriteLibraries: ElementFinder = browser.element(by.css(Sidenav.selectors.favoriteLibraries));
   shared: ElementFinder = this.component.element(by.css(Sidenav.selectors.shared));
   recentFiles: ElementFinder = this.component.element(by.css(Sidenav.selectors.recentFiles));
   favorites: ElementFinder = this.component.element(by.css(Sidenav.selectors.favorites));
@@ -105,8 +106,7 @@ export class Sidenav extends Component {
   }
 
   async isActive(name: string) {
-    const className = await this.getLinkLabel(name).getAttribute('class');
-    return className.includes(Sidenav.selectors.active);
+    return await this.getLinkLabel(name).isElementPresent(by.css(Sidenav.selectors.activeClass));
   }
 
   async childIsActive(name: string) {
@@ -137,7 +137,15 @@ export class Sidenav extends Component {
   }
 
   async getLinkTooltip(name: string) {
-    return await this.getLink(name).getAttribute('title');
+    const link = this.getLinkLabel(name);
+
+    const condition = () => link.getAttribute('title').then(value => value && value.length > 0);
+
+    await browser.actions().mouseMove(link).perform();
+
+    await browser.wait(condition, BROWSER_WAIT_TIMEOUT);
+
+    return await link.getAttribute('title');
   }
 
   async clickLink(name: string) {