diff --git a/projects/aca-content/src/lib/components/details/details.component.scss b/projects/aca-content/src/lib/components/details/details.component.scss index de481d464..4e76575e8 100644 --- a/projects/aca-content/src/lib/components/details/details.component.scss +++ b/projects/aca-content/src/lib/components/details/details.component.scss @@ -4,7 +4,7 @@ app-details-manager { .aca-close-details-button { margin-right: 15px; - margin-top: 2px; + margin-top: 12px; outline: none; border-radius: 4px; diff --git a/projects/aca-shared/rules/src/navigation.rules.spec.ts b/projects/aca-shared/rules/src/navigation.rules.spec.ts index 44f43e8e7..9582223e4 100644 --- a/projects/aca-shared/rules/src/navigation.rules.spec.ts +++ b/projects/aca-shared/rules/src/navigation.rules.spec.ts @@ -226,26 +226,6 @@ describe('navigation.evaluators', () => { }); describe('isDetails', () => { - it('should return true if url ends with `/details`', () => { - const context: any = { - navigation: { - url: '/path/details' - } - }; - - expect(app.isDetails(context)).toBe(true); - }); - - it('should return true if url starts with `/details`', () => { - const context: any = { - navigation: { - url: '/details/path' - } - }; - - expect(app.isDetails(context)).toBe(true); - }); - it('should return true if url includes with `/details`', () => { const context: any = { navigation: { @@ -255,6 +235,16 @@ describe('navigation.evaluators', () => { expect(app.isDetails(context)).toBe(true); }); + + it('should return false if url not includes with `/details`', () => { + const context: any = { + navigation: { + url: '/path' + } + }; + + expect(app.isDetails(context)).toBe(false); + }); }); describe('isRecentFiles', () => { diff --git a/projects/aca-shared/rules/src/navigation.rules.ts b/projects/aca-shared/rules/src/navigation.rules.ts index 5a3c5569c..a26d8a236 100644 --- a/projects/aca-shared/rules/src/navigation.rules.ts +++ b/projects/aca-shared/rules/src/navigation.rules.ts @@ -112,7 +112,7 @@ export function isLibraryContent(context: RuleContext): boolean { export function isDetails(context: RuleContext): boolean { const { url } = context.navigation; - return url && (url.endsWith('/details') || url.includes('/details/') || url.startsWith('/details')); + return url?.includes('/details'); } /**