inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2026-09-09 18:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-11051] getChild usage refactored (#5056)

Browse Source 
* [ACS-11051] getChild usage refactored

* [ACS-11051] sonar fix 1

* [ACS-11051] test fixes 1

* [ACS-11051] test fixes 2

* [ACS-11051] review fixes 1

* [ACS-11051] review fixes 2
This commit is contained in:
Adam Świderski
2026-02-20 15:06:37 +01:00
committed by GitHub
parent 6c1f3b3188
commit 1218c0fb64
30 changed files with 198 additions and 111 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/playwright/search/src/tests/search-filters-categories.e2e.ts
+1 -1
View File
@@ -76,7 +76,7 @@ test.describe('Search - Filters - Categories', () => {
await searchPage.searchFilters.categoriesFilter.click();
await searchPage.searchFiltersCategories.addOptionInput.fill(newSubcategories[0].name);
await searchPage.searchFilters.dropdownOptions.first().click();
await searchPage.searchFilters.menuCardApply.click();
await searchPage.searchMenuCard.menuCardApply.click();
await expect(searchPage.dataTable.getRowByName(fileNamePdf)).toBeHidden();
await expect(searchPage.dataTable.getRowByName(fileNameJpg)).toBeVisible();
e2e/playwright/search/src/tests/search-filters-general.e2e.ts
+8 -8
View File
@@ -46,10 +46,10 @@ test.describe('Search - Filters - General', () => {
test('[XAT-5575] Search Filters Menu cards have proper titles', async ({ searchPage }) => {
async function checkMenuCardTitle(page: SearchPage, filterLocator: Locator, expectText: string): Promise<void> {
await filterLocator.click();
await expect(page.searchFilters.menuCardTitle).toContainText(expectText);
await page.searchFilters.menuCardClose.click();
await page.searchFilters.menuCardClose.waitFor({ state: 'hidden' });
await expect(page.searchFilters.menuCardClose).toBeHidden();
await expect(page.searchMenuCard.menuCardTitle).toContainText(expectText);
await page.searchMenuCard.menuCardClose.click();
await page.searchMenuCard.menuCardClose.waitFor({ state: 'hidden' });
await expect(page.searchMenuCard.menuCardClose).toBeHidden();
}
const testCases = [
@@ -88,12 +88,12 @@ test.describe('Search - Filters - General', () => {
const filterTextBefore = await searchPage.searchFilters.propertiesFilter.textContent();
await searchPage.searchFilters.propertiesFilter.click();
await searchPage.searchFiltersProperties.fileSizeInput.fill('1000');
await searchPage.searchFilters.menuCardApply.click();
await searchPage.searchMenuCard.menuCardApply.click();
await searchPage.dataTable.progressBarWaitForReload();
const filterTextAfter = await searchPage.searchFilters.propertiesFilter.textContent();
await searchPage.searchFilters.propertiesFilter.click();
await searchPage.searchFilters.menuCardClear.click();
await searchPage.searchMenuCard.menuCardClear.click();
await searchPage.searchFiltersProperties.fileSizeInput.waitFor({ state: 'hidden' });
const filterTextCleared = await searchPage.searchFilters.propertiesFilter.textContent();
@@ -105,14 +105,14 @@ test.describe('Search - Filters - General', () => {
const propertiesFilterTextBefore = await searchPage.searchFilters.propertiesFilter.textContent();
await searchPage.searchFilters.propertiesFilter.click();
await searchPage.searchFiltersProperties.fileSizeInput.fill('1000');
await searchPage.searchFilters.menuCardApply.click();
await searchPage.searchMenuCard.menuCardApply.click();
await searchPage.dataTable.progressBarWaitForReload();
const propertiesFilterTextAfter = await searchPage.searchFilters.propertiesFilter.textContent();
const logicFilterTextBefore = await searchPage.searchFilters.logicFilter.textContent();
await searchPage.searchFilters.logicFilter.click();
await searchPage.searchFiltersLogic.matchAllInput.fill('test');
await searchPage.searchFilters.menuCardApply.click();
await searchPage.searchMenuCard.menuCardApply.click();
await searchPage.dataTable.progressBarWaitForReload();
const logicFilterTextAfter = await searchPage.searchFilters.logicFilter.textContent();
e2e/playwright/search/src/tests/search-filters-logic.e2e.ts
+7 -7
View File
@@ -80,7 +80,7 @@ test.describe('Search - Filters - Logic', () => {
await searchPage.searchFiltersLogic.matchAllInput.fill(
`${logicFile1NameSplit[0]} ${logicFile1NameSplit[1]} ${logicFile1TitleSplit[1]} ${logicFile1DescriptionSplit[1]}`
);
await searchPage.searchFilters.menuCardApply.click();
await searchPage.searchMenuCard.menuCardApply.click();
await searchPage.dataTable.progressBarWaitForReload();
await expect(searchPage.dataTable.getRowByName(logicFile1.name)).toBeVisible();
@@ -92,7 +92,7 @@ test.describe('Search - Filters - Logic', () => {
await searchPage.searchFiltersLogic.matchAnyInput.fill(
`${logicFile1NameSplit[2]}-${logicFile1NameSplit[3]} ${logicFile1TitleSplit[0]} ${logicFile1DescriptionSplit[0]}`
);
await searchPage.searchFilters.menuCardApply.click();
await searchPage.searchMenuCard.menuCardApply.click();
await searchPage.dataTable.progressBarWaitForReload();
expect(await searchPage.dataTable.getRowsCount()).toBe(2);
@@ -106,7 +106,7 @@ test.describe('Search - Filters - Logic', () => {
`${logicFile1NameSplit[0]}-${logicFile1NameSplit[1]} ${logicFile1TitleSplit[0]} ${logicFile1DescriptionSplit[0]}`
);
await searchPage.searchFiltersLogic.excludeInput.fill(`${logicFile1DescriptionSplit[1]}`);
await searchPage.searchFilters.menuCardApply.click();
await searchPage.searchMenuCard.menuCardApply.click();
await searchPage.dataTable.progressBarWaitForReload();
expect(await searchPage.dataTable.getRowsCount()).toBe(1);
@@ -117,7 +117,7 @@ test.describe('Search - Filters - Logic', () => {
test('[XAT-5587] should able to filter search result with logic filter with Exact Phrase', async ({ searchPage }) => {
await searchPage.searchFilters.logicFilter.click();
await searchPage.searchFiltersLogic.matchExactInput.fill(logicFile1.name);
await searchPage.searchFilters.menuCardApply.click();
await searchPage.searchMenuCard.menuCardApply.click();
await searchPage.dataTable.progressBarWaitForReload();
expect(await searchPage.dataTable.getRowsCount()).toBe(1);
@@ -126,7 +126,7 @@ test.describe('Search - Filters - Logic', () => {
await searchPage.searchFilters.logicFilter.click();
await searchPage.searchFiltersLogic.matchExactInput.fill(logicFile1.title);
await searchPage.searchFilters.menuCardApply.click();
await searchPage.searchMenuCard.menuCardApply.click();
await searchPage.dataTable.progressBarWaitForReload();
expect(await searchPage.dataTable.getRowsCount()).toBe(1);
@@ -135,7 +135,7 @@ test.describe('Search - Filters - Logic', () => {
await searchPage.searchFilters.logicFilter.click();
await searchPage.searchFiltersLogic.matchExactInput.fill(logicFile1.description);
await searchPage.searchFilters.menuCardApply.click();
await searchPage.searchMenuCard.menuCardApply.click();
await searchPage.dataTable.progressBarWaitForReload();
expect(await searchPage.dataTable.getRowsCount()).toBe(1);
@@ -151,7 +151,7 @@ test.describe('Search - Filters - Logic', () => {
await searchPage.searchFiltersLogic.matchAnyInput.fill(`${logicFile1NameSplit[0]} ${logicFile1TitleSplit[2]}`);
await searchPage.searchFiltersLogic.excludeInput.fill(`${logicFile1NameSplit[3]}`);
await searchPage.searchFiltersLogic.matchExactInput.fill(`${logicFile2NameSplit[1]}-${logicFile2NameSplit[2]}-${logicFile2NameSplit[3]}`);
await searchPage.searchFilters.menuCardApply.click();
await searchPage.searchMenuCard.menuCardApply.click();
await searchPage.dataTable.progressBarWaitForReload();
expect(await searchPage.dataTable.getRowsCount()).toBe(1);