From 160d9763a6b21183cd7cacadb20ab46adaeafe6e Mon Sep 17 00:00:00 2001 From: Denys Vuika Date: Thu, 11 Oct 2018 17:24:11 +0100 Subject: [PATCH] reduce external dependencies (#705) --- angular.json | 12 +----------- package-lock.json | 12 ++++-------- package.json | 4 +--- src/app/extensions.module.ts | 11 +---------- 4 files changed, 7 insertions(+), 32 deletions(-) diff --git a/angular.json b/angular.json index a4c84fbd6..bde639d7d 100644 --- a/angular.json +++ b/angular.json @@ -47,17 +47,7 @@ "output": "/" }, { - "glob": "**/*", - "input": "node_modules/monaco-editor/min", - "output": "./assets/monaco" - }, - { - "glob": "**/*.js", - "input": "node_modules/@ngstack/code-editor/workers", - "output": "./assets/workers" - }, - { - "glob": "dev.tools.json", + "glob": "**/*.json", "input": "node_modules/@denysvuika/aca-dev-tools/assets", "output": "./assets/plugins" }, diff --git a/package-lock.json b/package-lock.json index 0f81bd230..2b073ac63 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1622,10 +1622,11 @@ } }, "@denysvuika/aca-dev-tools": { - "version": "0.1.3", - "resolved": "https://registry.npmjs.org/@denysvuika/aca-dev-tools/-/aca-dev-tools-0.1.3.tgz", - "integrity": "sha512-t8c1eNk/YJeKnpZizmYtGjXhNpIorcOha1oYMmiRsJbxjkaOBVWJSH3sEY+E5BnjH6ZLE7bdtXSLMzrsmU0pRQ==", + "version": "0.1.5", + "resolved": "https://registry.npmjs.org/@denysvuika/aca-dev-tools/-/aca-dev-tools-0.1.5.tgz", + "integrity": "sha512-O+r6L+yZX1TB8ORaGpjowlcWq/1u/HeSpalQtfBJyuyUzWo0NdWNQtWfs2wQ5e8Bvwyu+u8qAIxYJgmIzqWL1w==", "requires": { + "@ngstack/code-editor": "^0.4.3", "showdown": "^1.8.6", "tslib": "^1.9.0" } @@ -9991,11 +9992,6 @@ "moment": "*" } }, - "monaco-editor": { - "version": "0.14.2", - "resolved": "https://registry.npmjs.org/monaco-editor/-/monaco-editor-0.14.2.tgz", - "integrity": "sha512-SgWGZtoUcb+34gK/aEoqRpJ8/zKp19j1zqP2rZlT75pGHQoM3EIGZH7Qrlp6n5RWDySGVNdxlvsoecs5SghJ3A==" - }, "move-concurrently": { "version": "1.0.1", "resolved": "https://registry.npmjs.org/move-concurrently/-/move-concurrently-1.0.1.tgz", diff --git a/package.json b/package.json index 8a4dc9a87..8537d4a46 100644 --- a/package.json +++ b/package.json @@ -45,14 +45,13 @@ "@angular/platform-browser": "6.1.8", "@angular/platform-browser-dynamic": "6.1.8", "@angular/router": "6.1.8", - "@denysvuika/aca-dev-tools": "^0.1.3", + "@denysvuika/aca-dev-tools": "^0.1.5", "@mat-datetimepicker/core": "^2.0.1", "@mat-datetimepicker/moment": "^2.0.1", "@ngrx/effects": "^6.1.0", "@ngrx/router-store": "^6.1.0", "@ngrx/store": "^6.1.0", "@ngrx/store-devtools": "^6.1.0", - "@ngstack/code-editor": "^0.4.3", "@ngx-translate/core": "^10.0.2", "alfresco-js-api": "2.6.0", "chrome-remote-interface": "^0.26.1", @@ -61,7 +60,6 @@ "minimatch-browser": "^1.0.0", "moment": "^2.22.2", "moment-es6": "1.0.0", - "monaco-editor": "^0.14.2", "pdfjs-dist": "^2.0.489", "rxjs": "^6.3.2", "zone.js": "0.8.26" diff --git a/src/app/extensions.module.ts b/src/app/extensions.module.ts index 675b1aa9e..7480846a5 100644 --- a/src/app/extensions.module.ts +++ b/src/app/extensions.module.ts @@ -1,19 +1,10 @@ import { NgModule } from '@angular/core'; import { AcaDevToolsModule } from '@denysvuika/aca-dev-tools'; -import { CodeEditorModule } from '@ngstack/code-editor'; // Main entry point for external extensions only. // For any application-specific code use CoreExtensionsModule instead. @NgModule({ - imports: [ - CodeEditorModule.forRoot({ - // use local Monaco installation - baseUrl: 'assets/monaco', - // use local Typings Worker - typingsWorkerUrl: 'assets/workers/typings-worker.js' - }), - AcaDevToolsModule - ] + imports: [AcaDevToolsModule] }) export class AppExtensionsModule {}