inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2026-09-09 18:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-10956] Update eslint configuration for all automated tests related files (#4991)

Browse Source 
* [ACS-10956] ACS-10956 updates eslint for more files

* [ACS-10956] eslint update

* Revert package-lock.json changes

* Revert package-lock.json to develop version

* testing eslint changes 1

* [ACS-10956] updated eslint for e2e folder

* [ACS-10956] added eslint for aca-playwright-shared file

* Sync package-lock.json with develop

* [ACS-10956] eslint e2e now uses playwright and angular plugin.

* [ACS-10956] changed error to warn for no-angular-material-selectors

* [ACS-10956] two rules turned off for aca-playwright-shared

* [ACS-10956] reverted changes for spec files

* [ACS-10956] changed back to error

* [ACS-10956] first eslint fixes

* [ACS-10956] more eslint fixes

* [ACS-10956] more eslint fixes pt 23

* [ACS-10956] last lintfix fixes

* [ACS-10956] sonar fixes 1

* [ACS-10956] reverted package-lock.json

* [ACS-10956] test fixes after the eslint changes 1

* [ACS-10956] sonar fix2

* [ACS-10956] test fixes after eslint update 24
This commit is contained in:
Adam Świderski
2026-01-30 15:23:48 +01:00
committed by GitHub
parent bf367628ae
commit 19270e256c
61 changed files with 188 additions and 281 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/playwright/authentication/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/authentication/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/copy-move-actions/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/copy-move-actions/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/create-actions/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/create-actions/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/delete-actions/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/delete-actions/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/edit-actions/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/edit-actions/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/favorite-actions/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/favorite-actions/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/folder-information-actions/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/folder-information-actions/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/folder-rules/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/folder-rules/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/folder-rules/src/tests/create-rules.e2e.ts
+1
View File
@@ -26,6 +26,7 @@ import { expect } from '@playwright/test';
import { ActionType, ApiClientFactory, test, Utils, TrashcanApi, NodesApi, Comparator, Field } from '@alfresco/aca-playwright-shared';
test.use({ launchOptions: { slowMo: 300 } });
test.describe('Folder Rules Actions', () => {
const apiClientFactory = new ApiClientFactory();
let nodesApi: NodesApi;
e2e/playwright/folder-rules/src/tests/delete-view-rules.e2e.ts
+1
View File
@@ -26,6 +26,7 @@ import { ApiClientFactory, test, Utils, NodesApi, TrashcanApi, RulesApi } from '
import { expect } from '@playwright/test';
test.use({ launchOptions: { slowMo: 300 } });
test.describe('Rules - Manage Rules', () => {
const apiClientFactory = new ApiClientFactory();
let nodesApi: NodesApi;
e2e/playwright/folder-rules/src/tests/transform-rules.e2e.ts
+1
View File
@@ -106,6 +106,7 @@ async function verifyTransformation(
}
test.use({ launchOptions: { slowMo: 300 } });
test.describe('Folder Rules Actions', () => {
const apiClientFactory = new ApiClientFactory();
let nodesApi: NodesApi;
e2e/playwright/folder-rules/src/tests/update-rules.e2e.ts
+1
View File
@@ -26,6 +26,7 @@ import { ApiClientFactory, test, Utils, NodesApi, TrashcanApi, ActionType, Rules
import { expect } from '@playwright/test';
test.use({ launchOptions: { slowMo: 300 } });
test.describe('Rules - Manage Rules', () => {
const apiClientFactory = new ApiClientFactory();
let nodesApi: NodesApi;
e2e/playwright/info-drawer/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/info-drawer/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/info-drawer/src/tests/library-properties.e2e.ts
+4 -4
View File
@@ -195,8 +195,8 @@ test.describe('Library properties', () => {
await myLibrariesPage.libraryDetails.editButton.click();
await myLibrariesPage.libraryDetails.nameField.fill(Utils.string257Long);
await expect(myLibrariesPage.libraryDetails.errorMessage).toBeVisible();
expect((await myLibrariesPage.libraryDetails.errorMessage.textContent()).trim()).toEqual('Use 256 characters or less for title');
await expect(myLibrariesPage.libraryDetails.errorNameMessage).toBeVisible();
expect((await myLibrariesPage.libraryDetails.errorNameMessage.textContent()).trim()).toEqual('Use 256 characters or less for title');
await expect(myLibrariesPage.libraryDetails.updateButton).toBeDisabled();
});
@@ -210,8 +210,8 @@ test.describe('Library properties', () => {
await myLibrariesPage.libraryDetails.editButton.click();
await myLibrariesPage.libraryDetails.descriptionField.fill(Utils.string513Long);
await expect(myLibrariesPage.libraryDetails.errorMessage).toBeVisible();
expect((await myLibrariesPage.libraryDetails.errorMessage.textContent()).trim()).toEqual('Use 512 characters or less for description');
await expect(myLibrariesPage.libraryDetails.errorDescriptionMessage).toBeVisible();
expect((await myLibrariesPage.libraryDetails.errorDescriptionMessage.textContent()).trim()).toEqual('Use 512 characters or less for description');
await expect(myLibrariesPage.libraryDetails.updateButton).toBeDisabled();
});
});
e2e/playwright/library-actions/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/library-actions/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/list-views/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/list-views/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/list-views/src/tests/permissions.e2e.ts
+1
View File
@@ -40,6 +40,7 @@ import { Site } from '@alfresco/js-api';
test.describe('Special permissions', () => {
const username = `userPermissions-${Utils.random()}`;
let siteApiAdmin: SitesApi;
test.beforeAll(async () => {
const apiClientFactory = new ApiClientFactory();
await apiClientFactory.setUpAcaBackend('admin');
e2e/playwright/list-views/src/tests/sort-list.e2e.ts
+1
View File
@@ -240,6 +240,7 @@ test.describe('Remember sorting', () => {
test.describe('User Tests', () => {
test.describe.configure({ mode: 'serial' });
test('[XAT-4520] Size sort order is retained when user logs out and logs back in', async ({ personalFiles, loginPage }) => {
await personalFiles.dataTable.sortBy('Name', 'desc');
await personalFiles.dataTable.spinnerWaitForReload();
e2e/playwright/navigation/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/navigation/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/pagination/.eslintrc.json
+2 -3
View File
@@ -4,11 +4,10 @@
"overrides": [
{
"files": ["*.ts"],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": ["e2e/playwright/pagination/tsconfig.e2e.json"],
"createDefaultProgram": true
"project": ["e2e/playwright/pagination/tsconfig.e2e.json"]
},
"plugins": ["rxjs", "unicorn"],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/pagination/src/tests/multiple-pages-files.e2e.ts
+1
View File
@@ -68,6 +68,7 @@ test.describe('Pagination on multiple pages : ', () => {
test.beforeAll(async () => {
await favoritesApi.waitForApi(username, { expect: initialFavoritesTotalItems + 51 });
});
favoritesTests(username);
});
});
e2e/playwright/search/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/search/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/search/src/tests/search-filters-date.e2e.ts
+1
View File
@@ -26,6 +26,7 @@ import { expect } from '@playwright/test';
import { ApiClientFactory, Utils, test, NodesApi, TrashcanApi, FileActionsApi, TEST_FILES } from '@alfresco/aca-playwright-shared';
test.use({ launchOptions: { slowMo: 500 } });
test.describe('Search - Filters - Date', () => {
let nodesApi: NodesApi;
let trashcanApi: TrashcanApi;
e2e/playwright/search/src/tests/search-highlighting.e2e.ts
+1
View File
@@ -26,6 +26,7 @@ import { expect } from '@playwright/test';
import { ApiClientFactory, Utils, test, NodesApi, TrashcanApi, TEST_FILES, FileActionsApi } from '@alfresco/aca-playwright-shared';
test.use({ launchOptions: { slowMo: 500 } });
test.describe('Search Highlighting', () => {
let nodesApi: NodesApi;
let trashcanApi: TrashcanApi;
e2e/playwright/search/src/tests/search-sorting.e2e.ts
+1
View File
@@ -37,6 +37,7 @@ import {
} from '@alfresco/aca-playwright-shared';
test.use({ launchOptions: { slowMo: 500 } });
test.describe('Search sorting', () => {
const random = Utils.random();
e2e/playwright/share-action/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/share-action/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/share-action/src/tests/share/share-file.e2e.ts
+4
View File
@@ -182,6 +182,10 @@ test.describe('Share a file', () => {
await personalFiles.shareDialog.expireToggle.click();
expect(await personalFiles.shareDialog.isExpireToggleEnabled()).toBe(true);
await personalFiles.shareDialog.expireInput.click();
await personalFiles.shareDialog.clockIcon.click();
await expect(personalFiles.shareDialog.dateErrorText).toContainText('Invalid date');
await personalFiles.shareDialog.datetimePickerButton.click();
expect(await personalFiles.shareDialog.dateTimePicker.isCalendarOpen()).toBe(true);
e2e/playwright/smoke-test/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/smoke-test/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/special-permissions-actions-available/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/special-permissions-actions-available/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/special-permissions-actions-available/src/tests/folders-actions.e2e.ts
+4 -21
View File
@@ -32,18 +32,6 @@ test.describe('Folders - available actions : ', () => {
let trashcanApi: TrashcanApi;
async function checkActionsAvailable(
myPersonalFiles: PersonalFilesPage,
item: string,
expectedToolbarPrimary: string[],
expectedToolbarMore: string[]
): Promise<void> {
await myPersonalFiles.dataTable.selectItems(item);
await myPersonalFiles.acaHeader.verifyToolbarPrimaryActions(expectedToolbarPrimary);
await myPersonalFiles.acaHeader.clickMoreActions();
await myPersonalFiles.matMenu.verifyActualMoreActions(expectedToolbarMore);
}
async function checkMultipleSelActionsAvailable(
myPersonalFiles: PersonalFilesPage,
expectedToolbarPrimary: string[],
expectedToolbarMore: string[]
@@ -84,18 +72,13 @@ test.describe('Folders - available actions : ', () => {
test('[XAT-4637] Actions for a folder, not favorite', async ({ personalFiles }) => {
await personalFiles.dataTable.getRowByName(testData.folderFile.name).click({ button: 'right' });
await personalFiles.matMenu.verifyActualMoreActions(testData.folderFile.contextMenu);
await checkActionsAvailable(personalFiles, testData.folderFile.name, testData.folderFile.toolbarPrimary, testData.folderFile.toolbarMore);
await checkActionsAvailable(personalFiles, testData.folderFile.toolbarPrimary, testData.folderFile.toolbarMore);
});
test('[XAT-4638] Actions for a folder, favorite', async ({ personalFiles }) => {
await personalFiles.dataTable.getRowByName(testData.folderFavFile.name).click({ button: 'right' });
await personalFiles.matMenu.verifyActualMoreActions(testData.folderFavFile.contextMenu);
await checkActionsAvailable(
personalFiles,
testData.folderFavFile.name,
testData.folderFavFile.toolbarPrimary,
testData.folderFavFile.toolbarMore
);
await checkActionsAvailable(personalFiles, testData.folderFavFile.toolbarPrimary, testData.folderFavFile.toolbarMore);
});
test('[XAT-4642] Actions on multiple folders', async ({ personalFiles }) => {
@@ -103,14 +86,14 @@ test.describe('Folders - available actions : ', () => {
await personalFiles.dataTable.getRowByName(testData.folderFavFile.name).click({ button: 'right' });
await personalFiles.page.reload({ waitUntil: 'load' });
await personalFiles.dataTable.selectItems(testData.folderFavFile.name, testData.folderFile.name);
await checkMultipleSelActionsAvailable(personalFiles, testData.multipleSelFile.toolbarPrimary, testData.multipleSelFile.toolbarMore);
await checkActionsAvailable(personalFiles, testData.multipleSelFile.toolbarPrimary, testData.multipleSelFile.toolbarMore);
});
test('[XAT-4643] Actions on multiple selection - files and folders', async ({ personalFiles }) => {
await personalFiles.dataTable.selectItems(testData.file.name, testData.folderFile.name);
await personalFiles.dataTable.getRowByName(testData.folderFile.name).click({ button: 'right' });
await personalFiles.matMenu.verifyActualMoreActions(testData.multipleSelFile.contextMenu);
await checkMultipleSelActionsAvailable(personalFiles, testData.multipleSelFile.toolbarPrimary, testData.multipleSelFile.toolbarMore);
await checkActionsAvailable(personalFiles, testData.multipleSelFile.toolbarPrimary, testData.multipleSelFile.toolbarMore);
});
});
});
e2e/playwright/upload-download-actions/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/upload-download-actions/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/viewer/.eslintrc.json
+2 -6
View File
@@ -8,16 +8,12 @@
"files": [
"*.ts"
],
"extends": ["../../../.eslintrc.e2e.json"],
"parserOptions": {
"project": [
"e2e/playwright/viewer/tsconfig.e2e.json"
],
"createDefaultProgram": true
]
},
"plugins": [
"rxjs",
"unicorn"
],
"rules": {
"@typescript-eslint/no-floating-promises": "off"
}
e2e/playwright/viewer/src/tests/viewer-action.e2e.ts
+1
View File
@@ -26,6 +26,7 @@ import { expect } from '@playwright/test';
import { ApiClientFactory, getUserState, test, TEST_FILES, timeouts, Utils } from '@alfresco/aca-playwright-shared';
test.use({ storageState: getUserState('hruser') });
test.describe('viewer action file', () => {
const apiClientFactory = new ApiClientFactory();
const randomFolderName = `viewer-action-${Utils.random()}`;
e2e/playwright/viewer/src/tests/viewer-file-types.e2e.ts
+1
View File
@@ -36,6 +36,7 @@ import {
} from '@alfresco/aca-playwright-shared';
test.use({ channel: 'chrome' });
test.describe('viewer file types', () => {
const randomString = Utils.random();
const username = `user-${randomString}`;
e2e/playwright/viewer/src/tests/viewer-protected.e2e.ts
+1
View File
@@ -26,6 +26,7 @@ import { expect } from '@playwright/test';
import { ApiClientFactory, getUserState, test, TEST_FILES, Utils } from '@alfresco/aca-playwright-shared';
test.use({ storageState: getUserState('hruser') });
test.describe('viewer file', () => {
const apiClientFactory = new ApiClientFactory();
const randomFolderName = `viewer-protected-${Utils.random()}`;