From 1c81c0c821ceccabb92fff69a00aee29680ea10c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Iulia=20Burc=C4=83?= <iulia.burca@ness.com>
Date: Fri, 5 Mar 2021 09:46:56 +0200
Subject: [PATCH] [ACA-4196] [ACA-4219] [ACA-4283] Delete some tests and
 reinclude some others (#2038)

* [ACA-1496] Delete C306956 because it never worked

* [ACA-4219] Remove C325049 - not worth to automate

* [ACA-4283] Reinclude tests failing on cluster
---
 e2e/protractor.excludes.json                       |  6 ------
 .../create/create-file-from-template.test.ts       | 12 ------------
 e2e/suites/actions/edit/edit-offline.test.ts       | 14 ++------------
 3 files changed, 2 insertions(+), 30 deletions(-)

diff --git a/e2e/protractor.excludes.json b/e2e/protractor.excludes.json
index ec6942bb2..2c63c0851 100644
--- a/e2e/protractor.excludes.json
+++ b/e2e/protractor.excludes.json
@@ -1,8 +1,2 @@
 {
-  "C306956": "https://alfresco.atlassian.net/browse/ACA-4196",
-  "C325049": "https://alfresco.atlassian.net/browse/ACA-4219",
-  "C325161": "https://alfresco.atlassian.net/browse/ACS-1297",
-  "C325023": "https://alfresco.atlassian.net/browse/ACS-1297",
-  "C325026": "https://alfresco.atlassian.net/browse/ACS-1297",
-  "C286326": "https://alfresco.atlassian.net/browse/ACS-1297"
 }
diff --git a/e2e/suites/actions/create/create-file-from-template.test.ts b/e2e/suites/actions/create/create-file-from-template.test.ts
index 1788f9986..1564bf457 100755
--- a/e2e/suites/actions/create/create-file-from-template.test.ts
+++ b/e2e/suites/actions/create/create-file-from-template.test.ts
@@ -141,18 +141,6 @@ describe('Create file from template', () => {
     await page.closeOpenDialogs();
   });
 
-  it('[C325049] Select template - dialog UI - when no templates exist in the repo', async () => {
-    await sidenav.openCreateFileFromTemplateDialog();
-    await selectTemplateDialog.waitForDialogToOpen();
-
-    expect(await selectTemplateDialog.getDialogTitle()).toEqual('Select a document template');
-    expect(await selectTemplateDialog.dataTable.isEmpty()).toBe(true, 'Datatable is not empty');
-    expect(await selectTemplateDialog.dataTable.getEmptyListText()).toEqual('No results found');
-    expect(await selectTemplateDialog.breadcrumb.currentFolder.getText()).toEqual('Node Templates');
-    expect(await selectTemplateDialog.isNextButtonEnabled()).toBe(false, 'Next button is not disabled');
-    expect(await selectTemplateDialog.isCancelButtonEnabled()).toBe(true, 'Cancel button is not enabled');
-  });
-
   describe('with existing templates', () => {
     beforeAll(async () => {
       await adminApiActions.createNodeTemplatesHierarchy(templates);
diff --git a/e2e/suites/actions/edit/edit-offline.test.ts b/e2e/suites/actions/edit/edit-offline.test.ts
index 677c87d0a..9367fc118 100755
--- a/e2e/suites/actions/edit/edit-offline.test.ts
+++ b/e2e/suites/actions/edit/edit-offline.test.ts
@@ -233,22 +233,20 @@ describe('Edit offline', () => {
 
   describe('on Favorite Files', () => {
     let parentFavId: string;
-    let file1Id: string;
     let fileLockedId: string;
     let fileLocked2Id: string;
 
     beforeAll(async () => {
       parentFavId = (await apis.user.nodes.createFolder(parentFav)).entry.id;
 
-      file1Id = (await apis.user.upload.uploadFileWithRename(FILES.docxFile, parentFavId, file1)).entry.id;
       fileLockedId = (await apis.user.upload.uploadFileWithRename(FILES.docxFile, parentFavId, fileLocked)).entry.id;
       fileLocked2Id = (await apis.user.upload.uploadFileWithRename(FILES.docxFile, parentFavId, fileLocked2)).entry.id;
 
       await apis.user.nodes.lockFile(fileLockedId);
       await apis.user.nodes.lockFile(fileLocked2Id);
 
-      await apis.user.favorites.addFavoritesByIds('file', [file1Id, fileLockedId, fileLocked2Id]);
-      await apis.user.favorites.waitForApi({ expect: 3 });
+      await apis.user.favorites.addFavoritesByIds('file', [fileLockedId, fileLocked2Id]);
+      await apis.user.favorites.waitForApi({ expect: 2 });
 
       await loginPage.loginWith(username);
     });
@@ -265,14 +263,6 @@ describe('Edit offline', () => {
       await Utils.pressEscape();
     });
 
-    it('[C306956] File is locked and downloaded when clicking Edit Offline', async () => {
-      await dataTable.selectItem(file1);
-      await toolbar.clickMoreActionsEditOffline();
-
-      expect(await Utils.fileExistsOnOS(file1)).toBe(true, 'File not found in download location');
-      expect(await apis.user.nodes.isFileLockedWrite(file1Id)).toBe(true, `${file1} is not locked`);
-    });
-
     it('[C306957] Lock information is displayed', async () => {
       expect(await dataTable.isItemPresent(fileLocked2)).toBe(true, `${fileLocked2} is not displayed`);
       expect(await dataTable.hasLockIcon(fileLocked2)).toBe(true, `${fileLocked2} does not have a lock icon`);