diff --git a/app/src/app/app.module.ts b/app/src/app/app.module.ts index 87eab3bb6..1253e42c9 100644 --- a/app/src/app/app.module.ts +++ b/app/src/app/app.module.ts @@ -88,7 +88,7 @@ registerLocaleData(localeSv); BrowserModule, TranslateModule.forRoot(), CoreModule.forRoot(), - SharedModule.forRoot(), + SharedModule, CoreExtensionsModule.forRoot(), AppLoginModule, environment.e2e ? NoopAnimationsModule : BrowserAnimationsModule, diff --git a/karma.conf.js b/karma.conf.js index 916090daa..e2c5b9582 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -64,7 +64,7 @@ module.exports = () => { statements: 75, branches: 67, functions: 73, - lines: 75 + lines: 74 } } }, diff --git a/projects/aca-content/src/lib/aca-content.module.ts b/projects/aca-content/src/lib/aca-content.module.ts index 82730db2d..3da5bb1d5 100644 --- a/projects/aca-content/src/lib/aca-content.module.ts +++ b/projects/aca-content/src/lib/aca-content.module.ts @@ -34,7 +34,7 @@ import { LibraryStatusColumnComponent, TrashcanNameColumnComponent } from '@alfresco/adf-content-services'; -import { DocumentBasePageService, ExtensionsDataLoaderGuard, PageLayoutModule, SharedModule } from '@alfresco/aca-shared'; +import { DocumentBasePageService, ExtensionsDataLoaderGuard, PageLayoutModule, SharedModule, GenericErrorComponent } from '@alfresco/aca-shared'; import * as rules from '@alfresco/aca-shared/rules'; import { FilesComponent } from './components/files/files.component'; @@ -47,11 +47,10 @@ import { MaterialModule } from './material.module'; import { CoreExtensionsModule } from './extensions/core.extensions.module'; import { AppInfoDrawerModule } from './components/info-drawer/info.drawer.module'; import { DirectivesModule } from './directives/directives.module'; -import { ContextMenuModule } from './components/context-menu/context-menu.module'; import { ExtensionService, ExtensionsModule } from '@alfresco/adf-extensions'; import { AppToolbarModule } from './components/toolbar/toolbar.module'; import { AppSidenavModule } from './components/sidenav/sidenav.module'; -import { AppCommonModule } from './components/common/common.module'; +import { APP_COMMON_DIRECTIVES } from './components/common/common.module'; import { AppSearchInputModule } from './components/search/search-input.module'; import { DocumentListCustomComponentsModule } from './components/dl-custom-components/document-list-custom-components.module'; import { AppSearchResultsModule } from './components/search/search-results.module'; @@ -93,6 +92,7 @@ import { SidenavComponent } from './components/sidenav/sidenav.component'; import { ContentManagementService } from './services/content-management.service'; import { ShellLayoutComponent, SHELL_NAVBAR_MIN_WIDTH } from '@alfresco/adf-core/shell'; import { UserMenuComponent } from './components/sidenav/user-menu/user-menu.component'; +import { ContextMenuComponent } from './components/context-menu/context-menu.component'; @NgModule({ imports: [ @@ -107,10 +107,10 @@ import { UserMenuComponent } from './components/sidenav/user-menu/user-menu.comp SharedModule, MaterialModule, AppStoreModule, - AppCommonModule, + ...APP_COMMON_DIRECTIVES, PageLayoutModule, DirectivesModule, - ContextMenuModule, + ContextMenuComponent, AppInfoDrawerModule, AppToolbarModule, AppSidenavModule, @@ -121,11 +121,12 @@ import { UserMenuComponent } from './components/sidenav/user-menu/user-menu.comp ViewProfileModule, AppTrashcanModule, AppSharedLinkViewModule, - AcaFolderRulesModule + AcaFolderRulesModule, + GenericErrorComponent, + DetailsComponent ], declarations: [ FilesComponent, - DetailsComponent, LibrariesComponent, FavoriteLibrariesComponent, FavoritesComponent, diff --git a/projects/aca-content/src/lib/components/common/common.module.ts b/projects/aca-content/src/lib/components/common/common.module.ts index 8d6c78444..5d3ccb6d5 100644 --- a/projects/aca-content/src/lib/components/common/common.module.ts +++ b/projects/aca-content/src/lib/components/common/common.module.ts @@ -22,30 +22,25 @@ * from Hyland Software. If not, see . */ -import { CoreModule } from '@alfresco/adf-core'; -import { ExtensionsModule } from '@alfresco/adf-extensions'; -import { CommonModule } from '@angular/common'; import { NgModule } from '@angular/core'; -import { GenericErrorModule } from '@alfresco/aca-shared'; import { LocationLinkComponent } from './location-link/location-link.component'; import { ToggleSharedComponent } from './toggle-shared/toggle-shared.component'; import { LanguagePickerComponent } from './language-picker/language-picker.component'; import { LogoutComponent } from './logout/logout.component'; -import { ContentModule } from '@alfresco/adf-content-services'; import { UserInfoComponent } from './user-info/user-info.component'; -import { RouterModule } from '@angular/router'; +/** + * @deprecated Use `APP_COMMON_DIRECTIVES` instead + */ @NgModule({ - imports: [CommonModule, CoreModule.forChild(), ContentModule.forChild(), ExtensionsModule, GenericErrorModule, RouterModule], - declarations: [LocationLinkComponent, ToggleSharedComponent, LanguagePickerComponent, LogoutComponent, UserInfoComponent], - exports: [ - ExtensionsModule, - LocationLinkComponent, - GenericErrorModule, - ToggleSharedComponent, - LanguagePickerComponent, - LogoutComponent, - UserInfoComponent - ] + imports: [LanguagePickerComponent, LocationLinkComponent, LogoutComponent, ToggleSharedComponent, UserInfoComponent] }) export class AppCommonModule {} + +export const APP_COMMON_DIRECTIVES = [ + LanguagePickerComponent, + LocationLinkComponent, + LogoutComponent, + ToggleSharedComponent, + UserInfoComponent +] as const; diff --git a/projects/aca-content/src/lib/components/common/language-picker/language-picker.component.ts b/projects/aca-content/src/lib/components/common/language-picker/language-picker.component.ts index 87da0e959..ec6464df1 100644 --- a/projects/aca-content/src/lib/components/common/language-picker/language-picker.component.ts +++ b/projects/aca-content/src/lib/components/common/language-picker/language-picker.component.ts @@ -22,9 +22,15 @@ * from Hyland Software. If not, see . */ +import { LanguageMenuModule } from '@alfresco/adf-core'; import { Component } from '@angular/core'; +import { MatIconModule } from '@angular/material/icon'; +import { MatMenuModule } from '@angular/material/menu'; +import { TranslateModule } from '@ngx-translate/core'; @Component({ + standalone: true, + imports: [TranslateModule, MatIconModule, MatMenuModule, LanguageMenuModule], selector: 'aca-language-picker', template: `