Code cleanup and optimisations (#3383)

* cleanup unused css

* remove unused store/reducer blocks

* fix typo in toolbar ("tool-bar")

* toolbar action: break dependency on adf-core

* unified toolbar component

* break dependency on adf toolbar module

* update e2e

* update e2e

* update e2e

* update e2e

* update e2e

* fix search results toolbar spacing

* cleanup unused app state

* cleanup unused code

* fix toolbar divider color

* fix missing buttons in the info drawer

* fix css nesting

* fix search results css

projects/aca-content/src/lib/components/search/search-libraries-results/search-libraries-results.component.html

@@ -1,12 +1,8 @@
 <aca-page-layout>
   <div class="aca-page-layout-header">
     <aca-search-input></aca-search-input>
-    <div class="adf-toolbar--spacer adf-toolbar-divider"></div>
-    <adf-toolbar class="adf-toolbar--inline">
-      <ng-container *ngFor="let entry of actions; trackBy: trackByActionId">
-        <aca-toolbar-action [actionRef]="entry"></aca-toolbar-action>
-      </ng-container>
-    </adf-toolbar>
+    <div class="aca-search-toolbar-spacer"></div>
+    <aca-toolbar [items]="actions"></aca-toolbar>
   </div>
 
   <div class="aca-page-layout-content">

projects/aca-content/src/lib/components/search/search-libraries-results/search-libraries-results.component.scss

@@ -1,6 +1,10 @@
 @import '../../../ui/mixins';
 
 aca-search-results {
+  .aca-search-toolbar-spacer {
+    width: 100%;
+  }
+
   .adf-search-results {
     @include flex-row;
 

projects/aca-content/src/lib/components/search/search-libraries-results/search-libraries-results.component.ts

@@ -35,13 +35,13 @@ import {
   PageComponent,
   PageLayoutComponent,
   PaginationDirective,
-  ToolbarActionComponent
+  ToolbarComponent
 } from '@alfresco/aca-shared';
 import { DocumentListPresetRef, ExtensionsModule } from '@alfresco/adf-extensions';
 import { CommonModule } from '@angular/common';
 import { TranslateModule } from '@ngx-translate/core';
 import { SearchInputComponent } from '../search-input/search-input.component';
-import { DataTableModule, PaginationModule, ToolbarModule } from '@alfresco/adf-core';
+import { DataTableModule, PaginationModule } from '@alfresco/adf-core';
 import { MatProgressBarModule } from '@angular/material/progress-bar';
 import { DocumentListModule } from '@alfresco/adf-content-services';
 import { DocumentListDirective } from '../../../directives/document-list.directive';
@@ -52,7 +52,6 @@ import { DocumentListDirective } from '../../../directives/document-list.directi
     CommonModule,
     TranslateModule,
     SearchInputComponent,
-    ToolbarModule,
     MatProgressBarModule,
     DocumentListModule,
     DataTableModule,
@@ -61,9 +60,9 @@ import { DocumentListDirective } from '../../../directives/document-list.directi
     InfoDrawerComponent,
     ContextActionsDirective,
     DocumentListDirective,
-    ToolbarActionComponent,
     PaginationDirective,
-    PageLayoutComponent
+    PageLayoutComponent,
+    ToolbarComponent
   ],
   selector: 'aca-search-results',
   templateUrl: './search-libraries-results.component.html',

projects/aca-content/src/lib/components/search/search-results/search-results.component.html

@@ -1,12 +1,8 @@
 <aca-page-layout>
   <div class="aca-page-layout-header">
     <aca-search-input></aca-search-input>
-    <div class="adf-toolbar--spacer adf-toolbar-divider"></div>
-    <adf-toolbar class="adf-toolbar--inline">
-      <ng-container *ngFor="let entry of actions; trackBy: trackByActionId">
-        <aca-toolbar-action [actionRef]="entry"></aca-toolbar-action>
-      </ng-container>
-    </adf-toolbar>
+    <div class="aca-search-toolbar-spacer"></div>
+    <aca-toolbar [items]="actions"></aca-toolbar>
   </div>
 
   <div class="aca-page-layout-content">

projects/aca-content/src/lib/components/search/search-results/search-results.component.scss

@@ -1,5 +1,11 @@
 @import '../../../ui/mixins';
 
+aca-search-results {
+  .aca-search-toolbar-spacer {
+    width: 100%;
+  }
+}
+
 .adf-search-results {
   @include flex-row;
 

projects/aca-content/src/lib/components/search/search-results/search-results.component.ts

@@ -35,7 +35,7 @@ import {
   ShowInfoDrawerPreviewAction,
   SnackbarErrorAction
 } from '@alfresco/aca-shared/store';
-import { DataTableModule, PaginationModule, ToolbarModule, TranslationService, ViewerModule } from '@alfresco/adf-core';
+import { DataTableModule, PaginationModule, TranslationService, ViewerModule } from '@alfresco/adf-core';
 import { combineLatest } from 'rxjs';
 import {
   ContextActionsDirective,
@@ -43,7 +43,7 @@ import {
   PageComponent,
   PageLayoutComponent,
   PaginationDirective,
-  ToolbarActionComponent
+  ToolbarComponent
 } from '@alfresco/aca-shared';
 import { SearchSortingDefinition } from '@alfresco/adf-content-services/lib/search/models/search-sorting-definition.interface';
 import { takeUntil } from 'rxjs/operators';
@@ -66,7 +66,6 @@ import { SearchResultsRowComponent } from '../search-results-row/search-results-
     CommonModule,
     TranslateModule,
     SearchInputComponent,
-    ToolbarModule,
     MatProgressBarModule,
     SearchModule,
     MatDividerModule,
@@ -85,8 +84,8 @@ import { SearchResultsRowComponent } from '../search-results-row/search-results-
     SearchResultsRowComponent,
     PaginationDirective,
     ViewerModule,
-    ToolbarActionComponent,
-    PageLayoutComponent
+    PageLayoutComponent,
+    ToolbarComponent
   ],
   selector: 'aca-search-results',
   templateUrl: './search-results.component.html',