Code cleanup and optimisations (#3383)

* cleanup unused css

* remove unused store/reducer blocks

* fix typo in toolbar ("tool-bar")

* toolbar action: break dependency on adf-core

* unified toolbar component

* break dependency on adf toolbar module

* update e2e

* update e2e

* update e2e

* update e2e

* update e2e

* fix search results toolbar spacing

* cleanup unused app state

* cleanup unused code

* fix toolbar divider color

* fix missing buttons in the info drawer

* fix css nesting

* fix search results css

projects/aca-shared/store/src/actions/app-action-types.ts

@@ -23,7 +23,6 @@
  */
 
 export enum AppActionTypes {
-  SetSettingsParameter = 'SET_SETTINGS_PARAMETER',
   SetInitialState = 'SET_INITIAL_STATE',
   SetCurrentFolder = 'SET_CURRENT_FOLDER',
   SetCurrentVersion = 'SET_CURRENT_VERSION',
@@ -31,7 +30,6 @@ export enum AppActionTypes {
   SetUserProfile = 'SET_USER_PROFILE',
   SetRepositoryInfo = 'SET_REPOSITORY_INFO',
   ToggleInfoDrawer = 'TOGGLE_INFO_DRAWER',
-  ToggleDocumentDisplayMode = 'TOGGLE_DOCUMENT_DISPLAY_MODE',
   Logout = 'LOGOUT',
   ReloadDocumentList = 'RELOAD_DOCUMENT_LIST',
   ResetSelection = 'RESET_SELECTION',

projects/aca-shared/store/src/actions/app.actions.ts

@@ -27,12 +27,6 @@ import { Node, Person, Group, RepositoryInfo, VersionEntry } from '@alfresco/js-
 import { AppState } from '../states/app.state';
 import { AppActionTypes } from './app-action-types';
 
-export class SetSettingsParameterAction implements Action {
-  readonly type = AppActionTypes.SetSettingsParameter;
-
-  constructor(public payload: { name: string; value: any }) {}
-}
-
 export class SetInitialStateAction implements Action {
   readonly type = AppActionTypes.SetInitialState;
 
@@ -67,10 +61,6 @@ export class ToggleInfoDrawerAction implements Action {
   readonly type = AppActionTypes.ToggleInfoDrawer;
 }
 
-export class ToggleDocumentDisplayMode implements Action {
-  readonly type = AppActionTypes.ToggleDocumentDisplayMode;
-}
-
 export class LogoutAction implements Action {
   readonly type = AppActionTypes.Logout;
 }

projects/aca-shared/store/src/selectors/app.selectors.ts

@@ -40,7 +40,6 @@ export const getNavigationState = createSelector(selectApp, (state) => state.nav
 export const isInfoDrawerOpened = createSelector(selectApp, (state) => state.infoDrawerOpened);
 export const infoDrawerPreview = createSelector(selectApp, (state) => state.infoDrawerPreview);
 export const showFacetFilter = createSelector(selectApp, (state) => state.showFacetFilter);
-export const getDocumentDisplayMode = createSelector(selectApp, (state) => state.documentDisplayMode);
 export const getRepositoryStatus = createSelector(selectApp, (state) => state.repository);
 export const isQuickShareEnabled = createSelector(getRepositoryStatus, (info) => info.status.isQuickShareEnabled);
 export const isAdmin = createSelector(selectApp, (state) => state.user.isAdmin);

projects/aca-shared/store/src/states/app.state.ts

@@ -42,7 +42,6 @@ export interface AppState {
   infoDrawerPreview: boolean;
   infoDrawerMetadataAspect: string;
   showFacetFilter: boolean;
-  documentDisplayMode: string;
   repository: RepositoryInfo;
   fileUploadingDialog: boolean;
   showLoader: boolean;