Code cleanup and optimisations (#3383)

* cleanup unused css

* remove unused store/reducer blocks

* fix typo in toolbar ("tool-bar")

* toolbar action: break dependency on adf-core

* unified toolbar component

* break dependency on adf toolbar module

* update e2e

* update e2e

* update e2e

* update e2e

* update e2e

* fix search results toolbar spacing

* cleanup unused app state

* cleanup unused code

* fix toolbar divider color

* fix missing buttons in the info drawer

* fix css nesting

* fix search results css

projects/aca-testing-shared/src/components/info-drawer/info-drawer.ts

@@ -29,6 +29,7 @@ import { CommentsTab } from './info-drawer-comments-tab';
 import { LibraryMetadata } from './info-drawer-metadata-library';
 import { ContentMetadata } from './info-drawer-metadata-content';
 import { waitForPresence } from '../../utilities/utils';
+import { Toolbar } from '../toolbar/toolbar';
 
 export class InfoDrawer extends Component {
   commentsTab = new CommentsTab('adf-info-drawer');
@@ -43,6 +44,7 @@ export class InfoDrawer extends Component {
   selectedTab = TestElement.byCss(`.mat-tab-list [aria-selected='true'] div`);
   expandedDetailsPermissionsTab = TestElement.byText('.acs-details-container .mat-tab-label-content', 'Permissions');
   previewButton = TestElement.byCss(`button[title='Preview File']`);
+  toolbar = new Toolbar('adf-info-drawer');
 
   constructor(ancestor?: string) {
     super('adf-info-drawer', ancestor);
@@ -113,9 +115,7 @@ export class InfoDrawer extends Component {
     try {
       await BrowserActions.click(this.getTabByTitle('Comments'));
       await this.commentsTab.waitForCommentsContainer();
-      await Promise.all([
-        BrowserVisibility.waitUntilElementIsVisible(this.commentsTab.component),
-      ]);
+      await Promise.all([BrowserVisibility.waitUntilElementIsVisible(this.commentsTab.component)]);
     } catch (error) {
       Logger.error('--- info-drawer clickCommentsTab catch error: ', error);
     }

projects/aca-testing-shared/src/components/toolbar/toolbar.ts

@@ -48,7 +48,7 @@ export class Toolbar extends Component {
   viewerDownloadButton = element(By.css('[id="app.viewer.download"]'));
 
   constructor(ancestor?: string) {
-    super('.adf-toolbar', ancestor);
+    super('aca-toolbar', ancestor);
   }
 
   async isEmpty(): Promise<boolean> {
@@ -118,11 +118,6 @@ export class Toolbar extends Component {
     await BrowserActions.click(this.menu.createFolderAction);
   }
 
-  async openCreateLibraryDialog(): Promise<void> {
-    await this.openCreateMenu();
-    await BrowserActions.click(this.menu.createLibraryAction);
-  }
-
   async openCreateFileFromTemplateDialog(): Promise<void> {
     await this.openCreateMenu();
     await BrowserActions.click(this.menu.createFileFromTemplateAction);

projects/aca-testing-shared/src/pages/browsing-page.ts

@@ -29,7 +29,7 @@ import { Page } from './page';
 export class BrowsingPage extends Page {
   header = new Header(this.appRoot);
   sidenav = new Sidenav(this.appRoot);
-  toolbar = new Toolbar(this.appRoot);
+  toolbar = new Toolbar('.aca-page-layout');
   breadcrumb = new Breadcrumb(this.appRoot);
   pageLayoutHeader = new PageLayoutHeader(this.appRoot);
   dataTable = new DataTable(this.appRoot);