[ADF-5183] Upgrade to Angular 10 (#1506)

* upgrade preparation fixes

* remove fdescribe

* update browserlist config

* ng8

* ngrx 8

* ng9

* ngrx 9

* remove entryComponents

* unit tests

* ng 10

* latest ADF

* fix unit tests

* fix lint

* update deps and travis

* code fixes

* upgrade webdriver

* cleanup libs

* fix test

* update test

* Use browserTarget as target for lite-serve

* Use the update webdriver with CI condition

* Use version console.log('load', path

* Fix path sh

* Try to use remote env

* Add the . to export variabled

* Use hardcoded chrome version

* Remove the run remote

* Avoid to use the escape

* Skip flaky e2e and raise issue ACA-3615

* SKip failing e2e

* Skip flaky e2e and raise issue ACA-3615

* Fix close app toolbar menu and preconditions + tests of  mark-favorite.test.ts  Personal Files section

* Fix mark-favorite tests

* Fix ext-header test

* Fix new-menu tests

* Fix lint

* no message

* Fix viewer tests

Co-authored-by: maurizio vitale <maurizio.vitale@alfresco.com>
Co-authored-by: Cristina Jalba <cristina.jalba@ness.com>

projects/aca-testing-shared/src/components/header/header.ts

@@ -30,6 +30,7 @@ import { Menu } from '../menu/menu';
 import { Toolbar } from './../toolbar/toolbar';
 import { SearchInput } from '../search/search-input';
 import { waitElement } from '../../utilities/utils';
+import { BrowserActions } from '@alfresco/adf-testing';
 
 export class Header extends Component {
   logoLink = this.byCss('.app-menu__title');
@@ -50,6 +51,11 @@ export class Header extends Component {
     await this.menu.waitForMenuToOpen();
   }
 
+  async closeMoreMenu(): Promise<void> {
+    await BrowserActions.click(this.moreActions);
+    await this.menu.waitForMenuToClose();
+  }
+
   async isSignOutDisplayed(): Promise<boolean> {
     return this.userInfo.menu.isMenuItemPresent('Sign out');
   }

projects/aca-testing-shared/src/components/sidenav/sidenav.ts

@@ -24,7 +24,7 @@
  */
 
 import { ElementFinder, by, element, browser } from 'protractor';
-import { Logger } from '@alfresco/adf-testing';
+import { Logger, BrowserActions } from '@alfresco/adf-testing';
 import { SIDEBAR_LABELS, BROWSER_WAIT_TIMEOUT } from '../../configs';
 import { Menu } from '../menu/menu';
 import { Component } from '../component';
@@ -79,6 +79,13 @@ export class Sidenav extends Component {
     await this.menu.waitForMenuToOpen();
   }
 
+  async closeNewMenu(): Promise<void> {
+    await BrowserActions.click(
+      element(by.css('button[data-automation-id="create-button"] span span'))
+    );
+    await this.menu.waitForMenuToClose();
+  }
+
   async openCreateFolderDialog(): Promise<void> {
     await this.openNewMenu();
     await this.menu.createFolderAction.click();

projects/aca-testing-shared/src/components/toolbar/toolbar.ts

@@ -92,7 +92,16 @@ export class Toolbar extends Component {
     await this.menu.waitForMenuToOpen();
   }
 
-  async closeMoreMenu() {
+  async closeMoreMenu(): Promise<void> {
+    await this.isButtonPresent('More Actions');
+
+    const moreMenu = this.getButtonByTitleAttribute('More Actions');
+    await BrowserActions.click(moreMenu);
+
+    await this.menu.waitForMenuToClose();
+  }
+
+  async closeMoreMenuEscape() {
     await Utils.pressEscape();
   }
 

projects/aca-testing-shared/src/pages/page.ts

@@ -53,7 +53,7 @@ export abstract class Page {
   }
 
   async load(relativeUrl: string = '') {
-    const hash = USE_HASH_STRATEGY ? '/#' : '';
+    const hash = USE_HASH_STRATEGY ? '#' : '';
     const path = `${browser.baseUrl}${hash}${this.url}${relativeUrl}`;
     return browser.get(path);
   }

projects/aca-testing-shared/src/utilities/admin-actions.ts

@@ -147,9 +147,9 @@ export class AdminActions {
 
     // folder links are deleted automatically when original folder is deleted
     // Software Engineering Project is the default folder template coming from ACS, should not be deleted
-    const nodesToDelete = (await this.adminApi.nodes.getNodeChildren(
-      spaceTemplatesNodeId
-    )).list.entries
+    const nodesToDelete = (
+      await this.adminApi.nodes.getNodeChildren(spaceTemplatesNodeId)
+    ).list.entries
       .filter(
         node =>
           node.entry.nodeType !== 'app:folderlink' &&

projects/aca-testing-shared/src/utilities/repo-client/apis/nodes/node-content-tree.ts

@@ -69,14 +69,12 @@ export function flattenNodeContentTree(
 
   if (folders) {
     const foldersData: NodeBodyCreate[] = folders
-      .map(
-        (folder: string | NodeContentTree): NodeBodyCreate[] => {
-          const folderData: NodeContentTree =
-            typeof folder === 'string' ? { name: folder } : folder;
+      .map((folder: string | NodeContentTree): NodeBodyCreate[] => {
+        const folderData: NodeContentTree =
+          typeof folder === 'string' ? { name: folder } : folder;
 
-          return flattenNodeContentTree(folderData, relativePath);
-        }
-      )
+        return flattenNodeContentTree(folderData, relativePath);
+      })
       .reduce(
         (nodesData: NodeBodyCreate[], folderData: NodeBodyCreate[]) =>
           nodesData.concat(folderData),

projects/aca-testing-shared/src/utilities/repo-client/apis/sites/sites-api.ts

@@ -328,9 +328,9 @@ export class SitesApi extends RepoApi {
   async hasMembershipRequest(siteId: string) {
     try {
       await this.apiAuth();
-      const requests = (await this.sitesApi.getSiteMembershipRequests(
-        '-me-'
-      )).list.entries.map(e => e.entry.id);
+      const requests = (
+        await this.sitesApi.getSiteMembershipRequests('-me-')
+      ).list.entries.map(e => e.entry.id);
       return requests.includes(siteId);
     } catch (error) {
       this.handleError(

projects/aca-testing-shared/src/utilities/utils.ts

@@ -179,9 +179,7 @@ export class Utils {
   static async setSessionStorageFromConfig(
     configFileName: string
   ): Promise<void> {
-    const configFile = `${
-      browser.params.e2eRootPath
-    }/resources/extensibility-configs/${configFileName}`;
+    const configFile = `${browser.params.e2eRootPath}/resources/extensibility-configs/${configFileName}`;
     const fileContent = JSON.stringify(
       fs.readFileSync(configFile, { encoding: 'utf8' })
     );