From 28a4fb7ba793cf73d740b59d419f3d4f8861e340 Mon Sep 17 00:00:00 2001 From: Adina Parpalita Date: Wed, 12 Sep 2018 12:08:20 +0300 Subject: [PATCH] [ACA-870] add tests for right click actions (#625) --- e2e/components/data-table/data-table.ts | 17 + .../context-menu-multiple-selection.test.ts | 381 +++++++++++ .../context-menu-single-selection.test.ts | 355 ++++++++++ ...cial-permissions-available-actions.test.ts | 631 ++++++++++++++++++ .../toolbar-multiple-selection.test.ts | 303 ++------- .../actions/toolbar-single-selection.test.ts | 447 ++----------- 6 files changed, 1515 insertions(+), 619 deletions(-) create mode 100755 e2e/suites/actions/context-menu-multiple-selection.test.ts create mode 100755 e2e/suites/actions/context-menu-single-selection.test.ts create mode 100755 e2e/suites/actions/special-permissions-available-actions.test.ts diff --git a/e2e/components/data-table/data-table.ts b/e2e/components/data-table/data-table.ts index d68be01f8..f459179fb 100755 --- a/e2e/components/data-table/data-table.ts +++ b/e2e/components/data-table/data-table.ts @@ -26,6 +26,7 @@ import { ElementFinder, ElementArrayFinder, promise, by, browser, ExpectedConditions as EC, protractor } from 'protractor'; import { BROWSER_WAIT_TIMEOUT } from '../../configs'; import { Component } from '../component'; +import { Menu } from '../menu/menu'; import { Utils } from '../../utilities/utils'; export class DataTable extends Component { @@ -67,6 +68,8 @@ export class DataTable extends Component { emptyListSubtitle: ElementFinder = this.component.element(by.css(DataTable.selectors.emptyListSubtitle)); emptyListText: ElementArrayFinder = this.component.all(by.css(DataTable.selectors.emptyListText)); + menu: Menu = new Menu(); + constructor(ancestor?: ElementFinder) { super(DataTable.selectors.root, ancestor); } @@ -208,6 +211,16 @@ export class DataTable extends Component { }); } + async rightClickOnItem(itemName: string) { + const item = this.getRowFirstCell(itemName); + await browser.actions().click(item, protractor.Button.RIGHT).perform(); + } + + async rightClickOnMultipleSelection() { + const itemFromSelection = this.getSelectedRows().get(0); + await browser.actions().click(itemFromSelection, protractor.Button.RIGHT).perform(); + } + getItemLocation(name: string) { return this.getRowByName(name).element(this.locationLink); } @@ -273,4 +286,8 @@ export class DataTable extends Component { return this.getRows().all(by.cssContainingText(DataTable.selectors.cell, name)) .map(cell => cell.getText()); } + + async hasContextMenu() { + return (await this.menu.getItemsCount()) > 0; + } } diff --git a/e2e/suites/actions/context-menu-multiple-selection.test.ts b/e2e/suites/actions/context-menu-multiple-selection.test.ts new file mode 100755 index 000000000..9c1fe4810 --- /dev/null +++ b/e2e/suites/actions/context-menu-multiple-selection.test.ts @@ -0,0 +1,381 @@ +/*! + * @license + * Alfresco Example Content Application + * + * Copyright (C) 2005 - 2018 Alfresco Software Limited + * + * This file is part of the Alfresco Example Content Application. + * If the software was purchased under a paid Alfresco license, the terms of + * the paid license agreement will prevail. Otherwise, the software is + * provided under the following open source license terms: + * + * The Alfresco Example Content Application is free software: you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * The Alfresco Example Content Application is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with Alfresco. If not, see . + */ + +import { browser, protractor } from 'protractor'; +import { LoginPage, LogoutPage, BrowsingPage } from '../../pages/pages'; +import { SITE_VISIBILITY, SIDEBAR_LABELS } from '../../configs'; +import { RepoClient } from '../../utilities/repo-client/repo-client'; +import { Utils } from '../../utilities/utils'; + +describe('Context menu actions - multiple selection : ', () => { + const username = `user-${Utils.random()}`; + + const file1 = `file1-${Utils.random()}.txt`; let file1Id; + const file2 = `file2-${Utils.random()}.txt`; let file2Id; + + const folder1 = `folder1-${Utils.random()}`; let folder1Id; + const folder2 = `folder2-${Utils.random()}`; let folder2Id; + + const fileInTrash1 = `deletedFile1-${Utils.random()}.txt`; let fileInTrash1Id; + const fileInTrash2 = `deletedFile2-${Utils.random()}.txt`; let fileInTrash2Id; + const folderInTrash1 = `deletedFolder1-${Utils.random()}`; let folderInTrash1Id; + const folderInTrash2 = `deletedFolder2-${Utils.random()}`; let folderInTrash2Id; + + const siteName = `site-${Utils.random()}`; + const file1Site = `file1-${Utils.random()}.txt`; + const file2Site = `file2-${Utils.random()}.txt`; + const folder1Site = `folder1-${Utils.random()}`; + const folder2Site = `folder2-${Utils.random()}`; + + const apis = { + admin: new RepoClient(), + user: new RepoClient(username, username) + }; + + const loginPage = new LoginPage(); + const logoutPage = new LogoutPage(); + const page = new BrowsingPage(); + const { dataTable } = page; + const contextMenu = dataTable.menu; + + beforeAll(async (done) => { + await apis.admin.people.createUser({ username }); + file1Id = (await apis.user.nodes.createFile(file1)).entry.id; + file2Id = (await apis.user.nodes.createFile(file2)).entry.id; + folder1Id = (await apis.user.nodes.createFolder(folder1)).entry.id; + folder2Id = (await apis.user.nodes.createFolder(folder2)).entry.id; + + await apis.user.sites.createSite(siteName, SITE_VISIBILITY.PUBLIC); + const docLibId = (await apis.user.sites.getDocLibId(siteName)); + await apis.user.nodes.createFile(file1Site, docLibId); + await apis.user.nodes.createFile(file2Site, docLibId); + await apis.user.nodes.createFolder(folder1Site, docLibId); + await apis.user.nodes.createFile(folder2Site, docLibId); + + await apis.user.shared.shareFilesByIds([ file1Id, file2Id ]); + await apis.user.shared.waitForApi({ expect: 2 }); + + await apis.user.favorites.addFavoritesByIds('file', [ file1Id, file2Id ]); + await apis.user.favorites.addFavoritesByIds('folder', [ folder1Id, folder2Id ]); + await apis.user.favorites.waitForApi({ expect: 4 }); + + fileInTrash1Id = (await apis.user.nodes.createFile(fileInTrash1)).entry.id; + fileInTrash2Id = (await apis.user.nodes.createFile(fileInTrash2)).entry.id; + folderInTrash1Id = (await apis.user.nodes.createFolder(folderInTrash1)).entry.id; + folderInTrash2Id = (await apis.user.nodes.createFolder(folderInTrash2)).entry.id; + await apis.user.nodes.deleteNodesById([ fileInTrash1Id, fileInTrash2Id, folderInTrash1Id, folderInTrash2Id ], false); + + await loginPage.loginWith(username); + done(); + }); + + afterAll(async (done) => { + await Promise.all([ + apis.user.nodes.deleteNodesById([ file1Id, file2Id, folder1Id, folder2Id ]), + apis.user.sites.deleteSite(siteName), + apis.user.trashcan.emptyTrash(), + logoutPage.load() + ]); + done(); + }); + + xit(''); + + describe('Generic tests', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.PERSONAL_FILES); + await dataTable.waitForHeader(); + await dataTable.clearSelection(); + done(); + }); + + it('Context menu appears on right click on a multiple selection of items - [C286268]', async () => { + await dataTable.selectMultipleItems([ file1, file2 ]); + // await dataTable.rightClickOnItem(file1); + await dataTable.rightClickOnMultipleSelection(); + expect(await dataTable.hasContextMenu()).toBe(true, 'Context menu is not displayed'); + }); + + it('Context menu appears when right clicking on a single item while having multiple items selected - [C286269]', async () => { + await dataTable.selectMultipleItems([ file2, folder1 ]); + await dataTable.rightClickOnItem(file1); + expect(await dataTable.hasContextMenu()).toBe(true, `Context menu is not displayed for ${file1}`); + expect(await dataTable.countSelectedRows()).toEqual(1, 'incorrect number of selected rows'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, `Edit is displayed for ${file1}`); + expect(await dataTable.hasCheckMarkIcon(file1)).toBe(true, `${file1} is not selected`); + expect(await dataTable.hasCheckMarkIcon(file2)).toBe(false, `${file2} is selected`); + expect(await dataTable.hasCheckMarkIcon(folder1)).toBe(false, `${folder1} is selected`); + }); + }); + + describe('on Personal Files', () => { + beforeEach(async (done) => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.PERSONAL_FILES); + await dataTable.waitForHeader(); + await dataTable.clearSelection(); + done(); + }); + + it('correct actions appear when multiple files are selected - [C280661]', async () => { + await dataTable.selectMultipleItems([file1, file2]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed`); + }); + + it('correct actions appear when multiple folders are selected - [C280632]', async () => { + await dataTable.selectMultipleItems([folder1, folder2]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, 'Edit is displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed`); + }); + + it('correct actions appear when both files and folders are selected - [C280631]', async () => { + await dataTable.selectMultipleItems([file1, file2, folder1, folder2]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, 'Edit is displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed`); + }); + }); + + describe('on File Libraries', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await dataTable.clearSelection(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); + done(); + }); + + it('correct actions appear when multiple files are selected - [C280641]', async () => { + await dataTable.selectMultipleItems([ file1Site, file2Site ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, 'Edit is displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed`); + }); + + it('correct actions appear when multiple folders are selected - [C280574]', async () => { + await dataTable.selectMultipleItems([ folder1Site, folder2Site ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, 'Edit is displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed`); + }); + + it('correct actions appear when both files and folders are selected - [C280642]', async () => { + await dataTable.selectMultipleItems([ file1Site, file2Site, folder1Site, folder2Site ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, 'Edit is displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed`); + }); + }); + + describe('on Shared Files', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await dataTable.clearSelection(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.SHARED_FILES); + await dataTable.waitForHeader(); + done(); + }); + + it('correct actions appear when multiple files are selected - [C280648]', async () => { + await dataTable.selectMultipleItems([ file1, file2 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, 'Edit is displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed`); + }); + }); + + describe('Recent Files', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await dataTable.clearSelection(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.RECENT_FILES); + await dataTable.waitForHeader(); + done(); + }); + + it('correct actions appear when multiple files are selected - [C280652]', async () => { + await dataTable.selectMultipleItems([ file1, file2 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, 'Edit is displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed`); + }); + }); + + describe('Favorites', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await dataTable.clearSelection(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); + await dataTable.waitForHeader(); + done(); + }); + + it('correct actions appear when multiple files are selected - [C280656]', async () => { + await dataTable.selectMultipleItems([ file1, file2 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, 'Edit is displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + // TODO: enable when ACA-1794 is fixed + // expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed`); + }); + + it('correct actions appear when multiple folders are selected - [C280664]', async () => { + await dataTable.selectMultipleItems([ folder1, folder2 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, 'Edit is displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + // TODO: enable when ACA-1794 is fixed + // expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed`); + }); + + it('correct actions appear when both files and folders are selected - [C280657]', async () => { + await dataTable.selectMultipleItems([ file1, file2, folder1, folder2 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, 'Edit is displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + // TODO: enable when ACA-1794 is fixed + // expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed`); + }); + }); + + describe('Trash', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await dataTable.clearSelection(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.TRASH); + await dataTable.waitForHeader(); + done(); + }); + + it('correct actions appear when multiple files are selected - [C286273]', async () => { + await dataTable.selectMultipleItems([ fileInTrash1, fileInTrash2 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('Permanently delete')).toBe(true, 'Permanently delete is not displayed'); + expect(await contextMenu.isMenuItemPresent('Restore')).toBe(true, 'Restore is not displayed'); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(false, 'Download is displayed'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, 'Edit is displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(false, `Copy is displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(false, `Favorite is displayed`); + }); + + it('correct actions appear when multiple folders are selected - [C286274]', async () => { + await dataTable.selectMultipleItems([ folderInTrash1, folderInTrash2 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('Permanently delete')).toBe(true, 'Permanently delete is not displayed'); + expect(await contextMenu.isMenuItemPresent('Restore')).toBe(true, 'Restore is not displayed'); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(false, 'Download is displayed'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, 'Edit is displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(false, `Copy is displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(false, `Favorite is displayed`); + }); + + it('correct actions appear when both files and folders are selected - [C286275]', async () => { + await dataTable.selectMultipleItems([ fileInTrash1, fileInTrash2, folderInTrash1, folderInTrash2 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('Permanently delete')).toBe(true, 'Permanently delete is not displayed'); + expect(await contextMenu.isMenuItemPresent('Restore')).toBe(true, 'Restore is not displayed'); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(false, 'Download is displayed'); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, 'Edit is displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(false, `Copy is displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(false, `Favorite is displayed`); + }); + }); +}); diff --git a/e2e/suites/actions/context-menu-single-selection.test.ts b/e2e/suites/actions/context-menu-single-selection.test.ts new file mode 100755 index 000000000..7d8408c3a --- /dev/null +++ b/e2e/suites/actions/context-menu-single-selection.test.ts @@ -0,0 +1,355 @@ +/*! + * @license + * Alfresco Example Content Application + * + * Copyright (C) 2005 - 2018 Alfresco Software Limited + * + * This file is part of the Alfresco Example Content Application. + * If the software was purchased under a paid Alfresco license, the terms of + * the paid license agreement will prevail. Otherwise, the software is + * provided under the following open source license terms: + * + * The Alfresco Example Content Application is free software: you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * The Alfresco Example Content Application is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with Alfresco. If not, see . + */ + +import { browser, protractor } from 'protractor'; +import { LoginPage, LogoutPage, BrowsingPage } from '../../pages/pages'; +import { SITE_VISIBILITY, SIDEBAR_LABELS } from '../../configs'; +import { RepoClient } from '../../utilities/repo-client/repo-client'; +import { Utils } from '../../utilities/utils'; + +describe('Context menu actions - single selection : ', () => { + const username = `user-${Utils.random()}`; + + const fileUser = `fileUser-${Utils.random()}.txt`; let fileUserId; + const folderUser = `folderUser-${Utils.random()}`; let folderUserId; + const fileInTrash = `fileForDelete-${Utils.random()}.txt`; let fileInTrashId; + const folderInTrash = `folderForDelete-${Utils.random()}`; let folderInTrashId; + + const siteName = `userSite-${Utils.random()}`; + const fileSiteUser = `fileUser-${Utils.random()}.txt`; + const folderSiteUser = `folderUser-${Utils.random()}`; + + const apis = { + admin: new RepoClient(), + user: new RepoClient(username, username) + }; + + const loginPage = new LoginPage(); + const logoutPage = new LogoutPage(); + const page = new BrowsingPage(); + const { dataTable } = page; + const contextMenu = dataTable.menu; + + beforeAll(async (done) => { + await apis.admin.people.createUser({ username }); + + fileUserId = (await apis.user.nodes.createFile(fileUser)).entry.id; + folderUserId = (await apis.user.nodes.createFolder(folderUser)).entry.id; + + await apis.user.sites.createSite(siteName, SITE_VISIBILITY.PUBLIC); + const docLibId = await apis.user.sites.getDocLibId(siteName); + await apis.user.nodes.createFile(fileSiteUser, docLibId); + await apis.user.nodes.createFolder(folderSiteUser, docLibId); + + fileInTrashId = (await apis.user.nodes.createFiles([fileInTrash])).entry.id; + folderInTrashId = (await apis.user.nodes.createFolders([ folderInTrash ])).entry.id; + await apis.user.nodes.deleteNodeById(fileInTrashId, false); + await apis.user.nodes.deleteNodeById(folderInTrashId, false); + + await apis.user.shared.shareFileById(fileUserId); + await apis.user.shared.waitForApi({ expect: 1 }); + + await apis.user.favorites.addFavoriteById('file', fileUserId); + await apis.user.favorites.addFavoriteById('folder', folderUserId); + await apis.user.favorites.waitForApi({ expect: 2 }); + + await loginPage.loginWith(username); + done(); + }); + + afterAll(async (done) => { + await Promise.all([ + apis.user.nodes.deleteNodeById(fileUserId), + apis.user.nodes.deleteNodeById(folderUserId), + apis.user.sites.deleteSite(siteName), + apis.user.trashcan.emptyTrash(), + logoutPage.load() + ]); + done(); + }); + + xit(''); + + describe('Generic tests', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.PERSONAL_FILES); + await dataTable.waitForHeader(); + done(); + }); + + it('Row is marked with a check circle icon on direct right click - [C286252]', async () => { + await dataTable.rightClickOnItem(fileUser); + expect(await dataTable.hasCheckMarkIcon(fileUser)).toBe(true, 'check mark missing'); + }); + + it('Context menu appears on direct right click on an item - [C286253]', async () => { + await dataTable.rightClickOnItem(fileUser); + expect(await dataTable.hasContextMenu()).toBe(true, 'Context menu is not displayed'); + }); + + it('Context menu appears when selecting an item and then right clicking on it - [C286254]', async () => { + await dataTable.selectItem(fileUser); + await dataTable.rightClickOnItem(fileUser); + expect(await dataTable.hasContextMenu()).toBe(true, 'Context menu is not displayed'); + }); + + it('Context menu appears correctly when right clicking on another item - [C284666]', async () => { + await dataTable.selectItem(fileUser); + await dataTable.rightClickOnItem(folderUser); + expect(await dataTable.hasContextMenu()).toBe(true, `Context menu is not displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(true, `Edit is not displayed for ${folderUser}`); + expect(await dataTable.hasCheckMarkIcon(folderUser)).toBe(true, `${folderUser} is not selected`); + expect(await dataTable.hasCheckMarkIcon(fileUser)).toBe(false, `${fileUser} is not selected`); + }); + + it('Context menu closes when clicking away from it - [C280619]', async () => { + await dataTable.rightClickOnItem(fileUser); + expect(await dataTable.hasContextMenu()).toBe(true, 'Context menu is not displayed'); + await page.sidenav.activeLink.click(); + expect(await dataTable.hasContextMenu()).toBe(false, 'Context menu is displayed'); + }); + + it('Context menu does not appear for a library - [C286276]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.rightClickOnItem(siteName); + expect(await dataTable.hasContextMenu()).toBe(false, 'Context menu is displayed for a site'); + }); + }); + + describe('on Personal Files', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await dataTable.clearSelection(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.PERSONAL_FILES); + await dataTable.waitForHeader(); + done(); + }); + + it('Context menu has the correct actions for a file - [C280615]', async () => { + await dataTable.rightClickOnItem(fileUser); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, `Download is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(true, `View is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Share')).toBe(true, `Share is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')).toBe(true, `Manage Versions is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, `Edit is displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('View details')).toBe(false, `View details is displayed for ${fileUser}`); + }); + + it('Context menu has the correct actions for a folder - [C280616]', async () => { + await dataTable.rightClickOnItem(folderUser); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, `Download is not enabled for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(true, `Edit is not displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, `View is displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')).toBe(false, `Manage Versions is displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Share')).toBe(false, `Share is displayed for ${folderUser}`); + }); + }); + + describe('File Libraries', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); + done(); + }); + + it('Context menu has the correct actions for a file - [C280594]', async () => { + await dataTable.rightClickOnItem(fileSiteUser); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, `Download is not displayed for ${fileSiteUser}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(true, `View is not displayed for ${fileSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${fileSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${fileSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${fileSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${fileSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Share')).toBe(true, `Share is not displayed for ${fileSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')).toBe(true, `Manage Versions not displayed for ${fileSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed for ${fileSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, `Edit is displayed for ${fileSiteUser}`); + expect(await contextMenu.isMenuItemPresent('View details')).toBe(false, `View details is displayed for ${fileSiteUser}`); + }); + + it('Context menu has the correct actions for a folder - [C280595]', async () => { + await dataTable.rightClickOnItem(folderSiteUser); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, `Download is not enabled for ${folderSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(true, `Edit is not displayed for ${folderSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${folderSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${folderSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${folderSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${folderSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed for ${folderSiteUser}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, `View is displayed for ${folderSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')).toBe(false, `Manage Versions displayed for ${folderSiteUser}`); + expect(await contextMenu.isMenuItemPresent('Share')).toBe(false, `Share is displayed for ${folderSiteUser}`); + }); + }); + + describe('Shared Files', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.SHARED_FILES); + await dataTable.waitForHeader(); + done(); + }); + + it('Context menu has the correct actions for a file - [C280601]', async () => { + await dataTable.rightClickOnItem(fileUser); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, `Download is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(true, `View is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${fileUser}`); + // TODO: enable this when the action is properly implemented: ACA-92 + // expect(await contextMenu.isMenuItemPresent('Share')).toBe(true, `Share is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')).toBe(true, `Manage Versions not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, `Edit is displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('View details')).toBe(false, `View details is displayed for ${fileUser}`); + }); + }); + + describe('Recent Files', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.RECENT_FILES); + await dataTable.waitForHeader(); + done(); + }); + + it('Context menu has the correct actions for a file - [C280622]', async () => { + await dataTable.rightClickOnItem(fileUser); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, `Download is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(true, `View is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Share')).toBe(true, `Share is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')).toBe(true, `Manage Versions not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, `Edit is displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('View details')).toBe(false, `View details is displayed for ${fileUser}`); + }); + }); + + describe('Favorites', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); + await dataTable.waitForHeader(); + done(); + }); + + it('Context menu has the correct actions for a file - [C280608]', async () => { + await dataTable.rightClickOnItem(fileUser); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, `Download is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(true, `View is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Share')).toBe(true, `Share is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')).toBe(true, `Manage Versions is not displayed for ${fileUser}`); + // TODO: enable when ACA-1794 is fixed + // expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, `Edit is displayed for ${fileUser}`); + expect(await contextMenu.isMenuItemPresent('View details')).toBe(false, `View details is displayed for ${fileUser}`); + }); + + it('Context menu has the correct actions for a folder - [C280609]', async () => { + await dataTable.rightClickOnItem(folderUser); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, `Download is not enabled for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(true, `Edit is not displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${folderUser}`); + // TODO: enable when ACA-1794 is fixed + // expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, `View is displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')).toBe(false, `Manage Versions is displayed for ${folderUser}`); + expect(await contextMenu.isMenuItemPresent('Share')).toBe(false, `Share is displayed for ${folderUser}`); + }); + }); + + describe('Trash', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.TRASH); + await dataTable.waitForHeader(); + done(); + }); + + it('Context menu has the correct actions for a file - [C286258]', async () => { + await dataTable.rightClickOnItem(fileInTrash); + expect(await contextMenu.isMenuItemPresent('Permanently delete')) + .toBe(true, `Permanently delete is not displayed for ${fileInTrash}`); + expect(await contextMenu.isMenuItemPresent('Restore')).toBe(true, `Restore is not displayed for ${fileInTrash}`); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(false, `Download is not displayed for ${fileInTrash}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, `View is not displayed for ${fileInTrash}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(false, `Favorite is not displayed for ${fileInTrash}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(false, `Copy is not displayed for ${fileInTrash}`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is not displayed for ${fileInTrash}`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is not displayed for ${fileInTrash}`); + expect(await contextMenu.isMenuItemPresent('Share')).toBe(false, `Share is not displayed for ${fileInTrash}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')) + .toBe(false, `Manage Versions is not displayed for ${fileInTrash}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, `Edit is displayed for ${fileInTrash}`); + expect(await contextMenu.isMenuItemPresent('View details')).toBe(false, `View details is displayed for ${fileInTrash}`); + }); + + it('Context menu has the correct actions for a folder - [C286259]', async () => { + await dataTable.rightClickOnItem(folderInTrash); + expect(await contextMenu.isMenuItemPresent('Permanently delete')) + .toBe(true, `Permanently delete is not displayed for ${folderInTrash}`); + expect(await contextMenu.isMenuItemPresent('Restore')).toBe(true, `Restore is not displayed for ${folderInTrash}`); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(false, `Download is not displayed for ${folderInTrash}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, `View is not displayed for ${folderInTrash}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(false, `Favorite is not displayed for ${folderInTrash}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(false, `Copy is not displayed for ${folderInTrash}`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is not displayed for ${folderInTrash}`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is not displayed for ${folderInTrash}`); + expect(await contextMenu.isMenuItemPresent('Share')).toBe(false, `Share is not displayed for ${folderInTrash}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')) + .toBe(false, `Manage Versions is not displayed for ${folderInTrash}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, `Edit is displayed for ${folderInTrash}`); + expect(await contextMenu.isMenuItemPresent('View details')).toBe(false, `View details is displayed for ${folderInTrash}`); + }); + }); +}); diff --git a/e2e/suites/actions/special-permissions-available-actions.test.ts b/e2e/suites/actions/special-permissions-available-actions.test.ts new file mode 100755 index 000000000..150d1c2df --- /dev/null +++ b/e2e/suites/actions/special-permissions-available-actions.test.ts @@ -0,0 +1,631 @@ +/*! + * @license + * Alfresco Example Content Application + * + * Copyright (C) 2005 - 2018 Alfresco Software Limited + * + * This file is part of the Alfresco Example Content Application. + * If the software was purchased under a paid Alfresco license, the terms of + * the paid license agreement will prevail. Otherwise, the software is + * provided under the following open source license terms: + * + * The Alfresco Example Content Application is free software: you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * The Alfresco Example Content Application is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with Alfresco. If not, see . + */ + +import { browser, protractor } from 'protractor'; +import { LoginPage, LogoutPage, BrowsingPage } from '../../pages/pages'; +import { SITE_VISIBILITY, SITE_ROLES, SIDEBAR_LABELS } from '../../configs'; +import { RepoClient } from '../../utilities/repo-client/repo-client'; +import { Utils } from '../../utilities/utils'; + +describe('Granular permissions available actions : ', () => { + const userConsumer = `consumer-${Utils.random()}`; + const userManager = `manager-${Utils.random()}`; + + const siteName = `site-private-${Utils.random()}`; + const file1 = `file1-${Utils.random()}.txt`; let file1Id; + const file2 = `file2-${Utils.random()}.txt`; let file2Id; + const file3 = `file3-${Utils.random()}.txt`; let file3Id; + + const folder1 = `folder1-${Utils.random()}`; let folder1Id; + const folder2 = `folder2-${Utils.random()}`; let folder2Id; + + const apis = { + admin: new RepoClient(), + userConsumer: new RepoClient(userConsumer, userConsumer), + userManager: new RepoClient(userManager, userManager) + }; + + const loginPage = new LoginPage(); + const logoutPage = new LogoutPage(); + const page = new BrowsingPage(); + const { dataTable, toolbar } = page; + const contextMenu = dataTable.menu; + + beforeAll(async (done) => { + await apis.admin.people.createUser({ username: userConsumer }); + await apis.admin.people.createUser({ username: userManager }); + + await apis.admin.sites.createSite(siteName, SITE_VISIBILITY.PRIVATE); + const docLibId = await apis.admin.sites.getDocLibId(siteName); + + file1Id = (await apis.admin.nodes.createFile(file1, docLibId)).entry.id; + file2Id = (await apis.admin.nodes.createFile(file2, docLibId)).entry.id; + file3Id = (await apis.admin.nodes.createFile(file3, docLibId)).entry.id; + folder1Id = (await apis.admin.nodes.createFolder(folder1, docLibId)).entry.id; + folder2Id = (await apis.admin.nodes.createFolder(folder2, docLibId)).entry.id; + + await apis.admin.sites.addSiteMember(siteName, userManager, SITE_ROLES.SITE_MANAGER); + await apis.admin.sites.addSiteMember(siteName, userConsumer, SITE_ROLES.SITE_CONSUMER); + + await apis.admin.nodes.setGranularPermission(file3Id, false, userConsumer, SITE_ROLES.SITE_MANAGER); + + await apis.userConsumer.shared.shareFileById(file1Id); + await apis.userConsumer.shared.shareFileById(file2Id); + await apis.admin.shared.shareFileById(file3Id); + await apis.userConsumer.shared.waitForApi({ expect: 3 }); + + await apis.userConsumer.favorites.addFavoritesByIds('file', [ file1Id, file2Id, file3Id ]); + await apis.userConsumer.favorites.addFavoritesByIds('folder', [ folder1Id, folder2Id ]); + await apis.userConsumer.favorites.waitForApi({ expect: 5 }); + + await loginPage.loginWith(userConsumer); + done(); + }); + + afterAll(async (done) => { + await Promise.all([ + apis.admin.sites.deleteSite(siteName), + logoutPage.load() + ]); + done(); + }); + + xit(''); + + describe('toolbar displays correct actions when selecting multiple files with different granular permissions', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + done(); + }); + + it('on File Libraries - [C280476]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ file1, file2 ]); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for selected files`); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); + expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for selected files`); + expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for selected files`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); + await toolbar.actions.closeMoreMenu(); + }); + + it('on Shared Files - [C280477]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.SHARED_FILES); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ file1, file2 ]); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for selected files`); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); + expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for selected files`); + expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for selected files`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); + await toolbar.actions.closeMoreMenu(); + }); + + it('on Favorites - [C280478]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ file1, file2 ]); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for selected files`); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); + // TODO: enable when ACA-1737 is done + // expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for selected files`); + // expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for selected files`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); + await toolbar.actions.closeMoreMenu(); + }); + }); + + describe('toolbar actions appear correctly for a file - consumer', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + done(); + }); + + it('on File Libraries - [C280455]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); + await dataTable.selectItem(file1); + expect(await toolbar.actions.isButtonPresent('View')).toBe(true, `View is not displayed for ${file1}`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${file1}`); + expect(await toolbar.actions.isButtonPresent('View details')).toBe(true, `View details is not displayed for ${file1}`); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${file1}`); + + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${file1}`); + expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${file1}`); + expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${file1}`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${file1}`); + await toolbar.actions.closeMoreMenu(); + }); + + it('on Shared Files - [C280456]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.SHARED_FILES); + await page.dataTable.waitForHeader(); + await page.dataTable.selectItem(file1); + expect(await toolbar.actions.isButtonPresent('View')).toBe(true, `View is not displayed for ${file1}`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${file1}`); + expect(await toolbar.actions.isButtonPresent('View details')).toBe(true, `View details is not displayed for ${file1}`); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${file1}`); + const menu = await toolbar.actions.openMoreMenu(); + + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${file1}`); + expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${file1}`); + expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${file1}`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${file1}`); + await toolbar.actions.closeMoreMenu(); + }); + + it('on Favorites - [C213121]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); + await dataTable.waitForHeader(); + await dataTable.selectItem(file1); + expect(await toolbar.actions.isButtonPresent('View')).toBe(true, `View is not displayed for ${file1}`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${file1}`); + expect(await toolbar.actions.isButtonPresent('View details')).toBe(true, `View details is not displayed for ${file1}`); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${file1}`); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${file1}`); + // TODO: enable when ACA-1737 is done + // expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${file1}`); + // expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${file1}`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${file1}`); + await toolbar.actions.closeMoreMenu(); + }); + }); + + describe('toolbar actions appear correctly for a folder - consumer', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + done(); + }); + + it('on File Libraries - [C280444]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); + await dataTable.selectItem(folder1); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for ${folder1}`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${folder1}`); + expect(await toolbar.actions.isButtonPresent('View details')).toBe(true, `View details is not displayed for ${folder1}`); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${folder1}`); + + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${folder1}`); + expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${folder1}`); + expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${folder1}`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${folder1}`); + await toolbar.actions.closeMoreMenu(); + }); + + it('on Favorites - [C286266]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); + await dataTable.waitForHeader(); + await dataTable.selectItem(folder1); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is not displayed for ${folder1}`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${folder1}`); + expect(await toolbar.actions.isButtonPresent('View details')).toBe(true, `View details is not displayed for ${folder1}`); + // TODO: enable when ACA-1737 is done + // expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${folder1}`); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${folder1}`); + // TODO: enable when ACA-1737 is done + // expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${folder1}`); + // expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${folder1}`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${folder1}`); + await toolbar.actions.closeMoreMenu(); + }); + }); + + describe('toolbar actions appear correctly for multiple selection of files - consumer', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await dataTable.clearSelection(); + done(); + }); + + it('on File Libraries - [C280464]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ file1, file2 ]); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed'); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, 'Edit is displayed'); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); + expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + await toolbar.actions.closeMoreMenu(); + }); + + it('on Shared Files - [C286284]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.SHARED_FILES); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ file1, file2 ]); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for selected files`); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); + expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for selected files`); + expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for selected files`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); + await toolbar.actions.closeMoreMenu(); + }); + + it('on Favorites - [C286285]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ file1, file2 ]); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for selected files`); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); + // TODO: enable when ACA-1737 is done + // expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for selected files`); + // expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for selected files`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); + await toolbar.actions.closeMoreMenu(); + }); + }); + + describe('toolbar actions appear correctly for multiple selection of folders - consumer', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await dataTable.clearSelection(); + done(); + }); + + it('on File Libraries - [C280465]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ folder1, folder2 ]); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed'); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, 'Edit is displayed'); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); + expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + await toolbar.actions.closeMoreMenu(); + }); + + it('on Favorites - [C286286]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ folder1, folder2 ]); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for selected files`); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); + // TODO: enable when ACA-1737 is done + // expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for selected files`); + // expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for selected files`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); + await toolbar.actions.closeMoreMenu(); + }); + }); + + describe('toolbar actions appear correctly for when both files and folders are selected - consumer', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await dataTable.clearSelection(); + done(); + }); + + it('on File Libraries - [C280466]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ file1, folder1 ]); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed'); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, 'Edit is displayed'); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); + expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + await toolbar.actions.closeMoreMenu(); + }); + + it('on Favorites - [C286287]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ file1, folder1 ]); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for selected files`); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for selected files`); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); + // TODO: enable when ACA-1737 is done + // expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for selected files`); + // expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for selected files`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); + await toolbar.actions.closeMoreMenu(); + }); + }); + + describe('context menu actions are correct for a file - consumer', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + done(); + }); + + it('on File Libraries - [C280599]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); + await dataTable.rightClickOnItem(file1); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, `Download is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(true, `View is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Share')).toBe(true, `Share is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')).toBe(true, `Manage Versions not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(false, `Permissions is displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, `Edit is displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('View details')).toBe(false, `View details is displayed for ${file1}`); + }); + + it('on Shared Files - [C286264]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.SHARED_FILES); + await dataTable.waitForHeader(); + await dataTable.rightClickOnItem(file1); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, `Download is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(true, `View is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${file1}`); + // TODO: enable this when the action is properly implemented: ACA-92 + // expect(await contextMenu.isMenuItemPresent('Share')).toBe(true, `Share is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')).toBe(true, `Manage Versions not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(false, `Permissions is displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, `Edit is displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('View details')).toBe(false, `View details is displayed for ${file1}`); + }); + + it('on Favorites - [C286262]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); + await dataTable.waitForHeader(); + await dataTable.rightClickOnItem(file1); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, `Download is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(true, `View is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${file1}`); + // TODO: enable when ACA-1737 is done + // expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${file1}`); + // expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Share')).toBe(true, `Share is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')).toBe(true, `Manage Versions is not displayed for ${file1}`); + // TODO: enable when ACA-1794 is fixed + // expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, `Edit is displayed for ${file1}`); + expect(await contextMenu.isMenuItemPresent('View details')).toBe(false, `View details is displayed for ${file1}`); + }); + }); + + describe('context menu actions are correct for a folder - consumer', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + done(); + }); + + it('on File Libraries - [C280600]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); + await dataTable.rightClickOnItem(folder1); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, `Download is not enabled for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, `Edit is displayed for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(false, `Permissions is displayed for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, `View is displayed for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')).toBe(false, `Manage Versions displayed for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('Share')).toBe(false, `Share is displayed for ${folder1}`); + }); + + it('on Favorites - [C286263]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); + await dataTable.waitForHeader(); + await dataTable.rightClickOnItem(folder1); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, `Download is not enabled for ${folder1}`); + // enable when ACA-1737 is done + // expect(await contextMenu.isMenuItemPresent('Edit')).toBe(false, `Edit is displayed for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${folder1}`); + // TODO: enable when ACA-1737 is done + // expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${folder1}`); + // expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${folder1}`); + // TODO: enable when ACA-1794 is fixed + // expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(true, `Permissions is not displayed for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, `View is displayed for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('Manage Versions')).toBe(false, `Manage Versions is displayed for ${folder1}`); + expect(await contextMenu.isMenuItemPresent('Share')).toBe(false, `Share is displayed for ${folder1}`); + }); + }); + + describe('context menu actions are correct for multiple selection of files - consumer', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await dataTable.clearSelection(); + done(); + }); + + it('on File Libraries - [C280647]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ file1, file2 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(false, `Permissions is displayed`); + }); + + it('on Shared Files - [C286283]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.SHARED_FILES); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ file1, file2 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(false, `Permissions is displayed`); + }); + + it('on Favorites - [C286280]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ file1, file2 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + // TODO: enable when ACA-1737 is done + // expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); + // expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(false, `Permissions is displayed`); + }); + }); + + describe('context menu actions are correct for multiple selection of folders - consumer', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await dataTable.clearSelection(); + done(); + }); + + it('on File Libraries - [C280666]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ folder1, folder2 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(false, `Permissions is displayed`); + }); + + it('on Favorites - [C286281]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ folder1, folder2 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + // TODO: enable when ACA-1737 is done + // expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); + // expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(false, `Permissions is displayed`); + }); + }); + + describe('context menu actions are correct when both files and folders are selected - consumer', () => { + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await dataTable.clearSelection(); + done(); + }); + + it('on File Libraries - [C280669]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ file1, folder1 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); + expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(false, `Permissions is displayed`); + }); + + it('on Favorites - [C286282]', async () => { + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); + await dataTable.waitForHeader(); + await dataTable.selectMultipleItems([ file1, folder1 ]); + await dataTable.rightClickOnMultipleSelection(); + expect(await contextMenu.isMenuItemPresent('View')).toBe(false, 'View is displayed'); + expect(await contextMenu.isMenuItemPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await contextMenu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); + // TODO: enable when ACA-1737 is done + // expect(await contextMenu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); + // expect(await contextMenu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); + expect(await contextMenu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); + expect(await contextMenu.isMenuItemPresent('Permissions')).toBe(false, `Permissions is displayed`); + }); + }); +}); diff --git a/e2e/suites/actions/toolbar-multiple-selection.test.ts b/e2e/suites/actions/toolbar-multiple-selection.test.ts index 164641b17..0e57962b0 100755 --- a/e2e/suites/actions/toolbar-multiple-selection.test.ts +++ b/e2e/suites/actions/toolbar-multiple-selection.test.ts @@ -25,48 +25,43 @@ import { browser, protractor } from 'protractor'; import { LoginPage, LogoutPage, BrowsingPage } from '../../pages/pages'; -import { SITE_VISIBILITY, SITE_ROLES, SIDEBAR_LABELS } from '../../configs'; +import { SITE_VISIBILITY, SIDEBAR_LABELS } from '../../configs'; import { RepoClient } from '../../utilities/repo-client/repo-client'; import { Utils } from '../../utilities/utils'; describe('Toolbar actions - multiple selection : ', () => { - const user1 = `user-${Utils.random()}`; - const user2 = `user-${Utils.random()}`; + const username = `user-${Utils.random()}`; - const file1 = `file-${Utils.random()}.txt`; - let file1Id; - const file2 = `file-${Utils.random()}.txt`; - let file2Id; + const file1 = `file-${Utils.random()}.txt`; let file1Id; + const file2 = `file-${Utils.random()}.txt`; let file2Id; - const folder1 = `folder-${Utils.random()}`; - let folder1Id; - const folder2 = `folder-${Utils.random()}`; - let folder2Id; + const folder1 = `folder-${Utils.random()}`; let folder1Id; + const folder2 = `folder-${Utils.random()}`; let folder2Id; const fileForDelete1 = `file-${Utils.random()}.txt`; let fileForDelete1Id; const fileForDelete2 = `file-${Utils.random()}.txt`; let fileForDelete2Id; const folderForDelete1 = `folder-${Utils.random()}`; let folderForDelete1Id; const folderForDelete2 = `folder-${Utils.random()}`; let folderForDelete2Id; - const siteName = `site-private-${Utils.random()}`; - const file1Admin = `file-${Utils.random()}.txt`; - const file2Admin = `file-${Utils.random()}.txt`; - const folder1Admin = `folder-${Utils.random()}`; - const folder2Admin = `folder-${Utils.random()}`; + const siteName = `site-${Utils.random()}`; + const file1InSite = `file1-${Utils.random()}.txt`; + const file2InSite = `file2-${Utils.random()}.txt`; + const folder1InSite = `folder1-${Utils.random()}`; + const folder2InSite = `folder2-${Utils.random()}`; const apis = { admin: new RepoClient(), - user: new RepoClient(user1, user1) + user: new RepoClient(username, username) }; const loginPage = new LoginPage(); const logoutPage = new LogoutPage(); const page = new BrowsingPage(); - const { dataTable } = page; - const { toolbar } = page; + const { dataTable, toolbar } = page; beforeAll(async (done) => { - await apis.admin.people.createUser({ username: user1 }); + await apis.admin.people.createUser({ username }); + file1Id = (await apis.user.nodes.createFiles([ file1 ])).entry.id; file2Id = (await apis.user.nodes.createFiles([ file2 ])).entry.id; folder1Id = (await apis.user.nodes.createFolders([ folder1 ])).entry.id; @@ -85,6 +80,14 @@ describe('Toolbar actions - multiple selection : ', () => { await apis.user.nodes.deleteNodesById([ fileForDelete1Id, fileForDelete2Id, folderForDelete1Id, folderForDelete2Id ], false); + await apis.user.sites.createSite(siteName, SITE_VISIBILITY.PRIVATE); + const docLibId = await apis.user.sites.getDocLibId(siteName); + await apis.user.nodes.createFile(file1InSite, docLibId); + await apis.user.nodes.createFile(file2InSite, docLibId); + await apis.user.nodes.createFolder(folder1InSite, docLibId); + await apis.user.nodes.createFolder(folder2InSite, docLibId); + + await loginPage.loginWith(username); done(); }); @@ -92,6 +95,7 @@ describe('Toolbar actions - multiple selection : ', () => { await Promise.all([ apis.user.nodes.deleteNodesById([ file1Id, file2Id, folder1Id, folder2Id ]), apis.user.trashcan.emptyTrash(), + apis.user.sites.deleteSite(siteName), logoutPage.load() ]); done(); @@ -100,28 +104,18 @@ describe('Toolbar actions - multiple selection : ', () => { xit(''); describe('Personal Files', () => { - beforeAll(async (done) => { - await loginPage.loginWith(user1); - done(); - }); - beforeEach(async (done) => { + await dataTable.clearSelection(); await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.PERSONAL_FILES); await dataTable.waitForHeader(); done(); }); - afterAll(async (done) => { - await logoutPage.load(); - done(); - }); - it('Unselect items with single click - [C280458]', async () => { await dataTable.selectMultipleItems([ file1, file2, folder1, folder2 ]); expect(await dataTable.countSelectedRows()).toEqual(4, 'incorrect selected rows number'); await dataTable.selectItem(file1); expect(await dataTable.countSelectedRows()).toEqual(1, 'incorrect selected rows number'); - await dataTable.clearSelection(); }); it('Select / unselect selected items by CMD+click - [C217110]', async () => { @@ -137,7 +131,6 @@ describe('Toolbar actions - multiple selection : ', () => { await dataTable.selectItem(file2); await browser.actions().sendKeys(protractor.Key.NULL).perform(); expect(await dataTable.countSelectedRows()).toEqual(2, 'incorrect selected rows number'); - await dataTable.clearSelection(); }); it('correct actions appear when multiple files are selected - [C217112]', async () => { @@ -150,8 +143,7 @@ describe('Toolbar actions - multiple selection : ', () => { expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); - await dataTable.clearSelection(); + await toolbar.actions.closeMoreMenu(); }); it('correct actions appear when multiple folders are selected - [C280459]', async () => { @@ -164,8 +156,7 @@ describe('Toolbar actions - multiple selection : ', () => { expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); - await dataTable.clearSelection(); + await toolbar.actions.closeMoreMenu(); }); it('correct actions appear when both files and folders are selected - [C280460]', async () => { @@ -178,23 +169,14 @@ describe('Toolbar actions - multiple selection : ', () => { expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); - await dataTable.clearSelection(); + await toolbar.actions.closeMoreMenu(); }); }); describe('File Libraries', () => { - beforeAll(async (done) => { - await apis.admin.sites.createSite(siteName, SITE_VISIBILITY.PUBLIC); - await apis.admin.people.createUser({ username: user2 }); - await apis.admin.sites.addSiteMember(siteName, user1, SITE_ROLES.SITE_MANAGER); - await apis.admin.sites.addSiteMember(siteName, user2, SITE_ROLES.SITE_CONSUMER); - await apis.admin.nodes.createFiles([ file1Admin, file2Admin ], `Sites/${siteName}/documentLibrary`); - await apis.admin.nodes.createFolders([ folder1Admin, folder2Admin ], `Sites/${siteName}/documentLibrary`); - done(); - }); - beforeEach(async (done) => { + await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); + await dataTable.clearSelection(); await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); await dataTable.waitForHeader(); await dataTable.doubleClickOnRowByName(siteName); @@ -202,145 +184,52 @@ describe('Toolbar actions - multiple selection : ', () => { done(); }); - afterAll(async (done) => { - await apis.admin.sites.deleteSite(siteName); - done(); + it('correct actions appear when multiple files are selected - [C280461]', async () => { + await dataTable.selectMultipleItems([file1InSite, file2InSite]); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed for selected files'); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, 'Download is not displayed for selected files'); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, 'Edit is displayed for selected files'); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); + expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); + expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); }); - xit(''); - - describe('user is Manager', () => { - beforeAll(async (done) => { - await loginPage.loginWith(user1); - done(); - }); - - afterAll(async (done) => { - await logoutPage.load(); - done(); - }); - - it('correct actions appear when multiple files are selected - [C280461]', async () => { - await dataTable.selectMultipleItems([file1Admin, file2Admin]); - expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed for selected files'); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, 'Download is not displayed for selected files'); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, 'Edit is displayed for selected files'); - const menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - - await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); - await dataTable.clearSelection(); - }); - - it('correct actions appear when multiple folders are selected - [C280462]', async () => { - await dataTable.selectMultipleItems([folder1Admin, folder2Admin]); - expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed'); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, 'Download is not displayed'); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, 'Edit is displayed'); - const menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - - await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); - await dataTable.clearSelection(); - }); - - it('correct actions appear when both files and folders are selected - [C280463]', async () => { - await dataTable.selectMultipleItems([file1Admin, file2Admin, folder1Admin, folder2Admin]); - expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed'); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, 'Download is not displayed'); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, 'Edit is displayed'); - const menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - - await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); - await dataTable.clearSelection(); - }); + it('correct actions appear when multiple folders are selected - [C280462]', async () => { + await dataTable.selectMultipleItems([folder1InSite, folder2InSite]); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed'); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, 'Edit is displayed'); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); + expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); + expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); }); - describe('user is Consumer', () => { - beforeAll(async (done) => { - await loginPage.loginWith(user2); - done(); - }); - - afterAll(async (done) => { - await logoutPage.load(); - done(); - }); - - it('correct actions appear when multiple files are selected - [C280464]', async () => { - await dataTable.selectMultipleItems([file1Admin, file2Admin]); - expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed for selected files'); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, 'Download is not displayed for selected files'); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, 'Edit is displayed for selected files'); - const menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for selected files`); - expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for selected files`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - - await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); - await dataTable.clearSelection(); - }); - - it('correct actions appear when multiple folders are selected - [C280465]', async () => { - await dataTable.selectMultipleItems([folder1Admin, folder2Admin]); - expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed'); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, 'Download is not displayed'); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, 'Edit is displayed'); - const menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed`); - expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed`); - expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed`); - - await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); - await dataTable.clearSelection(); - }); - - it('correct actions appear when both files and folders are selected - [C280466]', async () => { - await dataTable.selectMultipleItems([file1Admin, file2Admin, folder1Admin, folder2Admin]); - expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed'); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, 'Download is not displayed for selected files'); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, 'Edit is displayed'); - const menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - - await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); - await dataTable.clearSelection(); - }); + it('correct actions appear when both files and folders are selected - [C280463]', async () => { + await dataTable.selectMultipleItems([file1InSite, file2InSite, folder1InSite, folder2InSite]); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed'); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, 'Download is not displayed'); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, 'Edit is displayed'); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); + expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); + expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); }); }); describe('Shared Files', () => { - beforeAll(async (done) => { - await loginPage.loginWith(user1); - done(); - }); - beforeEach(async (done) => { + await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); + await dataTable.clearSelection(); await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.SHARED_FILES); await dataTable.waitForHeader(); done(); }); - afterAll(async (done) => { - await logoutPage.load(); - done(); - }); - it('correct actions appear when multiple files are selected - [C280467]', async () => { await dataTable.selectMultipleItems([file1, file2]); expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed'); @@ -351,29 +240,18 @@ describe('Toolbar actions - multiple selection : ', () => { expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - - await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); - await dataTable.clearSelection(); }); }); describe('Recent Files', () => { - beforeAll(async (done) => { - await loginPage.loginWith(user1); - done(); - }); - beforeEach(async (done) => { + await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); + await dataTable.clearSelection(); await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.RECENT_FILES); await dataTable.waitForHeader(); done(); }); - afterAll(async (done) => { - await logoutPage.load(); - done(); - }); - it('correct actions appear when multiple files are selected - [C280468]', async () => { await dataTable.selectMultipleItems([file1, file2]); expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed'); @@ -384,29 +262,18 @@ describe('Toolbar actions - multiple selection : ', () => { expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - - await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); - await dataTable.clearSelection(); }); }); describe('Favorites', () => { - beforeAll(async (done) => { - await loginPage.loginWith(user1); - done(); - }); - beforeEach(async (done) => { + await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); + await dataTable.clearSelection(); await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); await dataTable.waitForHeader(); done(); }); - afterAll(async (done) => { - await logoutPage.load(); - done(); - }); - it('correct actions appear when multiple files are selected - [C280469]', async () => { await dataTable.selectMultipleItems([file1, file2]); expect(await toolbar.actions.isButtonPresent('View')).toBe(false, 'View is displayed'); @@ -417,9 +284,6 @@ describe('Toolbar actions - multiple selection : ', () => { expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - - await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); - await dataTable.clearSelection(); }); it('correct actions appear when multiple folders are selected - [C280470]', async () => { @@ -432,9 +296,6 @@ describe('Toolbar actions - multiple selection : ', () => { expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - - await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); - await dataTable.clearSelection(); }); it('correct actions appear when both files and folders are selected - [C280471]', async () => { @@ -447,51 +308,33 @@ describe('Toolbar actions - multiple selection : ', () => { expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for selected files`); expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for selected files`); expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - - await browser.actions().mouseMove(browser.$('body'), { x: 0, y: 0 }).click().perform(); - await dataTable.clearSelection(); }); }); describe('Trash', () => { - beforeAll(async (done) => { - await loginPage.loginWith(user1); - done(); - }); - beforeEach(async (done) => { + await dataTable.clearSelection(); await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.TRASH); await dataTable.waitForHeader(); done(); }); - afterAll(async (done) => { - await logoutPage.load(); - done(); - }); - it('correct actions appear when multiple files are selected - [C280472]', async () => { await dataTable.selectMultipleItems([fileForDelete1, fileForDelete2]); - expect(await toolbar.actions.isButtonPresent('Permanently delete')) - .toBe(true, 'Permanently delete is displayed for selected files'); - expect(await toolbar.actions.isButtonPresent('Restore')).toBe(true, 'Restore is not displayed for selected files'); - await dataTable.clearSelection(); + expect(await toolbar.actions.isButtonPresent('Permanently delete')).toBe(true, 'Permanently delete is displayed'); + expect(await toolbar.actions.isButtonPresent('Restore')).toBe(true, 'Restore is not displayed'); }); it('correct actions appear when multiple folders are selected - [C280473]', async () => { await dataTable.selectMultipleItems([folderForDelete1, folderForDelete2]); - expect(await toolbar.actions.isButtonPresent('Permanently delete')) - .toBe(true, 'Permanently delete is displayed for selected files'); - expect(await toolbar.actions.isButtonPresent('Restore')).toBe(true, 'Restore is not displayed for selected files'); - await dataTable.clearSelection(); + expect(await toolbar.actions.isButtonPresent('Permanently delete')).toBe(true, 'Permanently delete is displayed'); + expect(await toolbar.actions.isButtonPresent('Restore')).toBe(true, 'Restore is not displayed'); }); it('correct actions appear when both files and folders are selected - [C280474]', async () => { await dataTable.selectMultipleItems([fileForDelete1, fileForDelete2, folderForDelete1, folderForDelete2]); - expect(await toolbar.actions.isButtonPresent('Permanently delete')) - .toBe(true, 'Permanently delete is displayed for selected files'); - expect(await toolbar.actions.isButtonPresent('Restore')).toBe(true, 'Restore is not displayed for selected files'); - await dataTable.clearSelection(); + expect(await toolbar.actions.isButtonPresent('Permanently delete')).toBe(true, 'Permanently delete is displayed'); + expect(await toolbar.actions.isButtonPresent('Restore')).toBe(true, 'Restore is not displayed'); }); }); }); diff --git a/e2e/suites/actions/toolbar-single-selection.test.ts b/e2e/suites/actions/toolbar-single-selection.test.ts index ad3871f47..4f3c2de25 100755 --- a/e2e/suites/actions/toolbar-single-selection.test.ts +++ b/e2e/suites/actions/toolbar-single-selection.test.ts @@ -25,22 +25,21 @@ import { browser, protractor } from 'protractor'; import { LoginPage, LogoutPage, BrowsingPage } from '../../pages/pages'; -import { SITE_VISIBILITY, SITE_ROLES, SIDEBAR_LABELS } from '../../configs'; +import { SITE_VISIBILITY, SIDEBAR_LABELS } from '../../configs'; import { RepoClient } from '../../utilities/repo-client/repo-client'; import { Utils } from '../../utilities/utils'; describe('Toolbar actions - single selection : ', () => { const username = `user-${Utils.random()}`; - const username2 = `user-${Utils.random()}`; const fileUser = `fileUser-${Utils.random()}.txt`; let fileUserId; const folderUser = `folderUser-${Utils.random()}`; let folderUserId; const fileForDelete = `fileForDelete-${Utils.random()}.txt`; let fileForDeleteId; const folderForDelete = `folderForDelete-${Utils.random()}`; let folderForDeleteId; - const siteName = `site-private-${Utils.random()}`; - const fileAdmin = `fileAdmin-${Utils.random()}.txt`; - const folderAdmin = `folderAdmin-${Utils.random()}`; + const siteName = `site-${Utils.random()}`; + const fileInSite = `fileAdmin-${Utils.random()}.txt`; + const folderInSite = `folderAdmin-${Utils.random()}`; const apis = { admin: new RepoClient(), @@ -55,10 +54,10 @@ describe('Toolbar actions - single selection : ', () => { beforeAll(async (done) => { await apis.admin.people.createUser({ username }); - fileUserId = (await apis.user.nodes.createFiles([fileUser])).entry.id; - fileForDeleteId = (await apis.user.nodes.createFiles([fileForDelete])).entry.id; - folderForDeleteId = (await apis.user.nodes.createFolders([ folderForDelete ])).entry.id; - folderUserId = (await apis.user.nodes.createFolders([ folderUser ])).entry.id; + fileUserId = (await apis.user.nodes.createFile(fileUser)).entry.id; + fileForDeleteId = (await apis.user.nodes.createFile(fileForDelete)).entry.id; + folderForDeleteId = (await apis.user.nodes.createFolder(folderForDelete)).entry.id; + folderUserId = (await apis.user.nodes.createFolder(folderUser)).entry.id; await apis.user.shared.shareFileById(fileUserId); await apis.user.shared.waitForApi({ expect: 1 }); @@ -67,42 +66,37 @@ describe('Toolbar actions - single selection : ', () => { await apis.user.favorites.addFavoriteById('folder', folderUserId); await apis.user.favorites.waitForApi({ expect: 2 }); + await apis.user.sites.createSite(siteName, SITE_VISIBILITY.PRIVATE); + const docLibId = await apis.user.sites.getDocLibId(siteName); + + await apis.user.nodes.createFile(fileInSite, docLibId); + await apis.user.nodes.createFolder(folderInSite, docLibId); + + await apis.user.nodes.deleteNodeById(fileForDeleteId, false); + await apis.user.nodes.deleteNodeById(folderForDeleteId, false); + + await loginPage.loginWith(username); done(); }); afterAll(async (done) => { await Promise.all([ apis.user.nodes.deleteNodeById(fileUserId), - apis.user.nodes.deleteNodeById(folderUserId) + apis.user.nodes.deleteNodeById(folderUserId), + apis.user.sites.deleteSite(siteName), + apis.user.trashcan.emptyTrash(), + logoutPage.load() ]); - done(); }); xit(''); describe('General tests', () => { - const userSite = `userSite-${Utils.random()}`; - - beforeAll(async (done) => { - await apis.user.sites.createSite(userSite, SITE_VISIBILITY.PUBLIC); - await loginPage.loginWith(username); - done(); - }); - - afterAll(async (done) => { - await Promise.all([ - apis.user.sites.deleteSite(userSite), - logoutPage.load() - ]); - - done(); - }); - it('actions not displayed for top level of File Libraries - [C213135]', async () => { await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); await dataTable.waitForHeader(); - await dataTable.selectItem(userSite); + await dataTable.selectItem(siteName); expect(await toolbar.actions.isEmpty()).toBe(true, 'toolbar not empty'); }); @@ -114,210 +108,15 @@ describe('Toolbar actions - single selection : ', () => { }); }); - describe('granular permissions', () => { - const site = `site-${Utils.random()}`; - const file1 = `file1-${Utils.random()}`; let file1Id; - const file2 = `file2-${Utils.random()}`; let file2Id; - - beforeAll(async (done) => { - await apis.admin.sites.createSite(site, SITE_VISIBILITY.PRIVATE); - const docLibId = await apis.admin.sites.getDocLibId(site); - - file1Id = (await apis.admin.nodes.createFile(file1, docLibId)).entry.id; - file2Id = (await apis.admin.nodes.createFile(file2, docLibId)).entry.id; - - await apis.admin.sites.addSiteMember(site, username, SITE_ROLES.SITE_CONSUMER); - await apis.admin.nodes.setGranularPermission(file1Id, false, username, SITE_ROLES.SITE_CONSUMER); - await apis.admin.nodes.setGranularPermission(file2Id, false, username, SITE_ROLES.SITE_MANAGER); - - await apis.user.shared.shareFileById(file1Id); - await apis.admin.shared.shareFileById(file2Id); - await apis.user.shared.waitForApi({ expect: 3 }); - - await apis.user.favorites.addFavoritesByIds('file', [file1Id, file2Id]); - await apis.user.favorites.waitForApi({ expect: 3 }); - - await loginPage.loginWith(username); - done(); - }); - - afterAll(async (done) => { - await Promise.all([ - apis.admin.sites.deleteSite(site), - logoutPage.load() - ]); - - done(); - }); - - describe('actions update accordingly for files with different granular permissions', () => { - beforeEach(async (done) => { - await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); - done(); - }); - - it('on File Libraries - [C280455]', async () => { - await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); - await dataTable.waitForHeader(); - await dataTable.doubleClickOnRowByName(site); - await dataTable.waitForHeader(); - await dataTable.selectItem(file1); - expect(await toolbar.actions.isButtonPresent('View')).toBe(true, `View is not displayed for ${file1}`); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${file1}`); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${file1}`); - - let menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${file1}`); - expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${file1}`); - expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${file1}`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${file1}`); - await toolbar.actions.closeMoreMenu(); - - await dataTable.selectItem(file2); - expect(await toolbar.actions.isButtonPresent('View')).toBe(true, `View is not displayed for ${file2}`); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${file2}`); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${file2}`); - - menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${file2}`); - expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${file2}`); - expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${file2}`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${file2}`); - await toolbar.actions.closeMoreMenu(); - }); - - it('on Shared Files - [C280456]', async () => { - await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.SHARED_FILES); - await page.dataTable.waitForHeader(); - await page.dataTable.selectItem(file1); - expect(await toolbar.actions.isButtonPresent('View')).toBe(true, `View is not displayed for ${file1}`); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${file1}`); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${file1}`); - let menu = await toolbar.actions.openMoreMenu(); - - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${file1}`); - expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${file1}`); - expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${file1}`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${file1}`); - await toolbar.actions.closeMoreMenu(); - - await page.dataTable.selectItem(file2); - expect(await toolbar.actions.isButtonPresent('View')).toBe(true, `View is not displayed for ${file2}`); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${file2}`); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${file2}`); - menu = await toolbar.actions.openMoreMenu(); - - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${file2}`); - expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${file2}`); - expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${file2}`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${file2}`); - await toolbar.actions.closeMoreMenu(); - }); - - // disabled until ACA-1737 is done - xit('on Favorites - [C213121]', async () => { - await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); - await dataTable.waitForHeader(); - await dataTable.selectItem(file1); - expect(await toolbar.actions.isButtonPresent('View')).toBe(true, `View is not displayed for ${file1}`); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${file1}`); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${file1}`); - let menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${file1}`); - expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${file1}`); - expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${file1}`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${file1}`); - await toolbar.actions.closeMoreMenu(); - - await dataTable.selectItem(file2); - expect(await toolbar.actions.isButtonPresent('View')).toBe(true, `View is not displayed for ${file2}`); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${file2}`); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${file2}`); - menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${file2}`); - expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${file2}`); - expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${file2}`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${file2}`); - await toolbar.actions.closeMoreMenu(); - }); - }); - - describe('correct actions are displayed when selecting multiple files with different granular permissions', () => { - beforeEach(async (done) => { - await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); - done(); - }); - - it('on File Libraries - [C280476]', async () => { - await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); - await dataTable.waitForHeader(); - await dataTable.doubleClickOnRowByName(site); - await dataTable.waitForHeader(); - await dataTable.selectMultipleItems([ file1, file2 ]); - expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for selected files`); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for selected files`); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for selected files`); - const menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for selected files`); - expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for selected files`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - await toolbar.actions.closeMoreMenu(); - }); - - it('on Shared Files - [C280477]', async () => { - await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.SHARED_FILES); - await dataTable.waitForHeader(); - await dataTable.selectMultipleItems([ file1, file2 ]); - expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for selected files`); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for selected files`); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for selected files`); - const menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for selected files`); - expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for selected files`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - await toolbar.actions.closeMoreMenu(); - }); - - // disabled until ACA-1737 is done - xit('on Favorites - [C280478]', async () => { - await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); - await dataTable.waitForHeader(); - await dataTable.selectMultipleItems([ file1, file2 ]); - expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for selected files`); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for selected files`); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for selected files`); - const menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for selected files`); - expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for selected files`); - expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for selected files`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for selected files`); - await toolbar.actions.closeMoreMenu(); - }); - }); - - xit(''); - }); - describe('Personal Files', () => { - beforeAll(async (done) => { - await loginPage.loginWith(username); - done(); - }); - beforeEach(async (done) => { await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await dataTable.clearSelection(); await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.PERSONAL_FILES); await dataTable.waitForHeader(); done(); }); - afterAll(async (done) => { - await logoutPage.load(); - done(); - }); - it('actions are not displayed when no item is selected - [C213120]', async () => { expect(await toolbar.actions.isEmpty()).toBe(true, `actions displayed though nothing selected`); }); @@ -352,139 +151,49 @@ describe('Toolbar actions - single selection : ', () => { }); describe('File Libraries', () => { - beforeAll(async (done) => { - await apis.admin.sites.createSite(siteName, SITE_VISIBILITY.PUBLIC); - const docLibId = await apis.admin.sites.getDocLibId(siteName); - - await apis.admin.people.createUser({ username: username2 }); - await apis.admin.sites.addSiteMember(siteName, username, SITE_ROLES.SITE_MANAGER); - await apis.admin.sites.addSiteMember(siteName, username2, SITE_ROLES.SITE_CONSUMER); - - await apis.admin.nodes.createFile(fileAdmin, docLibId); - await apis.admin.nodes.createFolder(folderAdmin, docLibId); + beforeEach(async (done) => { + await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); + await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); + await dataTable.waitForHeader(); + await dataTable.doubleClickOnRowByName(siteName); + await dataTable.waitForHeader(); done(); }); - afterAll(async (done) => { - await apis.admin.sites.deleteSite(siteName); - done(); + it('actions are not displayed when no item is selected - [C280439]', async () => { + expect(await toolbar.actions.isEmpty()).toBe(true, `actions displayed though nothing selected`); }); - xit(''); - - describe('user is Manager', () => { - beforeAll(async (done) => { - await loginPage.loginWith(username); - done(); - }); - - beforeEach(async (done) => { - await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); - await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); - await dataTable.waitForHeader(); - await dataTable.doubleClickOnRowByName(siteName); - await dataTable.waitForHeader(); - done(); - }); - - afterAll(async (done) => { - await logoutPage.load(); - done(); - }); - - it('actions are not displayed when no item is selected - [C280439]', async () => { - expect(await toolbar.actions.isEmpty()).toBe(true, `actions displayed though nothing selected`); - }); - - it('correct actions appear when a file is selected - [C280440]', async () => { - await dataTable.selectItem(fileAdmin); - expect(await toolbar.actions.isEmpty()).toBe(false, `actions not displayed for ${fileAdmin}`); - expect(await toolbar.actions.isButtonPresent('View')).toBe(true, `View is not displayed for ${fileAdmin}`); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${fileAdmin}`); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${fileAdmin}`); - const menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${fileAdmin}`); - expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${fileAdmin}`); - expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${fileAdmin}`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${fileAdmin}`); - await toolbar.actions.closeMoreMenu(); - }); - - it('correct actions appear when a folder is selected - [C280441]', async () => { - await dataTable.selectItem(folderAdmin); - expect(await toolbar.actions.isEmpty()).toBe(false, `actions not displayed for ${folderAdmin}`); - expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for ${folderAdmin}`); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not enabled for ${folderAdmin}`); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(true, `Edit is not displayed for ${folderAdmin}`); - const menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${folderAdmin}`); - expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${folderAdmin}`); - expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${folderAdmin}`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${folderAdmin}`); - await toolbar.actions.closeMoreMenu(); - }); + it('correct actions appear when a file is selected - [C280440]', async () => { + await dataTable.selectItem(fileInSite); + expect(await toolbar.actions.isEmpty()).toBe(false, `actions not displayed for ${fileInSite}`); + expect(await toolbar.actions.isButtonPresent('View')).toBe(true, `View is not displayed for ${fileInSite}`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${fileInSite}`); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${fileInSite}`); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${fileInSite}`); + expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${fileInSite}`); + expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${fileInSite}`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${fileInSite}`); + await toolbar.actions.closeMoreMenu(); }); - describe('user is Consumer', () => { - beforeAll(async (done) => { - await loginPage.loginWith(username2); - done(); - }); - - beforeEach(async (done) => { - await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); - await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FILE_LIBRARIES); - await dataTable.waitForHeader(); - await dataTable.doubleClickOnRowByName(siteName); - await dataTable.waitForHeader(); - done(); - }); - - afterAll(async (done) => { - await logoutPage.load(); - done(); - }); - - it('actions are not displayed when no item is selected - [C280442]', async () => { - expect(await toolbar.actions.isEmpty()).toBe(true, `actions displayed though nothing selected`); - }); - - it('correct actions appear when a file is selected - [C280443]', async () => { - await dataTable.selectItem(fileAdmin); - expect(await toolbar.actions.isEmpty()).toBe(false, `actions not displayed for ${fileAdmin}`); - expect(await toolbar.actions.isButtonPresent('View')).toBe(true, `View is not displayed for ${fileAdmin}`); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not displayed for ${fileAdmin}`); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${fileAdmin}`); - const menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${fileAdmin}`); - expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${fileAdmin}`); - expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${fileAdmin}`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${fileAdmin}`); - await toolbar.actions.closeMoreMenu(); - }); - - it('correct actions appear when a folder is selected - [C280444]', async () => { - await dataTable.selectItem(folderAdmin); - expect(await toolbar.actions.isEmpty()).toBe(false, `actions not displayed for ${folderAdmin}`); - expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for ${folderAdmin}`); - expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not enabled for ${folderAdmin}`); - expect(await toolbar.actions.isButtonPresent('Edit')).toBe(false, `Edit is displayed for ${folderAdmin}`); - const menu = await toolbar.actions.openMoreMenu(); - expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${folderAdmin}`); - expect(await menu.isMenuItemPresent('Delete')).toBe(false, `Delete is displayed for ${folderAdmin}`); - expect(await menu.isMenuItemPresent('Move')).toBe(false, `Move is displayed for ${folderAdmin}`); - expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${folderAdmin}`); - await toolbar.actions.closeMoreMenu(); - }); + it('correct actions appear when a folder is selected - [C280441]', async () => { + await dataTable.selectItem(folderInSite); + expect(await toolbar.actions.isEmpty()).toBe(false, `actions not displayed for ${folderInSite}`); + expect(await toolbar.actions.isButtonPresent('View')).toBe(false, `View is displayed for ${folderInSite}`); + expect(await toolbar.actions.isButtonPresent('Download')).toBe(true, `Download is not enabled for ${folderInSite}`); + expect(await toolbar.actions.isButtonPresent('Edit')).toBe(true, `Edit is not displayed for ${folderInSite}`); + const menu = await toolbar.actions.openMoreMenu(); + expect(await menu.isMenuItemPresent('Copy')).toBe(true, `Copy is not displayed for ${folderInSite}`); + expect(await menu.isMenuItemPresent('Delete')).toBe(true, `Delete is not displayed for ${folderInSite}`); + expect(await menu.isMenuItemPresent('Move')).toBe(true, `Move is not displayed for ${folderInSite}`); + expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${folderInSite}`); + await toolbar.actions.closeMoreMenu(); }); }); describe('Shared Files', () => { - beforeAll(async (done) => { - await loginPage.loginWith(username); - done(); - }); - beforeEach(async (done) => { await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.SHARED_FILES); @@ -492,16 +201,11 @@ describe('Toolbar actions - single selection : ', () => { done(); }); - afterAll(async (done) => { - await logoutPage.load(); - done(); - }); - it('actions are not displayed when no item is selected - [C280445]', async () => { expect(await toolbar.actions.isEmpty()).toBe(true, `actions displayed though nothing selected`); }); - it('correct actions appear when a file is selected - [C280446]', async () => { + it('correct actions appear when a file is selected - [C286265]', async () => { await page.dataTable.selectItem(fileUser); expect(await toolbar.actions.isEmpty()).toBe(false, `actions not displayed for ${fileUser}`); expect(await toolbar.actions.isButtonPresent('View')).toBe(true, `View is not displayed for ${fileUser}`); @@ -514,14 +218,10 @@ describe('Toolbar actions - single selection : ', () => { expect(await menu.isMenuItemPresent('Favorite')).toBe(true, `Favorite is not displayed for ${fileUser}`); await toolbar.actions.closeMoreMenu(); }); + }); describe('Recent Files', () => { - beforeAll(async (done) => { - await loginPage.loginWith(username); - done(); - }); - beforeEach(async (done) => { await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.RECENT_FILES); @@ -529,11 +229,6 @@ describe('Toolbar actions - single selection : ', () => { done(); }); - afterAll(async (done) => { - await logoutPage.load(); - done(); - }); - it('actions are not displayed when no item is selected - [C280447]', async () => { expect(await toolbar.actions.isEmpty()).toBe(true, `actions displayed though nothing selected`); }); @@ -554,11 +249,6 @@ describe('Toolbar actions - single selection : ', () => { }); describe('Favorites', () => { - beforeAll(async (done) => { - await loginPage.loginWith(username); - done(); - }); - beforeEach(async (done) => { await browser.actions().sendKeys(protractor.Key.ESCAPE).perform(); await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.FAVORITES); @@ -566,11 +256,6 @@ describe('Toolbar actions - single selection : ', () => { done(); }); - afterAll(async (done) => { - await logoutPage.load(); - done(); - }); - it('actions are not displayed when no item is selected - [C280449]', async () => { expect(await toolbar.actions.isEmpty()).toBe(true, `actions displayed though nothing selected`); }); @@ -605,13 +290,6 @@ describe('Toolbar actions - single selection : ', () => { }); describe('Trash', () => { - beforeAll(async (done) => { - await apis.user.nodes.deleteNodeById(fileForDeleteId, false); - await apis.user.nodes.deleteNodeById(folderForDeleteId, false); - await loginPage.loginWith(username); - done(); - }); - beforeEach(async (done) => { await browser.actions().sendKeys(protractor.Key.ESCAPE); await page.sidenav.navigateToLinkByLabel(SIDEBAR_LABELS.TRASH); @@ -619,15 +297,6 @@ describe('Toolbar actions - single selection : ', () => { done(); }); - afterAll(async (done) => { - await Promise.all([ - apis.user.trashcan.permanentlyDelete(fileForDeleteId), - apis.user.trashcan.permanentlyDelete(folderForDeleteId), - logoutPage.load() - ]); - done(); - }); - it('actions are not displayed when no item is selected - [C280452]', async () => { expect(await toolbar.actions.isEmpty()).toBe(true, `actions displayed though nothing selected`); });