amend implicit returns

e2e/utilities/repo-client/apis/favorites/favorites-api.ts

@@ -26,7 +26,7 @@
 import { RepoApi } from '../repo-api';
 import { RepoClient } from './../../repo-client';
 import { Utils } from '../../../../utilities/utils';
-import { FavoritesApi as AdfFavoritesApi, SitesApi as AdfSiteApi } from '@alfresco/js-api';
+import { FavoritesApi as AdfFavoritesApi, SitesApi as AdfSiteApi, FavoriteEntry } from '@alfresco/js-api';
 
 export class FavoritesApi extends RepoApi {
     favoritesApi = new AdfFavoritesApi(this.alfrescoJsApi);
@@ -48,7 +48,7 @@ export class FavoritesApi extends RepoApi {
         return await this.favoritesApi.createFavorite('-me-', data);
     }
 
-    async addFavoriteById(nodeType: 'file' | 'folder' | 'site', id: string) {
+    async addFavoriteById(nodeType: 'file' | 'folder' | 'site', id: string): Promise<FavoriteEntry|null> {
         let guid;
         await this.apiAuth();
 
@@ -68,6 +68,7 @@ export class FavoritesApi extends RepoApi {
           return await this.favoritesApi.createFavorite('-me-', data);
         } catch (error) {
           console.log('--- add favorite by id catch ');
+          return null;
         }
     }
 

e2e/utilities/repo-client/apis/shared-links/shared-links-api.ts

@@ -25,7 +25,7 @@
 
 import { RepoApi } from '../repo-api';
 import { Utils } from '../../../../utilities/utils';
-import { SharedlinksApi as AdfSharedlinksApi } from '@alfresco/js-api';
+import { SharedlinksApi as AdfSharedlinksApi, SharedLinkEntry } from '@alfresco/js-api';
 
 export class SharedLinksApi extends RepoApi {
     sharedlinksApi = new AdfSharedlinksApi(this.alfrescoJsApi);
@@ -34,7 +34,7 @@ export class SharedLinksApi extends RepoApi {
         super(username, password);
     }
 
-    async shareFileById(id: string, expireDate?: Date) {
+    async shareFileById(id: string, expireDate?: Date): Promise<SharedLinkEntry|null> {
       try {
         await this.apiAuth();
         const data = {
@@ -44,6 +44,7 @@ export class SharedLinksApi extends RepoApi {
       return await this.sharedlinksApi.createSharedLink(data);
       } catch (error) {
         console.log('---- shareFileById error: ', error);
+        return null;
       }
     }
 

e2e/utilities/repo-client/apis/sites/sites-api.ts

@@ -24,7 +24,7 @@
  */
 
 import { RepoApi } from '../repo-api';
-import { SiteBody, SiteMemberRoleBody, SiteMemberBody } from '@alfresco/js-api';
+import { SiteBody, SiteMemberRoleBody, SiteMemberBody, SiteEntry, SiteMembershipRequestEntry } from '@alfresco/js-api';
 import { SITE_VISIBILITY } from '../../../../configs';
 import { Utils } from '../../../../utilities/utils';
 import { SitesApi as AdfSiteApi } from '@alfresco/js-api';
@@ -66,7 +66,7 @@ export class SitesApi extends RepoApi {
       return site.entry.title;
     }
 
-    async createSite(title: string, visibility?: string, description?: string, siteId?: string) {
+    async createSite(title: string, visibility?: string, description?: string, siteId?: string): Promise<SiteEntry|null> {
         const site = <SiteBody>{
             title,
             visibility: visibility || SITE_VISIBILITY.PUBLIC,
@@ -79,6 +79,7 @@ export class SitesApi extends RepoApi {
         return await this.sitesApi.createSite(site);
         } catch (error) {
           console.log('=== create site catch: ', error);
+          return null;
         }
     }
 
@@ -134,7 +135,7 @@ export class SitesApi extends RepoApi {
         return await this.sitesApi.deleteSiteMembership(siteId, userId);
     }
 
-    async requestToJoin(siteId: string) {
+    async requestToJoin(siteId: string): Promise<SiteMembershipRequestEntry|null> {
         const body = {
           id: siteId
         };
@@ -143,6 +144,7 @@ export class SitesApi extends RepoApi {
           return await this.sitesApi.createSiteMembershipRequestForPerson('-me-', body);
         } catch (error) {
           console.log('====== requestToJoin catch ', error);
+          return null;
         };
     }