From 2d5b9ea7081de10962df50748ee7e65bbf8aa3b5 Mon Sep 17 00:00:00 2001
From: Denys Vuika <denys.vuika@gmail.com>
Date: Tue, 6 Aug 2024 12:47:17 -0400
Subject: [PATCH] simplify ngrx effect registration (#4008)

---
 .../src/lib/store/app-store.module.ts         |  7 ++--
 .../lib/store/effects/node.effects.spec.ts    | 10 ++++--
 projects/aca-shared/store/src/public-api.ts   |  2 --
 projects/aca-shared/store/src/store.module.ts | 33 -------------------
 4 files changed, 12 insertions(+), 40 deletions(-)
 delete mode 100644 projects/aca-shared/store/src/store.module.ts

diff --git a/projects/aca-content/src/lib/store/app-store.module.ts b/projects/aca-content/src/lib/store/app-store.module.ts
index c2c84a142..02297d68b 100644
--- a/projects/aca-content/src/lib/store/app-store.module.ts
+++ b/projects/aca-content/src/lib/store/app-store.module.ts
@@ -27,7 +27,7 @@ import { StoreModule } from '@ngrx/store';
 import { appReducer } from './reducers/app.reducer';
 import { StoreRouterConnectingModule, FullRouterStateSerializer } from '@ngrx/router-store';
 import { EffectsModule } from '@ngrx/effects';
-import { SharedStoreModule } from '@alfresco/aca-shared/store';
+import { RouterEffects, SnackbarEffects } from '@alfresco/aca-shared/store';
 import {
   AppEffects,
   NodeEffects,
@@ -58,7 +58,6 @@ import { INITIAL_STATE } from './initial-state';
       serializer: FullRouterStateSerializer,
       stateKey: 'router'
     }),
-    SharedStoreModule,
     EffectsModule.forRoot([
       AppEffects,
       NodeEffects,
@@ -69,7 +68,9 @@ import { INITIAL_STATE } from './initial-state';
       UploadEffects,
       FavoriteEffects,
       TemplateEffects,
-      ContextMenuEffects
+      ContextMenuEffects,
+      SnackbarEffects,
+      RouterEffects
     ])
   ]
 })
diff --git a/projects/aca-content/src/lib/store/effects/node.effects.spec.ts b/projects/aca-content/src/lib/store/effects/node.effects.spec.ts
index be2b97208..2488c934f 100644
--- a/projects/aca-content/src/lib/store/effects/node.effects.spec.ts
+++ b/projects/aca-content/src/lib/store/effects/node.effects.spec.ts
@@ -41,12 +41,13 @@ import {
   PrintFileAction,
   PurgeDeletedNodesAction,
   RestoreDeletedNodesAction,
+  RouterEffects,
   SetCurrentFolderAction,
   SetInfoDrawerStateAction,
   SetSelectedNodesAction,
-  SharedStoreModule,
   ShareNodeAction,
   ShowLoaderAction,
+  SnackbarEffects,
   UndoDeleteNodesAction,
   UnlockWriteAction,
   UnshareNodesAction
@@ -67,7 +68,12 @@ describe('NodeEffects', () => {
 
   beforeEach(() => {
     TestBed.configureTestingModule({
-      imports: [AppTestingModule, SharedStoreModule, EffectsModule.forRoot([NodeEffects, ViewerEffects]), MatDialogModule, MatSnackBarModule],
+      imports: [
+        AppTestingModule,
+        EffectsModule.forRoot([NodeEffects, ViewerEffects, SnackbarEffects, RouterEffects]),
+        MatDialogModule,
+        MatSnackBarModule
+      ],
       providers: [RenditionService]
     });
 
diff --git a/projects/aca-shared/store/src/public-api.ts b/projects/aca-shared/store/src/public-api.ts
index 98961ec53..e23673eaf 100644
--- a/projects/aca-shared/store/src/public-api.ts
+++ b/projects/aca-shared/store/src/public-api.ts
@@ -50,5 +50,3 @@ export * from './models/modal-configuration';
 export * from './selectors/app.selectors';
 
 export * from './states/app.state';
-
-export * from './store.module';
diff --git a/projects/aca-shared/store/src/store.module.ts b/projects/aca-shared/store/src/store.module.ts
deleted file mode 100644
index dcc3e9ed1..000000000
--- a/projects/aca-shared/store/src/store.module.ts
+++ /dev/null
@@ -1,33 +0,0 @@
-/*!
- * Copyright © 2005-2024 Hyland Software, Inc. and its affiliates. All rights reserved.
- *
- * Alfresco Example Content Application
- *
- * This file is part of the Alfresco Example Content Application.
- * If the software was purchased under a paid Alfresco license, the terms of
- * the paid license agreement will prevail. Otherwise, the software is
- * provided under the following open source license terms:
- *
- * The Alfresco Example Content Application is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Lesser General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * The Alfresco Example Content Application is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * from Hyland Software. If not, see <http://www.gnu.org/licenses/>.
- */
-
-import { NgModule } from '@angular/core';
-import { EffectsModule } from '@ngrx/effects';
-import { SnackbarEffects } from './effects/snackbar.effects';
-import { RouterEffects } from './effects/router.effects';
-
-@NgModule({
-  imports: [EffectsModule.forFeature([SnackbarEffects, RouterEffects])]
-})
-export class SharedStoreModule {}