inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2026-09-16 18:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-12817] copilot review fixes 1

Browse Source
This commit is contained in:
Adam Świderski
2026-09-16 14:57:37 +02:00
committed by Adam Świderski
parent 86e1b33dec
commit 340550904d
6 changed files with 29 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/aca-playwright-shared/src/api/nodes-api.ts
+2 -2
View File
@@ -214,7 +214,7 @@ export class NodesApi {
await this.apiService.nodes.checkoutNode(nodeId);
}
} catch (error) {
logger.error(`${this.constructor.name} ${this.checkoutNodes.name}: ${JSON.stringify(error)}`);
logger.error(`${this.constructor.name} ${this.checkoutNodes.name}: ${error instanceof Error ? error.message : JSON.stringify(error)}`);
}
}
@@ -224,7 +224,7 @@ export class NodesApi {
await this.apiService.nodes.cancelCheckoutNode(nodeId);
}
} catch (error) {
logger.error(`${this.constructor.name} ${this.cancelCheckout.name}: ${JSON.stringify(error)}`);
logger.error(`${this.constructor.name} ${this.cancelCheckout.name}: ${error instanceof Error ? error.message : JSON.stringify(error)}`);
}
}
projects/aca-playwright-shared/src/page-objects/pages/personal-files.page.ts
+2 -4
View File
@@ -101,11 +101,9 @@ export class PersonalFilesPage extends BasePage {
}
async copyOrMoveContentInDatatable(sourceFileList: string[], destinationName: string, operation = 'Copy'): Promise<void> {
await this.page.keyboard.down('Control');
for (const sourceName of sourceFileList) {
await this.dataTable.selectItems(sourceName);
for (const itemToSelect of sourceFileList) {
await this.dataTable.selectItems(itemToSelect);
}
await this.page.keyboard.up('Control');
await this.clickMoreActionsButton(operation);
await this.contentNodeSelector.selectDestination(destinationName);
await this.contentNodeSelector.actionButton.click();
projects/aca-playwright-shared/src/resources/test-data/test-data-permissions.ts
+3 -3
View File
@@ -81,7 +81,7 @@ const searchConsumerSharedToolbarPrimary = ['Shared Link Settings', 'Download',
const consumerToolbarMore = ['Favorite', 'Copy', 'Manage Versions'];
const consumerFavToolbarMore = ['Remove Favorite', 'Copy', 'Manage Versions'];
export const collaboratorToolbarPrimary = ['Shared Link Settings', 'View', 'View Details', 'More Actions'];
export const collaboratorToolbarPrimary = ['View', 'View Details', 'More Actions'];
export const collaboratorEditRowToolbarMore = [
'Edit Offline',
'Upload New Version',
@@ -114,7 +114,7 @@ export const collaboratorDocToolbarMore = [
'Edit Aspects',
'Permissions'
];
export const collaboratorLockCurrentUserToolbarMore = ['Cancel Editing', 'Upload New Version', 'Remove Favorite', 'Copy'];
export const collaboratorLockCurrentUserToolbarMore = ['Cancel Editing', 'Upload New Version', 'Copy'];
export const collaboratorLockOtherUserToolbarMore = ['Cancel Editing', 'Remove Favorite', 'Move', 'Copy', 'Permissions'];
export const collaboratorLockOtherUserSearchToolbarMore = ['Cancel Editing', 'Remove Favorite', 'Copy', 'Permissions'];
@@ -367,7 +367,7 @@ export const fileSharedFavLocked = buildFileData((fileRandom) => `file-${fileRan
searchToolbarPrimary: searchConsumerSharedToolbarPrimary
});
export const fileLockedByUser = buildNode((fileRandom) => `file-${fileRandom}-my-locked.txt`);
export const fileLockedByUser = buildNode((fileRandom) => `file-${fileRandom}-my-locked`);
// ---- non-versionable file (no cm:versionable aspect) ----