diff --git a/.travis.yml b/.travis.yml index 830eefc6f..5da86aa86 100644 --- a/.travis.yml +++ b/.travis.yml @@ -85,6 +85,11 @@ jobs: script: npm ci && ng test aca-settings cache: false + - stage: Quality and Unit tests + name: 'Unit tests: aca-folder-rules' + script: npm ci && ng test aca-folder-rules + cache: false + - stage: Quality and Unit tests name: 'Unit tests: ACA' script: diff --git a/projects/aca-folder-rules/karma.conf.js b/projects/aca-folder-rules/karma.conf.js index d81c2eb0a..ed84269d4 100644 --- a/projects/aca-folder-rules/karma.conf.js +++ b/projects/aca-folder-rules/karma.conf.js @@ -26,7 +26,7 @@ module.exports = function (config) { logLevel: config.LOG_INFO, autoWatch: true, browsers: ['Chrome'], - singleRun: false, + singleRun: true, restartOnFileChange: true }); }; diff --git a/projects/aca-folder-rules/src/lib/folder-rules.rules.spec.ts b/projects/aca-folder-rules/src/lib/folder-rules.rules.spec.ts index 7ee2283d6..4688c4021 100644 --- a/projects/aca-folder-rules/src/lib/folder-rules.rules.spec.ts +++ b/projects/aca-folder-rules/src/lib/folder-rules.rules.spec.ts @@ -24,9 +24,9 @@ */ import { AcaRuleContext } from '@alfresco/aca-shared/rules'; -import { isFolderRulesEnabled, canCreateFolderRule, canLinkFolderRule } from './folder-rules.rules'; +import { isFolderRulesEnabled, canManageFolderRules } from './folder-rules.rules'; -describe('Folder Rules', () => { +describe('Folder Rules Visibility Rules', () => { describe('isFolderRulesEnabled', () => { it('should have the feature enabled', () => { const context: any = { @@ -51,7 +51,7 @@ describe('Folder Rules', () => { }); }); - describe('canCreateFolderRule', () => { + describe('canManageFolderRules', () => { let context: AcaRuleContext; beforeEach(() => { @@ -72,47 +72,14 @@ describe('Folder Rules', () => { }); it('should allow creating a rule for the selected folder', () => { - const result = canCreateFolderRule(context); + const result = canManageFolderRules(context); expect(result).toEqual(true); }); it('should not allow creating a rule if no folder selected', () => { context.selection.folder = null; - const result = canCreateFolderRule(context); - expect(result).toEqual(false); - }); - }); - - describe('canLinkFolderRule', () => { - let context: AcaRuleContext; - - beforeEach(() => { - context = { - appConfig: { - get: () => true - }, - selection: { - folder: {} as any - }, - navigation: { - url: '/personal-files' - }, - permissions: { - check: () => true - } - } as any; - }); - - it('should allow linking rule for the selected folder', () => { - const result = canLinkFolderRule(context); - expect(result).toEqual(true); - }); - - it('should not allow linking rule if no folder selected', () => { - context.selection.folder = null; - - const result = canLinkFolderRule(context); + const result = canManageFolderRules(context); expect(result).toEqual(false); }); });