add missing typings to code (#1050)

* remove unused parameters

* add missing types

* add missing typing information

* fix tests

* restore old code

src/app/components/search/search-input/search-input.component.ts

@@ -50,12 +50,10 @@ import { Subject } from 'rxjs';
 import { SearchLibrariesQueryBuilderService } from '../search-libraries-results/search-libraries-query-builder.service';
 import { MatMenuTrigger } from '@angular/material';
 import { AppConfigService } from '@alfresco/adf-core';
-
-export enum SearchOptionIds {
-  Files = 'content',
-  Folders = 'folder',
-  Libraries = 'libraries'
-}
+import {
+  SearchOptionModel,
+  SearchOptionIds
+} from '../../../store/models/searchOption.model';
 
 @Component({
   selector: 'aca-search-input',
@@ -69,10 +67,10 @@ export class SearchInputComponent implements OnInit, OnDestroy {
   hasNewChange = false;
   navigationTimer: any;
   has400LibraryError = false;
-  searchOnChange;
+  searchOnChange: boolean;
 
-  searchedWord = null;
-  searchOptions: Array<any> = [
+  searchedWord: string = null;
+  searchOptions: Array<SearchOptionModel> = [
     {
       id: SearchOptionIds.Files,
       key: 'SEARCH.INPUT.FILES',

src/app/components/search/search-libraries-results/search-libraries-query-builder.service.ts

@@ -28,6 +28,14 @@ import { Injectable } from '@angular/core';
 import { SitePaging } from '@alfresco/js-api';
 import { Subject } from 'rxjs';
 
+export interface LibrarySearchQuery {
+  term: string;
+  opts: {
+    skipCount: number;
+    maxItems: number;
+  };
+}
+
 @Injectable({
   providedIn: 'root'
 })
@@ -65,7 +73,7 @@ export class SearchLibrariesQueryBuilderService {
     }
   }
 
-  buildQuery(): any {
+  buildQuery(): LibrarySearchQuery {
     const query = this.userQuery;
     if (query && query.length > 1) {
       const resultQuery = {
@@ -80,7 +88,7 @@ export class SearchLibrariesQueryBuilderService {
     return null;
   }
 
-  private findLibraries(libraryQuery): Promise<SitePaging> {
+  private findLibraries(libraryQuery: LibrarySearchQuery): Promise<SitePaging> {
     return this.alfrescoApiService
       .getInstance()
       .core.queriesApi.findSites(libraryQuery.term, libraryQuery.opts)

src/app/components/search/search-results-row/search-results-row.component.ts

@@ -108,7 +108,7 @@ export class SearchResultsRowComponent implements OnInit {
     this.store.dispatch(new NavigateToFolder(this.node));
   }
 
-  private getValue(path) {
+  private getValue(path: string) {
     return path
       .replace('["', '.')
       .replace('"]', '')