mirror of
https://github.com/Alfresco/alfresco-content-app.git
synced 2025-07-24 17:31:52 +00:00
Ng16 migration (#4104)
* Updated ACA to Angular 16 * Updated Subject types to void in cases where no values was being emitted * [ACS-8375] [ACA] [General] Selecting a checkbox gives a light green color on focus (#3937) * [ACS-8376] [ACA] [[Manage Rules] Multiple UI issues in create rule dialog (#3943) * [ACS-8378] Fixed inputs having fill styling throughout ACA (#3944) * [ACS-8378] Mat form fields now have white background instead of grey * [ACS-8378] Fixed issue where the background of the boolean mode control dropdown was appearing as white when in condition groups. Labels in create rules window are now black * [ACS-8415] Sidenav labels are now grey (#3946) * [ACS-8379] Fixed issue where icons in menus were coming as black after ng16 upgrade (#3935) * refactor DI into inject() methods (#3954) * Cleanup and remove unneeded commits and changes * Fix eslint (#4032) * [REVERTABLE] - this is a quick temp fix to be able to release ACA with NG16 * [MIGRATION] - added some fix after rebase * Refactor AppEffects (#4079) * Refactor effects to use inject() (#4080) * Refactor effects to use inject() (#4081) * Rebase fixes * [ACS-8739] Fix e2e tests (#4106) * Updated ADF deps * Fixed unit passing mandatory value * Updated ADF version * Updated ADF version * [ACS-8743] [ADW] click on search button open a blank page (#4125) * Updating ADF dep * Updating ADF * Refactor injections in effects (#4137) * Upstream dependencies * Refactor SearchAiEffects * Updating ADF and rebased * Rebased and updated * Rebased and updated * Updating deps * Updating deps * Updating deps * Rebased and updated deps * Pushing package-lock.json * Moved the JWT storage injection token at app level * Updated dependencies * Fixed unit test * Improved solutio for token with no need to set it explicitly * Updating dependencies * Updated package version * Updated ADF deps * Use latest ADF --------- Co-authored-by: swapnil.verma <swapnil.verma@globallogic.com> Co-authored-by: swapnil-verma-gl <92505353+swapnil-verma-gl@users.noreply.github.com> Co-authored-by: VitoAlbano <vito.albano.123@gmail.com> Co-authored-by: Ehsan Rezaei <ehsan.rezaei@hyland.com> Co-authored-by: MichalKinas <michal.kinas@hyland.com>
This commit is contained in:
committed by
GitHub
parent
e97fd97e7c
commit
3fbdc93c51
@@ -25,7 +25,7 @@
|
||||
import { ContentActionRef } from '@alfresco/adf-extensions';
|
||||
import { AppStore, getSearchItemsTotalCount } from '@alfresco/aca-shared/store';
|
||||
import { CommonModule } from '@angular/common';
|
||||
import { Component, Input, OnDestroy, OnInit, ViewEncapsulation } from '@angular/core';
|
||||
import { Component, inject, Input, OnDestroy, OnInit, ViewEncapsulation } from '@angular/core';
|
||||
import { MatSelectModule } from '@angular/material/select';
|
||||
import { Store } from '@ngrx/store';
|
||||
import { TranslateModule } from '@ngx-translate/core';
|
||||
@@ -50,11 +50,12 @@ export class BulkActionsDropdownComponent implements OnInit, OnDestroy {
|
||||
tooltip: string;
|
||||
bulkSelectControl = new FormControl();
|
||||
|
||||
private readonly totalItems$: Observable<number> = this.store.select(getSearchItemsTotalCount);
|
||||
private readonly store = inject<Store<AppStore>>(Store);
|
||||
private readonly translationService = inject(TranslationService);
|
||||
private readonly extensions = inject(AppExtensionService);
|
||||
|
||||
private readonly onDestroy$ = new Subject();
|
||||
|
||||
constructor(private store: Store<AppStore>, private translationService: TranslationService, private extensions: AppExtensionService) {}
|
||||
|
||||
private readonly totalItems$: Observable<number> = this.store.select(getSearchItemsTotalCount);
|
||||
ngOnInit() {
|
||||
this.totalItems$
|
||||
.pipe(
|
||||
@@ -88,7 +89,7 @@ export class BulkActionsDropdownComponent implements OnInit, OnDestroy {
|
||||
}
|
||||
|
||||
ngOnDestroy() {
|
||||
this.onDestroy$.next();
|
||||
this.onDestroy$.next(true);
|
||||
this.onDestroy$.complete();
|
||||
}
|
||||
|
||||
|
@@ -34,7 +34,7 @@ export class OutsideEventDirective implements OnInit, OnDestroy {
|
||||
private subscriptions: Subscription[] = [];
|
||||
|
||||
@Output()
|
||||
clickOutside: EventEmitter<null> = new EventEmitter();
|
||||
clickOutside: EventEmitter<void> = new EventEmitter();
|
||||
|
||||
ngOnInit() {
|
||||
this.subscriptions = this.subscriptions.concat([
|
||||
|
@@ -67,7 +67,7 @@ import { FileSizePipe, InfoDrawerButtonsDirective } from '@alfresco/adf-core';
|
||||
export class DetailsComponent extends PageComponent implements OnInit, OnDestroy {
|
||||
nodeId: string;
|
||||
isLoading: boolean;
|
||||
onDestroy$ = new Subject<boolean>();
|
||||
onDestroy$ = new Subject<void>();
|
||||
activeTab = 1;
|
||||
aspectActions: Array<ContentActionRef> = [];
|
||||
nodeIcon: string;
|
||||
|
@@ -138,12 +138,12 @@ describe('FavoriteLibrariesComponent', () => {
|
||||
});
|
||||
|
||||
it('should reload on libraryDeleted action', () => {
|
||||
appHookService.libraryDeleted.next();
|
||||
appHookService.libraryDeleted.next('');
|
||||
expect(contentApiService.getFavoriteLibraries).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it('should reload on libraryUpdated action', () => {
|
||||
appHookService.libraryUpdated.next();
|
||||
appHookService.libraryUpdated.next({} as any);
|
||||
expect(contentApiService.getFavoriteLibraries).toHaveBeenCalled();
|
||||
});
|
||||
|
||||
@@ -158,7 +158,7 @@ describe('FavoriteLibrariesComponent', () => {
|
||||
});
|
||||
|
||||
it('should reload on libraryLeft action', () => {
|
||||
appHookService.libraryLeft.next();
|
||||
appHookService.libraryLeft.next({} as any);
|
||||
expect(contentApiService.getFavoriteLibraries).toHaveBeenCalled();
|
||||
});
|
||||
});
|
||||
|
@@ -79,6 +79,10 @@
|
||||
width: 100%;
|
||||
user-select: none;
|
||||
|
||||
.aca-action-button__label {
|
||||
color: var(--theme-action-button-text-color);
|
||||
}
|
||||
|
||||
&:hover .aca-action-button__label {
|
||||
color: var(--theme-sidenav-active-text-color);
|
||||
}
|
||||
|
@@ -57,7 +57,7 @@ import { MatMenuModule } from '@angular/material/menu';
|
||||
})
|
||||
export class ToggleFavoriteLibraryComponent implements OnInit, OnDestroy {
|
||||
library;
|
||||
private onDestroy$: Subject<boolean> = new Subject<boolean>();
|
||||
private onDestroy$: Subject<void> = new Subject<void>();
|
||||
|
||||
constructor(private store: Store<AppStore>, private appHookService: AppHookService, private router: Router) {}
|
||||
|
||||
@@ -78,7 +78,7 @@ export class ToggleFavoriteLibraryComponent implements OnInit, OnDestroy {
|
||||
}
|
||||
|
||||
ngOnDestroy() {
|
||||
this.onDestroy$.next(true);
|
||||
this.onDestroy$.next();
|
||||
this.onDestroy$.complete();
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user