minor code reorg for Viewer and Extensions (#554)

* self-registering extension module

* move printing service to the preview chunk

src/app/app.module.ts

@@ -24,7 +24,7 @@
  */
 
 import { BrowserModule } from '@angular/platform-browser';
-import { NgModule, APP_INITIALIZER } from '@angular/core';
+import { NgModule } from '@angular/core';
 import { RouterModule, RouteReuseStrategy } from '@angular/router';
 import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
 import { FormsModule, ReactiveFormsModule } from '@angular/forms';
@@ -69,8 +69,6 @@ import { SearchResultsRowComponent } from './components/search/search-results-ro
 import { NodePermissionsDialogComponent } from './dialogs/node-permissions/node-permissions.dialog';
 import { PermissionsManagerComponent } from './components/permission-manager/permissions-manager.component';
 import { AppRouteReuseStrategy } from './app.routes.strategy';
-import { ViewUtilService} from './services/view-util.service';
-import { ExtensionService } from './extensions/extension.service';
 import { AppInfoDrawerModule } from './components/info-drawer/info.drawer.module';
 import { DirectivesModule } from './directives/directives.module';
 import { ToggleInfoDrawerComponent } from './components/toolbar/toggle-info-drawer/toggle-info-drawer.component';
@@ -78,9 +76,6 @@ import { DocumentDisplayModeComponent } from './components/toolbar/document-disp
 import { ToggleFavoriteComponent } from './components/toolbar/toggle-favorite/toggle-favorite.component';
 import { ContextMenuModule } from './components/context-menu/context-menu.module';
 
-export function setupExtensionServiceFactory(service: ExtensionService): Function {
-    return () => service.load();
-}
 @NgModule({
     imports: [
         BrowserModule,
@@ -147,14 +142,7 @@ export function setupExtensionServiceFactory(service: ExtensionService): Functio
         NodePermissionService,
         ProfileResolver,
         ExperimentalGuard,
-        ContentApiService,
-        {
-            provide: APP_INITIALIZER,
-            useFactory: setupExtensionServiceFactory,
-            deps: [ExtensionService],
-            multi: true
-        },
-        ViewUtilService
+        ContentApiService
     ],
     entryComponents: [
         LibraryDialogComponent,

src/app/components/preview/preview.component.ts

@@ -33,8 +33,9 @@ import { PageComponent } from '../page.component';
 import { ContentApiService } from '../../services/content-api.service';
 import { ExtensionService } from '../../extensions/extension.service';
 import { ContentManagementService } from '../../services/content-management.service';
-import { ViewUtilService } from '../../services/view-util.service';
 import { ContentActionRef } from '../../extensions/action.extensions';
+import { ViewUtilService } from './view-util.service';
+
 @Component({
     selector: 'app-preview',
     templateUrl: 'preview.component.html',

src/app/components/preview/preview.module.ts

@@ -27,11 +27,12 @@ import { CoreModule } from '@alfresco/adf-core';
 import { CommonModule } from '@angular/common';
 import { NgModule } from '@angular/core';
 import { Routes, RouterModule } from '@angular/router';
+import { ContentDirectiveModule } from '@alfresco/adf-content-services';
 import { CoreExtensionsModule } from '../../extensions/core.extensions.module';
 import { DirectivesModule } from '../../directives/directives.module';
 import { AppInfoDrawerModule } from '../info-drawer/info.drawer.module';
 import { PreviewComponent } from './preview.component';
-import { ContentDirectiveModule } from '@alfresco/adf-content-services';
+import { ViewUtilService } from './view-util.service';
 
 import * as pdfjsLib from 'pdfjs-dist';
 pdfjsLib.PDFJS.workerSrc = 'pdf.worker.js';
@@ -57,6 +58,9 @@ const routes: Routes = [
     declarations: [
         PreviewComponent,
     ],
+    providers: [
+        ViewUtilService
+    ],
     exports: [
         PreviewComponent
     ]

src/app/components/preview/view-util.service.ts

@@ -1,7 +1,7 @@
 import {Injectable} from '@angular/core';
 import {AlfrescoApiService, LogService} from '@alfresco/adf-core';
 import {RenditionEntry} from 'alfresco-js-api';
-import {ContentApiService} from './content-api.service';
+import {ContentApiService} from './../../services/content-api.service';
 
 @Injectable()
 export class ViewUtilService {

src/app/extensions/core.extensions.module.ts

@@ -38,8 +38,6 @@ import { ToggleFavoriteComponent } from '../components/toolbar/toggle-favorite/t
 import { ToolbarButtonComponent } from './components/toolbar/toolbar-button.component';
 
 export function setupExtensions(extensions: ExtensionService): Function {
-    return () =>
-        new Promise(resolve => {
     extensions.setComponents({
         'app.layout.main': LayoutComponent,
         'app.components.trashcan': TrashcanComponent,
@@ -81,8 +79,7 @@ export function setupExtensions(extensions: ExtensionService): Function {
         'app.navigation.isNotSearchResults': nav.isNotSearchResults
     });
 
-            resolve(true);
-        });
+    return () => extensions.load();
 }
 
 @NgModule({

src/app/testing/app-testing.module.ts

@@ -60,7 +60,7 @@ import { NodeActionsService } from '../services/node-actions.service';
 import { NodePermissionService } from '../services/node-permission.service';
 import { ContentApiService } from '../services/content-api.service';
 import { ExtensionService } from '../extensions/extension.service';
-import {ViewUtilService} from '../services/view-util.service';
+import { ViewUtilService } from '../components/preview/view-util.service';
 
 @NgModule({
     imports: [