Optimize e2e framework (#1428)

* reduce breadcrumb page

* imrpove readability of code

* reduce data-table page size

* reduce datetime-picker code

* fix datatable page

* header and info drawer

* update datatable page

* toolbar cleanup

* more test components cleanup

* even move component cleanup

* move wait utils to the Utils

* unified waits

* cleanup menu page

* code fixes

* fix code

* code improvements

* rename api

* fix code

* fix code

* cleanup dialog pages

* more fixes and dead code removal

* code fixes

* try to fix the flaky teset

* fix code

* fix code

* update code

* fix lint

* unified text input

* fix lint

* add missing await

* reduce the wrapper method around clear text

* resolve element value

Co-authored-by: Cilibiu Bogdan <bogdan.cilibiu@ness.com>

e2e/components/component.ts

@@ -23,21 +23,60 @@
  * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
  */
 
-import { ElementFinder, ExpectedConditions as EC, browser } from 'protractor';
-import { BROWSER_WAIT_TIMEOUT } from '../configs';
+import {
+  ElementFinder,
+  browser,
+  by,
+  ElementArrayFinder,
+  ProtractorBrowser
+} from 'protractor';
+import { waitForPresence } from '../utilities/utils';
 
 export abstract class Component {
   component: ElementFinder;
 
+  protected byCss(
+    css: string,
+    root: ElementFinder | ProtractorBrowser = this.component
+  ): ElementFinder {
+    return root.element(by.css(css));
+  }
+
+  protected byCssText(
+    css: string,
+    text: string,
+    root: ElementFinder | ProtractorBrowser = this.component
+  ): ElementFinder {
+    return root.element(by.cssContainingText(css, text));
+  }
+
+  protected byId(
+    css: string,
+    root: ElementFinder | ProtractorBrowser = this.component
+  ): ElementFinder {
+    return root.element(by.id(css));
+  }
+
+  protected allByCss(
+    css: string,
+    root: ElementFinder | ProtractorBrowser = this.component
+  ): ElementArrayFinder {
+    return root.all(by.css(css));
+  }
+
   constructor(selector: string, ancestor?: string) {
     const locator = selector;
 
     this.component = ancestor
-      ? browser.$$(ancestor).first().$$(locator).first()
+      ? browser
+          .$$(ancestor)
+          .first()
+          .$$(locator)
+          .first()
       : browser.$$(locator).first();
   }
 
   async wait() {
-    await browser.wait(EC.presenceOf(this.component), BROWSER_WAIT_TIMEOUT);
+    await waitForPresence(this.component);
   }
 }