From 52b4060e787bcc2099342c6e3d6865ed333db59e Mon Sep 17 00:00:00 2001 From: dominikiwanekhyland <141320833+dominikiwanekhyland@users.noreply.github.com> Date: Fri, 17 Jan 2025 13:15:35 +0100 Subject: [PATCH] [ACS-8960] Review and apply required inputs where possible (#4339) --- .../rule-list/rule-list-item/rule-list-item.ui-component.ts | 2 +- .../src/rule-list/rule-list/rule-list.ui-component.ts | 4 ++-- .../datatable-cell-badges/datatable-cell-badges.component.ts | 2 +- .../search/search-results-row/search-results-row.component.ts | 2 +- .../components/sidenav/components/button-menu.component.ts | 4 ++-- .../components/sidenav/components/expand-menu.component.ts | 2 +- .../src/lib/components/info-drawer/info-drawer.component.ts | 2 +- .../src/lib/components/toolbar/toolbar.component.ts | 2 +- 8 files changed, 10 insertions(+), 10 deletions(-) diff --git a/projects/aca-content/folder-rules/src/rule-list/rule-list-item/rule-list-item.ui-component.ts b/projects/aca-content/folder-rules/src/rule-list/rule-list-item/rule-list-item.ui-component.ts index 0cdacaf09..89ca390e8 100644 --- a/projects/aca-content/folder-rules/src/rule-list/rule-list-item/rule-list-item.ui-component.ts +++ b/projects/aca-content/folder-rules/src/rule-list/rule-list-item/rule-list-item.ui-component.ts @@ -37,7 +37,7 @@ import { MatSlideToggleModule } from '@angular/material/slide-toggle'; host: { class: 'aca-rule-list-item' } }) export class RuleListItemUiComponent { - @Input() + @Input({ required: true }) rule: Rule; @Input() @HostBinding('class.aca-selected') diff --git a/projects/aca-content/folder-rules/src/rule-list/rule-list/rule-list.ui-component.ts b/projects/aca-content/folder-rules/src/rule-list/rule-list/rule-list.ui-component.ts index a2cf50c25..83a839f9f 100644 --- a/projects/aca-content/folder-rules/src/rule-list/rule-list/rule-list.ui-component.ts +++ b/projects/aca-content/folder-rules/src/rule-list/rule-list/rule-list.ui-component.ts @@ -57,9 +57,9 @@ import { takeUntilDestroyed } from '@angular/core/rxjs-interop'; host: { class: 'aca-rule-list' } }) export class RuleListUiComponent implements OnInit { - @Input() + @Input({ required: true }) mainRuleSet$: Observable; - @Input() + @Input({ required: true }) folderId: string; @Input() inheritedRuleSets: RuleSet[] = []; diff --git a/projects/aca-content/src/lib/components/dl-custom-components/datatable-cell-badges/datatable-cell-badges.component.ts b/projects/aca-content/src/lib/components/dl-custom-components/datatable-cell-badges/datatable-cell-badges.component.ts index 89e503b09..2d36f48e6 100644 --- a/projects/aca-content/src/lib/components/dl-custom-components/datatable-cell-badges/datatable-cell-badges.component.ts +++ b/projects/aca-content/src/lib/components/dl-custom-components/datatable-cell-badges/datatable-cell-badges.component.ts @@ -41,7 +41,7 @@ import { takeUntilDestroyed } from '@angular/core/rxjs-interop'; standalone: true }) export class DatatableCellBadgesComponent implements OnInit { - @Input() node: NodeEntry; + @Input({ required: true }) node: NodeEntry; badges: Badge[]; diff --git a/projects/aca-content/src/lib/components/search/search-results-row/search-results-row.component.ts b/projects/aca-content/src/lib/components/search/search-results-row/search-results-row.component.ts index d57fa92ae..7ac88b9f3 100644 --- a/projects/aca-content/src/lib/components/search/search-results-row/search-results-row.component.ts +++ b/projects/aca-content/src/lib/components/search/search-results-row/search-results-row.component.ts @@ -54,7 +54,7 @@ export class SearchResultsRowComponent implements OnInit { private node: NodeEntry; - @Input() + @Input({ required: true }) context: any; name$ = new BehaviorSubject(''); diff --git a/projects/aca-content/src/lib/components/sidenav/components/button-menu.component.ts b/projects/aca-content/src/lib/components/sidenav/components/button-menu.component.ts index e8e364953..870758ee7 100644 --- a/projects/aca-content/src/lib/components/sidenav/components/button-menu.component.ts +++ b/projects/aca-content/src/lib/components/sidenav/components/button-menu.component.ts @@ -22,7 +22,7 @@ * from Hyland Software. If not, see . */ -import { Component, Input, ViewEncapsulation, OnInit, ChangeDetectorRef } from '@angular/core'; +import { ChangeDetectorRef, Component, Input, OnInit, ViewEncapsulation } from '@angular/core'; import { OverlayContainer } from '@angular/cdk/overlay'; import { NavBarLinkRef } from '@alfresco/adf-extensions'; import { CommonModule } from '@angular/common'; @@ -43,7 +43,7 @@ import { MenuPanelDirective } from '../directives/menu-panel.directive'; encapsulation: ViewEncapsulation.None }) export class ButtonMenuComponent implements OnInit { - @Input() + @Input({ required: true }) item: NavBarLinkRef; constructor(private cd: ChangeDetectorRef, private overlayContainer: OverlayContainer) { diff --git a/projects/aca-content/src/lib/components/sidenav/components/expand-menu.component.ts b/projects/aca-content/src/lib/components/sidenav/components/expand-menu.component.ts index c322fba82..a5f785309 100644 --- a/projects/aca-content/src/lib/components/sidenav/components/expand-menu.component.ts +++ b/projects/aca-content/src/lib/components/sidenav/components/expand-menu.component.ts @@ -51,7 +51,7 @@ import { ExpansionPanelDirective } from '../directives/expansion-panel.directive host: { class: 'app-expand-menu' } }) export class ExpandMenuComponent implements OnInit { - @Input() + @Input({ required: true }) item: NavBarLinkRef; @Output() diff --git a/projects/aca-shared/src/lib/components/info-drawer/info-drawer.component.ts b/projects/aca-shared/src/lib/components/info-drawer/info-drawer.component.ts index 83ab083a3..516aa1f60 100644 --- a/projects/aca-shared/src/lib/components/info-drawer/info-drawer.component.ts +++ b/projects/aca-shared/src/lib/components/info-drawer/info-drawer.component.ts @@ -49,7 +49,7 @@ export class InfoDrawerComponent implements OnChanges, OnInit, OnDestroy { @Input() nodeId: string; - @Input() + @Input({ required: true }) node: NodeEntry; isLoading = false; diff --git a/projects/aca-shared/src/lib/components/toolbar/toolbar.component.ts b/projects/aca-shared/src/lib/components/toolbar/toolbar.component.ts index ceceae602..28cadadf9 100644 --- a/projects/aca-shared/src/lib/components/toolbar/toolbar.component.ts +++ b/projects/aca-shared/src/lib/components/toolbar/toolbar.component.ts @@ -37,7 +37,7 @@ import { MatToolbarModule } from '@angular/material/toolbar'; encapsulation: ViewEncapsulation.None }) export class ToolbarComponent { - @Input() items: ContentActionRef[]; + @Input({ required: true }) items: ContentActionRef[]; trackByActionId(_: number, action: ContentActionRef) { return action.id;