[ACA-4712] disallow using important for styles (#3368)

* ACA-4712 Added rule to prevent using important for styles

* ACA-4712 Removed important from some global styles and from manage rule component

* ACA-4712 Removed important from rest global and theme styles

* ACA-4712 Removed usages of important from styles for components
This commit is contained in:
AleksanderSklorz
2023-07-26 09:43:14 +02:00
committed by GitHub
parent 4019508f0f
commit 5508ff1362
18 changed files with 135 additions and 121 deletions

View File

@@ -22,7 +22,7 @@ $top-margin: 12px;
font-size: 16px;
padding-left: 15px;
box-sizing: border-box;
margin-bottom: 12px !important;
margin-bottom: 12px;
.mat-form-field {
font-size: 16px;

View File

@@ -9,7 +9,10 @@ $top-margin: 12px;
width: 100%;
max-width: $search-width;
height: $search-height + $top-margin;
margin: 0 !important;
&.mat-menu-trigger {
margin: 0;
}
.app-search-button {
width: 32px;
@@ -23,9 +26,11 @@ $top-margin: 12px;
.app-close-icon {
height: 6px;
.mat-icon {
font-size: 18px !important;
line-height: 28px;
&.app-suffix-search-icon-wrapper {
.mat-icon {
font-size: 18px;
line-height: 28px;
}
}
}
@@ -70,8 +75,8 @@ mat-checkbox {
background-color: $search-background;
border-radius: $search-border-radius;
height: $search-height;
margin-bottom: 0 !important;
padding-bottom: 26px !important;
margin-bottom: 0;
padding-bottom: 26px;
}
.app-search-control {

View File

@@ -16,12 +16,12 @@
.link:hover,
.aca-location-link .adf-datatable-cell-value:hover {
color: var(--theme-primary-color) !important;
color: var(--theme-primary-color);
text-decoration: underline;
}
.adf-is-selected .link:not(:hover),
.adf-is-selected .adf-datatable-cell-value:not(:hover) {
color: var(--theme-primary-color) !important;
color: var(--theme-primary-color);
}
}

View File

@@ -22,7 +22,7 @@
[acaExpansionPanel]="item"
[@.disabled]="true"
>
<mat-expansion-panel-header expandedHeight="48px" collapsedHeight="48px" role="group">
<mat-expansion-panel-header expandedHeight="32px" collapsedHeight="32px" role="group">
<mat-panel-title>
<div class="item">
<button

View File

@@ -52,7 +52,6 @@
border-radius: 0;
&-header {
height: 32px !important;
padding: 0 32px 0 0;
display: flex;
align-items: center;
@@ -66,7 +65,7 @@
.mat-button {
line-height: 32px;
align-items: center;
border: none !important;
border: none;
}
.action-button__label {
@@ -99,7 +98,7 @@
}
.mat-expansion-panel:not(.mat-expanded) .mat-expansion-panel-header:not([aria-disabled='true']):hover {
background: none !important;
background: none;
}
.item {
@@ -128,7 +127,7 @@
}
.action-button--active {
color: var(--theme-selected-text-color) !important;
color: var(--theme-selected-text-color);
background: var(--theme-selected-background-color);
}
}

View File

@@ -83,9 +83,9 @@ app-view-profile {
}
.app-selected:focus {
border: 2px solid var(--theme-blue-button-color) !important;
border: 2px solid var(--theme-blue-button-color);
border-radius: 6px;
outline: none !important;
outline: none;
box-shadow: 0 0 2px var(--theme-blue-button-color);
}