From 572e6ee8b061dfcf10b076d12c6e86695e9ef809 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adam=20=C5=9Awiderski?= Date: Wed, 13 May 2026 14:18:52 +0200 Subject: [PATCH] [ACS-11740] copilot review fixes 1 --- .github/workflows/cron-e2e.yml | 30 +++++++++++++++++++++++++++--- .github/workflows/pull-request.yml | 17 +++++++++++++++++ 2 files changed, 44 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cron-e2e.yml b/.github/workflows/cron-e2e.yml index 3bd72d817..3bc019445 100644 --- a/.github/workflows/cron-e2e.yml +++ b/.github/workflows/cron-e2e.yml @@ -10,7 +10,15 @@ jobs: uses: ./.github/workflows/pull-request.yml with: browser: chrome - secrets: inherit + secrets: + SCREENSHOT_USERNAME: ${{ secrets.SCREENSHOT_USERNAME }} + SCREENSHOT_PASSWORD: ${{ secrets.SCREENSHOT_PASSWORD }} + REPORT_PORTAL_URL: ${{ secrets.REPORT_PORTAL_URL }} + REPORT_PORTAL_TOKEN: ${{ secrets.REPORT_PORTAL_TOKEN }} + DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }} + DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} + QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }} + QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }} firefox: name: "Cron browser E2E run - firefox" @@ -18,7 +26,15 @@ jobs: uses: ./.github/workflows/pull-request.yml with: browser: firefox - secrets: inherit + secrets: + SCREENSHOT_USERNAME: ${{ secrets.SCREENSHOT_USERNAME }} + SCREENSHOT_PASSWORD: ${{ secrets.SCREENSHOT_PASSWORD }} + REPORT_PORTAL_URL: ${{ secrets.REPORT_PORTAL_URL }} + REPORT_PORTAL_TOKEN: ${{ secrets.REPORT_PORTAL_TOKEN }} + DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }} + DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} + QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }} + QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }} webkit: name: "Cron browser E2E run - webkit" @@ -26,4 +42,12 @@ jobs: uses: ./.github/workflows/pull-request.yml with: browser: webkit - secrets: inherit + secrets: + SCREENSHOT_USERNAME: ${{ secrets.SCREENSHOT_USERNAME }} + SCREENSHOT_PASSWORD: ${{ secrets.SCREENSHOT_PASSWORD }} + REPORT_PORTAL_URL: ${{ secrets.REPORT_PORTAL_URL }} + REPORT_PORTAL_TOKEN: ${{ secrets.REPORT_PORTAL_TOKEN }} + DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }} + DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} + QUAY_USERNAME: ${{ secrets.QUAY_USERNAME }} + QUAY_PASSWORD: ${{ secrets.QUAY_PASSWORD }} diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 046894762..4a00797d2 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -9,6 +9,23 @@ on: browser: required: true type: string + secrets: + SCREENSHOT_USERNAME: + required: true + SCREENSHOT_PASSWORD: + required: true + REPORT_PORTAL_URL: + required: true + REPORT_PORTAL_TOKEN: + required: true + DOCKER_USERNAME: + required: true + DOCKER_PASSWORD: + required: true + QUAY_USERNAME: + required: true + QUAY_PASSWORD: + required: true concurrency: group: ${{ github.workflow }}-${{ github.ref }}