From 5e49d9591b28b4c540f7668497a052833ea9a74c Mon Sep 17 00:00:00 2001
From: Chris Rodriguez <chris.rodriguez@deque.com>
Date: Mon, 23 Mar 2020 10:23:37 -0400
Subject: [PATCH] [ACA-2582] menu menuitem roles (#1315)

* chore: wip

* chore: wip mark will poke around

* chore: removed unused directive

* remove useless directive

* cleanup code

Co-authored-by: Denys Vuika <denys.vuika@gmail.com>
---
 src/app/components/create-menu/create-menu.component.html     | 4 ++--
 .../toolbar-menu-item/toolbar-menu-item.component.html        | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/app/components/create-menu/create-menu.component.html b/src/app/components/create-menu/create-menu.component.html
index 26515c61e..3207c7eb1 100644
--- a/src/app/components/create-menu/create-menu.component.html
+++ b/src/app/components/create-menu/create-menu.component.html
@@ -37,7 +37,7 @@
   [overlapTrigger]="false"
   yPosition="below"
 >
-  <ng-container *ngFor="let action of createActions; trackBy: trackById">
+  <div role="menu" *ngFor="let action of createActions; trackBy: trackById">
     <app-toolbar-menu-item [actionRef]="action"></app-toolbar-menu-item>
-  </ng-container>
+  </div>
 </mat-menu>
diff --git a/src/app/components/toolbar/toolbar-menu-item/toolbar-menu-item.component.html b/src/app/components/toolbar/toolbar-menu-item/toolbar-menu-item.component.html
index 9ffd5e6fd..b0cf531c0 100644
--- a/src/app/components/toolbar/toolbar-menu-item/toolbar-menu-item.component.html
+++ b/src/app/components/toolbar/toolbar-menu-item/toolbar-menu-item.component.html
@@ -2,6 +2,7 @@
   <ng-container *ngSwitchCase="'menu'">
     <button
       mat-menu-item
+      role="menuitem"
       [disabled]="actionRef.disabled"
       [matMenuTriggerFor]="childMenu"
     >
@@ -29,6 +30,7 @@
   <ng-container *ngSwitchDefault>
     <button
       [id]="actionRef.id"
+      role="button"
       mat-menu-item
       [role]="'button'"
       color="primary"