Ng19 migration (#4520)

2025-07-24 17:31:52 +00:00 · 2025-07-03 13:33:05 +02:00
parent bcbdff9543
commit 5f5c238ccd
127 changed files with 8582 additions and 6369 deletions
--- a/projects/aca-shared/src/lib/components/document-base-page/document-base-page.spec.ts
+++ b/projects/aca-shared/src/lib/components/document-base-page/document-base-page.spec.ts
@@ -40,7 +40,9 @@ import { Router } from '@angular/router';

@Component({
  selector: 'aca-test',
-  template: ''
+  template: '',
+  // eslint-disable-next-line
+  standalone: false
 })
 class TestComponent extends PageComponent {
  node: any;
@@ -199,7 +201,7 @@ describe('PageComponent', () => {
      } as NodeEntry;

      component.showPreview(node);
-      expect(store.dispatch).toHaveBeenCalledWith(new ViewNodeAction(node.entry.id));
+      expect(store.dispatch).toHaveBeenCalledWith(jasmine.objectContaining({ ...new ViewNodeAction(node.entry.id) }));
    });

    it('should call ViewNodeAction on showPreview for `app:filelink` node type', () => {
@@ -216,7 +218,7 @@ describe('PageComponent', () => {

      component.showPreview(linkNode);
      const id = linkNode.entry.properties['cm:destination'];
-      expect(store.dispatch).toHaveBeenCalledWith(new ViewNodeAction(id));
+      expect(store.dispatch).toHaveBeenCalledWith(jasmine.objectContaining({ ...new ViewNodeAction(id) }));
    });
  });

--- a/projects/aca-shared/src/lib/components/generic-error/generic-error.component.ts
+++ b/projects/aca-shared/src/lib/components/generic-error/generic-error.component.ts
@@ -22,12 +22,11 @@
 * from Hyland Software. If not, see <http://www.gnu.org/licenses/>.
 */

-import { Component, ViewEncapsulation, ChangeDetectionStrategy, Input } from '@angular/core';
+import { ChangeDetectionStrategy, Component, Input, ViewEncapsulation } from '@angular/core';
 import { MatIconModule } from '@angular/material/icon';
 import { TranslateModule } from '@ngx-translate/core';

@Component({
-  standalone: true,
  imports: [MatIconModule, TranslateModule],
  selector: 'aca-generic-error',
  templateUrl: './generic-error.component.html',
--- a/projects/aca-shared/src/lib/components/info-drawer/info-drawer.component.ts
+++ b/projects/aca-shared/src/lib/components/info-drawer/info-drawer.component.ts
@@ -39,7 +39,6 @@ import { ContentService, NodesApiService } from '@alfresco/adf-content-services'
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';

@Component({
-  standalone: true,
  imports: [CommonModule, TranslateModule, MatProgressBarModule, InfoDrawerModule, A11yModule, ToolbarComponent, DynamicTabComponent],
  selector: 'aca-info-drawer',
  templateUrl: './info-drawer.component.html',
--- a/projects/aca-shared/src/lib/components/locked-by/locked-by.component.ts
+++ b/projects/aca-shared/src/lib/components/locked-by/locked-by.component.ts
@@ -22,13 +22,12 @@
 * from Hyland Software. If not, see <http://www.gnu.org/licenses/>.
 */

-import { Component, Input, ChangeDetectionStrategy, ViewEncapsulation, OnInit } from '@angular/core';
+import { ChangeDetectionStrategy, Component, Input, OnInit, ViewEncapsulation } from '@angular/core';
 import { NodeEntry } from '@alfresco/js-api';
 import { TranslateModule } from '@ngx-translate/core';
 import { MatIconModule } from '@angular/material/icon';

@Component({
-  standalone: true,
  imports: [TranslateModule, MatIconModule],
  selector: 'aca-locked-by',
  template: `
--- a/projects/aca-shared/src/lib/components/open-in-app/open-in-app.component.ts
+++ b/projects/aca-shared/src/lib/components/open-in-app/open-in-app.component.ts
@@ -23,7 +23,7 @@
 */

 import { Component, Inject, ViewEncapsulation } from '@angular/core';
-import { MatDialogRef, MAT_DIALOG_DATA, MatDialogModule } from '@angular/material/dialog';
+import { MAT_DIALOG_DATA, MatDialogModule, MatDialogRef } from '@angular/material/dialog';
 import { CommonModule } from '@angular/common';
 import { TranslateModule } from '@ngx-translate/core';
 import { MatButtonModule } from '@angular/material/button';
@@ -35,7 +35,6 @@ export interface OpenInAppDialogOptions {
  appStoreUrl: string;
 }
@Component({
-  standalone: true,
  imports: [CommonModule, TranslateModule, MatButtonModule, MatIconModule, A11yModule, MatDialogModule],
  selector: 'aca-open-in-app',
  templateUrl: './open-in-app.component.html',
--- a/projects/aca-shared/src/lib/components/page-layout/page-layout.component.ts
+++ b/projects/aca-shared/src/lib/components/page-layout/page-layout.component.ts
@@ -32,7 +32,6 @@ import { MatIconModule } from '@angular/material/icon';
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';

@Component({
-  standalone: true,
  imports: [CommonModule, TranslateModule, MatButtonModule, MatIconModule],
  selector: 'aca-page-layout',
  templateUrl: './page-layout.component.html',
--- a/projects/aca-shared/src/lib/components/toolbar/toolbar-action/toolbar-action.component.ts
+++ b/projects/aca-shared/src/lib/components/toolbar/toolbar-action/toolbar-action.component.ts
@@ -30,7 +30,6 @@ import { CommonModule } from '@angular/common';
 import { ToolbarMenuComponent } from '../toolbar-menu/toolbar-menu.component';

@Component({
-  standalone: true,
  imports: [CommonModule, ToolbarButtonComponent, ToolbarMenuComponent, DynamicExtensionComponent],
  selector: 'aca-toolbar-action',
  templateUrl: './toolbar-action.component.html',
--- a/projects/aca-shared/src/lib/components/toolbar/toolbar-button/toolbar-button.component.ts
+++ b/projects/aca-shared/src/lib/components/toolbar/toolbar-button/toolbar-button.component.ts
@@ -40,7 +40,6 @@ export enum ToolbarButtonType {
 }

@Component({
-  standalone: true,
  imports: [CommonModule, TranslateModule, MatButtonModule, IconModule, ToolbarMenuItemComponent],
  selector: 'app-toolbar-button',
  templateUrl: './toolbar-button.component.html',
--- a/projects/aca-shared/src/lib/components/toolbar/toolbar-menu-item/toolbar-menu-item.component.spec.ts
+++ b/projects/aca-shared/src/lib/components/toolbar/toolbar-menu-item/toolbar-menu-item.component.spec.ts
@@ -123,8 +123,9 @@ describe('ToolbarMenuItemComponent', () => {
    fixture.detectChanges();

    const innerElement = testingUtils.getByDirective(DynamicExtensionComponent);
-    innerElement.componentInstance.menuItem = new MatMenuItem(null, null, null, null, null);
+    const menuItem = {} as MatMenuItem;
+    innerElement.componentInstance.menuItem = menuItem;
    component.ngAfterViewInit();
-    expect(component.menuItem).toBeInstanceOf(MatMenuItem);
+    expect(component.menuItem).toEqual(menuItem);
  });
 });
--- a/projects/aca-shared/src/lib/components/toolbar/toolbar-menu-item/toolbar-menu-item.component.ts
+++ b/projects/aca-shared/src/lib/components/toolbar/toolbar-menu-item/toolbar-menu-item.component.ts
@@ -32,7 +32,6 @@ import { MatDividerModule } from '@angular/material/divider';
 import { IconComponent } from '@alfresco/adf-core';

@Component({
-  standalone: true,
  imports: [CommonModule, TranslateModule, MatMenuModule, MatDividerModule, IconComponent, DynamicExtensionComponent],
  selector: 'app-toolbar-menu-item',
  templateUrl: './toolbar-menu-item.component.html',
--- a/projects/aca-shared/src/lib/components/toolbar/toolbar-menu/toolbar-menu.component.ts
+++ b/projects/aca-shared/src/lib/components/toolbar/toolbar-menu/toolbar-menu.component.ts
@@ -33,7 +33,6 @@ import { TranslateModule } from '@ngx-translate/core';
 import { IconComponent } from '@alfresco/adf-core';

@Component({
-  standalone: true,
  imports: [CommonModule, TranslateModule, MatButtonModule, MatMenuModule, ToolbarMenuItemComponent, IconComponent, DynamicExtensionComponent],
  selector: 'app-toolbar-menu',
  templateUrl: './toolbar-menu.component.html',
--- a/projects/aca-shared/src/lib/components/toolbar/toolbar.component.ts
+++ b/projects/aca-shared/src/lib/components/toolbar/toolbar.component.ts
@@ -30,7 +30,6 @@ import { MatToolbarModule } from '@angular/material/toolbar';

@Component({
  selector: 'aca-toolbar',
-  standalone: true,
  imports: [CommonModule, ToolbarActionComponent, MatToolbarModule],
  templateUrl: './toolbar.component.html',
  styleUrls: ['./toolbar.component.scss'],
--- a/projects/aca-shared/src/lib/routing/plugin-enabled.guard.spec.ts
+++ b/projects/aca-shared/src/lib/routing/plugin-enabled.guard.spec.ts
@@ -26,7 +26,8 @@ import { AppConfigService } from '@alfresco/adf-core';
 import { TestBed } from '@angular/core/testing';
 import { PluginEnabledGuard } from './plugin-enabled.guard';
 import { ActivatedRouteSnapshot, Router, RouterStateSnapshot } from '@angular/router';
-import { HttpClientTestingModule } from '@angular/common/http/testing';
+import { provideHttpClientTesting } from '@angular/common/http/testing';
+import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';

 describe('PluginEnabledGuard', () => {
  let getSpy: jasmine.Spy<(key: string, defaultValue?: boolean) => boolean>;
@@ -34,7 +35,8 @@ describe('PluginEnabledGuard', () => {

  beforeEach(() => {
    TestBed.configureTestingModule({
-      imports: [HttpClientTestingModule]
+      imports: [],
+      providers: [provideHttpClient(withInterceptorsFromDi()), provideHttpClientTesting()]
    });
    getSpy = spyOn(TestBed.inject(AppConfigService), 'get');
    route = new ActivatedRouteSnapshot();
--- a/projects/aca-shared/src/lib/services/app.extension.service.spec.ts
+++ b/projects/aca-shared/src/lib/services/app.extension.service.spec.ts
@@ -25,7 +25,7 @@
 import { TestBed } from '@angular/core/testing';
 import { initialState, LibTestingModule } from '../testing/lib-testing-module';
 import { AppExtensionService } from './app.extension.service';
-import { Action, Store } from '@ngrx/store';
+import { Store } from '@ngrx/store';
 import { AppStore } from '@alfresco/aca-shared/store';
 import {
  ContentActionType,
@@ -327,11 +327,13 @@ describe('AppExtensionService', () => {
      spyOn(store, 'dispatch').and.stub();

      service.runActionById('aca:actions/create-folder');
-      expect(store.dispatch).toHaveBeenCalledWith({
-        type: 'CREATE_FOLDER',
-        payload: 'folder-name',
-        configuration: undefined
-      } as Action);
+      expect(store.dispatch).toHaveBeenCalledWith(
+        jasmine.objectContaining({
+          type: 'CREATE_FOLDER',
+          payload: 'folder-name',
+          configuration: undefined
+        })
+      );
    });

    it('should still invoke store if action is missing', () => {
--- a/projects/aca-shared/src/lib/services/app.service.spec.ts
+++ b/projects/aca-shared/src/lib/services/app.service.spec.ts
@@ -26,15 +26,15 @@ import { AppService } from './app.service';
 import { TestBed } from '@angular/core/testing';
 import {
  AuthenticationService,
+  NotificationService,
  PageTitleService,
+  StorageService,
  TranslationMock,
  TranslationService,
-  UserPreferencesService,
-  NotificationService,
-  StorageService
+  UserPreferencesService
 } from '@alfresco/adf-core';
 import { BehaviorSubject, Observable, of, Subject } from 'rxjs';
-import { HttpClientModule } from '@angular/common/http';
+import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
 import {
  AlfrescoApiService,
  AlfrescoApiServiceMock,
@@ -73,7 +73,7 @@ describe('AppService', () => {

  beforeEach(() => {
    TestBed.configureTestingModule({
-      imports: [CommonModule, HttpClientModule, TranslateModule.forRoot(), RouterTestingModule.withRoutes([]), MatDialogModule, MatSnackBarModule],
+      imports: [CommonModule, TranslateModule.forRoot(), RouterTestingModule.withRoutes([]), MatDialogModule, MatSnackBarModule],
      providers: [
        SearchQueryBuilderService,
        provideMockStore({}),
@@ -121,7 +121,8 @@ describe('AppService', () => {
            setStoragePrefix: () => null,
            getPropertyKey: (property: string) => `prefix__${property}`
          }
-        }
+        },
+        provideHttpClient(withInterceptorsFromDi())
      ]
    });

--- a/projects/aca-shared/src/lib/testing/lib-testing-module.ts
+++ b/projects/aca-shared/src/lib/testing/lib-testing-module.ts
@@ -27,7 +27,7 @@ import { TranslateLoader, TranslateModule } from '@ngx-translate/core';
 import { NoopAnimationsModule } from '@angular/platform-browser/animations';
 import { TranslateLoaderService, TranslationMock, TranslationService } from '@alfresco/adf-core';
 import { AlfrescoApiService, AlfrescoApiServiceMock } from '@alfresco/adf-content-services';
-import { HttpClientModule } from '@angular/common/http';
+import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
 import { RouterTestingModule } from '@angular/router/testing';
 import { EffectsModule } from '@ngrx/effects';
 import { StoreModule } from '@ngrx/store';
@@ -93,10 +93,10 @@ export class DocumentBasePageServiceMock extends DocumentBasePageService {
 }

@NgModule({
+  exports: [TranslateModule],
  imports: [
    NoopAnimationsModule,
    CommonModule,
-    HttpClientModule,
    RouterTestingModule,
    MatIconTestingModule,
    StoreModule,
@@ -119,10 +119,10 @@ export class DocumentBasePageServiceMock extends DocumentBasePageService {
      }
    })
  ],
-  exports: [TranslateModule],
  providers: [
    { provide: AlfrescoApiService, useClass: AlfrescoApiServiceMock },
-    { provide: TranslationService, useClass: TranslationMock }
+    { provide: TranslationService, useClass: TranslationMock },
+    provideHttpClient(withInterceptorsFromDi())
  ]
 })
 export class LibTestingModule {}